[Koha-bugs] [Bug 18882] Add location code to statistics table for checkouts and renewals

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #4)
> (In reply to M. Tompsett from comment #2)
> > The code puts '' if there is no location key. But if the location key is
> > NULL, because I hadn't set my shelving location, there is NULL. Do we want
> > NULL's? If so, I'll sign this off. If not, could you tweak that?
> 
> I think we should always use NULL is the location is not passed or is set to
> undef. It seems like odd behavior to convert undef values to empty strings.

What we are doing now however, is storing undef only for location. Which is
inconsistent. You change all lines in the second patch, only set undef for
location.
No blocker, but could be improved.
I think that empty string would have been better now.

-- 
You are receiving this mail because:
You are watching all bug changes.