[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Nov 3 12:24:26 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Upload local cover image
Upload status: Failed - (2) Root directory for uploads not defined
No, the directory was not writable.
This went wrong since the errcode is 2, but you forgot to add a zero entry in
you errMsgs array. So they are one position out of sync.
Please add a leading entry here (see also upload.tt)
var errMsgs = [ _("File already exists"), _("Directory is not writeable"),
_("Root directory for uploads not defined"), _("Temporary directory for uploads
not defined") ];
Adjust same thing in two other places ?

 //Next three errors have no code path to trigger that I see
I am very confident that I tested all codes when I wrote this. They may be hard
to simulate, but I did. Please remove this comment.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list