[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #0)
> Jenkins fails (run 287) on a test in
> t/db_dependent/Letters/TemplateToolkit.t:
> 
> With the historical syntax:
>         # Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been
> canceled for the following reason:
> 
> With the TT syntax:
>         # Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has
> been canceled for the following reason:
> 
> The last character of the biblio's title has been removed because it's a
> punctuation character.
> It comes from: C4::Letters::_parseletter
>  893         $val =~ s/\p{P}$// if $val && $table=~/biblio/;
> 
> The same replacement is done for patron's attributes too.
> 
> With the TT syntax we retrieve the objects and send them to the template,
> without fetching the attributes.
> To restore this behaviour we could apply this regex on all the fields of the
> biblio objects, but it could be perf killer (we will process fields that we
> will certainly not used in the template).
> I thought about the TT filter we could apply on all the variables we
> display, but we will not know where come from the data, and we need to apply
> this change only for the biblio table.
> 
> Any other ideas?

I think there are two valid options:
1) Remove line 893 ( what is it's purpose? )
2) Add a TT filter like you suggest. I think if we just apply it to any TT
syntax that contains ".biblio" within TT tags ( something like
/^\[%.*biblio\..*%\]$/ ) it would be safe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.