[Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I assume the obvious fix to this is to say that the id_type is required rather
than optional in the POD?  Alternative there could be a set of well defined
id_types that are cycled through to find matches (that would be a pretty easy
bit of code).

On a similar note, we've noticed that "email" also appears to be a valid
id_type but isn't in the POD list. A quick look in the code (hoorah for open
source!) shows that any field in the borrower table can be looked up with this
call.  For example "phone", "phonepro" or "mobile" let me find myself using my
primary, secondary and "other" phone number. 

This begs the question: should Koha be constraining the list of id_type's that
can be passed into this routine from the client? Or is being able to search on
any column in the borrowers table regarded as a useful feature (we've found
"email" to be handy for sure).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.