[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Nov 7 21:45:28 CET 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
--- Comment #193 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Some more:
1. This looks wrong
260 here_link => "/cgi-bin/koha/ill/ill-requests.pl"
url should be in template I'd say
2. This is not used, you are using an ajax call
219 } elsif ( $op eq 'illlist') {
220 # Display all current ILLs
221 my $requests = $illRequests->search();
222
223 $template->param(
224 requests => $requests
225 );
3. 257 media => [ "Book", "Article", "Journal" ],
Is this used?
4.
Config.pm
312 die "No DEFAULT_FORMATS has been defined in koha-conf.xml, but
UNMEDIATEDILL is active."
313 if ( $unmediated && !$configuration->{default_formats}->{default}
);
Not used yet, please remove
5. 794 \"YEAR(placed) = YEAR(NOW())"
This looks like a mysqlism
6. The branchcode is displayed instead of the branchname in the list of ILL
requests. Sounds easy to fix as we embed "branch" (must be library?)
7. api/v1/swagger/paths/*.json
"name": "branchcode"
vs
"name": "branch_id"
same with
borrowernumber vs borrower_id
and
biblionumber vs biblio_id
(to be continued...)
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list