[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Nov 13 02:59:57 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #63 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #61)
> Some additional remarks:
> 1. At some point I got the following error:
> {"error":"Checkout item already exists"}Status: 200 OK

I have to let Nick decide on that one

> 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> to make them translatable.

Done. Please let me know if it's not what you had in mind.

> 3. I see code related to pagination, but I do not see the previous/next
> buttons. I only see the OPACnumSearchResults first results.

Yes, at some stage the idea was to integrate all external searches into the
main results page, so I stopped short of implementing paging - will be thrown
away. Is it acceptable to leave as is?

> 
> And a question:
> Koha/ExternalContent/RecordedBooks.pm
>  76                 user_agent_params => { agent => $class->agent_string }
> Where is this used?

It is a param for WebService::ILS. Cannot remember any more, possibly was a
requirement for a provider that even did not get implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list