[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Thx David for your brave changes. Looks good, still asking some attention.

-        } elsif ( $issue->date_due and $patron->debarred ) {
+        if ( $new_debar == 0 and $patron->debarred ) {
Why do you remove the test on date_due (might be just theoretical)?
Since you change the program flow by changing an elsif into an if, the game may
change here. 
The comment on top is no longer valid at least ("There is no overdue...");
seems ok for the rest.

Variable $is_a_reminder is no longer used.
# if borrower was already debarred but does not get an extra debarment
Your changes make this comment look bad.
Since _debar_user_on_return now seems to return new or extended debarment dates
only, please adjust POD.
In AddReturn adjust varname accordingly (like newdebardate or so )?
You do not need $debardate and $new_debar now; $newdebardate would be enough to
test.

See Comment11 too. We still need additional unit testing.

-- 
You are receiving this mail because:
You are watching all bug changes.