[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 21 20:31:51 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69253|0                           |1
        is obsolete|                            |

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69258&action=edit
Bug 19410: Add Koha::Objects->search_for_api

Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:

"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
  my $c = shift->openapi->valid_input or return;
  my $args = $c->validation->output;
  my $vendors;

  return try {
    $vendors = Koha::Acquisition::Booksellers->api_list_search($c);
    return $c->render(status => 200, openapi => $vendors);
  } catch {
    ...
  }
}"

We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.

I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.

Thanks!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list