[Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69298&action=edit
Bug 19466 - Check if cardnumber mandatory

Turns out this isn't a bug, since it is caused by 'cardnumber' being in the
'BorrowerMandatoryField' syspref.

It is however confusing for the user that it suggested to leave the field blank
when the field is required. To alleviate this I added a condition to the code;
it will not suggest leaving the field blank if 'BorrowerMandatoryField'
contains 'cardnumber'.

To test:

Before:
0) Enable autoMemberNum
1) Add 'cardnumber' to BorrowerMandatoryField
2) Go to create a user: a message will appear suggesting you leave the
cardnumber field blank for autocalc, but when submitting the form it will show
as required.
Apply patch
2) Go to create a user: if 'cardnumber' is in BorrowerMandatoryField, the
suggestion will not be shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.