[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Srdjan Jankovic from comment #63)
> (In reply to Jonathan Druart from comment #61)
> > Some additional remarks:
> > 1. At some point I got the following error:
> > {"error":"Checkout item already exists"}Status: 200 OK
> 
> I have to let Nick decide on that one

Nick?

> > 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> > to make them translatable.
> 
> Done. Please let me know if it's not what you had in mind.

I am not sure to understand what you did, I already fixed the some translations
(patch "Bug 17602: Ease translation") from .tt, you needed to fix the strings
in .js files (.inc and .tt were ok)

> > 3. I see code related to pagination, but I do not see the previous/next
> > buttons. I only see the OPACnumSearchResults first results.
> 
> Yes, at some stage the idea was to integrate all external searches into the
> main results page, so I stopped short of implementing paging - will be
> thrown away. Is it acceptable to leave as is?

I do not think we should integrate code that is not used.

> > And a question:
> > Koha/ExternalContent/RecordedBooks.pm
> >  76                 user_agent_params => { agent => $class->agent_string }
> > Where is this used?
> 
> It is a param for WebService::ILS. Cannot remember any more, possibly was a
> requirement for a provider that even did not get implemented.

So we remove?

Moving out the NSO queue.

-- 
You are receiving this mail because:
You are watching all bug changes.