[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #70 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #64)

> > > 2. Strings from .js files are not translatable, `git grep MSG_` to know how
> > > to make them translatable.
> > 
> > Done. Please let me know if it's not what you had in mind.
> 
> I am not sure to understand what you did, I already fixed the some
> translations (patch "Bug 17602: Ease translation") from .tt, you needed to
> fix the strings in .js files (.inc and .tt were ok)

This should be fine now.

> 
> > > 3. I see code related to pagination, but I do not see the previous/next
> > > buttons. I only see the OPACnumSearchResults first results.
> > 
> > Yes, at some stage the idea was to integrate all external searches into the
> > main results page, so I stopped short of implementing paging - will be
> > thrown away. Is it acceptable to leave as is?
> 
> I do not think we should integrate code that is not used.

Actually that was a bug. Fixed.

> 
> > > And a question:
> > > Koha/ExternalContent/RecordedBooks.pm
> > >  76                 user_agent_params => { agent => $class->agent_string }
> > > Where is this used?
> > 
> > It is a param for WebService::ILS. Cannot remember any more, possibly was a
> > requirement for a provider that even did not get implemented.
> 
> So we remove?

Removed.

-- 
You are receiving this mail because:
You are watching all bug changes.