[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Are you fixing a missing status (Transit) from GetReserveStatus by working
around it in IsAvailableForItemLevelRequest ? (See above too)
What about other calls of GetReserveStatus ?

-                [% IF ( AllowOnShelfHolds OR ItemsIssued ) %]
+                [% IF ( AllowOnShelfHolds OR ItemsIssued OR
ItemsWaitingOrInTransit ) %]
Would it be easier to just have one template var for this?

+my $itemsWaitingOrInTransit = Koha::Holds->search(
+    {
+        biblionumber => $biblionumber,
+        found => ['W', 'T']
+    })->count();
+unless ($itemsWaitingOrInTransit) {
+    foreach my $item ( Koha::Items->search(biblionumber => $biblionumber) ) {
+        $itemsWaitingOrInTransit = 1 if $item->get_transfer;
+    }
+}
Move this code into a sub ? And test it ?

I think we are too late anyway to get this into the new release. Some of the
points mentioned are no blockers, but imo the code still needs some attention.

-- 
You are receiving this mail because:
You are watching all bug changes.