[Koha-bugs] [Bug 19410] Add a helper function for generating object searches for the API

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Nov 27 15:49:17 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69287|0                           |1
        is obsolete|                            |

--- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69389&action=edit
Bug 19410: (QA followup) Move build_query_params_from_api into a helper

This patch creates the 'build_query_params' helper, instead of the
original function in Koha::Objects.

Unit tests are removed for Koha::Objects::_build_query_params_from_api and
written for the helper plugin.

The objects.search helper gets a call to build_query_params added. Tests for it
updated to match this behaviour change.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t \
          t/db_dependent/Koha/Objects.t \
          t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Lari Taskula <lari.taskula at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list