[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Nov 27 17:46:25 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69394&action=edit
Bug 19370: (QA followup) Use OpenAPI's handling of pipe separated values

This patch makes the helper handling _order_by params expect a list of
values instead of a (to-be-splitted) string.

The idea is that the OpenAPI plugin will take care of splitting
pipe-delimited values if the spec is correctly defined.

Note: In the process I noticed + on the URL represents a space, so the
helper function is updated to handle both + and %2B as ascending.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Edit: Removed rebasing leftover making the tests fail.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list