[Koha-bugs] [Bug 19712] New: Fix command line options of delete_records_via_leader.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

            Bug ID: 19712
           Summary: Fix command line options of
                    delete_records_via_leader.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

1. This code:

  56  if ( $help || !$confirm ) {
  57 
...
  70     exit();
  71 }

means that unless you specify --confirm you will never be able to run the
script - it will just print the usage and exit. That means --test is useless. 

2. The script has both of these options:

     -c --confirm: Script will do nothing without this parameter
     -t --test: Test mode, does not delete records.

What happens if you specify both? Or none? I think test mode should be the
default (when no options are specified) and changes to the database should only
be done when --confirm is specified. This would be consistent with other
scripts, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.