From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 08:21:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 06:21:27 +0000
Subject: [Koha-bugs] [Bug 19247] Feature release change tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67419|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 21:45:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 19:45:42 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #4 from Alex Buckley ---
Hi Jonathan
Sorry I forgot to attach the newly updated patch containing t/lib/Selenium.pm.
This Perl module contains the Selenium functions common across all the the
Selenium tests for example auth.
I have tried to attach the new patch to the bug report a few minutes ago and I
am getting a SSL certificate verify failed error, so I am in the process of
troubleshooting now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:16:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:16:24 +0000
Subject: [Koha-bugs] [Bug 19013] sample_data.sql inserts patrons with
guarantorid that do not exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:20:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:20:04 +0000
Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not
calculate"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #12 from Katrin Fischer ---
Doesn't apply to 16.11.x, please rebase if you want it included.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:21:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:21:12 +0000
Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #11 from Katrin Fischer ---
Dependency is not in 16.11.x (doesn't apply). Please take a look if you want
this included.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:24:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:24:20 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #33 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:25:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:25:37 +0000
Subject: [Koha-bugs] [Bug 19003] Add a TestBuilder default for
borrowers.login_attempts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19003
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Depends on| |18314
--- Comment #8 from Katrin Fischer ---
Dependent on bug 18314 which is not in 16.11.x.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314
[Bug 18314] Account lockout
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:25:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:25:37 +0000
Subject: [Koha-bugs] [Bug 18314] Account lockout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19003
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19003
[Bug 19003] Add a TestBuilder default for borrowers.login_attempts
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:28:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:28:02 +0000
Subject: [Koha-bugs] [Bug 5471] Quotes in tags cause moderation
approval/rejection to fail
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #11 from Katrin Fischer ---
Patches don't apply cleanly to 16.11.x for the template changes to review.tt.
Please provide a patch for 16.11.x if you want this included.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:28:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:28:57 +0000
Subject: [Koha-bugs] [Bug 19042] Silence warnings t/db_dependent/Letters.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #8 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:30:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:30:59 +0000
Subject: [Koha-bugs] [Bug 19047] Fix AddBiblio call in Reserves.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19047
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:33:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:33:07 +0000
Subject: [Koha-bugs] [Bug 19070] Fix Circulation/Branch.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19070
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Stable |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Katrin Fischer ---
Patron clubs is not in 16.11.x, so this patch doesn't apply to 16.11.x.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:35:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:35:19 +0000
Subject: [Koha-bugs] [Bug 19071] Fix Circulation/issue.t and
Members/IssueSlip.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19071
--- Comment #11 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:37:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:37:05 +0000
Subject: [Koha-bugs] [Bug 13012] suggestion.suggesteddate should be set to
NOW if not defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13012
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #8 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:38:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:38:10 +0000
Subject: [Koha-bugs] [Bug 18941] C4:: Budgets GetBudgetByCode should return
active budgets over inactive budgets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #12 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:39:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:39:44 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #5 from Alex Buckley ---
Created attachment 67492
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67492&action=edit
Bug 19243 - Selenium test for testing administrative tasks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:41:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:41:10 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66788|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:41:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:41:46 +0000
Subject: [Koha-bugs] [Bug 18985] SQL reports 'Last edit' and 'Last run'
columns sort alphabetically, not chronologically
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18985
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Pushed to Stable |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Katrin Fischer ---
There is no 'Last Run' in 16.11.x as this is a 17.05 feature. Also no 'Last
edit'.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:42:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:42:02 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67492|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:43:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:43:10 +0000
Subject: [Koha-bugs] [Bug 19027] Circulation rules: Better wording for
standard rules for all libraries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19027
--- Comment #11 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:43:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:43:22 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #6 from Alex Buckley ---
Created attachment 67493
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67493&action=edit
Bug 19243 - Selenium test for testing administrative tasks
This selenium test checks the following Administrative module
functionality:
* Add item type
* Add circulation rule
* Modify frameworks
* Add library
* Add authorised values
* Add patron category
* Add patron attribute type
* Add Z39.50 target server
* Add item circulation alert
* Add city
Test plan (this test plan includes how to install Selenium as well as how to
run this test, for the benefit of people who have not got
Selenium installed on their machines):
1. wget
https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar
2. vim /etc/apt/sources.list.d/firefox.list
3. Paste into the file:
deb http://packages.linuxmint.com debian import
4. sudo apt-get update
5. sudo apt-get install firefox
6. sudo apt-get install xvfb
7. Set the SELENIUM_PATH vartiable:
SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar
8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null &
9. DISPLAY=:1 java -jar $SELENIUM_PATH
Note: This will start up the selenium server. Everytime you want to
shutdown this terminal window and want to restart Selenium just run
the step 9 command to restart the Selenium server
10. Open a new terminal window and write in:
git clone https://github.com/gempesaw/Selenium-Remote-Driver
--branch build/master --single-branch --depth 1
11. cd Selenium-Remote-Driver
12. perl Makefile.PL
13. make
14. make test
15. sudo make install
16. Now everything is installed and you can set up for running the
selenium tests
17. Drop and recreate the Koha database and restart memcached
18. Go through the web installer installing all sample data and
onboarding tool
19. Create a superlibrarian user with the username koha and password koha
20. If your usual port configuration for the intranet and OPAC is
8081 and 8080 respectively then set the staffClientBaseURL and
OPACBaseURL system preferences to localhost:8080 and localhost:80
respectively
21. sudo koha-shell
22. perl t/db_dependent/selenium/administration_tasks.t
23. The test should pass.
Note: The time_diff comments in the test output showing what the
test is doing
Note: If you have issues with installing Selenium and
Selenium::Remote::Driver please write a comment on the bug report
and I will be more than happy to create a screencapture video
showing all the steps
Note: Warns in front of the $driver->get_title() function have been
implemented because during troubleshooting they were found to be an
effective solution for stopping the test from failing due to not
being able to find an element on the page. If anyone can suggest an
alternative to using these warns please do
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:45:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:45:21 +0000
Subject: [Koha-bugs] [Bug 18292] Tests do not need to return 1;
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292
--- Comment #26 from Katrin Fischer ---
Patch set doesn't apply cleanly to 16.11.x. Please rebase if you want this to
be included.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Oct 1 23:55:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 21:55:03 +0000
Subject: [Koha-bugs] [Bug 18469] Suspend all holds when specifying a date to
resume hold does not keep date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #9 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:14:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:14:52 +0000
Subject: [Koha-bugs] [Bug 9409] koha-create --request-db should be able to
accept a dbhost option
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #9 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:16:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:16:08 +0000
Subject: [Koha-bugs] [Bug 18817] Update links in the help files for the new
17.11 manual
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817
--- Comment #26 from Katrin Fischer ---
Not applying to 16.11.x (still the old manual there)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:18:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:18:00 +0000
Subject: [Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more
than two names well
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #8 from Katrin Fischer ---
Doesn't apply cleanly to 16.11.x - please provide a rebased patch if you want
this to be included.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:19:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:19:14 +0000
Subject: [Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for
attribute 'name'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Stable |RESOLVED
CC| |katrin.fischer at bsz-bw.de
--- Comment #15 from Katrin Fischer ---
Dependent bug 13726 is not in 16.11.x.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:19:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:19:14 +0000
Subject: [Koha-bugs] [Bug 18120] CRUD endpoint for vendors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120
Bug 18120 depends on bug 19130, which changed state.
Bug 19130 Summary: K::A::Booksellers->search broken for attribute 'name'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Stable |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:20:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:20:19 +0000
Subject: [Koha-bugs] [Bug 19126] Fix Members.t with IndependentBranches set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:22:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:22:29 +0000
Subject: [Koha-bugs] [Bug 19118] Due to wrong variable name passed vendor
name is not coming in browser title bar
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #9 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:22:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:22:45 +0000
Subject: [Koha-bugs] [Bug 19393] New: Error date Returns
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19393
Bug ID: 19393
Summary: Error date Returns
Change sponsored?: ---
Product: Koha
Version: 16.11
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: carlos.cordovas at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Hello friends
I have koha Koha 16.1112000 on debian 9. I have a problem with the return time
is two hours later than the actual return time.
how to replicate the error.
1.- make a loan
2.- immediately return the book
3.- go to history of circulation and sort by date
4.- verify that the return time is two hours later
this is the TZ / DATE / HWCLOCK configuration
root at catalogo:/etc# timedatectl
Local time: Sun 2017-10-01 19:01:59 -03
Universal time: Sun 2017-10-01 22:01:59 UTC
RTC time: Sun 2017-10-01 22:03:00
Time zone: America/Santiago (-03, -0300)
Network time on: no
NTP synchronized: no
RTC in local TZ: no
root at catalogo:/etc# date
Sun Oct 1 19:02:01 -03 2017
root at catalogo:/etc# hwclock
2017-10-01 19:03:05.606684-0300
root at catalogo:/etc#
Sample from staff
issues Date 19:01
https://snag.gy/c6dz37.jpg
incorrect return time 22:04
https://snag.gy/cr90Kd.jpg
Regards
-Carlos
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:23:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:23:12 +0000
Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for
17.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Stable |RESOLVED
--- Comment #22 from Katrin Fischer ---
Obviously not for 16.11.x :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:24:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:24:04 +0000
Subject: [Koha-bugs] [Bug 19088] plugins-upload.pl causes uninitialized
value noise
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #10 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:25:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:25:21 +0000
Subject: [Koha-bugs] [Bug 18687] Translatability: abbr tag should not
contain lang attribute
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |trivial
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:28:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:28:05 +0000
Subject: [Koha-bugs] [Bug 18754] Translatability: Get rid of exposed tt
directives in opac-detail.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #15 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:28:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:28:41 +0000
Subject: [Koha-bugs] [Bug 18776] Translatability: Get rid of exposed tt
directives in opac-advsearch.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18776
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:31:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:31:11 +0000
Subject: [Koha-bugs] [Bug 18777] Translatability: Get rid of exposed tt
directives in opac-memberentry.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:31:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:31:48 +0000
Subject: [Koha-bugs] [Bug 18779] Translatability: Get rid of exposed tt
directives in authorities-search-results.inc (OPAC)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779
--- Comment #9 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:32:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:32:23 +0000
Subject: [Koha-bugs] [Bug 18780] Translatability: Get rid of exposed tt
directive in masthead-langmenu.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:33:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:33:19 +0000
Subject: [Koha-bugs] [Bug 18781] Translatability: Get rid of exposed tt
directives in openlibrary-readapi.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18781
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 00:35:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Oct 2017 22:35:41 +0000
Subject: [Koha-bugs] [Bug 18871] It is unclear how to view a patron list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18871
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.13.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 04:54:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 02:54:54 +0000
Subject: [Koha-bugs] [Bug 19393] Error date Returns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19393
Carlos C?rdova changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #1 from Carlos C?rdova ---
it was server configuration problem.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 05:08:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 03:08:06 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67493|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 05:08:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 03:08:33 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #7 from Alex Buckley ---
Created attachment 67494
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67494&action=edit
Bug 19243 - Selenium test for testing administrative tasks
This selenium test checks the following Administrative module
functionality:
* Add item type
* Add circulation rule
* Modify frameworks
* Add library
* Add authorised values
* Add patron category
* Add patron attribute type
* Add Z39.50 target server
* Add item circulation alert
* Add city
Test plan (this test plan includes how to install Selenium as well as how to
run this test, for the benefit of people who have not got
Selenium installed on their machines):
1. wget
https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar
2. vim /etc/apt/sources.list.d/firefox.list
3. Paste into the file:
deb http://packages.linuxmint.com debian import
4. sudo apt-get update
5. sudo apt-get install firefox
6. sudo apt-get install xvfb
7. Set the SELENIUM_PATH vartiable:
SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar
8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null &
9. DISPLAY=:1 java -jar $SELENIUM_PATH
Note: This will start up the selenium server. Everytime you want to
shutdown this terminal window and want to restart Selenium just run
the step 9 command to restart the Selenium server
10. Open a new terminal window and write in:
git clone https://github.com/gempesaw/Selenium-Remote-Driver
--branch build/master --single-branch --depth 1
11. cd Selenium-Remote-Driver
12. perl Makefile.PL
13. make
14. make test
15. sudo make install
16. Now everything is installed and you can set up for running the
selenium tests
17. Drop and recreate the Koha database and restart memcached
18. Go through the web installer installing all sample data and
onboarding tool
19. Create a superlibrarian user with the username koha and password koha
20. If your usual port configuration for the intranet and OPAC is
8081 and 8080 respectively then set the staffClientBaseURL and
OPACBaseURL system preferences to localhost:8080 and localhost:80
respectively
21. sudo koha-shell
22. perl t/db_dependent/selenium/administration_tasks.t
23. The test should pass.
Note: The time_diff comments in the test output showing what the
test is doing
Note: If you have issues with installing Selenium and
Selenium::Remote::Driver please write a comment on the bug report
and I will be more than happy to create a screencapture video
showing all the steps
Note: Warns in front of the $driver->get_title() function have been
implemented because during troubleshooting they were found to be an
effective solution for stopping the test from failing due to not
being able to find an element on the page. If anyone can suggest an
alternative to using these warns please do
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 05:09:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 03:09:05 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #8 from Alex Buckley ---
Created attachment 67495
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67495&action=edit
Bug 19243 - Followup moving common Selenium functions into a seperate module
In this patch a module t/lib/Selenium.pm has been created and it
contains the auth, patron_auth, patron_opac_auth, cleaup, time_difffunctions
which are common to other Selenium text scripts.
Also a function to wait for an element to be found before it is
interacted with was created and it is called pause_driver
At present this pause_driver function throws an error in the test output
saying that it cannot find an element and then it fails.
Test plan (this test plan includes how to install Selenium as well as how to
run this test, for the benefit of people who have not got
Selenium installed on their machines):
1. wget
https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar
2. vim /etc/apt/sources.list.d/firefox.list
3. Paste into the file:
deb http://packages.linuxmint.com debian import
4. sudo apt-get update
5. sudo apt-get install firefox
6. sudo apt-get install xvfb
7. Set the SELENIUM_PATH vartiable:
SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar
8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null &
9. DISPLAY=:1 java -jar $SELENIUM_PATH
Note: This will start up the selenium server. Everytime you want to
shutdown this terminal window and want to restart Selenium just run
the step 9 command to restart the Selenium server
10. Open a new terminal window and write in:
git clone https://github.com/gempesaw/Selenium-Remote-Driver
--branch build/master --single-branch --depth 1
11. cd Selenium-Remote-Driver
12. perl Makefile.PL
13. make
14. make test
15. sudo make install
16. Now everything is installed and you can set up for running the
selenium tests
17. Drop and recreate the Koha database and restart memcached
18. Go through the web installer installing all sample data and
onboarding tool
19. Create a superlibrarian user with the username koha and password
koha
20. If your usual port configuration for the intranet and OPAC is
8081 and 8080 respectively then set the staffClientBaseURL and
OPACBaseURL system preferences to localhost:8080 and localhost:80
respectively
21. sudo koha-shell
22. perl t/db_dependent/selenium/administration_tasks.t
23. The test should pass.
Note: The time_diff comments in the test output showing what the
test is doing
Note: If you have issues with installing Selenium and
Selenium::Remote::Driver please write a comment on the bug report
and I will be more than happy to create a screencapture video
showing all the steps
Note: Warns in front of the $driver->get_title() function have been
implemented because during troubleshooting they were found to be an
effective solution for stopping the test from failing due to not
being able to find an element on the page. If anyone can suggest an
alternative to using these warns please do
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 05:14:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 03:14:15 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #9 from Alex Buckley ---
Created attachment 67496
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67496&action=edit
Bug 19243 - Followup patch with xpaths changed to id's
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 05:27:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 03:27:25 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67496|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 05:27:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 03:27:50 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #10 from Alex Buckley ---
Created attachment 67497
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67497&action=edit
Bug 19243 - Followup patch with xpaths changed to id's
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 06:50:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 04:50:09 +0000
Subject: [Koha-bugs] [Bug 19394] New: Add ability for IT administrators to
skip onboarding tool ,
and then display the tool to superlibrarians when they first log in
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394
Bug ID: 19394
Summary: Add ability for IT administrators to skip onboarding
tool, and then display the tool to superlibrarians
when they first log in
Change sponsored?: ---
Product: Koha
Version: 17.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Installation and upgrade (web-based installer)
Assignee: koha-bugs at lists.koha-community.org
Reporter: alexbuckley at catalyst.net.nz
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
In many institutions it is the IT administrator staff member or support vendor
rather than a librarian that will install Koha. These people may not know what
the institution would like to set for the library branch, patron category,
patron superlibrarian, item type and circulation rule and so it would be good
to provide the ability for these users to skip the onboarding tool.
In order to make sure that this data is entered the next user they tries to
login with the koha database administrator account is prompted back to the
onboarding tool to complete it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 06:51:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 04:51:52 +0000
Subject: [Koha-bugs] [Bug 19394] Add ability for IT administrators to skip
onboarding tool,
and then display the tool to superlibrarians when they first log in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394
--- Comment #1 from Alex Buckley ---
Created attachment 67498
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67498&action=edit
Bug 19394 - Ability to skip the onboarding tool implemented
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 07:55:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 05:55:04 +0000
Subject: [Koha-bugs] [Bug 19395] New: [17.05][16.11] t/db_dependent/www/
auth_values_input_www.t is failing
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19395
Bug ID: 19395
Summary: [17.05][16.11]
t/db_dependent/www/auth_values_input_www.t is failing
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: fridolin.somers at biblibre.com, tomascohen at gmail.com
Since the push of the security fixes 3 tests for
t/db_dependent/www/auth_values_input_www.t
are failing.
I haven't figured out yet what the reason is, help appreciated.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 07:55:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 05:55:24 +0000
Subject: [Koha-bugs] [Bug 19395] [17.05][16.11] t/db_dependent/www/
auth_values_input_www.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19395
--- Comment #1 from Katrin Fischer ---
t/db_dependent/www/auth_values_input_www.t .. 2/33
# Failed test 'Add a new category button should be displayed'
# at t/db_dependent/www/auth_values_input_www.t line 90.
# got: '0'
# expected: '1'
# Failed test 'Add a new category button should be displayed'
# at t/db_dependent/www/auth_values_input_www.t line 110.
# got: '0'
# expected: '1'
t/db_dependent/www/auth_values_input_www.t .. 20/33
# Failed test at t/db_dependent/www/auth_values_input_www.t line 166.
# got: '0'
# expected: '1'
# Looks like you failed 3 tests of 33.
t/db_dependent/www/auth_values_input_www.t .. Dubious, test returned 3 (wstat
768, 0x300)
Failed 3/33 subtests
Test Summary Report
-------------------
t/db_dependent/www/auth_values_input_www.t (Wstat: 768 Tests: 33 Failed: 3)
Failed tests: 8, 12, 26
Non-zero exit status: 3
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 08:32:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 06:32:02 +0000
Subject: [Koha-bugs] [Bug 19127] Stored XSS in csv-profiles.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19127
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 08:32:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 06:32:06 +0000
Subject: [Koha-bugs] [Bug 19108] Stored XSS in multiple scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19108
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 08:32:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 06:32:10 +0000
Subject: [Koha-bugs] [Bug 19103] Stored XSS in itemtypes.pl -
patron-attr-types.pl - matching-rules.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19103
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 10:33:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 08:33:21 +0000
Subject: [Koha-bugs] [Bug 19190] Silly calculation of average time in
touch_all scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66550|0 |1
is obsolete| |
--- Comment #4 from Marcel de Rooy ---
Created attachment 67499
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67499&action=edit
Bug 19190: Silly calculation of average time in touch_all scripts
When you want to calculate average time, do not divide count by time :)
Test plan:
Run the script with a where condition and verbose option and see that
the average time is meaningful.
Signed-off-by: Marcel de Rooy
Signed-off-by: David Bourgault
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 10:33:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 08:33:25 +0000
Subject: [Koha-bugs] [Bug 19190] Silly calculation of average time in
touch_all scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67332|0 |1
is obsolete| |
--- Comment #5 from Marcel de Rooy ---
Created attachment 67500
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67500&action=edit
Bug 19190: [Follow-up] Do not rely on the return of ModItem
touch_all_items looks at the return of ModItem to determine if the
operation was successful. But ModItem does not return a meaningful
value. This patch puts the ModItem call in an eval and looks at $@.
Test plan:
Run touch_all_items with a where condition and verbose option.
Put print 1/0; at the end of ModItem.
Run touch_all_items again. You should see: ERROR WITH ITEM xxx !!!!
Signed-off-by: Marcel de Rooy
Signed-off-by: David Bourgault
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 10:34:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 08:34:09 +0000
Subject: [Koha-bugs] [Bug 19190] Silly calculation of average time in
touch_all scripts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190
--- Comment #6 from Marcel de Rooy ---
(In reply to David Bourgault from comment #3)
> Signed-off-by: David Bourgault
Thanks, David.
I added your signoff line also to the first patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 10:49:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 08:49:59 +0000
Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149
--- Comment #10 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #8)
> We really should remove Koha::Authorities->get_usage_count and
> Koha::Authorities->linked_biblionumbers, they are not method for the object
> set class.
Yes, I did put them here temporarily. When refactoring goes further and we have
these single objects in place, it will be trivial to move the code from the
plural class to the singular class.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:50:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:50:05 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66327|0 |1
is obsolete| |
Attachment #66328|0 |1
is obsolete| |
Attachment #66329|0 |1
is obsolete| |
Attachment #66330|0 |1
is obsolete| |
Attachment #66331|0 |1
is obsolete| |
--- Comment #56 from Marcel de Rooy ---
Created attachment 67501
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67501&action=edit
Bug 10306: Core module changes for multiple mappings
In order to allow multiple Koha to MARC mappings (for one kohafield), we
need to adjust a few key routines in C4/Biblio.pm. This results in a few
changes in dependent modules too.
Note: Multiple mappings also include 'alternating' mappings. Such as the
case of MARC21 260 and 264: only one of both fields will be used. Sub
TransformMarcToKoha will handle that just fine; the opposite transformation
is harder, since we do no longer know which field was the source. In that
case TransformKohaToMarc will fill both fields. We only use that operation
in Koha for items (in Acquisition and Cataloging).
Sub GetMarcSubfieldStructure
This sub used a selectall_hashref, which is fine as long as we have only
one mapping for each kohafield. But as DBI states it: If a row has the same
key as an earlier row then it replaces the earlier row. In other words,
we lose the first mapping if we have two.
This patch uses selectall_arrayref with Slice and rearranges the output so
that the returned hash returns an arrayref of hashrefs for each kohafield.
In order to improve consistency, we add an order clause to the SQL
statement used too.
Sub GetMarcFromKohaField
This sub just returned one tag and subfield, but in case of multiple
mappings we should return them all now.
Note: Many calls still expect just one result and will work just fine:
my ($tag, $sub) = GetMarcFromKohaField(...)
A possible second mapping would be silently ignored. Often the sub is
called for biblionumber or itemnumber. I would not recommend the use of
multiple mappings for such fields btw.
In case the sub is called in scalar context, it will return only the first
tag (instead of the number of tags and subfields).
Sub GetMarcSubfieldStructureFromKohaField
This sub previously returned the hash for one kohafield.
In scalar context it will behave like before: it returns the first hashref
in the arrayref that comes from GetMarcSubfieldStructure.
In list context, it returns an array of all hashrefs (incl. multiple
mappings).
The sub is not used in C4::Ris. Removed the use statement.
Sub TransformKohaToMarc
This sub got a second parameter: frameworkcode.
Historically, Koha more or less assumes kohafields to be defined across all
frameworks (see Koha to MARC mappings). Therefore it falls back to Default
when it is not passed.
When going thru all mappings in building a MARC record, it also supports
multiple mappings. Note that Koha uses this routine in Acquisition and in
Cataloging for items. Normally the MARC record is leading however and the
Koha fields are derivatives for optimization and reporting.
The added third parameter allows for passing a new option no_split => 1.
We use this option in C4::Items::Item2Marc; if two item fields are mapped to
one kohafield but would have different values (which would be very unusual),
these values are glued together. When transforming to MARC again, we do not
want to duplicate the item subfields, but we keep the glued value in both
subfields. This operation only affects items, since we are not doing this
reverse operation for biblio and biblioitem fields.
Sub _get_inverted_marc_field_map
This sub is a helper routine of TransformMarcToKoha, the opposite
transformation. When saving a MARC record, all kohafields are extracted
including multiple mappings.
Suppose that you had both 260c and 264c in your record (which you won't),
than both values get saved initially into copyrightdate like A | B. The
additional code for copyrightdate will extract the first year from this
string.
A small fix in TransformMarcToKoha makes that it only saves a value in a
kohafield if it is defined and not empty. (Same for concatenation.)
Sub TransformMarcToKohaOneField
This sub now just calls TransformMarcToKoha and extracts the requested
field. Note that since we are caching the structure, this does not result
in additional database access and is therefore performance-wise
insignificant. We simplify code and maintenance.
Instead of modifying the passed hashref, it simply returns a value. A call
in C4::Breeding is adjusted accordingly. The routine getKohaField in
Koha::MetadataRecord is redirected to TransformMarcToKohaOneField.
NOTE: The fourth patch restructures/optimizes TransformMarcToKoha[OneField].
Sub get_koha_field_from_marc
This sub can be removed. A call is replaced by TransformMarcToKohaOneField
in C4::XISBN.
Note: The commented lines for sub ModZebrafiles are removed (directly under
TransformMarcToKohaOneField).
Test plan:
For unit tests and interface tests, please see follow-ups.
Run qa tools in order to verify that the modules still compile well.
Read the code changes and verify that they make sense.
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:50:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:50:11 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
--- Comment #57 from Marcel de Rooy ---
Created attachment 67502
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67502&action=edit
Bug 10306: Allow controlfields in TransformKohaToMarc
Since the interface allows you to connect a kohafield to a MARC
controlfield, this routine should be able to handle that. Unfortunately
it did not.
Test plan:
Change will be tested in Biblio/TransformKohaToMarc.t in the next patch.
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:50:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:50:16 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
--- Comment #58 from Marcel de Rooy ---
Created attachment 67503
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67503&action=edit
Bug 10306: Add tests for module changes
GetMarcSubfieldStructure: In Biblio.t we are adding a subtest that checks
the structure returned by this routine. Is it a hashref pointing to
arrayrefs of hashrefs? ;)
In Search.t this routine was mocked. The change in the returned structure
is now applied to this mock too (moving the marc tag hashes into
arrayrefs).
GetMarcFromKohaField: In Biblio.t we add a subtest for it. We are checking
if it returns multiple mappings (per kohafield) and calling it in scalar
context too.
GetMarcSubfieldStructureFromKohaField: The existing subtest in Biblio.t is
expanded to also test the call in list context.
TransformKohaToMarc: This sub has its own test script. We are adding a
subtest in TransformKohaToMarc.t for a test with multiple mappings,
and for mapping to a control field in another framework. This also tests
the additional framework parameter.
Additionally, we add a test for the new no_split option used for items.
TransformMarcToKoha: This implicitly tests its helper sub _get_inverted.
This patch adds a new test script for this routine.
TransformMarcToKohaOneField: A few tests are added to the previous new
test script.
Test plan:
[1] Run t/db_dependent/Biblio.t
[2] Run t/db_dependent/Biblio/TransformKohaToMarc.t
[3] Run t/db_dependent/Biblio/TransformMarcToKoha.t
[4] Run t/db_dependent/Search.t
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:50:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:50:21 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
--- Comment #59 from Marcel de Rooy ---
Created attachment 67504
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67504&action=edit
Bug 10306: Restructure TransformMarcToKoha and update some POD lines
This patch makes the following changes:
[1] Added POD for CountItemsIssued, GetBiblioItemData
[2] Moved TransformMarcToKohaOneField closer to TransformMarcToKoha (before
sub CountItemsIssued)
[3] Restructured TransformMarcToKoha by extracting individual kohafields via
TransformMarcToKohaOneField. The latter does no longer call the former.
This small optimization avoids traversing the whole MARC record again
and again.
[4] Moved adjusting copyrightdate/publicationyear to separate helper routine
_adjust_pubyear
[5] Removed obsolete sub _get_inverted_marc_field_map.
Test plan:
Run t/db_dependent/Biblio/TransformMarcToKoha.t
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:50:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:50:32 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66547|0 |1
is obsolete| |
--- Comment #61 from Marcel de Rooy ---
Created attachment 67506
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67506&action=edit
Bug 10306: Adjusted online help text for koha2marclinks
Test plan:
Click on Help. Read the text.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:50:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:50:26 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
--- Comment #60 from Marcel de Rooy ---
Created attachment 67505
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67505&action=edit
Bug 10306: Support for multiple mappings in koha2marclinks
This actually refactors koha2marclinks.pl in order to support multiple
mappings per kohafield.
Instead of three separate mapping pages for biblio, biblioitems and items,
the script now lists them together. This gives a complete overview of all
mappings rightaway. Changes are applied immediately across all frameworks.
Note: This report handles the Default mappings just like it did before.
In this script Koha already considered them as authoritative, although
other parts of Koha did not. Follow-up report 19096 makes Default
mappings authoritative throughout all Koha.
On each line two buttons are provided, Add and Remove, in order to add or
remove an individual mapping. We do no longer provide a separate form with
the names of MARC tags. Since this form is targeted for administrators,
it should be enough to ask for a field tag and subfield code.
Note: The mappings for biblionumber, biblioitemnumber and itemnumber are
so vital that this form marks them as readonly. It is not recommended to
change them.
Test plan:
[1] Add a mapping. Verify via Frameworks or mysql command line that the
kohafield is saved to the other frameworks too.
[2] Remove the mapping again. Check Frameworks or mysql cl again.
[3] Test adding a second mapping. Map copyrightdate to 260c and 264c.
And map biblioitems.place to 260a and 264a.
[4] Edit biblio record 1: Put 1980 in 260c. Do not include 264c.
Edit biblio record 2: Put 1990 in 264c. Do not include 260c.
Edit biblio record 3: Put 2000 in both 260c and 264c. Put CityA in 260a
and in 264a.
Edit biblio record 4: Put 2010 in 260c, and 2015 in 264c (which you
should refuse normally). Put CityA in 260a, and CityB in 264a.
[5] Create a report that shows biblioitems.place and biblio.copyrightdate
for those biblio records.
Record 4 should have 2010 in copyrightdate (since TransformMarcToKoha
picks the first year for copyrightdate).
Record 3 should have place CityA; record 4 should have CityA | CityB.
Note: The CityA | CityB example illustrates that we should add some
additional handling in TransformMarcToKoha for multiple 264s.
[6] Add these four biblio records to a new list. Sort by Year.
With OPACXSLTListsDisplay==default, check if the order = 1,2,3,4.
(The order is based on biblio.copyrightdate.)
Note that (RDA) record 2 would be on top without this patch set, since
copyrightdate would have been null.
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:50:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:50:37 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66548|0 |1
is obsolete| |
--- Comment #62 from Marcel de Rooy ---
Created attachment 67507
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67507&action=edit
Bug 10306: [QA Follow-up] Correct a TestBuilder call
In order to create a new framework, MarcSubfieldStructure was used as
source. This works since that table contains a FK for frameworkcode.
But obviously, we should use BiblioFramework as source.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:51:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:51:09 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
--- Comment #63 from Marcel de Rooy ---
Simple rebase
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:55:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:55:25 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
Default authoritative
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66406|0 |1
is obsolete| |
--- Comment #16 from Marcel de Rooy ---
Created attachment 67508
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67508&action=edit
Bug 19096: Make Default authoritative in core modules
After feedback from the dev mailing list, it seems appropriate here to
propose making the Default framework authoritative for Koha to MARC
mappings. This implies checking only the Default framework in the
routines:
[1] GetMarcFromKohaField: The parameter frameworkcode is removed. A
follow-up report (19097) will update the calls not adjusted here.
This is safe since the parameter is silently ignored.
[2] GetMarcSubfieldStructureFromKohaField: Framework parameter is removed
and calls are adjusted. Includes acquisitions_stats.pl.
[3] TransformKohaToMarc: The parameter is removed; all calls are verified
or adjusted.
[4] TransformMarcToKoha: The parameter is no longer used and will be
removed in a follow-up report (19097). It always goes to Default now.
[5] TransformMarcToKohaOneField: The parameter is removed and all calls
are adjusted. Including: Breeding, XISBN and MetadataRecord modules.
[6] C4::Koha::IsKohaFieldLinked: This routine was called only once (in
C4::Items::_build_default_values_for_mod_marc. It can be replaced by
calling GetMarcFromKohaField. If there is no kohafield linked, undef
is returned. (Corresponding unit test is removed here.)
[7] C4::Items::ModItemFromMarc: The helper routine
_build_default_values_for_mod_marc does no longer have a framework
parameter. The cache key default_value_for_mod_marc- is no longer
combined with a frameworkcode. Three admin scripts are adjusted
accordingly; some tests will be corrected in the next patch.
Test plan:
See next patch. That patch adjusts all tests involved.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:55:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:55:29 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
Default authoritative
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66407|0 |1
is obsolete| |
--- Comment #17 from Marcel de Rooy ---
Created attachment 67509
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67509&action=edit
Bug 19096: Adjusts unit tests
The subroutines listed in the former patch are extensively tested in
Biblio.t, TransformKohaToMarc.t and TransformMarcToKoha.t.
These tests do no longer use new frameworks to add mappings.
In Biblio.t and TransformMarcToKoha.t we also test passing an individual
framework code (for an empty framework) to see if Default is still used.
Note that this parameter will be removed later on.
In Items.t the cache keys MarcStructure-0- and MarcStructure-1- are not
touched, so they do not need to be cleared. The cache key
default_value_for_mod_marc- should be used without framework now.
Similar adjustments in Items/AutomaticItemModificationByAge.t and
Reserves.t.
Furthermore the subtest for _build_default_values_for_mod_marc in Items.t
is adjusted since framework is no longer relevant. The biblio record with
items is created in a new framework, but the mappings from Default are
consulted.
Test plan:
Run all adjusted unit tests.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:55:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:55:32 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
Default authoritative
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66408|0 |1
is obsolete| |
--- Comment #18 from Marcel de Rooy ---
Created attachment 67510
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67510&action=edit
Bug 19096: Do not allow changes to kohafield within MARC frameworks
This patch makes two changes in the script for managing the MARC
frameworks in order to support making the Default authoritative
as for Koha to MARC mappings:
[1] Disable the kohafield select combo. Add a hidden input to save value.
[2] When a new subfield is added, the kohafield is still empty and should
be overwritten with its Default counterpart.
Note: Although we could leave the field empty, since Koha looks at the
Default framework only, it does not cost much to keep these fields in
sync with Default and perhaps catch a bug when someone somewhere looks
in the wrong framework.
Note: The description of Koha to MARC mapping on admin-home has been
adjusted accordingly (removing last two lines).
Test plan:
[1] Add a new tag and subfield in Default.
[2] Map it to a kohafield in koha2marclinks.pl
[3] Add the same tag and subfield in another framework.
Verify that the kohafield is updated after you saved the subfield.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:55:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:55:36 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
Default authoritative
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66409|0 |1
is obsolete| |
--- Comment #19 from Marcel de Rooy ---
Created attachment 67511
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67511&action=edit
Bug 19096: Online help changes
On the page admin/marc_subfields_structure we now tell that Koha link
has been disabled and refer to the help for koha2marclinks.
On the page admin/koha2marclinks we mention that the Default mapping is
considered authoritative now.
Test plan:
Read these online help pages and verify that the changes make sense.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:55:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:55:40 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
Default authoritative
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66410|0 |1
is obsolete| |
--- Comment #20 from Marcel de Rooy ---
Created attachment 67512
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67512&action=edit
Bug 19096: Restructure MarcSubfieldStructures.t first
Before adding more tests, move all current tests in one subtest.
Test plan:
Run t/db_dependent/Koha/MarcSubfieldStructures.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:55:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:55:44 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
Default authoritative
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66411|0 |1
is obsolete| |
--- Comment #21 from Marcel de Rooy ---
Created attachment 67513
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67513&action=edit
Bug 19096: Add dbrev to sync kohafield in all frameworks
The dbrev will use two new routines in MarcSubfieldStructures:
[1] get_kohafield_exceptions is used to report deviating kohafields in
the additional frameworks,
[2] sync_kohafield is used to reset kohafield in the other frameworks to
the mapping in Default.
Test plan:
Unit test and database revision:
[1] Run t/db_dependent/Koha/MarcSubfieldStructures.t
[2] Verify that your Default 100a is mapped to biblio.author. Go to another
framework and clear the mapping via mysql command line:
UPDATE marc_subfield_structure SET kohafield=NULL WHERE
frameworkcode=[your_framework] AND tagfield='100' AND tagsubfield='a';
[3] Run the db revision. It should report that 100a was adjusted.
[4] Check in admin/marc_subfield_structure that your 100a is mapped to
biblio.author again in that framework.
Additional interface testing (ensuring that the changes on this report do
not interfere with multiple mappings):
[5] Make two mappings for copyrightdate: 260c and 264a. And make two
mappings for biblioitems.pages: 300a and say 300g. Toggle with some
field values in those fields in the cataloging editor and verify the
contents of biblio.copyrightdate and biblioitems.pages. The former
should contain one year (due to additional logic) and the latter should
contain A | B if both fields are filled.
Remove the mapping for 300g.
[6] Set AcqCreateItem to ordering or placing. Verify that you can still
add or receive an order as usual.
[7] Add a mapping for itemcallnumber to 952f (this should remove the one
for coded_location_qualifier). This is very unusual but serves well in
testing multiple mappings for items.
Add or receive an order (fill 952f and 952o) with same and/or different
values. Verify the contents of items.callnumber. (Check with regular
item editor; see note.)
Do a similar edit in the regular item editor.
Note: You should expect to see A | B in both 952f and 925o if both
fields are filled with a different value.
Set items.coded_location_qualifier back to 952f in koha2marclinks.
Note: When AcqCreateItem==ordering, you will not see A|B in the callno
field when adding an item on neworderempty.pl. But when you submit
the main form, addorder.pl is called. At that time an item is created
and you will see that A|B is in both fields (952f and 952o).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 11:56:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 09:56:19 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
Default authoritative
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
--- Comment #22 from Marcel de Rooy ---
Simple rebase
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:02:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 10:02:35 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
html templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66317|0 |1
is obsolete| |
Attachment #66318|0 |1
is obsolete| |
Attachment #66319|0 |1
is obsolete| |
Attachment #66320|0 |1
is obsolete| |
Attachment #66321|0 |1
is obsolete| |
--- Comment #18 from Marcel de Rooy ---
Created attachment 67514
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67514&action=edit
Bug 17989: Centralize bad template check
The bad template check in get_template_and_user can be removed, since
this check has been added in gettemplate on bug 18010.
The check moves here to a new sub in C4::Templates. And will be extended
in a follow-up.
Removed unused variable $path in gettemplatefile.
Test plan:
[1] Run t/db_dependent/Auth.t (get_template_and_user bad calls).
[2] Run t/db_dependent/Templates.t (bad call to gettemplate).
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:02:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 10:02:39 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
html templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989
--- Comment #19 from Marcel de Rooy ---
Created attachment 67515
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67515&action=edit
Bug 17989: Extend bad template check
The check is now extended by only allowing templates from the regular
Koha template directories and additional plugin directories as defined
in koha-conf.xml.
Note: In order to prevent an uninitialized warning on $theme from sub
themelanguage for a not-existing file, I added a trivial assignment. Will
get further attention in a follow-up.
Test plan:
[1] Run t/db_dependent/Auth.t
[2] Run t/db_dependent/Templates.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:02:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 10:02:43 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
html templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989
--- Comment #20 from Marcel de Rooy ---
Created attachment 67516
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67516&action=edit
Bug 17989: Include full path logic in _get_template_file
Similar to the full path test in sub themelanguage, this patch makes a
change in _get_template_file. This allows you to pass a template
outside the modules directory to get_template_and_user. (Note: the sub
badtemplatecheck already blocks bad paths.)
Especially, this would be helpful for plugins using templates. As can be
seen in Templates.pm, a change was made earlier to overwrite the filename
for a plugin in sub gettemplate. This exception can now be removed.
Also note the small change in Koha/Plugin/Base.pm; mbf_path is already
absolute and if we pass a full path, we do not need it. This allows use of
a regular Koha template or a shared template between plugins (as long as
badtemplatecheck allows the path).
What are the side-effects of this change?
[1] We should not pass absolute paths if we mean relative ones.
A follow-up patch deals with one occurrence in the codebase.
No regressions for regular use.
[2] Plugins can call get_template_and_user directly or go via get_template
in Koha/Plugin/Base (absolute paths don't go via mbf_path).
Note: replaced two single quotes in Auth.pm to show template name in test
description.
Test plan:
[1] Open some page on OPAC or staff client to trigger a template.
[2] Run t/db_dependent/Auth.t to verify not allowing some bad templates.
[3] Run t/db_dependent/Templates.t to verify an absolute path.
[4] Run t/db_dependent/Plugins.t to verify using templates in a plugin.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:02:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 10:02:46 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
html templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989
--- Comment #21 from Marcel de Rooy ---
Created attachment 67517
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67517&action=edit
Bug 17989: Resolve "verbatim paragraph in NAME section" warning in
C4::Templates
*** WARNING: Verbatim paragraph in NAME section at line 28 in file
C4/Templates.pm
Test plan:
Run podchecker on C4::Templates and verify that the warning is resolved.
Signed-off-by: Marcel de Rooy
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:02:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 10:02:50 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
html templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989
--- Comment #22 from Marcel de Rooy ---
Created attachment 67518
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67518&action=edit
Bug 17989: Final changes
[1] The template sco/printslip.tt is in the regular modules directory.
Should not be prefixed with a slash.
[2] Script svc/members/search gets its template path from a URL parameter.
When you git grep json_template, you will have an idea what values it
should receive.
Test plan:
[1] Go intranet home page. Search for patrons in the combo box. Results?
[2] Try the URL /cgi-bin/koha/svc/members/search. Should trigger a 500
error with Bad template path in the logs.
[3] Try to find another occurrence just like the one corrected in
sco/printslip.pl where an absolute path is passed to gettemplate or
get_template_and_user. I already tried several regex variations
while git grepping template_name, but you may still find one..
Signed-off-by: Marcel de Rooy
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 12:03:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 10:03:09 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
html templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989
--- Comment #23 from Marcel de Rooy ---
Simple rebase
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 13:56:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 11:56:02 +0000
Subject: [Koha-bugs] [Bug 19396] New: Show availability line again on Place
Hold ( when nothing is available yet)
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19396
Bug ID: 19396
Summary: Show availability line again on Place Hold (when
nothing is available yet)
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
If the items of a book are on hold already, checked out, in transit, etc., it
would be helpful to see that again on the place hold form. (Perhaps in a yellow
dialog box on top.)
The information is on the search results now or in the items table on the form
but only after clicking the menu and clicking 'specific item'.
If the user does not open those and just adds a biblio level hold, it would be
helpful to have them informed already about the availability status.
Note that a user could reach the biblio detail page also from another page than
the search results. Perhaps via a list or a search with only one result?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:06:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:06:43 +0000
Subject: [Koha-bugs] [Bug 19397] New: Release team 17.11
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
Bug ID: 19397
Summary: Release team 17.11
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: About
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
Updating about team page for 17.11
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:07:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:07:24 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |18303
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303
[Bug 18303] Release team omnibus
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:07:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:07:24 +0000
Subject: [Koha-bugs] [Bug 18303] Release team omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19397
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
[Bug 19397] Release team 17.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:07:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:07:42 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |String patch
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:07:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:07:48 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:12:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:12:20 +0000
Subject: [Koha-bugs] [Bug 17608] Fix behaviour of bulkmarcimport.pl -insert
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17608
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=14420
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:12:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:12:20 +0000
Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17608
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:38:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:38:03 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:38:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:38:05 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
--- Comment #1 from Marcel de Rooy ---
Created attachment 67519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67519&action=edit
Bug 19397: Release team for 17.11
This patch adds the release team for 17.11 to about template.
Test plan:
Check the changes with the wiki pages for 17.05 and 17.11.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:48:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:48:49 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
administration module functionality
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
--- Comment #11 from Jonathan Druart ---
Quick note, to not forget:
Steps 10-15 should be
sudo cpanm -i Selenium::Remote::Driver
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 14:58:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 12:58:19 +0000
Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give
useful message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67480|0 |1
is obsolete| |
--- Comment #5 from Kyle M Hall ---
Created attachment 67520
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67520&action=edit
Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message
If a hold is 'waiting' for the patron to collect then the patron should be
prevented from cancelling the hold via their account in the opac.
If a patron tries to cancel the hold, Koha will give an 'are you sure' alert
and when you click Yes the page just refreshes and the hold remains.
Staff can cancel the hold from the staff interface but they can then action the
waiting hold.
I think therefore that it is correct behaviour that a patron cannot cancel a
hold when it reaches waiting state via the opac but it would be useful to
either have a warning to prevent the cancellation or a useful message when they
attempt to do so.
The template was using a method that tells Koha if *staff* can cancel a hold,
instead of patron.
Test Plan:
1) Set up a waiting hold
2) Try to cancel it from the opac
3) Note you cannot
4) Apply this patch
5) Reload the page
6) Note the cancel button has disappeared for found holds
Signed-off-by: Kyle M Hall
Signed-off-by: Caroline Cyr La Rose
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:05:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 13:05:07 +0000
Subject: [Koha-bugs] [Bug 18817] Update links in the help files for the new
17.11 manual
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Stable |RESOLVED
--- Comment #27 from Fridolin SOMERS ---
(In reply to Katrin Fischer from comment #25)
> I think we had agreed to use the old manual still for 17.05 and do the final
> switch with 17.11 - which means this shouldn't be pushed to 17.11.
Ah ok i revert and set resolved.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:16:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 13:16:43 +0000
Subject: [Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark
item seen" and doesn' t show data in table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324
--- Comment #2 from Marcel de Rooy ---
Jessie,
Thanks for your comments.
It could be clarifying to read the four commit messages on the patches of bug
14399. At least I hope so ;)
You say that the workflow for marking items has disappeared. The fourth patch
tells:
===
Currently, the value of compareinv2barcd is used to determine if the
Seen column, the Select/Clear all buttons and the Mark seen buttons are
displayed. But if we scanned barcodes, we already marked items as seen.
So we should only display these buttons when we did not upload barcodes.
===
In other words: We do no longer mark when we already marked.
> The second is Koha is not bringing back results (No data available in table) when you don't compare to a list.
It only reports errors on the barcodes you passed. If you do not pass barcodes,
you will get an inventory list. If I have two barcodes (one item not on shelf
H), I will get one result for the two barcodes and the filter on callnumber H.
That is the one on the wrong location. Commit message 2 and 3 tell you more.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:30:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 13:30:36 +0000
Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to
Koha::Patron-> notice_email_address
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304
--- Comment #3 from Jonathan Druart ---
Apply correctly for me, you need to apply the patches from bug 19303 first.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:30:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 13:30:42 +0000
Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to
Koha::Patron-> notice_email_address
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:37:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 13:37:01 +0000
Subject: [Koha-bugs] [Bug 18724] Upload cover image failed without error
message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18724
--- Comment #4 from Jonathan Druart ---
You should take a look at
https://dev.mysql.com/doc/refman/5.7/en/gone-away.html
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 15:56:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 13:56:52 +0000
Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned,
but not if renewed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805
Beth Lovallo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bethlovallo at taftschool.org
--- Comment #53 from Beth Lovallo ---
Any movement on this bug? We are new to Koha, and just ran into issues of staff
renewing items and the item is still lost with a bill. We would like to keep
the history, so reluctant to check in and check out again.
Thanks!
Beth
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:18:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 14:18:31 +0000
Subject: [Koha-bugs] [Bug 19395] [17.05][16.11] t/db_dependent/www/
auth_values_input_www.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19395
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19391
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #2 from Jonathan Druart ---
bug 19391?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:18:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 14:18:31 +0000
Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because
of bug 19128
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19395
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:22:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 14:22:09 +0000
Subject: [Koha-bugs] [Bug 19395] [17.05][16.11] t/db_dependent/www/
auth_values_input_www.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19395
--- Comment #3 from Katrin Fischer ---
Thx Joubu!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:56:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 14:56:08 +0000
Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip
when ES module not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66568|0 |1
is obsolete| |
--- Comment #11 from Tom?s Cohen Arazi ---
Created attachment 67521
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67521&action=edit
Bug 18897: Koha_Elasticsearch_Indexer.t doesn't skip when ES module(s) not
installed
If Catmandu::Importer::MARC is not installed,
Koha_Elasticsearch_Indexer.t fails instead of skipping.
It should skip as ES is not currently mandatory.
Test Plan:
1. Run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
as koha-shell
2. Note failure on test 1/5 indicating module not installed.
3. Apply patch.
4. Re-run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t"
5. Note test now skips.
Signed-off-by: Mark Tompsett
Signed-off-by: Lee Jamison
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:56:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 14:56:15 +0000
Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip
when ES module not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66569|0 |1
is obsolete| |
--- Comment #12 from Tom?s Cohen Arazi ---
Created attachment 67522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67522&action=edit
Bug 18897: Improve error message
Test Plan:
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
-- interactive apply just the first patch
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the wrong library is missing.
$ git bz apply 18897
-- interactive apply this patch
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
run the koha qa test tools
Signed-off-by: Mark Tompsett
Signed-off-by: Lee Jamison
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:56:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 14:56:22 +0000
Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip
when ES module not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66779|0 |1
is obsolete| |
--- Comment #13 from Tom?s Cohen Arazi ---
Created attachment 67523
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67523&action=edit
Bug 18897: Use Module::Load::Conditional::can_load
Rather than rely on eval(), Jonathan Druart recommended in
comment #6 to use Use Module::Load::Conditional::can_load.
This addresses that concern.
TEST PLAN
---------
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
$ sudo apt-get install libcatmandu-store-elasticsearch-perl
-- Note it runs as expected.
run the koha qa test tools
Signed-off-by: Lee Jamison
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 16:57:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 14:57:05 +0000
Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip
when ES module not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:13:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:13:28 +0000
Subject: [Koha-bugs] [Bug 19398] New: Wrong date format in quick patron
search table
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398
Bug ID: 19398
Summary: Wrong date format in quick patron search table
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
When searching for a patron from the circulation tab, the results table shows
the date of birth unformatted. (Confirmed for 16.11 so far)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:14:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:14:13 +0000
Subject: [Koha-bugs] [Bug 19399] New: Show reports screen should not display
query in textarea.
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399
Bug ID: 19399
Summary: Show reports screen should not display query in
textarea.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: koha-bugs at lists.koha-community.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
The Guided reports "Show SQL" e.g.
https://intranet.bywatersolutions.com/cgi-bin/koha/reports/guided_reports.pl?reports=120&phase=Show%20SQL
Looks very similar to the "Edit SQL" screen.
https://intranet.bywatersolutions.com/cgi-bin/koha/reports/guided_reports.pl?reports=120&phase=Edit%20SQL
Because of the visual similarity, there is a strong temptation to edit the SQL
on the Show SQL screen. This is an annoyance; it would be better UX to display
the SQL in a tag.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:21:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:21:08 +0000
Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip
when ES module not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
--- Comment #14 from Jonathan Druart ---
Sounds like we have other tests failing:
# Failed test 'Syntax check misc/search_tools/rebuild_elastic_search.pl'
# at /usr/share/perl5/Test/Strict.pm line 406.
# Can't locate Catmandu/Importer/MARC.pm in @INC (you may need to install the
Catmandu::Importer::MARC module) (@INC contains: installer misc/translator
/kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
/usr/local/share/perl/5.20.2/x86_64-linux-gnu-thread-multi
/usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
/usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl . /kohadevbox/koha /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
# BEGIN failed--compilation aborted at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
# Compilation failed in require at misc/search_tools/rebuild_elastic_search.pl
line 89.
# BEGIN failed--compilation aborted at
misc/search_tools/rebuild_elastic_search.pl line 89.
# Looks like you failed 1 test of 663.
[23:53:44] t/db_dependent/00-strict.t
# Failed test 'use Koha::SearchEngine::Elasticsearch::Search;'
# at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
# Tried to use 'Koha::SearchEngine::Elasticsearch::Search'.
# Error: Can't locate Catmandu/Store/ElasticSearch.pm in @INC (you may
need to install the Catmandu::Store::ElasticSearch module) (@INC contains:
/kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
/usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
/usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
# BEGIN failed--compilation aborted at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
# Compilation failed in require at
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
# BEGIN failed--compilation aborted at
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
Can't locate object method "search" via package
"Koha::SearchEngine::Elasticsearch::Search" at
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 47.
# Looks like your test exited with 255 just after 4.
[22:48:34] t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:22:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:22:57 +0000
Subject: [Koha-bugs] [Bug 18468] When adding from a staged file order
discounts are not passed into C4:: Acquisitions::populate_order_with_prices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:39:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:39:14 +0000
Subject: [Koha-bugs] [Bug 19029] Move the clone button and implement a
security question on smart-rules.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #10 from Jonathan Druart ---
Alex, you should use .format() to ease translation.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:39:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:39:32 +0000
Subject: [Koha-bugs] [Bug 19029] Move the clone button and implement a
security question on smart-rules.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:48:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:48:26 +0000
Subject: [Koha-bugs] [Bug 19374] CircSidebar overlapping transferred items
table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--- Comment #6 from Jonathan Druart ---
Upping severity, it impacts 17.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:48:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:48:48 +0000
Subject: [Koha-bugs] [Bug 19135] AllowHoldsOnPatronsPossessions is not
working
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66148|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:50:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:50:51 +0000
Subject: [Koha-bugs] [Bug 19135] AllowHoldsOnPatronsPossessions is not
working
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19135
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--- Comment #4 from Jonathan Druart ---
Upping severity, it impacts last 2 stable releases (17.05.x and 16.11.x).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 17:52:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 15:52:13 +0000
Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is
used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116
Joel Sasse changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsasse at plumcreeklibrary.net
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:06:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 16:06:10 +0000
Subject: [Koha-bugs] [Bug 19400] New: Reminder to unset gone no address flag
after patron makes a modification request
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19400
Bug ID: 19400
Summary: Reminder to unset gone no address flag after patron
makes a modification request
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: lari.taskula at jns.fi
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Our librarians requested a reminder to unset "gone no address" flag from
patron's record once the patron has made a modification request to update their
address.
I propose adding a message box under patron modification request to notify
librarians about patrons that have gone no address flag on, and an option to
unset the flag without the need of having to navigate into patron's details.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:06:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 16:06:19 +0000
Subject: [Koha-bugs] [Bug 19400] Reminder to unset gone no address flag
after patron makes a modification request
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19400
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:12:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 16:12:59 +0000
Subject: [Koha-bugs] [Bug 19400] Reminder to unset gone no address flag
after patron makes a modification request
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19400
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:13:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 16:13:01 +0000
Subject: [Koha-bugs] [Bug 19400] Reminder to unset gone no address flag
after patron makes a modification request
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19400
--- Comment #1 from Lari Taskula ---
Created attachment 67524
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67524&action=edit
Bug 19400: Reminder to unset gone no address flag after patron makes a
modification request
Our librarians requested a reminder to unset "gone no address" flag from
patron's
record once the patron has made a modification request to update their address.
I propose adding a message box under patron modification request to notify
librarians about patrons that have gone no address flag on, and an option to
unset the flag without the need of having to navigate into patron's details.
To test:
1. Apply patch
2. Set "Gone no address" flag for your test patron. You can do this by going
to patron modification screen in staff client.
3. Go to OPAC with your test patron
4. Make a modification request for your personal details
5. Go to staff client and see pending modification requests
6. Open the request you just created
7. Observe a message dialog that says this patron has gone no address flag set
8. Check the checkbox to unset the flag and approve the modification request
9. Click Submit
10. Observe your test patron no longer has gone no address flag set
11. Repeat steps 2-7
12. Do not check the checkbox, but approve the modification request
13. Observe your test patron still has gone no address flag set
14. Remove the gone no address flag from your test patron
15. Repeat steps 3-6
16. Observe there is no message dialog for gone no address
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:22:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 16:22:27 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
order_by params into SQL ::Abstract
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370
--- Comment #5 from Tom?s Cohen Arazi ---
Created attachment 67525
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67525&action=edit
Bug 19369: (followup) Rename params for consitency with 19370
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:37:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 16:37:10 +0000
Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip
when ES module not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897
--- Comment #15 from M. Tompsett ---
(In reply to Jonathan Druart from comment #14)
> Sounds like we have other tests failing:
>
> # Failed test 'Syntax check misc/search_tools/rebuild_elastic_search.pl'
> # at /usr/share/perl5/Test/Strict.pm line 406.
> # Can't locate Catmandu/Importer/MARC.pm in @INC (you may need to install
> the Catmandu::Importer::MARC module) (@INC contains: installer
> misc/translator /kohadevbox/koha /etc/perl
> /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
> /usr/local/share/perl/5.20.2/x86_64-linux-gnu-thread-multi
> /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
> /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
> /usr/local/lib/site_perl . /kohadevbox/koha /etc/perl
> /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
> /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
> /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
> /usr/local/lib/site_perl .) at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
> # BEGIN failed--compilation aborted at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 26.
> # Compilation failed in require at
> misc/search_tools/rebuild_elastic_search.pl line 89.
> # BEGIN failed--compilation aborted at
> misc/search_tools/rebuild_elastic_search.pl line 89.
> # Looks like you failed 1 test of 663.
> [23:53:44] t/db_dependent/00-strict.t
>
>
>
> # Failed test 'use Koha::SearchEngine::Elasticsearch::Search;'
> # at t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
> # Tried to use 'Koha::SearchEngine::Elasticsearch::Search'.
> # Error: Can't locate Catmandu/Store/ElasticSearch.pm in @INC (you may
> need to install the Catmandu::Store::ElasticSearch module) (@INC contains:
> /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
> /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
> /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
> /usr/local/lib/site_perl .) at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
> # BEGIN failed--compilation aborted at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 49.
> # Compilation failed in require at
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
> # BEGIN failed--compilation aborted at
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 27.
> Can't locate object method "search" via package
> "Koha::SearchEngine::Elasticsearch::Search" at
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t line 47.
> # Looks like your test exited with 255 just after 4.
> [22:48:34] t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
I would argue that OTHER failures are beyond the scope of this patch, and that
it should go back to passed QA, and two more bugs created.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 18:54:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 16:54:11 +0000
Subject: [Koha-bugs] [Bug 18897] Elastic related tests do not skip when ES
modules are not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Koha_Elasticsearch_Indexer. |Elastic related tests do
|t doesn't skip when ES |not skip when ES modules
|module not installed |are not installed
--- Comment #16 from Jonathan Druart ---
(In reply to M. Tompsett from comment #15)
> I would argue that OTHER failures are beyond the scope of this patch, and
> that it should go back to passed QA, and two more bugs created.
I do not think so, the fix should be quite trivial.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:10:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:10:48 +0000
Subject: [Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c
| |ommunity.org
Depends on| |18098
--- Comment #3 from Jonathan Druart ---
Caused by
commit 5ef1b6710e7520b844e145e248da0deeee707fde
Bug 18098: Add an index with the count of not onloan items
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098
[Bug 18098] Add an index with the count of not onloan items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:10:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:10:48 +0000
Subject: [Koha-bugs] [Bug 18098] Add an index with the count of not onloan
items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18098
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19122
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122
[Bug 19122] IncludeSeeFromInSearches is broken
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:15:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:15:30 +0000
Subject: [Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:15:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:15:34 +0000
Subject: [Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122
--- Comment #4 from Jonathan Druart ---
Created attachment 67526
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67526&action=edit
Bug 19122: (bug 18098 follow-up) Fix IncludeSeeFromInSearches behaviour
The IncludeSeeFromInSearches system preference is designed so that 'See from'
headings from the authorities are included when you search in the catalog.
That means that you could find an author not only by the name printed on the
book, but for example also by their pseudonym or a different spelling of their
name.
It was added by bug 7417.
This regression has been introduced by
commit 5ef1b6710e7520b844e145e248da0deeee707fde
Bug 18098: Add an index with the count of not onloan items
- } elsif ($record_type eq 'biblio' &&
C4::Context->preference('IncludeSeeFromInSearches')) {
- my $normalizer = Koha::RecordProcessor->new( { filters =>
'EmbedSeeFromHeadings' } );
[...]
+ push @filters, 'IncludeSeeFromInSearches'
+ if C4::Context->preference('IncludeSeeFromInSearches');
Test plan:
- Activate IncludeSeeFromInSearches
- Catalog an authority for a person
- main heading in 100
- see from headings in 400
- Catalog a bibliographic record and link it to the authority
- Make sure the record is indexed
- Verify that the record can be found searching for the main heading
- Verify that the record can be found searching for the see from headings
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:22:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:22:58 +0000
Subject: [Koha-bugs] [Bug 19398] Wrong date format in quick patron search
table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
|ity.org |ommunity.org
Depends on| |14874
Status|NEW |ASSIGNED
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874
[Bug 14874] Add ability to search for patrons by date of birth from checkout
and patron quick searches
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:22:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:22:58 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
of birth from checkout and patron quick searches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19398
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398
[Bug 19398] Wrong date format in quick patron search table
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:24:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:24:36 +0000
Subject: [Koha-bugs] [Bug 19395] [17.05][16.11] t/db_dependent/www/
auth_values_input_www.t is failing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19395
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #4 from Jonathan Druart ---
*** This bug has been marked as a duplicate of bug 19391 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:24:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:24:36 +0000
Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because
of bug 19128
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Jonathan Druart ---
*** Bug 19395 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:24:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:24:39 +0000
Subject: [Koha-bugs] [Bug 19398] Wrong date format in quick patron search
table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:24:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:24:42 +0000
Subject: [Koha-bugs] [Bug 19398] Wrong date format in quick patron search
table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398
--- Comment #1 from Jonathan Druart ---
Created attachment 67527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67527&action=edit
Bug 19398: Format date of birth in circ patron search
When searching for a patron from the circulation tab, the results table
shows the date of birth unformatted.
Test plan:
Apply this patch, search for patrons in the circ tab and confirm that
the date of birth are correctly formatted according to the dateformat
syspref
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:30:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:30:40 +0000
Subject: [Koha-bugs] [Bug 19389] Don' t offer search option for libary
groups when no groups are defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
|ity.org |ommunity.org
Depends on| |15295
Status|NEW |ASSIGNED
--- Comment #1 from Jonathan Druart ---
Regression introduced by bug 15295.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295
[Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:30:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:30:40 +0000
Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to
Koha::Libraries - part 2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19389
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389
[Bug 19389] Don't offer search option for libary groups when no groups are
defined
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:32:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:32:39 +0000
Subject: [Koha-bugs] [Bug 19389] Don' t offer search option for libary
groups when no groups are defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:32:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:32:42 +0000
Subject: [Koha-bugs] [Bug 19389] Don' t offer search option for libary
groups when no groups are defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389
--- Comment #2 from Jonathan Druart ---
Created attachment 67528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67528&action=edit
Bug 19389: Hide library groups pull down if empty
Regression introduced by bug
commit 141200794da9f27e0231e1c2dad4bcb994d650f3
Bug 15295: Koha::Libraries - Remove GetBranchCategories
The intranet advanced search page offers to search for groups of
libraries, even if the pull down is empty as no library groups have
been defined.
Test plan:
- Go to the adv search page at the intranet
- Without library group you must not see the "Groups of libraries"
dropdown list
- With at least a library group you must see it
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 19:38:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 17:38:05 +0000
Subject: [Koha-bugs] [Bug 19252] Upgrading message shows identical version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19252
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #2 from Jonathan Druart ---
This usually happens when memcached has not been restarted after the codebase
has been updated.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 20:07:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 18:07:10 +0000
Subject: [Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--- Comment #5 from Tom?s Cohen Arazi ---
Oops. Thank for taking care, Jonathan!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:34:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 19:34:27 +0000
Subject: [Koha-bugs] [Bug 19029] Move the clone button and implement a
security question on smart-rules.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029
--- Comment #11 from Alex Buckley ---
Created attachment 67529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67529&action=edit
Bug 19029 - Followup - Implemented .format() to ease translation
Sponosred by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:34:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 19:34:56 +0000
Subject: [Koha-bugs] [Bug 19029] Move the clone button and implement a
security question on smart-rules.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:51:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 19:51:09 +0000
Subject: [Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC
Modification Templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:51:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 19:51:14 +0000
Subject: [Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC
Modification Templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069
--- Comment #1 from Jonathan Druart ---
Created attachment 67530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67530&action=edit
Bug 19069: Fix 'does not match' behaviour in MARC modification template
The "does not match" condition does not behave as expected.
We want it to process the action if the subfield exists and that the
value does not match a given pattern.
Test plan:
Be creative and write different template actions using the "does not
match" condition.
Using the "Batch record modification" and the "Show MARC" popup, confirm
that the processed record is the one you are expecting.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 2 21:52:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 19:52:15 +0000
Subject: [Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC
Modification Templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Version|17.05 |master
Hardware|Macintosh |All
OS|Mac OS |All
Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
|ity.org |ommunity.org
--- Comment #2 from Jonathan Druart ---
I first glance I would say the the "does not exist" condition is buggy as well.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 00:09:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 22:09:29 +0000
Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per
patron by category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524
--- Comment #13 from Jesse Weaver ---
Created attachment 67531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67531&action=edit
Bug 15524: (follow-up) Rename database update
This ensures that this update is applied in the correct order relative
to its dependent bugs.
Just a rename to a DB update so this bug works better with its dependencies;
leaving as signed off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:07:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:07:23 +0000
Subject: [Koha-bugs] [Bug 19398] Wrong date format in quick patron search
table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:07:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:07:26 +0000
Subject: [Koha-bugs] [Bug 19398] Wrong date format in quick patron search
table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19398
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67527|0 |1
is obsolete| |
--- Comment #2 from Katrin Fischer ---
Created attachment 67532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67532&action=edit
Bug 19398: Format date of birth in circ patron search
When searching for a patron from the circulation tab, the results table
shows the date of birth unformatted.
Test plan:
Apply this patch, search for patrons in the circ tab and confirm that
the date of birth are correctly formatted according to the dateformat
syspref
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:13:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:13:46 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67519|0 |1
is obsolete| |
--- Comment #2 from Katrin Fischer ---
Created attachment 67533
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67533&action=edit
Bug 19397: Release team for 17.11
This patch adds the release team for 17.11 to about template.
Test plan:
Check the changes with the wiki pages for 17.05 and 17.11.
Signed-off-by: Marcel de Rooy
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:13:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:13:43 +0000
Subject: [Koha-bugs] [Bug 19397] Release team 17.11
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:17:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:17:07 +0000
Subject: [Koha-bugs] [Bug 19389] Don' t offer search option for libary
groups when no groups are defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:17:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:17:10 +0000
Subject: [Koha-bugs] [Bug 19389] Don' t offer search option for libary
groups when no groups are defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67528|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 67534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67534&action=edit
Bug 19389: Hide library groups pull down if empty
Regression introduced by bug
commit 141200794da9f27e0231e1c2dad4bcb994d650f3
Bug 15295: Koha::Libraries - Remove GetBranchCategories
The intranet advanced search page offers to search for groups of
libraries, even if the pull down is empty as no library groups have
been defined.
Test plan:
- Go to the adv search page at the intranet
- Without library group you must not see the "Groups of libraries"
dropdown list
- With at least a library group you must see it
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:19:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:19:01 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|cnighswonger at foundations.ed |david.bourgault at inlibro.com
|u |
CC| |katrin.fischer at bsz-bw.de
--- Comment #4 from Katrin Fischer ---
Hi David, please change Assignee to yourself when you want to adopt a bug and
provide patches :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:34:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:34:01 +0000
Subject: [Koha-bugs] [Bug 18418] Advanced Editor - Rancor - Add a control
number widget
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18418
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
Hi Nick,
found some things:
1) comment#2
2) I think the new authorised value category should appear in the list by
default.
3) I can't get it to work :(
a) When I manually assign the control number, things seem ok.
b) When I add the authorised value, I don't see the other buttons as
described. I can't get this part to work at all.
4) The stocknumberAV.pl plugin uses a very similar mechanism, but the
authorised value code is the prefix (for example the year) and is
never changed and the description is the counter. I think making
this here consistent with the existing behaviour would be nice.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:35:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:35:54 +0000
Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts
for copyright symbols (C) (P)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
This works nicely, but needs documentation. Maybe add it to the shortcut list?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:46:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:46:00 +0000
Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken
under Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
Wanted to test, but can't get Elasticsearch working in kohadevbox :(
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:52:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:52:27 +0000
Subject: [Koha-bugs] [Bug 19029] Implement a security question for cloning
circulation conditions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Move the clone button and |Implement a security
|implement a security |question for cloning
|question on smart-rules.tt |circulation conditions
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 01:54:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Oct 2017 23:54:01 +0000
Subject: [Koha-bugs] [Bug 19029] Implement a security question for cloning
circulation conditions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #12 from Katrin Fischer ---
There seems to be no security question for cloning conditions from one library
to another. I think it would be good to be consistent and always ask, as
cloning accidentally can create quite a chaos.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Oct 3 02:13:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Oct 2017 00:13:06 +0000
Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search
facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376
--- Comment #2 from Katrin Fischer ---
Comment on attachment 67412
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67412
Bug 19376 - Adds 655$a to Zebra facets
Review of attachment 67412:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19376&attachment=67412)
-----------------------------------------------------------------
::: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
@@ -777,5 @@
> - Subject:p
> -
> -
> -
> -