[Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 67412
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67412
Bug 19376 - Adds 655$a to Zebra facets

Review of attachment 67412:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19376&attachment=67412)
-----------------------------------------------------------------

::: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
@@ -777,5 @@
> -    <target_index>Subject:p</target_index>
> -  </index_data_field>
> -  <!--record.abs line 189: melm 656$9      Koha-Auth-Number    -->
> -  <index_subfields tag="656" subfields="9">
> -    <target_index>Koha-Auth-Number:w</target_index>

Why are you removing these lines? It will break search when using authorities
with 655 (link build using $9) and libraries using more than the $a subfield.
(http://www.loc.gov/marc/bibliographic/bd655.html)

::: etc/zebradb/marc_defs/marc21/biblios/record.abs
@@ -198,2 @@
>  melm 655$9      Koha-Auth-Number
> -melm 655        Subject,Subject:p

These changes are not necessary as grs-1 is deprecated, but will also be a
regression if you want to search for sufields other than $a:
http://www.loc.gov/marc/bibliographic/bd655.html

::: koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
@@ +15,4 @@
>  [% IF facets_loo.type_label_Authors %]<span id="facet-authors">Authors</span>[% END %]
>  [% IF facets_loo.type_label_Titles %]<span id="facet-titles">Titles</span>[% END %]
>  [% IF facets_loo.type_label_Topics %]<span id="facet-topics">Topics</span>[% END %]
> +[% IF facets_loo.type_label_GenreForm %]<span id="facet-genreform">Genre form</span>[% END %]

I think it should probably be Genre/Form matching the detail page :)

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
@@ +21,4 @@
>                      <li id="[% facets_loo.type_id %]">
>                          [% IF facets_loo.type_label_Authors %]<h5 id="facet-authors">Authors</h5>[% END %]
>                          [% IF facets_loo.type_label_Titles %]<h5 id="facet-titles">Titles</h5>[% END %]
> +                        [% IF facets_loo.type_label_GenreForm %]<h5 id="facet-genreform">Genre form</h5>[% END %]

Same here as above: Genre/Form.

-- 
You are receiving this mail because:
You are watching all bug changes.