[Koha-bugs] [Bug 19415] New: FindDuplicateAuthority is searching on biblioserver since 16.05

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415

            Bug ID: 19415
           Summary: FindDuplicateAuthority is searching on biblioserver
                    since 16.05
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using
SimpleSearch use the new version] changed sub FindDuplicateAuthority and
replaced this call (from 3.22.x) in 16.05 (pushed April 2016):
    my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0,
1, [ "authorityserver" ] );

The new call does unfortunately not include the authorityserver:
    my ($error, $results, $total_hits) = $searcher->simple_search_compat(
$query, 0, 1 );
Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch
assumes a biblioserver if no server is passed.

This effectively makes FindDuplicateAuthority useless since we will no longer
find duplicates and we could see an error like this in the log:

16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN
@attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout

Patch forthcoming

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.