[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 5 22:44:08 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Josef

Thanks for rebasing, I have tested the patch and functionally everything works
well, however running QA test tools it fails for pagination.inc (see the below
test output). Can you please fix this up and then I'll be happy to sign off on
this patch.


 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/pagination.inc
   FAIL   forbidden patterns
                forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 1)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list