[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #71 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Aleisha Amohia from comment #54)
> Hi Josef
> 
> I have one test failing in t/db_dependent/Circulation.t. I've pasted the
> output here: http://paste.koha-community.org/621
> 
> All other tests pass.
> 
> Some notes from following the rest of your test plan:
> When deleting a collection, two different confirmation boxes pop up. (i know
> this is the behaviour before your patches)
> Deleting a collection with items was no different from deleting a collection
> without items (no error message to say the collection had items).
> No difference when returning an item in an untransferred collection and
> returning an item in a transferred collection
> 
> I know the first point is the original behaviour before your patches.
> Unfortunately I can't test whether the second and third points are the
> expected behaviour because rotating collections appears to be broken for me
> without your patches! :) If the behaviour I've described is expected, then
> everything looks good.
> 
> Setting to Failed QA for the failed test.

Thanks for testing!

I did another rebase today. 

Test t/db_dependent/Circulation.t is passing form me.

The double confirmation dialog was easy to fix, I am doing it in followup

Ability to delete a collection with items is current behavior in master, I will
fix it on another report

Returning from transferred and untransferred collection is not diferrentiate in
in current master too.

Setting back to needs signoff

-- 
You are receiving this mail because:
You are watching all bug changes.