[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Trying to test :)

- Nothing found in code review.
- Database update works nicely.

Not OK:

- QA test tools give some bad results:

 FAIL   Koha/Schema/Result/Sign.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
   OK     spelling
   OK     valid

 FAIL   Koha/Schema/Result/SignStream.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
   OK     spelling
   OK     valid

 FAIL   Koha/Schema/Result/SignsToStream.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
   OK     spelling
   OK     valid

 FAIL   Koha/Sign.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
   OK     spelling
   OK     valid

 FAIL   Koha/SignStream.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
   OK     spelling
   OK     valid

 FAIL   Koha/SignsToStream.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
   OK     spelling
   OK     valid

 FAIL   installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql
   OK     git manipulation
   FAIL   semicolon
   OK     sysprefs_order

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt
   FAIL   forbidden patterns
   OK     git manipulation
   FAIL   spelling
   OK     tt_valid
   OK     valid_template

- On the /cgi-bin/koha/tools/signs.pl the datatable is broken (next page, etc.)
- I think it would be nicer to use "SIGN" instead of "SIG" for the report group
and include it in the sample values.
- On point 16) of the test plan I receive an internal server error, so can't
test the last steps:
Can't use string ("1") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/C4/Biblio.pm line 1182.

-- 
You are receiving this mail because:
You are watching all bug changes.