[Koha-bugs] [Bug 19425] Adding orders from order file with multiple budgets per record triggers error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19425

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67866|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 68049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68049&action=edit
Bug 19425 - Adding orders from order file with multiple budgets per record
triggers error

If you import an order file ( using MarcItemFieldsToOrder ) that has a
different budget for each item to be ordered, you will get an error and a
partially created basket. This is because Koha attempts to add the item to each
order *for each budget*. This is clearly incorrect. Instead, we should be
grouping items by budget and for each budget only adding those items that have
a matching budget.

Test plan:
1) Do not apply this patch
2) Download the provided MARC record
3) Add the branchcode 'ALD' to your server
4) Add the ccode 'ACOL' to your server
5) Add the budget codes 'adultay' and 'branchay' to your server
6) Stage the order file
7) Create a basket, import the order file
8) No we have 3 records, 2 of them have 2 items each with different budget
codes
9) Attempt to import, note the error
10) Apply this patch
11) Repeat steps 6-8, note the order completes and results in 5 order lines
being added to the basket!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Christopher Kellermeyer <ckellermeyer at altadenalibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
First step of test plan amended (not apply instead of apply).

-- 
You are receiving this mail because:
You are watching all bug changes.