[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Oct 15 12:24:39 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As you need to register the IP, I can't test on my kohadevbox. 
Maybe on a sandbox?

QA tool doesn't complain about syspref order, but it was added to the end,
maybe while you are on it move them up in the right alphabetic spot?

In the system preference description it might be helfpul to add a quick
description like "Swedish service for spellchecking" or something so you have a
bit more of context looking at the pref and deciding if you want to turn it on.
I know LIBRIS to be Swedish, but most people won't.

QA test tools fail:

 FAIL   Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'NAME'
   OK     spelling
   OK     valid

 FAIL   installer/data/mysql/sysprefs.sql
   OK     git manipulation
   FAIL   semicolon
                simicolon found instead of comma at line 596
   OK     sysprefs_order

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 17)
                forbidden pattern: tab char (line 16)
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list