[Koha-bugs] [Bug 18506] Shibboleth SSO Only Mode

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Oct 15 14:21:58 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 62810
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62810
BUG 18506 - Add xShibOnly preference for shibboleth

Review of attachment 62810:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18506&attachment=62810)
-----------------------------------------------------------------

>From looking at the patch:

Author in patch file is not correct - PTFS Admin <hosting at ptfs-europe.com>

::: installer/data/mysql/atomicupdate/shibOnly.perl
@@ +1,5 @@
> +$DBversion = 'XXX';  # will be replaced by the RM
> +if( CheckVersion( $DBversion ) ) {
> +    $dbh->do( "INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('opacShibOnly','0','If ON enables shibboleth only authentication for the opac','','YesNo'),('staffShibOnly','0','If ON enables shibboleth only authentication for the staff client','','YesNo')" );
> +    SetVersion( $DBversion );
> +    print "Upgrade to $DBversion done (Bug XXXXX - shibOnly preferences)\n";

Missing the bug number and maybe a nicer explanation?

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ +828,5 @@
> +            - pref: opacShibOnly
> +              choices:
> +                  yes: "Don't allow"
> +                  no: Allow
> +            - patrons to login by means other than shibboleth.

Should shibboleth be Shibboleth?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list