[Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 18 01:27:31 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60236|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 68237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68237&action=edit
Bug 18118 - Unexpected behaviour with 'GoogleOpenIDConnect' and 'OpacPublic'
syspref combination.

TEST PLAN
----------
1/ configure a working 'GoogleOpenIDConnect' account

See comment #5 which also links back to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892#c3

2/ set 'OpacPublic' (under OPAC) to 'Disabled' and
   'GoogleOpenIDConnect' (under Administration) to 'Yes'.

3/ log in user successfully via google-auth, observe redirect to
   opac-user.pl (bad)

4/ apply patch
   -- on kohadevbox remember to restart all! Plack is unforgiving. :)

5/ log in user successfully via google-auth, observe expected
   redirect to opac-main.pl (good)

While I would normally suggest running koha qa test tools, because
this file doesn't end in .pl, it doesn't get picked up by them.

6/ perlcritic -4 opac/svc/auth/googleopenidconnect
   -- notice this is a level better than required. :)

This also eyeballs easily well.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list