[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
-    unless( $onsite_checkout and
C4::Context->preference("OnSiteCheckoutsForce") ) {
+    if ( $error->{UNKNOWN_BARCODE} or not $onsite_checkout or not
C4::Context->preference("OnSiteCheckoutsForce") ) {

If CanBookBeIssued sets the UNKNOWN_BARCODE flag, it returns no DEBT question
and no other impossible errors. But since there is one error, it will set
$blocker to 1. 
Just wondering if there are other errors that should trigger the blocker flag
when doing onsite checkouts here. If CanBookBeIssued said No, when is an onsite
checkout still possible?

-    if( !$blocker || $force_allow_issue ){
+
+    if( $item and ( !$blocker or $force_allow_issue ) ){

Since you raised the blocker flag in the unknown barcode case, you do not need
to test for $item here. Note that item is found by barcode and CanBookBeIssued
calls GetItem with barcode parameter.

Please clarify/adjust.

-- 
You are receiving this mail because:
You are watching all bug changes.