[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
We will be doing this a lot of times when a biblio has more items:

my $issuing_rule = Koha::IssuingRules->get_effective_issuing_rule({
categorycode => $borrowercategory, itemtype => $itype, branchcode =>
$branchcode });

The categorycode is always the same. Branchcode is holding branch, often too.
And probably we will not have a lot of different itemtypes for one biblio. So
this could be more intelligent.
For longer lists with biblios having much items (serials), we are not improving
performance.

And another thing:
We are using OnShelfHoldsAllowed on detail forms but NOT on search results with
20 biblios. Why should we use it on a list that may contain much more biblios?
I would rather set $this_item->{allow_onshelf_holds} to 1 and let opac-reserve
handle the details, similar to opac-search. The template already contains
itemsloo.norequests and also tests itemsloo.itemsissued..

-- 
You are receiving this mail because:
You are watching all bug changes.