[Koha-bugs] [Bug 19487] Internal server error when writing off lost fine for item not checked out

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #10)
> Comment on attachment 68313 [details] [review]
> Bug 19487: (QA follow-up) More changes to MarkIssueReturned.t
> 
> I am not willing to push this patch.
But you wanted to be RM ;)

> We want a fix for stable releases, so something easy to backport.
> This change is quite big may slow down the backport.
OK OK

> Moreover it seems that at least one test has been removed:
> -unlike ( $@, qr<Fatal error: the patron \(\d+\) .* AnonymousPatron>, );
No it isnt. This one is even sharper..
+is( $@, '', 'No die triggered by invalid itemnumber' );

> and this line too, which makes me think you cut a bit too much:
> t::lib::Mocks::mock_preference('AnonymousPatron', $anonymous_borrowernumber);
Yes I removed it since it was made useless by the previous changes. When you
pass a wrong item number, MarkIssueReturned will now return undef rightaway.
The whole anynomous stuff is not in reach. Leaving it in could reflect that we
are testing it, while we are not.

> Please move it to its own bug report.
Bug 19513

-- 
You are receiving this mail because:
You are watching all bug changes.