[Koha-bugs] [Bug 19512] Koha::File - wrapper/utility routines for file handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19512

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Olle, 

first I have to say I like the idea of file wrapper, I've tried to test this
but:

test Koha/File.t is not passing for me
Both test warn:

Use of uninitialized value $ENV{"KOHA_PATH"} in concatenation (.) or string

koha qa tools has also some complains:

 FAIL   Koha/Exceptions/File.pm
   FAIL   pod
                =head2 without preceding higher level
                *** WARNING: 

                 in file Koha/Exceptions/File.pm
   FAIL   pod coverage
                POD is missing for Fields
                POD is missing for description
                POD is missing for path
                POD is missing for stat

 FAIL   Koha/File.pm
   FAIL   critic
                "return" statement with explicit "undef" at line 36, column 5.
See page 199 of PBP.
   FAIL   pod coverage
                POD is missing for 'getDiagnosticsString'

 FAIL   t/Koha/Exceptions/File.t
   FAIL   spelling
                 throughly  ==> thoroughly

 FAIL   t/Koha/File.t
   FAIL   critic
                Integer with leading zeros: "07777" at line 20, column 50. See
page 58 of PBP.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.