[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Marcel de Rooy from comment #9)
> > Created attachment 68461 [details] [review] [review]
> > Bug 19298: (QA follow-up) Remove GetBiblioData call
> > 
> > In order to do at least something for performance, we could replace
> > the call to GetBiblioData since we are already fetching biblio data
> > with Koha::Biblios.
> 
> GetBiblioData also returns biblioitems fields, and the template uses them.
> At least publishercode, place, publicationyear, pages, notes, etc.

    my $query = " SELECT * , biblioitems.notes AS bnotes, itemtypes.notforloan
as bi_notforloan, biblio.notes
            FROM biblio
            LEFT JOIN biblioitems ON biblio.biblionumber =
biblioitems.biblionumber
            LEFT JOIN itemtypes ON biblioitems.itemtype = itemtypes.itemtype
            WHERE biblio.biblionumber = ?";

Please explain.
See my commit message too.

-- 
You are receiving this mail because:
You are watching all bug changes.