[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #141 from David Cook <dcook at prosentient.com.au> ---
(In reply to Josef Moravec from comment #139)
> No problem, here is relevant output from qa tools:
> 
> FAIL	Koha/Daemon.pm
>    FAIL	  critic
> 		"$fh" is declared but not used at line 78, column 14. Unused variables
> clutter code and make it harder to read.
> 		Bareword file handle opened at line 64, column 18. See pages 202,204 of
> PBP.
> 
> 

Fixed.

> FAIL	Koha/OAI/Harvester.pm
>    FAIL	  critic
> 		Variable declared in conditional statement at line 291, column 9. Declare
> variables outside of the condition.
>    FAIL	  pod
> 		=head3 without preceding higher level
> 		 in file Koha/OAI/Harvester.pm
> 
> 

Fixed.

> FAIL	Koha/OAI/Harvester/Downloader.pm
>    FAIL	  pod
> 		 in file Koha/OAI/Harvester/Downloader.pm
> 		=head2 without preceding higher level
> 
> 

Fixed.

> FAIL	Koha/OAI/Harvester/Import/RDFXML.pm
>    FAIL	  critic
> 		Variable declared in conditional statement at line 110, column 5. Declare
> variables outside of the condition.
>    FAIL	  forbidden patterns
> 		forbidden pattern: tab char (line 32)
> 
> 

Fixed.

> FAIL	Koha/OAI/Harvester/Import/Record.pm
>    FAIL	  critic
> 		Variable declared in conditional statement at line 325, column 17. Declare
> variables outside of the condition.
> 		Variable declared in conditional statement at line 262, column 13. Declare
> variables outside of the condition.
> 		"return" statement with explicit "undef" at line 145, column 41. See page
> 199 of PBP.
> 		Variable declared in conditional statement at line 252, column 5. Declare
> variables outside of the condition.
>    FAIL	  forbidden patterns
> 		forbidden pattern: tab char (line 152)
> 		forbidden pattern: tab char (line 156)
> 		forbidden pattern: tab char (line 142)
> 		forbidden pattern: tab char (line 139)
> 		forbidden pattern: tab char (line 136)
> 		forbidden pattern: tab char (line 384)
> 		forbidden pattern: tab char (line 380)
> 		forbidden pattern: tab char (line 140)
> 		forbidden pattern: tab char (line 141)
> 		forbidden pattern: tab char (line 151)
> 		forbidden pattern: tab char (line 155)
> 		forbidden pattern: tab char (line 149)
> 		forbidden pattern: tab char (line 154)
> 		forbidden pattern: tab char (line 153)
> 		forbidden pattern: tab char (line 138)
> 		forbidden pattern: tab char (line 150)
> 		forbidden pattern: tab char (line 137)
>    FAIL	  pod
> 		 in file Koha/OAI/Harvester/Import/Record.pm
> 		=head3 without preceding higher level
> 		empty =head3
> 	 
> 

Fixed.

> FAIL	Koha/OAI/Harvester/Request.pm
>    FAIL	  forbidden patterns
> 		forbidden pattern: tab char (line 69)
> 		forbidden pattern: tab char (line 191)
> 		forbidden pattern: tab char (line 189)
> 		forbidden pattern: tab char (line 181)
> 		forbidden pattern: tab char (line 188)
> 		forbidden pattern: tab char (line 193)
> 		forbidden pattern: tab char (line 104)
> 		forbidden pattern: tab char (line 98)
> 		forbidden pattern: tab char (line 77)
> 		forbidden pattern: tab char (line 113)
> 		forbidden pattern: tab char (line 183)
> 		forbidden pattern: tab char (line 184)
> 		forbidden pattern: tab char (line 89)
> 		forbidden pattern: tab char (line 185)
> 		forbidden pattern: tab char (line 101)
> 		forbidden pattern: tab char (line 190)
> 		forbidden pattern: tab char (line 83)
> 		forbidden pattern: tab char (line 102)
> 		forbidden pattern: tab char (line 70)
> 		forbidden pattern: tab char (line 78)
> 		forbidden pattern: tab char (line 95)
> 		forbidden pattern: tab char (line 194)
> 		forbidden pattern: tab char (line 107)
> 		forbidden pattern: tab char (line 76)
> 		forbidden pattern: tab char (line 80)
> 		forbidden pattern: tab char (line 108)
> 		forbidden pattern: tab char (line 182)
> 		forbidden pattern: tab char (line 99)
> 		forbidden pattern: tab char (line 109)
> 		forbidden pattern: tab char (line 66)
> 		forbidden pattern: tab char (line 97)
> 		forbidden pattern: tab char (line 106)
> 		forbidden pattern: tab char (line 103)
> 		forbidden pattern: tab char (line 112)
> 		forbidden pattern: tab char (line 93)
> 		forbidden pattern: tab char (line 170)
> 		forbidden pattern: tab char (line 111)
> 		forbidden pattern: tab char (line 105)
> 		forbidden pattern: tab char (line 192)
> 		forbidden pattern: tab char (line 114)
> 		forbidden pattern: tab char (line 90)
> 		forbidden pattern: tab char (line 110)
> 		forbidden pattern: tab char (line 187)
> 		forbidden pattern: tab char (line 79)
> 		forbidden pattern: tab char (line 186)
> 		forbidden pattern: tab char (line 115)
> 		forbidden pattern: tab char (line 92)
> 		forbidden pattern: tab char (line 94)
> 		forbidden pattern: tab char (line 91)
> 		forbidden pattern: tab char (line 100)
> 		forbidden pattern: tab char (line 96)
> 
> 

Fixed.

> FAIL	installer/data/mysql/kohastructure.sql
>    FAIL	  charset_collate
> 		The table oai_harvester_requests does not have the current charset collate
> (see bug 11944)
> 
> 

I think this is fixed. (Since I'm not on Debian, I'm just using my own checker
script based on https://github.com/joubu/koha-qa-tools.)

> FAIL	koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
>    FAIL	  forbidden patterns
> 		forbidden pattern: tab char (line 102)
> 
> 

Fixed (there were other pre-existing tab characters that I converted to spaces
as well since I was already here).

> FAIL
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/oai-pmh-harvester/dashboard.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: Do not use line breaks inside template tags (bug 18675)
> (line 308)
> 		forbidden pattern: Do not use line breaks inside template tags (bug 18675)
> (line 287)

I think this is fixed.

--

New patch coming presently...

-- 
You are receiving this mail because:
You are watching all bug changes.