[Koha-bugs] [Bug 19515] Refactor REST API session mocking to reduce code duplication

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19515

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi Olli, good innitiative. Just some remarks:
- You patch covers several endpoints not currently in master, so it won't
apply.
- It is way too much to make it dependent on the castToObject stuff, just a
personal opinion: you can just my $patron =
$builder->build_object({class=>'Koha::Patrons'}); to get a sample patron. This
is already in master...
- You are missing something that's important for testing: we need to be able to
assign the patron specific permissions, something in the lines of:
my $flags = ( $args->{authorized} ) ? 2**$args->{authorized} : 0;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.