[Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 25 23:26:02 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

int <int at arcor.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |int at arcor.de

--- Comment #2 from int <int at arcor.de> ---
'make test' fails differently depending on the database (with 'run the
database-dependent test suite' is set to 'no').
If he can't connect to a database (e.g. 'Access denied'),
Koha_ExternalContent_OverDrive.t and XSLT.t fail.
If he can connect to an empty database or a database without data (but with the
tables), Matcher.t and Prices.t fail. This seems to be your case.

With a "real" database with data, Matcher.t seems to work. I didn't investigate
this further, but if you import kohastructure.sql, e.g.
> mysql -u root -p kohatest < installer/data/mysql/kohastructure.sql
and everything from installer/data/mysql/mandatory and installer/data/mysql/en,
it should work. (If I didn't miss something.)

Prices.t seems to rely on some testdata, see the fixture data in t/Prices.t
(fixtures_ok).
If there is a database-connection available, he seem to want this data from the
database (and not the mock anymore). So if you set it up in the database, the
test also works:
> INSERT INTO aqbooksellers (id, name, listincgst, invoiceincgst)
> VALUES (1, '0 0', 0, 0), (2, '0 1', 0, 1), (3, '1 0', 1, 0), (4, '1 1', 1, 1);
I would assume that if 'run the database-dependent test suite' is set to 'no',
'make test' ignores even working database credentials in koha-conf.xml. This
doesn't seem to be the case right now. I don't know if this is a general
problem or if this bug should be split into several for each failing test
(Koha_ExternalContent_OverDrive.t, XSLT.t, Matcher.t and Prices.t).

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list