[Koha-bugs] [Bug 19540] New: opac-reserve does not correctly warn of too_much reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

            Bug ID: 19540
           Summary: opac-reserve does not correctly warn of too_much
                    reserves
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When attempting to place more holds than allowed, opac-reserve.pl only checks
against the SysPref 'maxreserves' and not the issuingrules 'holdsallowed'. If
the issuing rule's limitation is lower than maxreserve, the opac-reserve page
shows a message saying you cannot place any more holds but the explanatory
message does not show.

To reproduce:
0) Set MaxReserve to a high value (50 is default);
1) Set an issuing rule's "Holds allowed" to a low number (1 or 2);
2) Place as many holds as you can (for the corresponding (categorycode, itype,
branchcode, etc). When you reach the maximum allowed by the issuing rule,
you'll see a message telling you cannot place any more holds, but the
explanatory message saying that you cannot place more than %d holds will not
show. (It will show "No items available instead".

Bug is present on 16.05 and master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.