[Koha-bugs] [Bug 19456] Some pages title tag contains html

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #5)
> 1/ QA script detected a missing %
>  FAIL  
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>    FAIL   valid_template
>                 parse error -
> /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/
> circulation_batch_checkouts.tt line 109: unexpected token (])
>   [% INCLUDE 'patron-title.inc' invert_name = 1 use_html = 1 ] [% END %]
> 

Fixed in new patch, now it passes qa tools

> 
> 2/ So basically we want use_html everywhere but in title tags, right?
> If this is correct, I would prefer to do the reverse: add a do_not_use_html
> flag when patron-title.inc is used in title tags. That could be easily
> caught with `git grep patron-title.inc|grep '<title>'`

You are right, the ratio is 23 in page content versus 12 in title tag
I changed it.

Followup would rewrite almost everything anyway, so I decided to make new patch
and ask again for sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.