From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 00:01:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Aug 2017 22:01:52 +0000 Subject: [Koha-bugs] [Bug 19231] New: No warning of number of attached items when deleting a course Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Bug ID: 19231 Summary: No warning of number of attached items when deleting a course Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org There is a confirm message when attempting to delete a course that has items in it, but it should also warn about the number of items in the course. If a course has many items in it they may decide not to delete it, or realise they are deleting the wrong one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 00:06:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Aug 2017 22:06:11 +0000 Subject: [Koha-bugs] [Bug 19231] No warning of number of attached items when deleting a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 00:06:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Aug 2017 22:06:14 +0000 Subject: [Koha-bugs] [Bug 19231] No warning of number of attached items when deleting a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 --- Comment #1 from Aleisha Amohia --- Created attachment 66679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66679&action=edit Bug 19231: Add number of attached items to confirm message when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves and create 3 new courses 3) Add one item to a course, add two items to another course, and add no items to the third course 4) Delete the course with no items. Confirm the error message shows up. No need to say how many attached items there are here (because there are none). 5) Delete the course with one item. Confirm the error message shows and warns of the one attached item and makes grammatical sense 6) Delete the course with two items. Confirm the error message shows and shows the correct number of attached items and makes grammatical sense 7) Confirm clicking 'Cancel' and 'OK' does what is expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 00:06:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Aug 2017 22:06:33 +0000 Subject: [Koha-bugs] [Bug 19231] No warning of number of attached items when deleting a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 00:42:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Aug 2017 22:42:03 +0000 Subject: [Koha-bugs] [Bug 19232] New: Move C4::CourseReserves code into Koha:: CourseReserve modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19232 Bug ID: 19232 Summary: Move C4::CourseReserves code into Koha::CourseReserve modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 00:42:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Aug 2017 22:42:13 +0000 Subject: [Koha-bugs] [Bug 19232] Move C4::CourseReserves code into Koha::CourseReserve modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19232 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 02:54:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 00:54:41 +0000 Subject: [Koha-bugs] [Bug 19233] New: Add ability to send itemnumbers in report results to batch modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Bug ID: 19233 Summary: Add ability to send itemnumbers in report results to batch modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: nick at bywatersolutions.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 02:57:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 00:57:27 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 02:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 00:57:29 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #1 from Nick Clemens --- Created attachment 66680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66680&action=edit Bug 19233 - Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 05:03:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 03:03:25 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #1 from Jesse Weaver --- Created attachment 66681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66681&action=edit Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 05:03:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 03:03:39 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pianohacker at gmail.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:43:06 +0000 Subject: [Koha-bugs] [Bug 19194] Internal server error when receiving an order with no itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:43:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:43:23 +0000 Subject: [Koha-bugs] [Bug 19194] Internal server error when receiving an order with no itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:43:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:43:09 +0000 Subject: [Koha-bugs] [Bug 19194] Internal server error when receiving an order with no itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66674|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 66682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66682&action=edit Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:45:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:45:20 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 --- Comment #25 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:48:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:48:44 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Marcel de Rooy --- admin/aqbudgetperiods.pl | 4 ++-- .../prog/en/modules/admin/.aqbudgetperiods.tt.swp | Bin 0 -> 40960 bytes 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/.aqbudgetperiods.tt.swp Please remove swap files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:49:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:49:16 +0000 Subject: [Koha-bugs] [Bug 19209] Koha::Objects should provide ->is_paged method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:57:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:57:34 +0000 Subject: [Koha-bugs] [Bug 19209] Koha::Objects should provide ->is_paged method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66632|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 66684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66684&action=edit Bug 19209: (QA followup) Improve tests This path merges the pager() test and adds search results count tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:57:38 +0000 Subject: [Koha-bugs] [Bug 19209] Koha::Objects should provide ->is_paged method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66633|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 66685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66685&action=edit Bug 19209 [Followup] - Ensure checkouts don't prevent deleting patrons Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:57:29 +0000 Subject: [Koha-bugs] [Bug 19209] Koha::Objects should provide ->is_paged method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66631|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 66683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66683&action=edit Bug 19209: Add ->is_paged method to Koha::Objects This patch adds ->is_paged to Koha::Objects. It is inherited from the underlying resultset from DBIC so there's no code besides adding it to the known methods in AUTOLOAD. Tests are added for the newly exported method. To test: - Apply this patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: Camden County Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 07:58:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 05:58:19 +0000 Subject: [Koha-bugs] [Bug 19209] Koha::Objects should provide ->is_paged method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #11 from Marcel de Rooy --- Small remark: + is( ref($patrons->pager), 'DBIx::Class::ResultSet::Pager', + 'Koha::Objects->pager returns a valid DBIx::Class object' ); If that is what we really want? Until now we wrapped lots of things in Koha objects. Btw: pager returns a Data::Page object for the current resultset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:00:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:00:21 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:03:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:03:21 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #46 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:03:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:03:28 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:09:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:09:04 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #47 from Marcel de Rooy --- You add exceptions that are already there. Koha::Exceptions::BadParameter Koha::Exceptions::WrongParameter Koha::Exceptions::ObjectNotFound Koha::Exceptions::UnknownObject -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:29:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:29:20 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, will that only work if you name the column itemnumber? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:41:14 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:41:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:41:18 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64035|0 |1 is obsolete| | Attachment #64036|0 |1 is obsolete| | Attachment #64037|0 |1 is obsolete| | Attachment #64038|0 |1 is obsolete| | Attachment #64039|0 |1 is obsolete| | Attachment #64040|0 |1 is obsolete| | Attachment #64041|0 |1 is obsolete| | Attachment #64042|0 |1 is obsolete| | Attachment #64043|0 |1 is obsolete| | Attachment #64044|0 |1 is obsolete| | Attachment #64795|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy --- Created attachment 66686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66686&action=edit Bug 17499: Add Koha-objects for messaging preferences This patch adds Koha-objects for messaging preferences. This patch does not add any extra logic into these objects. Includes test coverage for basic usage. To test: 1. prove t/db_dependent/Koha/Patron/Message/* Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: Add useful Koha::Exceptions This patch adds some basic Koha::Exceptions that will be useful. Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: Add basic validation for messaging preference This patch adds simple validation for messaging preferences. The validation includes - check that only either borrowernumber or categorycode is given, but not both - throw exception if patron for the given borrowernumber is not found - throw exception if category for the given categorycode is not found - throw exception if days in advance cannot be configured - throw exception if days in advance configuration is invalid (value between 0-30) - throw exception if digest is not available To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: Throw an exception on duplicate messaging preference When trying to add a duplicate messaging preference that has the same borrowernumber or category, and message_attribute_id as another preference, throw Koha::Exceptions::DuplicateObject. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: Add a method for getting messaging options This patch adds a method for getting available messaging options. To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: Add a method for setting default messaging preferences This patch adds a method Koha::Patron::Message::Preference->new_from_default that can be used to add category's default messaging preferences to patron for a given message type. Example call: Koha::Patron::Message::Preference->new_from_default({ borrowernumber => 123, categorycode => "ABC", message_attribute_id => 1, }); Also adds a simple method for Koha::Patron, set_default_messaging_preferences. Usage: $patron->set_default_messaging_preferences() To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: Improve object usability by enabling direct access to transport preferences Since messaging preference is a feature that has multiple related database tables, usage via Koha-objects is sometimes frustrating. This patch adds a feature for Koha::Patron::Message::Preference which enables access to message transport preferences directly via this object. It allows us to skip calls to Koha::Patron::Message::Transport::Preference(s) because we can now get and set via K::P::M::Preference. Get: $preference->message_transport_types Returns a hashref, where each key is stored transport type and value for the key is letter code for the transport. Set: $preference->set({ message_transport_types => ['sms'] }) or $preference->message_transport_types('email', 'sms') or $preference->message_transport_types(['email', 'sms']) Returns $self (Koha::Patron::Message::Preference object) To test: 1. Run t/db_dependent/Koha/Patron/Message/Preferences.t Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: Simplify searching by message_name This patch adds optional search & find parameter message_name for Koha::Patron::Message::Preferences->search and ->find. This simplifies object usage by allowing us to skip joins or finding the attribute id ourselves. prove -v t/db_dependent/Koha/Patron/Message/Preferences.t turns green Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: (follow-up) Bugfix for validation - Bugfix for days_in_advance and wants_digest validation. Have to check definedness of value instead the value itself. - Fixes broken tests caused by above update. - Adding a missing unit test for wants_digest validation - Minor edits to exception messages. - Throwing exception for invalid message_attribute_id. Incl. unit test Tested again, prove -v t/db_dependent/Koha/Patron/Message/Preferences.t turns green prove -v t/db_dependent/Koha/Patron/Message/* turns green Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Bug 17499: (follow-up) Bugfix for validation, 2 Remove duplicate validation for digest availability. This is already checked in $preference->validate(). Set values for current object before validating messaging transport types, not the other way around as it was before this patch. Also prevents a crash when patron has messaging transport type selected for a message for which it should not be available. This patch logs it with as a warning, and only throws an exception when attempting to set it. To test: 1. prove t/db_dependent/Koha/Patron/Message/* Signed-off-by: Josef Moravec Bug 17499: (follow-up) Add information on digest being the only option to get_options If a library wants to force digest on a message type, add this information to Koha::Patron::Message::Preferences->get_options. Signed-off-by: Marcel de Rooy Squashed 11 commits during QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:42:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:42:37 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #49 from Marcel de Rooy --- QA Comment: Looks good to me overall (see also comment47). No blockers found. Koha::Patron::Message::Preferences sub find_with_message_name my $attr = Koha::Patron::Message::Attributes->find({ message_name => $id->{'message_name'}, }); Isnt this actually a search? Couldnt we have multiple results on name ? Similar question for search_with_message_name later my $name = $transport->get_column('message_name'); Why get_column, not just message_name ? +=head3 search + +Koha::Patron::Message::Preferences->search_with_message_name({ + borrowernumber => 123, + message_name => 'Hold_Filled', +}); Wrong POD header -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:47:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:47:21 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:47:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:47:23 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66510|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 66687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66687&action=edit Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {?????? ?????} The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:47:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:47:32 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:49:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:49:32 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:51:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:51:16 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:52:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:52:52 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:53:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:53:48 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:59:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:59:33 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:59:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:59:36 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63265|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 66688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66688&action=edit Bug 18493: Add new searchable languages This patch adds the following languages into advanced search "Languages" dropdown: Bosnian Welsh Esperanto Estonian Irish Gaelic Scottish Gaelic Ancient Greek Kazakh Greenlandic Karelian Cornish Lithuanian Latvian Burmese Punjabi Pashto Finnish Kalo Sanskrit Akkala Sami Kildin Sami Ter Sami Pite Sami Kemi Sami Ume Sami Southern Sami Northern Sami Sami languages Lule Sami Inari Sami Skolt Sami Somali Sotho Votic Yiddish To test: 1. perl installer/data/mysql/updatedatabase.pl 2. Go to intranet advanced search 3. Click "More options" 4. See "Limits" fieldset, it should have "Language" drop down 5. Observe that the languages provided in this patch are visible in this dropdown Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Just noting that the order in this dropdown is hopeless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 08:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 06:59:47 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:03:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:03:31 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:20:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:20:11 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:20:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:20:13 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64019|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 66689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66689&action=edit Bug 18718: Language selector in staff header menu similar to OPAC This patch adds a language selector menu to the top menu of staff client similar to the OPAC. Display of language selectors at top, bottom or both can be configured with system preference StaffLangSelectorModer. It defaults to bottom. To test: - Apply patch - Udate database - Restart plack and memchached - Go to staff client, verify that language selector displays at the bottom of the page (as before) - Go to system preferences, verify that there is a new preference StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and that it is set to 'footer' - Change mode for top, both and footer and verify, go to staff client and verify for each that the language selector displays as appropriate (Amended for comment #2 2017-06-02 mv) Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:20:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:20:33 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:26:24 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #12 from Marcel de Rooy --- Nick, What are you doing here?! Deleting tests without further notice? Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:33:03 +0000 Subject: [Koha-bugs] [Bug 19198] Renewal as issue causes too many error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:33:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:33:09 +0000 Subject: [Koha-bugs] [Bug 19198] Renewal as issue causes too many error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:55:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:55:36 +0000 Subject: [Koha-bugs] [Bug 19198] Renewal as issue causes too many error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy --- cd t/db_dependent/; git grep -l CanBookBeIssued | xargs prove not ok 8 - Not a specific case, $delta should not be incremented # Failed test 'Not a specific case, $delta should not be incremented' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 146. # got: undef # expected: 'TOO_MANY_CHECKOUTS' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:58:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:58:29 +0000 Subject: [Koha-bugs] [Bug 19208] Pay select option doesn't pay the selected fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66653|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 66690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66690&action=edit Bug 19208 [Master] - Pay select option doesn't pay the selected fine The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The fine on top of the list gets the amount deducted, even if another fine is choosen from the list. Test Plan: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. 5) Apply this patch 6) Repeat steps 1-3 7) Note the correct fine is paid Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 09:58:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 07:58:47 +0000 Subject: [Koha-bugs] [Bug 19208] Pay select option doesn't pay the selected fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:20:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:20:54 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:20:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:20:42 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Marcel de Rooy --- QA Comment: Thx for your proposal. Some points that need attention: Breeding.pm: @servers = (); foreach my $id (@id) { push @servers, {id => $id}; } Please explain what you are doing here. Seems unneeded or wrong. $template->param( additionalFields => '1' ) if C4::Context->preference('AdditionalFieldsInZ3950ResultSearch'); Please use Koha::Preference in the template. sub _add_rowdata Just intuitive, these additions dont look that nice to me. I think you should add more validation and put this in another subroutine, taking care that you do not overwrite the default fields. +++ b/installer/data/mysql/atomicupdate/bug_12747-additional_fields_in_Z3950_search_result.sql @@ -0,0 +1 @@ +INSERT INTO systempreferences Please INSERT IGNORE +('AddressFormat','us','','Choose format to display postal addresses', 'Choice'), +('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), Please respect the sort order in sysprefs. Note: I saw that a LOT of other new prefs are not in the right order. But you dont need to correct that here of course. Just add your own one in the right place. + [% IF additionalFields %] + +
+ [% FOREACH addnumberfield IN breeding_loo.addnumberfields %] +
[% addnumberfield %]:
+
[% breeding_loo.$addnumberfield %]
+ [% END %] +
+ + [% END %] You add all additional fields in one column?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:28:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:28:06 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #12 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:28:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:28:42 +0000 Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64163|0 |1 is obsolete| | Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com --- Comment #6 from Kyle M Hall --- Created attachment 64323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64323&action=edit Bug 15924 - Coce not enabled on lists To test: Enable Coce and disable other image services Load a list and not there are no covers Apply patch Load a list and note there are covers https://bugs.koha-community.org/show_bug.cgi?id=15924 Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:43:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:43:20 +0000 Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64323|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 66691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66691&action=edit Bug 15924 - Coce not enabled on lists To test: Enable Coce and disable other image services Load a list and not there are no covers Apply patch Load a list and note there are covers https://bugs.koha-community.org/show_bug.cgi?id=15924 Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:43:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:43:35 +0000 Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:48:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:48:17 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:50:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:50:18 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy --- QA Comment: Thanks for your work. I think this is not yet ready for inclusion. sub XSLTParse4Display { - my ( $biblionumber, $orig_record, $xslsyspref, $fixamps, $hidden_items, $sysxml, $xslfilename, $lang ) = @_; + my ( $biblionumber, $orig_record, $xslsyspref, $fixamps, $hidden_items, $sysxml, $xslfilename, $lang, $xslFile, $opac ) = @_; We already have $xslfilename. You add $xslFile ? Does not look good. The added code seems repetitive. You add a new routine CustomXSLTExportList. It needs unit tests. In that routine you are parsing the xsl files for something like +. I am not sure if that is a good idea. Another QA pov is welcome too. Note that you are doing it each time again too. If you provide clear xslt names, that should probably be sufficient. Please think about another way to enrich that information if needed. --- a/Koha/XSLT_Handler.pm +++ b/Koha/XSLT_Handler.pm @@ -168,7 +168,6 @@ sub transform { ( $xml, $filename, $format ) = @_; $format ||= 'chars'; } - #Initialized yet? if ( !$self->{xslt_hash} ) { $self->_init; No need to remove an empty line if you are not touching this module anyway. diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/README b/koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/README new file mode 100644 Empty README ? And another further on. koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport-samples/MARC21_simple_export.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl What is the use of adding two identical files here ? Actually, all files here are sort of sample files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:52:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:52:30 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:58:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:58:10 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy --- +++ b/Koha/Account/Lines.pm +sub amount_outstanding { You add this sub, but you are not using it ? And not testing it ? This needs feedback. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 10:59:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 08:59:50 +0000 Subject: [Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:08:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:08:36 +0000 Subject: [Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:08:39 +0000 Subject: [Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64161|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 66692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66692&action=edit Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:11:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:11:14 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > Would not it make sense to add it everywhere? > > % git grep ', thanks' **/*.tt|cut -d':' -f1|uniq > koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt > koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt > koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt > > It seems that occurrences in pay.tt are not relevant, we do not display > payments in this table. No response on this question. Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:11:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:11:56 +0000 Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:14:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:14:18 +0000 Subject: [Koha-bugs] [Bug 18812] SIP Patron status does not respect OverduesBlockCirc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18812 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:40:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:40:38 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:41:15 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65346|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 66693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66693&action=edit Bug 19007 - Allow paypal payments via debit or credit card again A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. Test Plan: 1) Enable paypal for your Koha instance 2) Ensure you are not logged in to PayPal 3) Attempt to pay a fine via PayPal 4) Not the the "Pay with Debit or Credit Card" option is missing 5) Apply this patch 6) Refresh opac-account.pl 7) Attempt to make a payment via PayPal again 8) Note the option "Pay with Debit or Credit Card" is now available Signed-off-by: Kyle M Hall Signed-off-by: George Williams Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:43:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:43:27 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Julian Maurice --- I can't see the "Pay with Debit or Credit Card" option, but this is probably because of a misconfiguration in my PayPal account. According to the documentation at https://developer.paypal.com/docs/classic/api/merchant/SetExpressCheckout_API_Operation_NVP/ the patch is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:45:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:45:31 +0000 Subject: [Koha-bugs] [Bug 19056] Move C4::Reserves::GetReserveCount to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:46:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:46:13 +0000 Subject: [Koha-bugs] [Bug 19055] GetReservesToBranch is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19055 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:47:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:47:55 +0000 Subject: [Koha-bugs] [Bug 19055] GetReservesToBranch is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19055 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65616|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 66694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66694&action=edit Bug 19055: Remove C4::Reserves::GetReservesToBranch This subroutine is no longer in used and can be removed Test plan: git grep GetReservesToBranch must not return any results Signed-off-by: Marc V?ron Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:48:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:48:05 +0000 Subject: [Koha-bugs] [Bug 19055] GetReservesToBranch is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19055 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:51:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:51:11 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:51:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:51:15 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63947|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 66695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66695&action=edit Bug 17797: Add XSLT_Handler in opac/unapi Replaces some code by a call to existing module. Removes the $@->code and $@->message calls. Test plan [1] Run /cgi-bin/koha/unapi?id=koha:biblionumber:[number]&format=marcxml [2] Try some variations. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:52:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:52:58 +0000 Subject: [Koha-bugs] [Bug 19056] Move C4::Reserves::GetReserveCount to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65617|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 66696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66696&action=edit Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Signed-off-by: Marc V?ron Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:53:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:53:08 +0000 Subject: [Koha-bugs] [Bug 19056] Move C4::Reserves::GetReserveCount to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:53:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:53:26 +0000 Subject: [Koha-bugs] [Bug 18812] SIP Patron status does not respect OverduesBlockCirc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18812 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:53:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:53:28 +0000 Subject: [Koha-bugs] [Bug 18812] SIP Patron status does not respect OverduesBlockCirc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18812 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64420|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 66697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66697&action=edit Bug 18812 - SIP Patron status does not respect OverduesBlockCirc To test: 1 - Set 'OverduesBlockCirc' to block 2 - Find or create a patron with overdues 3 - Perform a SIP patron lookup on that patron misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron {userid or cardnumber} --password {pass} -m patron_information 4 - Note the first character of response is a ' ' 5 - Apply patch 6 - Restart memcached, apache, and plack 7 - Perform SIP patron lookup 8 - Note the first character of response is 'Y' 9 - prove t/db_dependent/SIP/Patron.t 10 - Test should return green Signed-off-by: Chris Kirby Works as advertised Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 11:55:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 09:55:14 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:01:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:01:11 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:01:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:01:14 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64447|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 66698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66698&action=edit Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:05:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:05:00 +0000 Subject: [Koha-bugs] [Bug 19209] Koha::Objects should provide ->is_paged method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 --- Comment #12 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #11) > Small remark: > > + is( ref($patrons->pager), 'DBIx::Class::ResultSet::Pager', > + 'Koha::Objects->pager returns a valid DBIx::Class object' ); > > If that is what we really want? Until now we wrapped lots of things in Koha > objects. > Btw: pager returns a Data::Page object for the current resultset. yeah, that looked weird, but I'm not touching it besides moving the tests into another subtsests. It is probably worth discussing and eventually filling a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:08:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:08:27 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #5 from Marcel de Rooy --- (In reply to Nick Clemens from comment #4) > Signed-off-by: Nick Clemens Please read QA contact field ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:10:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:10:00 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:12:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:12:05 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #6 from Marcel de Rooy --- Yes, I was testing it too and would have passed qa on it. But I could not manange somehow to make this patch show a difference. Followed the test plan and emptied Nav NavBottom MainUserBlock. Refreshing etc. no difference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:14:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:14:02 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 --- Comment #5 from Marcel de Rooy --- (In reply to Nick Clemens from comment #4) > Signed-off-by: Nick Clemens Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:16:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:16:48 +0000 Subject: [Koha-bugs] [Bug 17214] Add item in LIST by Record number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #11 from Marcel de Rooy --- QA: Looking here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:27:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:27:15 +0000 Subject: [Koha-bugs] [Bug 17214] Add item in LIST by Record number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Marcel de Rooy --- Bug 18260 has been pushed in the meantime and it removed GetBiblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:27:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:27:51 +0000 Subject: [Koha-bugs] [Bug 17214] Add item in LIST by Record number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 --- Comment #13 from Marcel de Rooy --- Internal server error: Undefined subroutine &CGI::Compile::ROOT::usr_share_koha_masterclone_virtualshelves_shelves_2epl::GetBiblio called at /usr/share/koha/masterclone/virtualshelves/shelves.pl line 178. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:34:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:34:11 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:35:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:35:08 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64072|0 |1 is obsolete| | Attachment #64876|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 66699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66699&action=edit Bug 16726: Clear text in syspref searchbox after submitting To test: 1) Go to Admin -> search for a system preference 2) Notice your search stays in the search box (this is inconsistent with search behaviour across Koha) 3) Apply patch and refresh page 4) Make another search 5) Confirm search still works as expected and search terms have been cleared from search box 6) Confirm search terms show at the top of the results Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:35:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:35:05 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:35:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:35:11 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #20 from Nick Clemens --- Created attachment 66700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66700&action=edit Bug 16726: [FOLLOW-UP] Putting text in h1 Works as outlined in test plan, search terms now appear at top as h1 as well Signed-off-by: Dilan Johnpull? Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:36:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:36:48 +0000 Subject: [Koha-bugs] [Bug 19021] Inventory column sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:42:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:42:13 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #49 from Blou --- To the last comment: << You add all additional fields in one column?? >> Yes. And it's beautiful. I'll get someone to look at your other points as soon as possible. The one about Koha.Preference just shows the age of this feature. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:42:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:42:39 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:44:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:44:13 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65907|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 66701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66701&action=edit Bug 19076 - unit tests Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:44:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:44:17 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65908|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 66702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66702&action=edit Bug 19076 - Move issue logging in AddIssue into condtional clause Currently AddIssue tests if renewal, but logs an issue even if so. This patch moves the logging into the conditional so a log entry is only added if we aren't renewing (as renewals are logged separately) To test: 1 - prove t/db_dependent/Circulation.t - one test should fail 2 - Enable both issue and renewal logs 3 - Checkout an item to a patron 4 - View the logs - the issue is captured 5 - Checkout the item to the patron again and confirm renewal 6 - Both an issue and a renewal are logged 7 - Apply patch 8 Repeat 1-6, tests should pass and only renewal should be logged Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:44:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:44:20 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65916|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 66703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66703&action=edit Bug 19076 - followup - delete fines from additional renewal Signed-off-by: Christopher Brannon Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:44:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:44:30 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:45:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:45:35 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65654|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 66704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66704&action=edit Bug 10112 - add test for ./debian/control* files to test, apply patch... 1/ install libparse-debcontrol-perl package apt-get install libparse-debcontrol-perl 2/ run successful tests $ perl ./t/00-valid-debian-control-file.t 1..2 ok 1 - parsed ./debian/control file cleanly ok 2 - parsed ./debian/control.in file cleanly 3/ add some bad syntax to a file $ sed -i -e '20i -------\' ./debian/control.in 4/ run failed tests $ perl ./t/00-valid-debian-control-file.t 1..2 ok 1 - parsed ./debian/control file cleanly not ok 2 - parsed ./debian/control.in file cleanly Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:45:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:45:33 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:48:02 +0000 Subject: [Koha-bugs] [Bug 19021] Inventory column sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021 --- Comment #5 from Nick Clemens --- > => With patch first column is not sortable and table is sorted by barcode When performing an inventory without a barcode file we are essentially generating a shelf list, shouldn't callnumber (or cn_sort ideally) be the default sort here? Even when comparing to a barcode file I think we should probably be sorting by callnumber in our results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:52:06 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:52:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:52:52 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:52:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:52:55 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65779|0 |1 is obsolete| | Attachment #65780|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 66705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66705&action=edit Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date not on closed day (depending on useDaysMode) Test plan: 1. ReturnBeforeExpiry is activated 2. useDaysMode is different from "circulation rules only" 3. Set expiry date of a patron to a near date 4. Set a closed day on calendar for this date 5. Do a checkout Without patch, return date will be patron expiration date With the patch, return date will be last open day before patron expiration day Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:53:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:53:03 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #16 from Kyle M Hall --- Created attachment 66706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66706&action=edit BUG 11580 : Added unit test Added one unit test when the syspref useDaysMode is active. This does not move code anymore Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:53:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:53:06 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #17 from Kyle M Hall --- Created attachment 66707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66707&action=edit Bug 11580 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:53:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:53:35 +0000 Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:53:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:53:50 +0000 Subject: [Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 12:55:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 10:55:05 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:19:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:19:29 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:19:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:19:33 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66309|0 |1 is obsolete| | Attachment #66310|0 |1 is obsolete| | Attachment #66311|0 |1 is obsolete| | Attachment #66312|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 66708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66708&action=edit Bug 18811: Change visibility checks in authorities.pl The check is now <=-4 or >=5, but the framework uses 0 for Show all and -5 for Hide all. (Note that sql installer scripts also use 8.) When modifying an authority, the script also showed hidden fields when filled, since it did not check the hidden field but only the tab field. NOTE: The proposed solution restores consistency, but will remove hidden fields from the MARC record. Test plan: [1] Set field 942a to Show all in an authority framework. [2] Open a new record in this framework and verify that you see 942a. [3] Edit an existing record in this framework and verify again. [4] Set field 942a now to Hide all in this framework. [5] Open a new record in this framework and verify that 942a is hidden. [6] Edit an existing record in this framework and verify again. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:19:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:19:36 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #19 from Nick Clemens --- Created attachment 66709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66709&action=edit Bug 18811: Add Koha Objects for authority tags and subfields Trivial copy and paste activity. Will be used in a later patch. No test plan needed. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:19:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:19:43 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #21 from Nick Clemens --- Created attachment 66711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66711&action=edit Bug 18811: Atomic update to print warning at upgrade time The warning encourages people to run the auth_show_hidden_data script to check for data in hidden fields and adjust their frameworks. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:19:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:19:40 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #20 from Nick Clemens --- Created attachment 66710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66710&action=edit Bug 18811: Add a script for checking authority data in hidden fields If you edit an authority record while having data in hidden fields or subfields, that data will be lost now. This script can help you to unhide some fields and prevent data loss. Test plan: [1] Add a PERSO_NAME record. Fill e.g. 100b. [2] Hide 100b in the PERSO_NAME framework. [3] Run auth_show_hidden_data.pl and verify that it reports 100b in the PERSO_NAME framework. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:21:24 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #7 from Nick Clemens --- Failing per comment #6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:27:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:27:21 +0000 Subject: [Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:32:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:32:11 +0000 Subject: [Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:32:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:32:14 +0000 Subject: [Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66143|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 66712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66712&action=edit Bug 16401: System preference staffClientBaseURL hardcoded to 'http://' Test plan: 1) Insert some value to staffBaseURL preference, without starting http:// 2) Apply the patch 3) Update database 4) Go to system preferences adminsitration, find the staffBaseURL preference, the inserted value should be prepended with 'http://' and the comment should be "This should be a complete URL, starting with http:// or https://. Do not include a trailing slash in the URL. (This must be filled in correctly for CAS, svc, and load_testing to work.)" 5) prove t/db_dependent/Auth_with_cas.t 6) prove t/db_dependent/selenium/basic_workflow.t 7) prove t/db_dependent/check_sysprefs.t Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:33:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:33:37 +0000 Subject: [Koha-bugs] [Bug 19021] Inventory column sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:42:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:42:18 +0000 Subject: [Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:42:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:42:20 +0000 Subject: [Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66257|0 |1 is obsolete| | Attachment #66258|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 66713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66713&action=edit Bug 19129 - Clean up Details tab for Organisation patrons Problem: A patron category "I" would cause display problems on the details in the intranet. This is because the templates confused patron category "I" with patron type "I" (organisation). Patch: - Cleans up variable confusion between categorycode and categorytype. - The template contained code to change the labels below the address to 'Organisational phone:" etc., I have removed this part as it does not match the edit form anymore. - Initials, date of birth and gender are still hidden for organisation - matching the edit form. Bonus: - The patron category description was missing on the right and left side of the details tab. Now it displays. - Fixes some html issues: - doubled up class attribute in a tag - doubled up To test: - Create 3 patrons - patron category code doesn't matter, but category type organisation - patron category code 'I', category type NOT organisation - patron category code NOT I, category type NOT organisaton - Check details tab in patron account in staff for all 3 - Verify patron category description shows correctly - Verify information added to the account displays correctly (phone numbers, emails, ...) Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:42:28 +0000 Subject: [Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129 --- Comment #9 from Kyle M Hall --- Created attachment 66714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66714&action=edit Bug 19129 - Follow-up - Add changes to patron duplicate warning Adds logic from the previous fix to the brief patron summary shown when checking a possible patron duplicate. Bonus: Also fixes missing patron category description there. To Test: - Add 2 patrons - Add a patron with the same surname and firstname as an existing patron in order to trigger the duplicate message - Click "View existing patron" - Verify display is correct when existing patron is - an organisation - not an organisation - Verify that the patron category description shows Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:43:06 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:43:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:43:44 +0000 Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:44:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:44:02 +0000 Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 13:43:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 11:43:47 +0000 Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 --- Comment #6 from Kyle M Hall --- Created attachment 66715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66715&action=edit Bug 18621: Added in value attribute to dateexpiry field Test plan: 1. Create a patron category with the dateexpiry value of 29/9/2017 2. Create a patron user from that patron category (which I'll refer to as patron A) with the date expiry value of 1/10/2017 and submit the form 3. Notice that the manual dateexpiry you have submitted is correctly displayed 4. Create a duplicate patron with the same firstname and surname and patron A, and set the date expiry value of 1/10/2017 and submit the form 5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now 6. Select the new member (not a duplicate member) option in the messagebox 7. The form successfully submits and notice that the date expiry value displayed is that of the patron category (i.e. it is 29/9/2017) not the dateexpiry value of 1/10/2017 that you manually set for this patron 8. Apply patch 9. Repeat step 4 10. The form displays a duplicate patron message. Notice the dateexpiry input box still contains the value you entered which is 1/10/2017. Select the new member (not a duplicate member) option in the messagebox 11. The form successfully submits and notice that the date expiry value displayed is 1/10/2017 that you manually set for this patron Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:01:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:01:18 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Julian Maurice --- QA comment: 1. It is possible to delete protected categories by changing the URL, e.g. /cgi-bin/koha/admin/authorised_values.pl?op=del_category&category=Bsort1 The deletion must be prevented on the server side. 2. The 'Delete category' button is inside the message box for "There are no authorised values ...". Why not in the toolbar like the other buttons ? 3. After a successful deletion, there is no redirect, so if we refresh the page the deletion is tried again and we end up with the following error message: "error_on_delete_cat". This message should be more human-friendly and IMO there should be a redirect after the deletion. 4. As comment 11 says, LOC appears twice in the hash, as well as LOST. These duplicates must be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:01:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:01:57 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #32 from Colin Campbell --- (In reply to Marcel de Rooy from comment #31) > + foreach my $key ( keys %{$href} ) { > + if ( $key =~ m/[^A-Z_]/ ) { > + delete $href->{$key}; > + } > > Don't understand this. You are deleting the uppercase keys ? SHouldn't you > do the reverse ? No that deletes lowercase [^A-Z] is a negated character class (includes lowercase and non alpha) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:07:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:07:56 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #92 from Kyle M Hall --- Created attachment 66716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66716&action=edit Bug 14826 - Add account offset type table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:08:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:08:55 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:10:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:10:48 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 --- Comment #5 from Nick Clemens --- What is the use of $plugin_file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:32:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:32:46 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:33:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:33:13 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:33:23 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 --- Comment #12 from Kyle M Hall --- Created attachment 66718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66718&action=edit Bug 9857 - Follow-up - Fix for searches with su= or su: When the initial search is su=.../su:... the links was not constructed correctly. With this change, it should be the case. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:33:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:33:16 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66325|0 |1 is obsolete| | Attachment #66326|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 66717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66717&action=edit Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:34:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:34:31 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:42:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:42:16 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65089|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 66719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66719&action=edit Bug 18946 - Change language from external web fails How to reproduce: 1. Get a multiling?al Koha like http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=en http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=es-ES 2. Copy that urls to any web page in an other domain -it must be in some host - and try to link to the spanish or english version,it will keep you in the same position. 3. Apply this patch and try again , everything should work fine . Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:42:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:42:22 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 --- Comment #5 from Kyle M Hall --- Created attachment 66720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66720&action=edit Bug 18946 [QA Followup] - code cleanup Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:42:29 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:44:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:44:01 +0000 Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:46:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:46:19 +0000 Subject: [Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:46:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:46:44 +0000 Subject: [Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:46:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:46:46 +0000 Subject: [Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66037|0 |1 is obsolete| | Attachment #66038|0 |1 is obsolete| | Attachment #66546|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 66721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66721&action=edit Bug 19004: Patrons.t should create its own data for enrollment fees. If the patron categories J, K, YA would not exist, Patrons.t would fail. Test plan: [1] Remove one of these patron categories. [2] Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:46:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:46:53 +0000 Subject: [Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 --- Comment #16 from Kyle M Hall --- Created attachment 66722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66722&action=edit Bug 19004: Adjust AddReturn for retrieving item type In the regular situation, you can get itemtype via biblio and then biblioitem as well as via biblioitem (at least when item-level_itypes is set to biblio). But since Koha unfortunately defined two relations in item, one for biblioitemnumber (the good one) and one for biblionumber (redundant), TestBuilder (correctly) builds one biblioitem and two biblios. If you item-level_itypes to biblio record, this will result in failing tests when calling AddReturn (in this case Koha/Patrons.t). It will crash on: Can't call method "itemtype" on an undefined value at C4/Circulation.pm line 1826. Cause: AddReturn goes via the biblionumber to biblio and than to biblioitems, and it does not find a biblioitem. (Not a fault from TestBuilder but a database design problem.) This patch makes a small change in AddReturn to retrieve the itemtype via biblioitem. It actually is a shorter road than items->biblio->biblioitems. Note: I do not test the Biblioitems->find call, since we already checked the GetItem call before and we have a foreign key constraint. I did not call $item->effective_itemtype since we still use GetItem; this could be done later. Adjusted Circulation/Returns.t too: If we add an item with TestBuilder and we called AddBiblio before, we should link biblioitemnumber as well. Test plan: [1] Do not apply this patch yet. [2] Set item-level_itypes to biblio record. [3] Run t/db_dependent/Koha/Patrons.t. (It should fail.) [4] Apply this patch. [5] Run t/db_dependent/Koha/Patrons.t again. [6] Run t/db_dependent/Circulation/Returns.t [7] Git grep on AddReturn and run a few other tests calling it. Note: Bugs 19070/19071 address three tests that call AddReturn too. [8] In the interface, check in a book. Signed-off-by: Marcel de Rooy Note: Bugs 19070 and 19071 are already pushed. The command in comment #4 has all the tests successful. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:46:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:46:56 +0000 Subject: [Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 --- Comment #17 from Kyle M Hall --- Created attachment 66723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66723&action=edit Bug 19004: [QA Follow-up] No need to check item-level_itypes again As Jonathan pointed out, GetItem already called effective_itemtype. So we can just use $item->{itype} here. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:48:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:48:12 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63687|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 66724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66724&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:48:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:48:39 +0000 Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #23 from Jonathan Druart --- Very easy conflict with bug 18292 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:50:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:50:35 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:51:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:51:17 +0000 Subject: [Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:51:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:51:20 +0000 Subject: [Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66042|0 |1 is obsolete| | Attachment #66043|0 |1 is obsolete| | Attachment #66044|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 66725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66725&action=edit Bug 19024: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:51:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:51:27 +0000 Subject: [Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024 --- Comment #21 from Kyle M Hall --- Created attachment 66726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66726&action=edit Bug 19024 Fix some infelicities of phrasing in test messages The test messages were awkwardly phrased, re phrase them to sound more natuaral. Patch is cosmetic (grammar) only Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:51:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:51:30 +0000 Subject: [Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024 --- Comment #22 from Kyle M Hall --- Created attachment 66727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66727&action=edit Bug 19024 Do not unset order cancelled status on basket close On closing a basket, status is updated to ordered for orders not completed. However the operation was resetting the status for cancelled as well as new orders. While display is correct from the basket view (it checks the cancellation date). The status in the acquisitions tab from the catalogue view reverts erroneously to ordered. This patch adds cancelled to the statuses not updated on basket close. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:54:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:54:56 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 --- Comment #6 from Jonathan Druart --- Created attachment 66728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66728&action=edit Bug 19081: Remove useless $plugin_file variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:55:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:55:28 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 --- Comment #7 from Jonathan Druart --- (In reply to Nick Clemens from comment #5) > What is the use of $plugin_file? none, it was a previous try. I will squash the patches later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:55:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:55:34 +0000 Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66553|0 |1 is obsolete| | --- Comment #20 from Julian Maurice --- Created attachment 66729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66729&action=edit Bug 16485: collection column in Item search is always empty This patch fills the column 'Collection' in item search from the item values. To test: - Go to item search - Reproduce issue from initial comment - Apply patch - Verify that the column 'Collection' is filled Still to do, but outside of my datatable skills: Filter by drop down in the column header does a substring search. Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:55:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:55:53 +0000 Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:56:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:56:15 +0000 Subject: [Koha-bugs] [Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66516|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 66730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66730&action=edit Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields This patch adds a note to the system preferences autonembernum and BorrowerMandatoryFields regarding a conflict if automembernum is on and BorrowerMandatoryFields contains cardnumber. To reproduce issue: See initial comment. To test: - Apply patch - Verify that in system preferences note appears with both prefs automembernum and BorrowerMandatoryFields Followed test plan, works as described Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:56:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:56:12 +0000 Subject: [Koha-bugs] [Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:59:47 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 14:59:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 12:59:50 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65906|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 66731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66731&action=edit Bug 18692 - intranet part Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intranet messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:05:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:05:56 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |In Discussion --- Comment #23 from Kyle M Hall --- On master I cannot input more than the max number of characters for cardnumber. Is this patch still necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:06:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:06:46 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65657|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 66732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66732&action=edit Bug 10267: Show error message if user tries to enter too many characters for cardnumber This patch displays a message if the user tries to enter more than the max number of characters for a cardnumber. To test: 1) Apply patch and go to Patrons -> New patron 2) Scroll down to Card number 3) Put in any characters. Notice that when you have entered the max number of characters, you are unable to type any more. 4) Click out of the text field (so it loses focus), the error message will show up. 5) if you backspace some characters and click out of the text field again, the message should disappear Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:06:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:06:54 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:08:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:08:18 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:08:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:08:21 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66719|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 66733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66733&action=edit Bug 18946 - Change language from external web fails How to reproduce: 1. Get a multiling?al Koha like http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=en http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=es-ES 2. Copy that urls to any web page in an other domain -it must be in some host - and try to link to the spanish or english version,it will keep you in the same position. 3. Apply this patch and try again , everything should work fine . Signed-off-by: Hugo Agud Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:08:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:08:54 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66720|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 66734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66734&action=edit Bug 18946 [QA Followup] - code cleanup Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:11:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:11:58 +0000 Subject: [Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch record deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66226|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 66735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66735&action=edit Bug 14316: Clarify meaning of record number in Batch record modification tool Same change as the first patch, but for the batch record modification tool. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:11:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:11:56 +0000 Subject: [Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch record deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:14:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:14:45 +0000 Subject: [Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 --- Comment #18 from Jonathan Druart --- Note to myself: - my $item_level_itypes = C4::Context->preference("item-level_itypes"); - my $biblio = $item_level_itypes ? undef : Koha::Biblios->find( $item->{ biblionumber } ); # don't get bib data unless we need it - my $itemtype = $item_level_itypes ? $item->{itype} : $biblio->biblioitem->itemtype; + my $itemtype = $item->{itype}; # GetItem called effective_itemtype This is not equal, but the previous code was buggy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:18:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:18:08 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66566|0 |1 is obsolete| | Attachment #66728|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 66736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66736&action=edit Bug 19081: Do not list plugins that have been uninstalled Under plack, can_load should not check if a package is in cache, but reload it. Otherwise plugins that have been uninstalled will still get listed. The error raised by can_load must only be displayed if the plugin has been removed. Test plan: 1/ Upload a plugin 2/ Note the plugin is listed as installed 3/ Modify the package of the plugin to add a compilation error (use 'Foo' for instance) 4/ Reload the page 5/ The plugin is not listed and a warning appear in the logs 6/ Remove the compilation error and uninstall the plugin 7/ The plugin is no longer listed and no warning appear in the logs Signed-off-by: Lee Jamison Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:18:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:18:05 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:18:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:18:14 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 --- Comment #9 from Kyle M Hall --- Created attachment 66737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66737&action=edit Bug 19081: Remove useless $plugin_file variable Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:21:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:21:26 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:21:29 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66499|0 |1 is obsolete| | Attachment #66500|0 |1 is obsolete| | Attachment #66501|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 66738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66738&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:21:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:21:32 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #19 from Nick Clemens --- Created attachment 66739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66739&action=edit Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:21:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:21:35 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #20 from Nick Clemens --- Created attachment 66740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66740&action=edit Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:21:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:21:39 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #21 from Nick Clemens --- Created attachment 66741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66741&action=edit Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion After order is deleted we don't have a vendor or basket so we get blank breadcrumbs, this removes them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:24:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:24:13 +0000 Subject: [Koha-bugs] [Bug 16797] errors in UNIMARC complet sample authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |julian.maurice at biblibre.com --- Comment #23 from Julian Maurice --- (In reply to Jonathan Druart from comment #22) > Maybe a silly question but why do not you create the authtypecodez AUTTIT, > SAUT, SCO and STU instead? Changing status to In Discussion to have an answer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:29:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:29:40 +0000 Subject: [Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:30:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:30:18 +0000 Subject: [Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:42:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:42:32 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:43:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:43:05 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:44:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:44:43 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #33 from Colin Campbell --- Kyle's update differs from the original patch in the following - # $noerror = 0; + $noerror = 0; The commented out line was added back in 2008 and there was no setting of the variable prior to that. The difference is with the line commented out the sipserver proceeds with the issue with noerror being set to 0 the issue is blocked. It meant that the code was overriding the syspref setting (which it had actually passed to CanBookBeIssued) So it cleans up a long standing bug in that response. Checked that issues were allowed/disallowed as per the syspref setting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:47:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:47:08 +0000 Subject: [Koha-bugs] [Bug 18810] Update Font Awesome to 4.7.0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|josef.moravec at gmail.com |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:48:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:48:04 +0000 Subject: [Koha-bugs] [Bug 18810] Update Font Awesome to 4.7.0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:50:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:50:02 +0000 Subject: [Koha-bugs] [Bug 18810] Update Font Awesome to 4.7.0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:50:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:50:08 +0000 Subject: [Koha-bugs] [Bug 18810] Update Font Awesome to 4.7.0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64482|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 66742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66742&action=edit Bug 18810: Update Font Awesome to 4.7.0 Test plan: 0) Apply the patch 1) Edit a template and use any of the new icons, see http://fontawesome.io/icons/ 2) Verify that the added icon is shown For alternative test see comment #2. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:50:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:50:58 +0000 Subject: [Koha-bugs] [Bug 18810] Update Font Awesome to 4.7.0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66742|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 66743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66743&action=edit Bug 18810: Update Font Awesome to 4.7.0 Test plan: 0) Apply the patch 1) Edit a template and use any of the new icons, see http://fontawesome.io/icons/ 2) Verify that the added icon is shown For alternative test see comment #2. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:51:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:51:49 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED Assignee|jonathan.druart at bugs.koha-c |magnus at libriotech.no |ommunity.org | --- Comment #13 from Jonathan Druart --- (In reply to Magnus Enger from comment #11) > have changed things enough that it now makes sense to revive the current > bug/patch. I have made a similar change on my live server and customers are > happy with it. What is the patch? This one does no longer apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:54:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:54:08 +0000 Subject: [Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66147|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 66744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66744&action=edit Bug 13766 - Change *bibioitems.ean to mediumtext and add indexes - biblioitems.ean and deleteditems.ean are changed to mediumtext to match issn and isbn. - An index is added for ean on both tables. Patch cleans up inconsistencies caused by bug 5337 that causes some older databases to have an existing index on biblioitems.ean. Signed-off-by: Colin Campbell Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:54:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:54:05 +0000 Subject: [Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:54:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:54:10 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:54:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:54:56 +0000 Subject: [Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com --- Comment #14 from Nick Clemens --- Looks good and worked for me. Wondered if we need to check for existing indexes on deletedbiblioitems but think this is okay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:58:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:58:17 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #65939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 15:59:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 13:59:34 +0000 Subject: [Koha-bugs] [Bug 17834] Change library news text for single-branch libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:00:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:00:38 +0000 Subject: [Koha-bugs] [Bug 17834] Change library news text for single-branch libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:00:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:00:41 +0000 Subject: [Koha-bugs] [Bug 17834] Change library news text for single-branch libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64566|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 66745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66745&action=edit Bug 17834: Change library news text for single-branch libraries To test: 1) Log into OPAC, go to home page 2) Confirm that the text shows as 'RSS feed for (branchname) library news' if single-branch library 3) Confirm text shows as normal for libraries with more than one branch Sponsored-by: Catalyst IT Signed-off-by: maricris Signed-off-by: anafe Signed-off-by: iflora Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:05:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:05:42 +0000 Subject: [Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Jonathan Druart --- (In reply to Nick Clemens from comment #14) > Looks good and worked for me. Wondered if we need to check for existing > indexes on deletedbiblioitems but think this is okay Yes, please. Check all of them, and use C4::Installer::index_exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:10:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:10:29 +0000 Subject: [Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 --- Comment #4 from Julian Maurice --- (In reply to Jonathan Druart from comment #2) > Regarding bug 7679 this line was wrong, that is why it has been removed. It looks like it has been removed by accident while resolving a merge conflict. The commit that remove those lines doesn't mention this change. I believe the TOTAL row has been fixed by bug 7679, but even if it's wrong, the same data should appear on screen and in the CSV export (and the TOTAL row is already displayed on screen). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:10:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:10:47 +0000 Subject: [Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 --- Comment #5 from Julian Maurice --- Created attachment 66746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66746&action=edit Bug 18742: Circulation statistics wizard no longer exports the total row To test: - Run the circulation wizard - Export to csv - Note there is no total row - Apply patch - Export to csv - Total row totally there! Signed-off-by: Christopher Brannon Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:10:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:10:50 +0000 Subject: [Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 --- Comment #6 from Julian Maurice --- Created attachment 66747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66747&action=edit Bug 18742: (QA followup) Fix indentation Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:11:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:11:20 +0000 Subject: [Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:11:54 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #50 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #49) > Koha::Patron::Message::Preferences > sub find_with_message_name > my $attr = Koha::Patron::Message::Attributes->find({ > message_name => $id->{'message_name'}, > }); > Isnt this actually a search? Couldnt we have multiple results on name ? > Similar question for search_with_message_name later It's a unique key UNIQUE KEY `message_name` (`message_name`) > my $name = $transport->get_column('message_name'); > Why get_column, not just message_name ? It's a column from another table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:13:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:13:04 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #9) > (In reply to Aleisha Amohia from comment #8) > > (In reply to Marcel de Rooy from comment #7) > > > Have the impression that we should not hide labels with a syspref but > > > resolve this with custom css. Please convince me that I am wrong. > > > > The syspref just provides the functionality for the library to hide or show > > the text, without having to play around with css or ask us to do it for > > them. I don't think it's fair to assume that librarians know how to write > > css. > > We have to find a balance between adding a syspref for showing/hiding > elements and css customization. Yes, not each librarian writes css. I will > not block this patch and change the status to Signed off again. Another QA > opinion please. I must agree, my first thought was to ask why not just add a class to make it easy to hide with css. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:14:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:14:03 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #51 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #47) > You add exceptions that are already there. > > Koha::Exceptions::BadParameter > Koha::Exceptions::WrongParameter > > Koha::Exceptions::ObjectNotFound > Koha::Exceptions::UnknownObject Lari, please adjust. Are you ok with the squash? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:19:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:19:39 +0000 Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:21:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:21:11 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:22:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:22:40 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:27:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:27:22 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:29:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:29:24 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart --- You need to check the existence of these languages in the update DB, otherwise they will be duplicated. Note: the "added" column is wrong, but useless as well. It should be an automatic timestamp. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:33:23 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:40:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:40:29 +0000 Subject: [Koha-bugs] [Bug 17864] Increase test coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64435|0 |1 is obsolete| | Attachment #64436|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 66748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66748&action=edit Bug 17793: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett https://bugs.koha-community.org/show_bug.cgi?id=17864 Signed-off-by: Lee Jamison Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:40:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:40:26 +0000 Subject: [Koha-bugs] [Bug 17864] Increase test coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:40:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:40:36 +0000 Subject: [Koha-bugs] [Bug 17864] Increase test coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #13 from Kyle M Hall --- Created attachment 66749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66749&action=edit Bug 17864: Follow up to add missing tests This adds tests for the missing items. Remember the kohadevbox has annoying caching issues, so close tab, vagrant halt, vagrant up just to be certain you are not failing because of caching. Signed-off-by: Lee Jamison Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:41:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:41:10 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #18 from Nick Clemens --- Created attachment 66750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66750&action=edit Bug 17380: (QA followup) Fix parameter in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:41:14 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #19 from Nick Clemens --- Created attachment 66751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66751&action=edit Bug 17380: (Alternate proposal) Report error to user instead of throwing exception Internal server errors are good, user feedback is better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:42:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:42:10 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #20 from Nick Clemens --- Marcel - I fixed a problem in tests and provide an alternate to the exceptions, does this seem reasonable? -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:48:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:48:44 +0000 Subject: [Koha-bugs] [Bug 19234] New: Add query parameters handling helpers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Bug ID: 19234 Summary: Add query parameters handling helpers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org In order to ease endpoint writing, we need a common (and fully tested) way of dealing with two things: - Extract pagination controlling params from the query params and create the right pagination setup for Koha::Objects - Generate the right DBIC query for the passed params -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:51:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:51:00 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > Yes, I was testing it too and would have passed qa on it. > But I could not manange somehow to make this patch show a difference. > Followed the test plan and emptied Nav NavBottom MainUserBlock. Refreshing > etc. no difference? Same, I cannot see any difference. Could you explain a bit more? Philippe, the author's name of the patch is Paudet, is it what you want? It will appear as it in the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:57:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:57:24 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #21 from Jonathan Druart --- It does not look good to me: https://pageshot.net/kN7OYETHoEC4WTSQ/pro.kohadev.org Does someone has something else to suggest? Maybe we should style a bit h1, or h2? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 16:57:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 14:57:50 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #76 from Julian Maurice --- (In reply to Jonathan Druart from comment #75) > I have rebased the branch (tricky!), but I get > > Undefined subroutine &C4::Items::TransformKohaToMarc called at > /home/vagrant/kohaclone/C4/Items.pm line 1491. > > when I hit /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=42 > > TransformKohaToMarc is exported by C4::Biblio. > And it is what we are trying to avoid... > > Any ideas? Circular dependencies. C4::Biblio use C4::Items which use C4::Biblio; If I comment 'use C4::Items ...' in C4::Biblio, MARCdetail.pl works fine. It seems that this 'use' is not even needed. C4::Items is 'require'd each time it's needed in C4::Biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:00:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:00:03 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #22 from Jonathan Druart --- 11:57 < Joubu> does it look good for you? 11:58 < oleonard> Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:01:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:01:54 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |kyle at bywatersolutions.com, | |lari.taskula at jns.fi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:02:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:02:32 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 66752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66752&action=edit Bug 19234: Unit tests for query parameters handling helpers This patch adds unit tests for the new query parameters handling Mojo plugin. Sponsored-by: Camden County Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:02:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:02:38 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 66753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66753&action=edit Bug 19234: Add query parameters handling helpers This patch introduces a Mojolicious plugin to be used on the REST api. It adds a helper method: generate_dbic_query =================== When used, it generates what's needed to perform a search on DBIC/Koha::Objects like this: my $params = $c->validation->output; my ($filter, $attributes) = $c->generate_dbic_query($params); my $patrons = Koha::Patrons->search( $filter, $attributes ); It introduces a reserved word _exact_match that controls the generated $filter: - Default behaviour: right truncation on the query params - _exact_match=1: no truncation added. All the plugin's behaviour is tested. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater solutions Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:02:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:02:44 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 66754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66754&action=edit Bug 19234: (followup) Make Query plugin available to endpoints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:02:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:02:59 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:02:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:02:59 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #12 from Jonathan Druart --- (In reply to Christopher Brannon from comment #8) You only signed off on the last patch, please read the wiki page https://wiki.koha-community.org/wiki/Git_bz_configuration#Bugs_with_more_than_one_patch and/or follow the tutorial: https://wiki.koha-community.org/wiki/Koha_howto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:06:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:06:00 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] REST api: Add an endpoint for acquisition orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:06:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:06:00 +0000 Subject: [Koha-bugs] [Bug 18731] REST api: Add an endpoint for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 [Bug 19234] Add query parameters handling helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:06:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:06:20 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #13 from Jonathan Druart --- (In reply to Nick Clemens from comment #5) > Created attachment 65916 [details] [review] > Bug 19076 - followup - delete fines from additional renewal Why this patch here? Sounds like it should be moved somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:08:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:08:41 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > The patch proposes a new dependency libparse-debcontrol-perl and there has > been some discussion about it. Where/When/Why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:08:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:08:51 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:17:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:17:14 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 --- Comment #14 from Nick Clemens --- It should be squashed into unit tests patch, the extra renewal I add for tests added a fine, had to remove that to not break other tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:19:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:19:50 +0000 Subject: [Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:19:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:19:53 +0000 Subject: [Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66371|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 66755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66755&action=edit Add quantity field to the opac suggestions form (with correct username and email) https://bugs.koha-community.org/show_bug.cgi?id=19068 Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:20:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:20:27 +0000 Subject: [Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com Assignee|oleonard at myacpl.org |J.P.Knight at lboro.ac.uk --- Comment #12 from Nick Clemens --- Looks good, includes id so easy to hide if unwanted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:28:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:28:21 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Jonathan Druart --- Please provide tests for new modules (based on t/db_dependent/Koha/Cities.t) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:37:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:37:45 +0000 Subject: [Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- What about the following query instead? UPDATE systempreferences SET value = CONCAT('http://', value) WHERE variable = 'staffClientBaseURL' AND value <> "" AND value NOT LIKE '^http%'; staffClientBaseURL is not supposed to be empty, but it will avoid to have it set to "http://" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:43:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:43:28 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:43:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:43:30 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Jonathan Druart --- Please provide tests for new modules (based on t/db_dependent/Koha/Cities.t). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:43:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:43:34 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66263|0 |1 is obsolete| | Attachment #66264|0 |1 is obsolete| | Attachment #66265|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 66756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66756&action=edit Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:43:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:43:38 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #22 from Nick Clemens --- Created attachment 66757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66757&action=edit Bug 12691: [FOLLOW-UP] Follow-up patch This patch fixes merge conflicts and fixes the problems in Comment 7 QA tools complain about missing bracket, will be fixed in next followup Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:43:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:43:41 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #23 from Nick Clemens --- Created attachment 66758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66758&action=edit Bug 12691: [FOLLOW-UP] Missing bracket Patch adds bracket to template file (Comment 16) Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 17:54:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 15:54:59 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #16 from Barton Chittenden --- This is a *bit* off topic, but I've been working on a plugin that fills a similar niche on the staff side: https://github.com/bywatersolutions/koha-plugin-support -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:03:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:03:07 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:03:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:03:24 +0000 Subject: [Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch record deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:03:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:03:40 +0000 Subject: [Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:03:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:03:50 +0000 Subject: [Koha-bugs] [Bug 19235] New: password visible in OPAC self registration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235 Bug ID: 19235 Summary: password visible in OPAC self registration Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: apurbajyoti at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 66759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66759&action=edit snapshop of the bug 1. OPAC Self Registration 2. Type password 3. Password characters visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:03:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:03:57 +0000 Subject: [Koha-bugs] [Bug 15924] Coce not enabled on lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:04:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:04:20 +0000 Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:04:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:04:37 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:04:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:04:49 +0000 Subject: [Koha-bugs] [Bug 17797] Add XSLT_Handler in opac/unapi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:05:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:05:06 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:05:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:05:17 +0000 Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:05:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:05:34 +0000 Subject: [Koha-bugs] [Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:05:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:05:58 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:06:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:06:09 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:06:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:06:25 +0000 Subject: [Koha-bugs] [Bug 18812] SIP Patron status does not respect OverduesBlockCirc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:06:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:06:42 +0000 Subject: [Koha-bugs] [Bug 18946] Change language from external web fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:07:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:07:00 +0000 Subject: [Koha-bugs] [Bug 19004] Koha/Patrons.t fails when item-level_itypes is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:07:11 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:07:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:07:28 +0000 Subject: [Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:08:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:08:01 +0000 Subject: [Koha-bugs] [Bug 19056] Move C4::Reserves::GetReserveCount to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:07:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:07:45 +0000 Subject: [Koha-bugs] [Bug 19055] GetReservesToBranch is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:08:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:08:23 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:08:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:08:36 +0000 Subject: [Koha-bugs] [Bug 19081] Plack preventing uninstalled plugins from being removed on the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:08:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:08:52 +0000 Subject: [Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:09:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:09:04 +0000 Subject: [Koha-bugs] [Bug 19194] Internal server error when receiving an order with no itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:09:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:09:15 +0000 Subject: [Koha-bugs] [Bug 19236] New: UNIF_TITLE authority ignores 2nd indicator value for all new headings saved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19236 Bug ID: 19236 Summary: UNIF_TITLE authority ignores 2nd indicator value for all new headings saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org When saving new headings to UNIF_TITLE authority, second indicator value is not saved. So when you selected such authority heading (as part the cataloguing), you have to manually re-enter the indicator value concerned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:09:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:09:24 +0000 Subject: [Koha-bugs] [Bug 19208] Pay select option doesn't pay the selected fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:09:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:09:43 +0000 Subject: [Koha-bugs] [Bug 19209] Koha::Objects should provide ->is_paged method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:09:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:09:57 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:10:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:10:47 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #77 from Kyle M Hall --- Not sure what's going on here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:10:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:10:53 +0000 Subject: [Koha-bugs] [Bug 19237] New: PERSO_NAME authority file ignores first indicator value of new headings saved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237 Bug ID: 19237 Summary: PERSO_NAME authority file ignores first indicator value of new headings saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org When saving new headings to PERSO_NAME authority, first indicator value is not saved. So when you selected such authority heading (as part the cataloguing), you have to manually re-enter the indicator value concerned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:11:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:11:05 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:12:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:12:20 +0000 Subject: [Koha-bugs] [Bug 19238] New: CORPO_NAME authority file ignores first indicator of new headings saved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19238 Bug ID: 19238 Summary: CORPO_NAME authority file ignores first indicator of new headings saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org When saving new headings to CORPO_NAME authority, first indicator value is not saved. So when you selected such authority heading (as part the cataloguing), you have to manually re-enter the indicator value concerned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:16:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:16:19 +0000 Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679 --- Comment #4 from Apurba Jyoti Majumder --- The option could not be located. The view in opac is available Editable in opac not available -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:18:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:18:13 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:18:18 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64775|0 |1 is obsolete| | Attachment #64776|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall --- Created attachment 66760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66760&action=edit Bug 12768 - Updated schema files Signed-off-by: Eivin Giske Skaaren Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:18:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:18:28 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #56 from Kyle M Hall --- Created attachment 66761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66761&action=edit Bug 12768 - Replacement cost and processing fee management Signed-off-by: Eivin Giske Skaaren Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:19:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:19:18 +0000 Subject: [Koha-bugs] [Bug 19239] New: Cataloguing authority search result list to show double dashes for selected MARC 6XX subfields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19239 Bug ID: 19239 Summary: Cataloguing authority search result list to show double dashes for selected MARC 6XX subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On the cataloguing authority search result result list, show double dashes (--) before MARC 6XX subfields $v, $x, $y and $z data. Currently, the result list shows as: Australia History 2001- Enhanced authority result list will show the above heading as: Australia -- History -- 2001- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:22:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:22:42 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:22:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:22:30 +0000 Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:30:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:30:42 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:31:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:31:32 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:31:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:31:36 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64934|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 66762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66762&action=edit Bug 18708 [Revised] Show itemBarcodeFallbackSearch results in a modal window This patch modifies the circulation template so that itemBarcodeFallbackSearch results show in a modal window. To test, enable the itemBarcodeFallbackSearch system preference and open a patron's account in circulation. - Submit a string which will return search results. When the page reloads a modal should display showing a table of title search results. - Test the "Check out" button and confirm that the correct item is submitted. - Test closing the modal and re-displaying it using the new "Show matching titles" button. - Confirm that the "Add record using fast cataloging" button still works correctly. - Submit a string which will return no results. No modal window should display, and only the "Add record" button should appear. - Confirm that normal checkout works correctly. - Test with itemBarcodeFallbackSearch disabled, and with a user who lacks Fast Cataloging permission. Revision removes a heading which was made redundant by the modal markup. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:33:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:33:10 +0000 Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:36:20 +0000 Subject: [Koha-bugs] [Bug 19240] New: Names after ampersand (&) are ignored for cataloguing authority searching Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19240 Bug ID: 19240 Summary: Names after ampersand (&) are ignored for cataloguing authority searching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Names after ampersand (&) are ignored for cataloguing authority searching. For example: Australia. Department of Agriculture & Environment (as appeared in the cataloguing record) will appear in the cataloguing authority search screen as: Australia. Department of Agriculture See attached pictures. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:37:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:37:05 +0000 Subject: [Koha-bugs] [Bug 19240] Names after ampersand (&) are ignored for cataloguing authority searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19240 --- Comment #1 from Iming Chan --- Created attachment 66763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66763&action=edit Heading appeared in the cataloguing record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:38:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:38:03 +0000 Subject: [Koha-bugs] [Bug 19240] Names after ampersand (&) are ignored for cataloguing authority searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19240 --- Comment #2 from Iming Chan --- Created attachment 66764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66764&action=edit Heading appeared on the cataloguing authority search screen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:38:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:38:51 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61108|0 |1 is obsolete| | Attachment #61109|0 |1 is obsolete| | Attachment #64595|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 66765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66765&action=edit Bug 15336 - New command-line script: merge_bookseller.pl Test plan (i.e. merge bookseller n? 3 into the n? 6): run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts and invoices had moved into bookseller 6. Check that bookseller n? 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:38:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:38:48 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:38:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:38:58 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #29 from Kyle M Hall --- Created attachment 66766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66766&action=edit Bug 15336 - Fix unit tests (t/Bookseller.t) Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 18:39:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 16:39:02 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #30 from Kyle M Hall --- Created attachment 66767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66767&action=edit Bug 15336 - Fix a QA issue Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:22:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:22:16 +0000 Subject: [Koha-bugs] [Bug 19235] password visible in OPAC self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:22:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:22:19 +0000 Subject: [Koha-bugs] [Bug 19235] password visible in OPAC self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235 --- Comment #1 from M. Tompsett --- Created attachment 66768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66768&action=edit Bug 19235: Password entry visible in OPAC Self-registration The HTML code was "text" instead of "password". TEST PLAN ---------- 1) 'Allow' PatronSelfRegistration system preference 2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT) 3) Open OPAC 4) Click 'Register here' on the right. (/cgi-bin/koha/opac-memberentry.pl) 5) Scroll to bottom 6) enter some passwords -- visible 7) apply this patch 8) refresh page 9) repeat 5-6 as needed -- passwords should not be visible while entering 10) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:23:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:23:50 +0000 Subject: [Koha-bugs] [Bug 19235] password visible in OPAC self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |apurbajyoti at gmail.com, | |mtompset at hotmail.com Assignee|oleonard at myacpl.org |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:28:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:28:02 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63341|0 |1 is obsolete| | --- Comment #33 from Tom?s Cohen Arazi --- Created attachment 66769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66769&action=edit Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager to test... 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real 16m34.104s 2/ apply patch 3/ install Parallel::ForkManager package $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl 4/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real 6m4.355s Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Edit: removed debian/control changes as the file is generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:28:11 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64322|0 |1 is obsolete| | --- Comment #34 from Tom?s Cohen Arazi --- Created attachment 66770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66770&action=edit Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager add KOHA_PROVE_CPUS envar to manually set number of cpus to test.. 1/ set number of cpus to 1 $ export KOHA_PROVE_CPUS=1 2/ observe 1 cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 1 CPUs... 3/ unset number of cpus $ export KOHA_PROVE_CPUS= 4/ observe all available cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 32 CPUs... Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:28:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:28:19 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #35 from Tom?s Cohen Arazi --- Created attachment 66771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66771&action=edit Bug 18055: (QA followup) Only print output if DEBUG Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:29:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:29:06 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:40:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:40:00 +0000 Subject: [Koha-bugs] [Bug 18437] Acquisitions fund edit repair In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62561|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 66772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66772&action=edit Bug 18437 - Acquisitions fund edit repair To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat stepps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. 12) Note "No owner" and "No users" messages have been added when there are none. https://bugs.koha-community.org/show_bug.cgi?id=18437 Signed-off-by: Lauren Denny -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:40:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:40:29 +0000 Subject: [Koha-bugs] [Bug 18437] Acquisitions fund edit repair In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #19 from Kyle M Hall --- "No owner" isn't translatable in the javascript. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:43:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:43:47 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Kyle M Hall --- Minor issue, the renewals remaining have been moved into the conditional so they will only show if the patron can renew the item themselves. Can be solved easily with an ELSE on canrenew. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:47:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:47:09 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:47:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:47:12 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65683|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 66773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66773&action=edit Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible Here we go, you will notice at the dependency list that this one is a bit different. In our former syntax we have 2 custom tags and . These tags were allowed to permit loop on the checked out items and the overdue items. In this patch, we will use the "loops" parameter, introduced by bug 17971, to pass the list of checkouts and overdues to the template. Note that Kyle suggested another approach on bug 15283: all the checkouts were send into the same array and each element of this array calls the is_from_today method, to know if the checkout is an overdue. I don't think we should rely on the Koha API, that's why I suggest to pass 2 differents object list, 1 which contains the checkouts and another one with the overdues. Note that we do rely on the Koha API, we call the Koha::Checkout->item and Koha::Item->biblio to propose an equivalent TT notice. But I think we can accept that. Test plan: Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the same notices you generated with the historical syntax. Signed-off-by: Kyle M Hall https://bugs.koha-community.org/show_bug.cgi?id=17969 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:48:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:48:14 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #36 from Tom?s Cohen Arazi --- I removed the changes to debian/control from the first patch. That file is actually generated and we shuold leave that to Mirko. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:48:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:48:16 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65686|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 66774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66774&action=edit Bug 17967: TT syntax for notices - Prove that ODUE is compatible Nothing new here, unless we are introducing a regression. The items.fine is a trick of our historical syntax. We need to provide a way to access this value from the a notice template using the TT syntax. A bug 17976 has been opened for discussion. Test plan: Define ODUE and OVERDUES_SLIP notice templates and use it to generate overdue notices from the cronjob script (misc/cronjobs/overdue_notices.pl) or the interface (members/print_overdues.pl). You should be able to generate the same notices with and without using the TT syntax Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:48:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:48:14 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:48:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:48:57 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:50:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:50:29 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:56:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:56:38 +0000 Subject: [Koha-bugs] [Bug 19057] Move C4::Reserves::GetReserve to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65618|0 |1 is obsolete| | Attachment #65619|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 66775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66775&action=edit Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds This GetReserve subroutine can be replaced with Koha::Holds->find Test plan: - git grep GetReserve must not return results where GetReserve is called - Cancel a reserve Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:56:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:56:35 +0000 Subject: [Koha-bugs] [Bug 19057] Move C4::Reserves::GetReserve to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 19:56:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 17:56:44 +0000 Subject: [Koha-bugs] [Bug 19057] Move C4::Reserves::GetReserve to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19057 --- Comment #6 from Kyle M Hall --- Created attachment 66776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66776&action=edit Bug 19057: Remove C4::Reserves::GetReserve Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:10:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:10:12 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #25 from Katrin Fischer --- The problem is not input - try and copy a longer string in. You won't notice that it has been cut off - with the patch you get a note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:13:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:13:32 +0000 Subject: [Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 --- Comment #16 from Katrin Fischer --- We can check both - I didn't to it initially, because we only had one on biblioitems in the past, but it makes sense for backporting. I will look for an example for index_exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:16:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:16:10 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 --- Comment #12 from Katrin Fischer --- Honestly? I don't remember. Probably just have to check with Mirko if it's ok? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:17:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:17:04 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 --- Comment #13 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #12) > Honestly? I don't remember. Probably just have to check with Mirko if it's > ok? Yeah, we need to check with Mirko if he is ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:20:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:20:44 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:20:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:20:48 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 --- Comment #8 from M. Tompsett --- Created attachment 66777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66777&action=edit Bug 18897: Use Module::Load::Conditional::can_load Rather than rely on eval(), Jonathan Druart recommended in comment #6 to use Use Module::Load::Conditional::can_load. This addresses that concern. TEST PLAN --------- $ git fetch $ git checkout -b bug_18897 origin/master $ git bz apply 18897 $ sudo apt-get remove libcatmandu-store-elasticsearch-perl ... $ prove t/db_dependent/Koha_Elasticsearch_Indexer.t -- Note that the message says the correct library is missing. $ sudo apt-get install libcatmandu-store-elasticsearch-perl -- Note it runs as expected. run the koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:21:24 +0000 Subject: [Koha-bugs] [Bug 19058] Move C4::Reserves::GetReserveId to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:21:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:21:27 +0000 Subject: [Koha-bugs] [Bug 19058] Move C4::Reserves::GetReserveId to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65635|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 66778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66778&action=edit Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:27:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:27:18 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 --- Comment #9 from M. Tompsett --- Missed a line: > TEST PLAN > --------- > $ git fetch > $ git checkout -b bug_18897 origin/master > $ git bz apply 18897 > $ sudo apt-get remove libcatmandu-store-elasticsearch-perl > ... > $ prove t/db_dependent/Koha_Elasticsearch_Indexer.t > -- Note that the message says the correct library is missing. > $ sudo apt-get install libcatmandu-store-elasticsearch-perl > $ prove t/db_dependent/Koha_Elasticsearch_Indexer.t > -- Note it runs as expected. > run the koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:29:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:29:07 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 --- Comment #26 from Marc V?ron --- (In reply to Kyle M Hall from comment #25) > Minor issue, the renewals remaining have been moved into the conditional so > they will only show if the patron can renew the item themselves. Can be > solved easily with an ELSE on canrenew. Sorry, I have no time ATM. Can you provide a counter patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:39:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:39:57 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Lots of complaints from koha-qa.pl that should be easy to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:43:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:43:37 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Tom?s Cohen Arazi --- Marcel, I agree with the removal, but you seem to be fixing a bug in the meantime (which I'm not against per-se) but I think if falls short, as we should be warning or similar about those non-existing authority records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:52:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:52:11 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66777|0 |1 is obsolete| | --- Comment #10 from Lee Jamison --- Created attachment 66779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66779&action=edit Bug 18897: Use Module::Load::Conditional::can_load Rather than rely on eval(), Jonathan Druart recommended in comment #6 to use Use Module::Load::Conditional::can_load. This addresses that concern. TEST PLAN --------- $ git fetch $ git checkout -b bug_18897 origin/master $ git bz apply 18897 $ sudo apt-get remove libcatmandu-store-elasticsearch-perl ... $ prove t/db_dependent/Koha_Elasticsearch_Indexer.t -- Note that the message says the correct library is missing. $ sudo apt-get install libcatmandu-store-elasticsearch-perl -- Note it runs as expected. run the koha qa test tools Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:52:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:52:08 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 20:52:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 18:52:23 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:02:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:02:20 +0000 Subject: [Koha-bugs] [Bug 18503] Confusing hold and transfer dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8451 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:02:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:02:20 +0000 Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18503 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:06:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:06:08 +0000 Subject: [Koha-bugs] [Bug 8451] Confusing and problematic double prompt for processing transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 --- Comment #13 from Christopher Brannon --- Not know this was being addressed, I tried my hand at it in 18503. I think unless someone can clearly present a scenario that would involve a hold an separate transfer in which both prompts need to be displayed, I have a hard time justifying keeping it in this state. If there is a legitimate need, then lets spell it out and make it work better for that scenario. Can someone come up with a scenario in which both are needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:16:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:16:29 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #19 from Jonathan Druart --- This change breaks test, please fix ASAP: t/db_dependent/Circulation/CalcDateDue.t .. 1/5 # Failed test 'date expiry' # at t/db_dependent/Circulation/CalcDateDue.t line 54. # got: '2012-12-31T23:59:00' # expected: '2013-01-01T23:59:00' # Looks like you failed 1 test of 5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:21:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:21:13 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 --- Comment #14 from Jonathan Druart --- Created attachment 66780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66780&action=edit Bug 9857: Fix failing test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:22:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:22:40 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 --- Comment #15 from Jonathan Druart --- Created attachment 66781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66781&action=edit Bug 9857: Fix failing tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:39:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:39:08 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #20 from Jonathan Druart --- I think the correct change is: + my $calendar = Koha::Calendar->new( branchcode => $branch ); + if ( $calendar->is_holiday($datedue) ) { + # Don't return on a closed day + $datedue = $calendar->prev_open_day($datedue); + } Because if expiry date is not a close day, the date due must be the expiry date. But then tests from t/db_dependent/Circulation/CalcDateDue.t are failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:52:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:52:33 +0000 Subject: [Koha-bugs] [Bug 19235] password visible in OPAC self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66768|0 |1 is obsolete| | --- Comment #2 from Lee Jamison --- Created attachment 66782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66782&action=edit Bug 19235: Password entry visible in OPAC Self-registration The HTML code was "text" instead of "password". TEST PLAN ---------- 1) 'Allow' PatronSelfRegistration system preference 2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT) 3) Open OPAC 4) Click 'Register here' on the right. (/cgi-bin/koha/opac-memberentry.pl) 5) Scroll to bottom 6) enter some passwords -- visible 7) apply this patch 8) refresh page 9) repeat 5-6 as needed -- passwords should not be visible while entering 10) run koha qa test tools Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:52:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:52:31 +0000 Subject: [Koha-bugs] [Bug 19235] password visible in OPAC self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:53:10 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #17 from Jonathan Druart --- Created attachment 66783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66783&action=edit Bug 19059: Fix compilation issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 21:53:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 19:53:55 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Jonathan Druart --- (In reply to Kyle M Hall from comment #16) > Lots of complaints from koha-qa.pl that should be easy to fix. Ooops! Sorry about that. Fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:13:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:13:33 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- The modal is a bit too wide when the title is short, but not blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:18:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:18:12 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #31 from Jonathan Druart --- I do not understand why you put the transaction in the pl and not in the method, are there any good reasons? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:19:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:19:27 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:19:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:19:29 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > Created attachment 66781 [details] [review] > Bug 9857: Fix failing tests > > Signed-off-by: Jonathan Druart Patch pushed to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:19:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:19:40 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:19:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:19:53 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:20:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:20:14 +0000 Subject: [Koha-bugs] [Bug 19057] Move C4::Reserves::GetReserve to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19057 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:20:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:20:22 +0000 Subject: [Koha-bugs] [Bug 19058] Move C4::Reserves::GetReserveId to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:21:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:21:32 +0000 Subject: [Koha-bugs] [Bug 17864] Increase test coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > I am not sure to understand how useful these regression tests can be. Answer still needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 1 22:57:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Sep 2017 20:57:17 +0000 Subject: [Koha-bugs] [Bug 19241] New: Items with status of hold show as available in cart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19241 Bug ID: 19241 Summary: Items with status of hold show as available in cart Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: michael at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 66784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66784&action=edit attachment shows item with status on hold in cart showing as available Items that have status of on hold show as available on cart list. While users can observe the item has the status of on hold before putting it in the cart, it was reported some patrons find this inconsistency confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 02:42:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 00:42:20 +0000 Subject: [Koha-bugs] [Bug 19242] New: Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19242 Bug ID: 19242 Summary: Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: samarosu1 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 66785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66785&action=edit Ossas -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 03:26:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 01:26:15 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 --- Comment #1 from M. Tompsett --- Created attachment 66786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66786&action=edit Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 03:26:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 01:26:21 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 --- Comment #2 from M. Tompsett --- Created attachment 66787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66787&action=edit Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 03:26:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 01:26:50 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 05:00:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 03:00:15 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 07:10:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 05:10:45 +0000 Subject: [Koha-bugs] [Bug 19242] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19242 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Summary|Koha |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 07:12:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 05:12:59 +0000 Subject: [Koha-bugs] [Bug 19242] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19242 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 07:38:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 05:38:25 +0000 Subject: [Koha-bugs] [Bug 19243] New: Selenium test for testing the administration module functionality Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Bug ID: 19243 Summary: Selenium test for testing the administration module functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The selenium test for this bug report will test the following Administrative module functionality: * Add item type * Add circulation rule * Modify frameworks * Add library * Add authorised values * Add patron category * Add patron attribute type * Add Z39.50 target server * Add item circulation alert * Add city -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 07:39:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 05:39:24 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 --- Comment #1 from Alex Buckley --- Created attachment 66788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66788&action=edit Bug 19243 - Selenium test for testing administrative tasks This selenium test checks the following Administrative module functionality: * Add item type * Add circulation rule * Modify frameworks * Add library * Add authorised values * Add patron category * Add patron attribute type * Add Z39.50 target server * Add item circulation alert * Add city Test plan (this test plan includes how to install Selenium as well as how to run this test, for the benefit of people who have not got Selenium installed on their machines): 1. wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar 2. vim /etc/apt/sources.list.d/firefox.list 3. Paste into the file: deb http://packages.linuxmint.com debian import 4. sudo apt-get update 5. sudo apt-get install firefox 6. sudo apt-get install xvfb 7. Set the SELENIUM_PATH vartiable: SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar 8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & 9. DISPLAY=:1 java -jar $SELENIUM_PATH Note: This will start up the selenium server. Everytime you want to shutdown this terminal window and want to restart Selenium just run the step 9 command to restart the Selenium server 10. Open a new terminal window and write in: git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch build/master --single-branch --depth 1 11. cd Selenium-Remote-Driver 12. perl Makefile.PL 13. make 14. make test 15. sudo make install 16. Now everything is installed and you can set up for running the selenium tests 17. Drop and recreate the Koha database and restart memcached 18. Go through the web installer installing all sample data and onboarding tool 19. Create a superlibrarian user with the username koha and password koha 20. If your usual port configuration for the intranet and OPAC is 8081 and 8080 respectively then set the staffClientBaseURL and OPACBaseURL system preferences to localhost:8080 and localhost:80 respectively 21. sudo koha-shell 22. perl t/db_dependent/selenium/administration_tasks.t 23. The test should pass. Note: The time_diff comments in the test output showing what the test is doing Note: If you have issues with installing Selenium and Selenium::Remote::Driver please write a comment on the bug report and I will be more than happy to create a screencapture video showing all the steps Note: Warns in front of the $driver->get_title() function have been implemented because during troubleshooting they were found to be an effective solution for stopping the test from failing due to not being able to find an element on the page. If anyone can suggest an alternative to using these warns please do Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 07:39:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 05:39:50 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 10:18:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 08:18:38 +0000 Subject: [Koha-bugs] [Bug 19242] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 10:20:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 08:20:50 +0000 Subject: [Koha-bugs] [Bug 19236] UNIF_TITLE authority ignores 2nd indicator value for all new headings saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19236 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Iming, I think 19238, 19237 and this one are probably all the same. Can you please add a step by step instruction on how to see the bug? I am not sure from the description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 10:21:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 08:21:25 +0000 Subject: [Koha-bugs] [Bug 19236] UNIF_TITLE authority ignores 2nd indicator value for all new headings saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19236 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19238, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19237 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 10:21:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 08:21:25 +0000 Subject: [Koha-bugs] [Bug 19238] CORPO_NAME authority file ignores first indicator of new headings saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19238 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19236 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 10:21:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 08:21:25 +0000 Subject: [Koha-bugs] [Bug 19237] PERSO_NAME authority file ignores first indicator value of new headings saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19236 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 18:09:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 16:09:11 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 18:10:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 16:10:38 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 18:11:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 16:11:36 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 2 19:34:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Sep 2017 17:34:18 +0000 Subject: [Koha-bugs] [Bug 19244] New: bud Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19244 Bug ID: 19244 Summary: bud Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: fikrymubarok17 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 66789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66789&action=edit bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 09:11:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 07:11:53 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #58 from Jiri Kozlovsky --- (In reply to Tom?s Cohen Arazi from comment #56) > Accountlines are tied to patrons. That means they might better be placed in > /patrons/{patron_id}/accountlines. Is there a place in Koha where all > accountlines are listed somehow that would require this kind of global > endpoint? I don't see the use case for it. Well Tomas, I see one use case for it. Imagine you'd like to create a bunch of very interesting statistics, which would then help you with improving your services. That could be done for example by observing correlations between fines cardinality. Imagine 70% of all users are having specific fee twice or more times in a month. That would be an alert signal for you to come up with some campaign to reduce users' fees (e.g. free month membership if you haven't any fee last year .. that's up to you) Moving this back to Signed Off - correct me, if you disagree :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 10:07:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 08:07:19 +0000 Subject: [Koha-bugs] [Bug 17708] Renewal log seems empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 11:15:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 09:15:30 +0000 Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #11 from Mason James --- (In reply to Marcel de Rooy from comment #9) > 'Test::More' => { > 'usage' => 'Core', > 'required' => '1', > 'min_ver' => '0.8' > }, > > Shouldn't we upgrade the min_ver for this one here too ? > > Needs feedback hi Marcel, the short answer is no Test::Simple has no dependency on Test::More, therefore there is no need to upgrade Test::More https://packages.debian.org/jessie/libtest-simple-perl https://packages.debian.org/stretch/libtest-simple-perl ..does that make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 11:27:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 09:27:26 +0000 Subject: [Koha-bugs] [Bug 19244] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19244 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bud |SPAM CC| |mtj at kohaaloha.com Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 16:31:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 14:31:18 +0000 Subject: [Koha-bugs] [Bug 19246] New: jhghjj Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19246 Bug ID: 19246 Summary: jhghjj Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: HP OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: akashtippa at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 20:08:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 18:08:24 +0000 Subject: [Koha-bugs] [Bug 19246] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|jhghjj |SPAM CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 20:08:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 18:08:33 +0000 Subject: [Koha-bugs] [Bug 19246] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 3 20:11:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 18:11:58 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #59 from Katrin Fischer --- I think it could be interesting for a library to see all types of different fines and how much is owed. XXX ILL fees XXX overdue fees XXX lost item Often fines and fees make part of a libraries budget. There is currently no place in Koha for it, but I can imagine that there exist a range of reports libraries use. I know we got one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 01:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 23:30:43 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 01:30:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Sep 2017 23:30:47 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 --- Comment #27 from Aleisha Amohia --- Created attachment 66791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66791&action=edit Bug 18351: [FOLLOW-UP] Removing swp file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 04:18:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 02:18:36 +0000 Subject: [Koha-bugs] [Bug 19247] New: Feature release change tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 Bug ID: 19247 Summary: Feature release change tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 05:21:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 03:21:09 +0000 Subject: [Koha-bugs] [Bug 19247] Feature release change tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 --- Comment #1 from Alex Buckley --- Created attachment 66792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66792&action=edit Bug 18645 -Koha feature release change tool This tool is displayed at the end of the update process to display all the new system preferences added during the update so that the administrator can view and modify their default values if neccessary Link to the release notes for the most recent installed release are also provided by this tool. Test plan: 1. Go to Administrator->global system preferences->Local use 2. Set the version number to 16.1200033 (Note: only 1 decimal place) and save 3. Go through the update process and notice that after submitting the 'Update database structure" page you are prompted to login and the main page appears if you logged in with the correct credentials 4. Apply patch 5. Repeat steps 1, and 2 6. Notice the button text on the 'Update database structure' page has changed and now it says 'Continue to feature release tool' 7. The feature release tool will be displayed. Click on the 'New Syspref information' tab and notice that the system preferences (names, explanations and (editable) default values) installed in the update process are displayed 8. Change the value of TranslateNotices syspref and click the 'Save all preferences' button 9. Refresh the page manually and click on the 'New syspref information' tab and notice the value of the TranslateNotices syspref has been altered 10. Click on the 'Release notes' tab and open the release note link which is 17.05 release notes 11. Leave the feature release change tool by clicking the 'Next and submit' button 12. You are prompted to login, after entering the correct credentials the intranet main page is displayed Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 08:23:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 06:23:08 +0000 Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302075 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #12 from Marcel de Rooy --- (In reply to Mason James from comment #11) > (In reply to Marcel de Rooy from comment #9) > > 'Test::More' => { > > 'usage' => 'Core', > > 'required' => '1', > > 'min_ver' => '0.8' > > }, > > > > Shouldn't we upgrade the min_ver for this one here too ? > > > > Needs feedback > > hi Marcel, the short answer is no > > Test::Simple has no dependency on Test::More, therefore there is no need to > upgrade Test::More > > https://packages.debian.org/jessie/libtest-simple-perl > https://packages.debian.org/stretch/libtest-simple-perl > > ..does that make sense? Hey MJ, When I follow that link, I see that libtest-simple-perl includes Test::More ! Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 08:45:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 06:45:54 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 --- Comment #4 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #3) > Marcel, I agree with the removal, but you seem to be fixing a bug in the > meantime (which I'm not against per-se) but I think if falls short, as we > should be warning or similar about those non-existing authority records. This is about two checks? [1] opac-authoritiesdetail -my $authtypecode = $authority->authtypecode; +my $authtypecode = $authority ? $authority->authtypecode : q{}; This does not fall short. It actually is only theoretical. If GetAuthority fails, the script redirects to 404. [2] authorities/detail.pl -my $authtypecode = Koha::Authorities->find($authid)->authtypecode; +my $authobj = Koha::Authorities->find($authid); +my $authtypecode = $authobj ? $authobj->authtypecode: q{}; Similar here. This check just prevents an ISE on authtypecode while a few lines later the output of GetAuthority is checked and an error is printed via the template. So no, it does not fall short. Please explain why this fails QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 09:01:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 07:01:31 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hagud at orex.es --- Comment #5 from Hugo Agud --- I have applied the patch followed the test plan and it works fine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 09:21:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 07:21:52 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 09:21:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 07:21:55 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #23 from Marcel de Rooy --- Created attachment 66793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66793&action=edit Bug 18811: [QA Follow-up] Add tests for Koha::Authority::Subfields/Tags Renaming t/db_dependent/Authorities to Authority Adding Subfields.t and Tags.t Test plan: [1] prove t/db_dependent/Authority Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 09:26:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 07:26:59 +0000 Subject: [Koha-bugs] [Bug 17039] No cancel/new item option when editing an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17039 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hagud at orex.es --- Comment #2 from Hugo Agud --- I have applied the patch and it works fine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:06:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:06:54 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #24 from Marcel de Rooy --- Created attachment 66794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66794&action=edit Bug 18811: [QA Follow-up] Resolved POD warnings Trivial changes to silence qa tools on POD warnings for Subfields and Tags. Note: Since Subfield and Tag only contain one sub which is considered as private by Pod::Coverage, these modules are listed as unrated (no public symbols defined) and trigger a FAIL on pod coverage in qa tools. This fail can be ignored. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:09:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:09:39 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #25 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #24) > Note: Since Subfield and Tag only contain one sub which is considered as > private by Pod::Coverage, these modules are listed as unrated (no public > symbols defined) and trigger a FAIL on pod coverage in qa tools. This fail > can be ignored. This is true for all 'empty' singular Koha objects. Could be resolved by renaming _type to type, or adding another public symbol. Should be done on another report, if we really feel the need to do so. We can just ignore them too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:15:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:15:05 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #21 from Marcel de Rooy --- (In reply to Nick Clemens from comment #18) > Created attachment 66750 [details] [review] > Bug 17380: (QA followup) Fix parameter in tests This has to do with the pushed enhancement that changes prototype of GetMarcBiblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:20:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:20:35 +0000 Subject: [Koha-bugs] [Bug 1022] DBD::mysql::st fetchrow failed: fetch() without execute() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1022 mksiva at yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |k.shivaswamy at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:23:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:23:07 +0000 Subject: [Koha-bugs] [Bug 19248] New: install.pl: DBD::mysql::st execute failed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 Bug ID: 19248 Summary: install.pl: DBD::mysql::st execute failed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: k.shivaswamy at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 66795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66795&action=edit Koha>Web Insteller> error The following error occurred while importing the database structure: [Mon Sep 4 13:12:33 2017] install.pl: DBD::mysql::st execute failed: Invalid default value for 'date_created' at /usr/share/perl5/DBIx/RunSQL.pm line 273. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:29:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:29:54 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #23 from Marcel de Rooy --- Created attachment 66797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66797&action=edit Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority If we got an authtypecode from the database and this value is not NULL since the table column does not allow it, there is no need to call GuessAuthTypeCode for empty string (read: Default framework) in the sub get_from_authid. Furthermore, we remove three Koha::MetadataRecord::Authority->new calls. They are useless, since we do not pass a record. It just generates: No record passed at authorities/merge.pl line 96. Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66. Instead we throw an ObjectNotFound exception. Test plan: [1] Run t/db_dependent/Koha_Authority.t [2] Interface will be tested in the following patches. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:29:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:29:50 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #22 from Marcel de Rooy --- Created attachment 66796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66796&action=edit Bug 17380: Add some checks around Authorities::Types->find Resolves: Use of uninitialized value $biblio_fields in scalar chop at authorities/detail.pl line 212. Can't call method "authtypetext" on an undefined value at authorities/detail.pl line 216. Can't call method "authtypecode" on an undefined value at authorities/detail.pl line 180. NOTE: Some of these problems have actually been resolved now by bugs 18801 and 18811, but it is still better imo to have these checks. Test plan: [1] Verify unchanged behavior. Search for some authorities on authorities.pl and click on the details of a record. [2] Open an authorities detail page and change the authid in the URL to a not existing number. Instead of an internal server error, you should see a message like "The authority record you requested does not exist". Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:29:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:29:58 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #24 from Marcel de Rooy --- Created attachment 66798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66798&action=edit Bug 17380: Graceful resolution of missing reporting tag in merge Altough this patch deals with a mostly hypothetical case and this report makes it practically impossible anymore to merge with records in the Default framework (having no reporting tag), we can make the code of sub merge still a bit more robust here. If you would merge biblio records from one authtype to another and the new framework would not have a reporting tag, before this patch the result would be data loss. Merge would handle this request as a delete. This patch makes merge handle it differently: instead of clearing the biblio records, it keeps $a and $9 in order to make a future corrective merge possible. Note: The additional condition on line 1468 for $tags_using_authtype makes sure that we do not select all fields when the authtype should unexpectedly be empty string (Default). This prevents crashing on a "Control fields do not have subfields" error. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:30:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:30:02 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #25 from Marcel de Rooy --- Created attachment 66799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66799&action=edit Bug 17380: Do not allow Default template in merge form This patch makes the following changes: [1] Removes Default from the template list. We should not merge with the Default framework, since it does not have a reporting tag. [2] Rearranges the error section in the template. It is confusing to have two error sections in this template. The error CANNOT_MOVE is not used. The error FRAMEWORK_NOT_SELECTED is replaced by WRONG_FRAMEWORK. [3] Do not allow to merge a record with itself. [4] Check if the merge reference record still contains any MARC tags. [5] Additional polishing: Simplify passing frameworks to template. Remove an unused Koha::Authority::Types->search. Remove obsolete POD header for functions from the script. Test plan: [1] Select two authorities to merge. Verify that you cannot select Default anymore as framework for the reference record. [2] Reproduce error WRONG_COUNT by adding another authid=999 in the URL after you selected two authority records for merging. [3] Remove the third authid from the URL and change the first or second authid into an unexisting record id. You should generate an Internal Server Error. The log should show the exception message. [4] Merge two authorities. Deselect all MARC tags. Should trigger the error EMPTY_MARC in the template. [5] Select the same authority record twice for merging. Should trigger the error DESTRUCTIVE_MERGE in the template. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:30:08 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66750|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy --- Created attachment 66800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66800&action=edit Bug 17380: (QA followup) Fix parameter in tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:30:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:30:12 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #27 from Marcel de Rooy --- Created attachment 66801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66801&action=edit Bug 17380: [QA Follow-up] Report error to user instead of throwing exception Internal server errors are good, user feedback is better. Signed-off-by: Marcel de Rooy Tiny change: removed the obsolete 'use Koha::Exceptions'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:30:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:30:59 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:31:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:31:01 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:31:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:31:03 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:31:05 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:30:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:30:57 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:31:08 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:33:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:33:24 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #28 from Marcel de Rooy --- (In reply to Nick Clemens from comment #20) > Marcel - I fixed a problem in tests and provide an alternate to the > exceptions, does this seem reasonable? > > -Nick Yes, looks good to me. Did you finish QA on this one with these adjustments? If so, please dont forget to add a signoff and change status. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:45:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:45:36 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #34 from Marcel de Rooy --- (In reply to Colin Campbell from comment #32) > (In reply to Marcel de Rooy from comment #31) > > + foreach my $key ( keys %{$href} ) { > > + if ( $key =~ m/[^A-Z_]/ ) { > > + delete $href->{$key}; > > + } > > > > Don't understand this. You are deleting the uppercase keys ? SHouldn't you > > do the reverse ? > > No that deletes lowercase [^A-Z] is a negated character class (includes > lowercase and non alpha) Of course, missed that somehow.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:49:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:49:36 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #35 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #30) > Marcel, Colin, can you try out this version? It's an update of Colin's patch. Looking back. I see that the patch dates from June 13 and I submitted a comment on July 14. No changes after that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 10:52:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 08:52:00 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #36 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #35) > (In reply to Kyle M Hall from comment #30) > > Marcel, Colin, can you try out this version? It's an update of Colin's patch. > > Looking back. I see that the patch dates from June 13 and I submitted a > comment on July 14. No changes after that? No, wait. You changed obsoleted flags.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 11:03:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 09:03:49 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #6 from Katrin Fischer --- Hi Hugo, please add your sign-off line to patche that you mark as signed off. Instructions on how to do this can be found on the wiki. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 12:04:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 10:04:02 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #4) > (In reply to Tom?s Cohen Arazi from comment #3) > > Marcel, I agree with the removal, but you seem to be fixing a bug in the > > meantime (which I'm not against per-se) but I think if falls short, as we > > should be warning or similar about those non-existing authority records. > > This is about two checks? > [1] opac-authoritiesdetail > -my $authtypecode = $authority->authtypecode; > +my $authtypecode = $authority ? $authority->authtypecode : q{}; > This does not fall short. It actually is only theoretical. If GetAuthority > fails, the script redirects to 404. > > [2] authorities/detail.pl > -my $authtypecode = Koha::Authorities->find($authid)->authtypecode; > +my $authobj = Koha::Authorities->find($authid); > +my $authtypecode = $authobj ? $authobj->authtypecode: q{}; > Similar here. This check just prevents an ISE on authtypecode while a few > lines later the output of GetAuthority is checked and an error is printed > via the template. So no, it does not fall short. > > Please explain why this fails QA. It is not a big deal, I just would like the script to warn (in the logs) in addition to the fallback to empty string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 12:08:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 10:08:29 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 --- Comment #6 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #5) > (In reply to Marcel de Rooy from comment #4) > > (In reply to Tom?s Cohen Arazi from comment #3) > > > Marcel, I agree with the removal, but you seem to be fixing a bug in the > > > meantime (which I'm not against per-se) but I think if falls short, as we > > > should be warning or similar about those non-existing authority records. > > > > This is about two checks? > > [1] opac-authoritiesdetail > > -my $authtypecode = $authority->authtypecode; > > +my $authtypecode = $authority ? $authority->authtypecode : q{}; > > This does not fall short. It actually is only theoretical. If GetAuthority > > fails, the script redirects to 404. > > > > [2] authorities/detail.pl > > -my $authtypecode = Koha::Authorities->find($authid)->authtypecode; > > +my $authobj = Koha::Authorities->find($authid); > > +my $authtypecode = $authobj ? $authobj->authtypecode: q{}; > > Similar here. This check just prevents an ISE on authtypecode while a few > > lines later the output of GetAuthority is checked and an error is printed > > via the template. So no, it does not fall short. > > > > Please explain why this fails QA. > > It is not a big deal, I just would like the script to warn (in the logs) in > addition to the fallback to empty string. We do not need these warns. As mentioned, the script either redirects to 404 or prints an error already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:00:04 +0000 Subject: [Koha-bugs] [Bug 19249] New: date picker broken in quick add brief form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Bug ID: 19249 Summary: date picker broken in quick add brief form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a date input like date of birth is mandatory, in quick add brief form the calendar icon appears but clicking on it does nothing. This is because quick add brief form creates a clone of inputs in the original form. An input with date picker is changed and linked to Javascript code (see calendar.inc) so it can not be cloned. Note also that creating a clone of an input in another form does not update the form value in its DOM. It can generate errors. In my opinion this feature should be reconsidered to hide unwanted fields instead of cloning wanted ones. Many bugs may be avoided. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:00:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:00:19 +0000 Subject: [Koha-bugs] [Bug 17344] Can't set guarantor in quick add brief form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17344 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19249 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:00:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:00:19 +0000 Subject: [Koha-bugs] [Bug 19249] date picker broken in quick add brief form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17344 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:00:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:00:29 +0000 Subject: [Koha-bugs] [Bug 19249] date picker broken in quick add brief form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:00:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:00:29 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 [Bug 19249] date picker broken in quick add brief form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:01:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:01:16 +0000 Subject: [Koha-bugs] [Bug 19249] date picker broken in quick add brief form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:02:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:02:43 +0000 Subject: [Koha-bugs] [Bug 19249] date picker broken in quick add brief form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 --- Comment #1 from Fridolin SOMERS --- Also date of birth has a small JS code showing age when date is changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:15:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:15:51 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 --- Comment #14 from Magnus Enger --- Looks like bug 19025 pulled the rug out from underneath this patch between my comment and that from Jonathan. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:17:10 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45800|0 |1 is obsolete| | --- Comment #15 from Magnus Enger --- Comment on attachment 45800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45800 Bug 12204: Display the expiration date on RESERVESLIP Bug 19025 makes this patch obsolete. But the problem described in the bug report remains, as far as I can tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 13:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 11:50:05 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #16 from Magnus Enger --- On further inspection it looks like this is completely fixed by bug 19025. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 14:54:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 12:54:49 +0000 Subject: [Koha-bugs] [Bug 19245] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|numpang lewat |SPAM Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing Severity|critical |minor QA Contact| |testopia at bugs.koha-communit | |y.org Resolution|--- |INVALID Group|Koha security | Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:53:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:53:41 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65110|0 |1 is obsolete| | --- Comment #101 from Tom?s Cohen Arazi --- Created attachment 66802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66802&action=edit Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible Also - adding some missing and new response definitions into Swagger spec. - fixing failing tests due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/holds.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:53:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:53:54 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65111|0 |1 is obsolete| | --- Comment #102 from Tom?s Cohen Arazi --- Created attachment 66803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66803&action=edit Bug 18137: Remove x-mojo-around-action Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch removes it from our specification document. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:54:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:54:06 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65112|0 |1 is obsolete| | --- Comment #103 from Tom?s Cohen Arazi --- Created attachment 66804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66804&action=edit Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages - DBIx::Class::Exception should use ->{msg} Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:54:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:54:21 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65113|0 |1 is obsolete| | --- Comment #104 from Tom?s Cohen Arazi --- Created attachment 66805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66805&action=edit Bug 18137: (QA-follow-up) Fix pod fail Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:54:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:54:42 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65404|0 |1 is obsolete| | --- Comment #106 from Tom?s Cohen Arazi --- Created attachment 66807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66807&action=edit Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies Edit (tcohen): I've changed the version numbers to match those Mirko has already successfully packaged and are known to work for this patchset. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:54:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:54:33 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65114|0 |1 is obsolete| | --- Comment #105 from Tom?s Cohen Arazi --- Created attachment 66806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66806&action=edit Bug 18137: (follow-up) Sort definitions.json Before this file grows, we should sort it alphabetically. To test: 1. prove t/db_dependent/api/v1 Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:54:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:54:50 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65714|0 |1 is obsolete| | --- Comment #107 from Tom?s Cohen Arazi --- Created attachment 66808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66808&action=edit Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:55:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:55:39 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65107|0 |1 is obsolete| | --- Comment #109 from Tom?s Cohen Arazi --- Created attachment 66810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66810&action=edit Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI This patch migrates from Swagger2 to Mojolicious::Plugin::OpenAPI as Swagger2 is no longer actively maintained. This migration involves some minor changes to our Swagger specification documents and to controllers. Each operation is migrated in following patches separately. Please see Mojolicious::Plugin::OpenAPI and its tutorial for more documentation. The patch also refactors some API authentication -related code by taking advantage of Koha::Exceptions. Authentication is now handled via Mojolicious's "under->to" functionality. The actual authentication & authorization checks are moved to Koha::REST::V1::Auth. Added a HTTP 503 response for when database update is required, instead of returning an authentication failure as before. To test: 1. prove t/db_dependent/api/v1/auth.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:55:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:55:30 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65106|0 |1 is obsolete| | --- Comment #108 from Tom?s Cohen Arazi --- Created attachment 66809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66809&action=edit Bug 18137: Add useful Koha::Exceptions Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:55:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:55:48 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65108|0 |1 is obsolete| | --- Comment #110 from Tom?s Cohen Arazi --- Created attachment 66811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66811&action=edit Bug 18137: Make /patrons Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. - fixing failing test due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/patrons.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:55:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:55:55 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65109|0 |1 is obsolete| | --- Comment #111 from Tom?s Cohen Arazi --- Created attachment 66812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66812&action=edit Bug 18137: Make /cities Mojolicious::Plugin::OpenAPI compatible Also: - adding some missing and new response definitions into Swagger spec. To test: 1. prove t/db_dependent/api/v1/cities.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:56:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:56:02 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66802|0 |1 is obsolete| | --- Comment #112 from Tom?s Cohen Arazi --- Created attachment 66813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66813&action=edit Bug 18137: Make /holds Mojolicious::Plugin::OpenAPI compatible Also - adding some missing and new response definitions into Swagger spec. - fixing failing tests due to Bug 17932's change of boolean values To test: 1. prove t/db_dependent/api/v1/holds.t Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:56:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:56:10 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66803|0 |1 is obsolete| | --- Comment #113 from Tom?s Cohen Arazi --- Created attachment 66814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66814&action=edit Bug 18137: Remove x-mojo-around-action Mojolicious::Plugin::OpenAPI does not support x-mojo-around action. This patch removes it from our specification document. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:56:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:56:18 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66804|0 |1 is obsolete| | --- Comment #114 from Tom?s Cohen Arazi --- Created attachment 66815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66815&action=edit Bug 18137: (follow-up) Fix handling DBIx::Class::Exception messages - DBIx::Class::Exception should use ->{msg} Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:56:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:56:26 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66805|0 |1 is obsolete| | --- Comment #115 from Tom?s Cohen Arazi --- Created attachment 66816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66816&action=edit Bug 18137: (QA-follow-up) Fix pod fail Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:56:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:56:34 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66806|0 |1 is obsolete| | --- Comment #116 from Tom?s Cohen Arazi --- Created attachment 66817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66817&action=edit Bug 18137: (follow-up) Sort definitions.json Before this file grows, we should sort it alphabetically. To test: 1. prove t/db_dependent/api/v1 Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:56:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:56:42 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66807|0 |1 is obsolete| | --- Comment #117 from Tom?s Cohen Arazi --- Created attachment 66818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66818&action=edit Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies Edit (tcohen): I've changed the version numbers to match those Mirko has already successfully packaged and are known to work for this patchset. Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 15:56:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 13:56:54 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66808|0 |1 is obsolete| | --- Comment #118 from Tom?s Cohen Arazi --- Created attachment 66819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66819&action=edit Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 16:03:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 14:03:56 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 --- Comment #119 from Tom?s Cohen Arazi --- Rebased against master, which changed Koha::REST::V1::Hold a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 16:28:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 14:28:54 +0000 Subject: [Koha-bugs] [Bug 19249] date picker broken in quick add brief form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:04:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:04:02 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66656|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 66820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66820&action=edit Bug 19196: Unit tests This patch adds unit tests for the new pagination Mojo plugin. Sponsored-by: ByWater Solutions Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:04:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:04:09 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66657|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 66821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66821&action=edit Bug 19196: Add Koha::REST::Plugin::Pagination This patch introduces a Mojolicious plugin to be used on the REST api. It adds a helper method: add_pagination_headers ====================== When used, it adds a _Link_ header to the reponse with the calculated values for pagination, and X-Total-Count containing the total results like this: my $params = $c->validation->output; my $patrons = Koha::Patrons->search; my $count = $patrons->count; $c->add_pagination_headers({ total => $count, params => $params )}; To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/Koha/REST/Plugin/Pagination.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater solutions Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:04:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:04:15 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66658|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 66822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66822&action=edit Bug 19196: Make plugin available to endpoints This patch just initializes the plugin on the main controller class so it is available for all endpoints to use. As it is not used, in order to test just restart plack and make sure the endpoints work (run the t/db_dependent/api/v1 tests). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:06:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:06:01 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 --- Comment #13 from Tom?s Cohen Arazi --- Patches reworked so the resulting pagination links preserve the query params :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:06:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:06:47 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:10:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:10:43 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra -f -v koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:10:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:10:47 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra -f -v koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 --- Comment #4 from Jonathan Druart --- Created attachment 66823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66823&action=edit Bug 18927: Use fully qualified subroutine names in C4::Items rebuild_zebra.pl fails in some conditions (perl version?) I do not recreate but it has been reported that reindex fails with: error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, line 751. To fix it we can use fully qualified subroutine names for: GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode Test plan: Confirm the rebuild_zebra script still works correctly after this patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:11:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:11:35 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-rebuild-zebra -f -v |koha-rebuild-zebra is |koha |failing with "error | |retrieving biblio" CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:18:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:18:28 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #14 from Katrin Fischer --- Can someone help out here and write the tests necessary please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:19:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:19:51 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #57 from Jonathan Druart --- Tests do not pass! t/db_dependent/Circulation/Chargelostitem.t .. Can't locate C4/Branch.pm in @INC (you may need to install the C4::Branch module) C4::Branch has been removed months ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:25:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:25:09 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #32 from Jonathan Druart --- + Add more POD to explain what the script actually does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:26:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:26:05 +0000 Subject: [Koha-bugs] [Bug 19077] When loading patrons matching on userid updates to matched patrons are rejected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #5 from Jonathan Druart --- Closing, reopen if it is still needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 17:38:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 15:38:59 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 19:15:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 17:15:17 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #15 from Jonathan Druart --- Created attachment 66824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66824&action=edit Bug 19116: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 19:15:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 17:15:48 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #16 from Jonathan Druart --- I do not recreate the issue with tests, someone else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 20:38:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 18:38:50 +0000 Subject: [Koha-bugs] [Bug 19250] New: Add pagination to /acquisitions/vendors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250 Bug ID: 19250 Summary: Add pagination to /acquisitions/vendors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com The vendors listing endpoint should provide a way to have pagination. Should be straightforward with bug 19196. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 20:38:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 18:38:57 +0000 Subject: [Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 20:39:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 18:39:05 +0000 Subject: [Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 [Bug 19196] Add pagination helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 20:39:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 18:39:05 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250 [Bug 19250] Add pagination to /acquisitions/vendors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 20:57:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 18:57:25 +0000 Subject: [Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi, can you share the version of your DBMS and the Koha version you tried to install, please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 21:02:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 19:02:44 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Component|Web services |REST api -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 21:02:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 19:02:55 +0000 Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: add routes to |Add routes to list |list libraries |libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 21:11:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 19:11:33 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #17 from Katrin Fischer --- If I am reading the test correctly, you miss returning in the library the item is 'sourced at' in order to create the transport status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 21:13:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 19:13:06 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |REST api |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 21:45:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 19:45:42 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #18 from Katrin Fischer --- The problem is that the item is not in transit, but I haven't figured out how to fix the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 22:29:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 20:29:28 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #19 from Katrin Fischer --- is( $hold->found, "T", 'Hold is in transit' ); before you return it again at the pickup library. No matter what I try, I only get 'undef'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 22:39:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 20:39:12 +0000 Subject: [Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 22:39:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 20:39:15 +0000 Subject: [Koha-bugs] [Bug 13766] Make biblioitems.ean longer and add index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 --- Comment #17 from Katrin Fischer --- Created attachment 66825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66825&action=edit Bug 13766 - Follow-up - use index_exists() Changes check for existing index to use index_exists. Also checks deletedbiblioitems for an existing ean index and drops it if one is found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 22:49:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 20:49:45 +0000 Subject: [Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title' s Checkout History display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 22:52:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 20:52:22 +0000 Subject: [Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title' s Checkout History display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994 --- Comment #2 from Mike --- Info where was checkin occured is very useful for us too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 23:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 21:07:20 +0000 Subject: [Koha-bugs] [Bug 19251] New: Show book drop information in the Checkout History Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19251 Bug ID: 19251 Summary: Show book drop information in the Checkout History Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, josef.moravec at gmail.com, kyle.m.hall at gmail.com, rbit at rbit.cz Depends on: 18994 All drop box check-ins will be marked and showed in history together with branch name. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994 [Bug 18994] Show the branch name where checkin occurred on a title's Checkout History display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 4 23:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 21:07:20 +0000 Subject: [Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title' s Checkout History display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19251 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19251 [Bug 19251] Show book drop information in the Checkout History -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 01:43:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Sep 2017 23:43:44 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #9 from Aleisha Amohia --- Created attachment 66826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66826&action=edit Bug 16486: [FOLLOW-UP] Putting time in date column In reply to Comment 6, I have moved the time into a column separate from the description. Unfortunately the timestamp has the date and the time, so I figured it was easier to just have them in the same column and replace the original date column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 04:48:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 02:48:37 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 04:48:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 02:48:41 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #10 from Aleisha Amohia --- Created attachment 66827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66827&action=edit Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places As suggested in Comment 7. The timestamp has also been added to printfeercpt.tt, printinvoice.tt, and opac-account.tt To test: 1) In Staff side, go to member account, go to Fines, go to Account tab 2) Click the Print button next to a payment 3) Confirm timestamp shows on print slip 4) Create a manual invoice 5) Go back to the Account tab 6) Click the Print button next to the invoice 7) Confirm timestamp shows on print slip 8) Log into OPAC 9) Go to your fines 10) Confirm timestamp shows Ready to test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 04:58:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 02:58:51 +0000 Subject: [Koha-bugs] [Bug 17214] Add item in LIST by Record number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 04:58:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 02:58:55 +0000 Subject: [Koha-bugs] [Bug 17214] Add item in LIST by Record number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 --- Comment #14 from Aleisha Amohia --- Created attachment 66828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66828&action=edit Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio Ready to test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 05:02:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 03:02:54 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 05:02:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 03:02:58 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64565|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia --- Created attachment 66829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66829&action=edit Bug 12365 - Notes for rules Lee Jamison rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. To test: Follow test plan in Comment 2 Signed-off-by: Mark Tompsett Signed-off-by: macon lauren KohaCon17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 05:05:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 03:05:01 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66829|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia --- Created attachment 66830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66830&action=edit Bug 12365 - Notes for rules Lee Jamison rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. To test: Follow test plan in Comment 2 Signed-off-by: Mark Tompsett Signed-off-by: macon lauren KohaCon17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 05:33:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 03:33:00 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 05:33:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 03:33:05 +0000 Subject: [Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #23 from Aleisha Amohia --- Created attachment 66831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66831&action=edit Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 07:13:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 05:13:21 +0000 Subject: [Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 --- Comment #2 from mksiva at yahoo.com --- sir, Thanks for your response. Versions of DBMS, Koha & Ubuntu are Mysql-5.7.2 KKoha - 17.05 Ubuntu-16.04 Thanks K.Sivasamy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 07:56:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 05:56:06 +0000 Subject: [Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer --- I think the reason for your problem is the version of MySQL, see here: Koha does not work well with MySQL 5.7 which is shipped with Ubuntu 16.04. use MariaDB instead. https://wiki.koha-community.org/wiki/Koha_on_Debian I'd recommend switching to MariaDB and redoing the import. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 08:20:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 06:20:47 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #25 from Katrin Fischer --- I seem to remember that I had tested it at some point and the system had allowed holds on the negative notforloan values. Wondering now if it something changed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 08:30:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 06:30:19 +0000 Subject: [Koha-bugs] [Bug 19178] Remove outdated sms/* scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66496|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 66832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66832&action=edit Bug 19178 - Remove outdated sms/* scripts and related files Those files appear unmaintained and unusable with current Koha and should be removed. It appears at some point there was work done on a feature to send SMS messages to a phone number using a form in the tools area. This has never been documented, files and git history make it look like work remained unfinished. sms/sms_listen_windows_start.pl - targetted for Windows, which is not supported by Koha 00-strict.t - reference to sms removed sms/sms_listen.pl - refers to a table sms_messages that doesn't exist - uses getmember() that doesn't exist sms/sms.pl - script calls routines that no longer exist in SMS.pm error_codes(), parse_phone(), write_sms() - template sms-home.tt is not accessible form anywhere in the templates sms-home.tt - see sms/sms.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 08:32:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 06:32:12 +0000 Subject: [Koha-bugs] [Bug 19178] Remove outdated sms/* scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 --- Comment #6 from Katrin Fischer --- (In reply to David Cook from comment #3) > I think t/00-testcritic.t might also need its 'sms' reference removed. Thx David, I've included the additional change in the new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 09:34:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 07:34:13 +0000 Subject: [Koha-bugs] [Bug 19178] Remove outdated sms/* scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 09:34:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 07:34:16 +0000 Subject: [Koha-bugs] [Bug 19178] Remove outdated sms/* scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66832|0 |1 is obsolete| | --- Comment #7 from Magnus Enger --- Created attachment 66833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66833&action=edit Bug 19178 - Remove outdated sms/* scripts and related files Those files appear unmaintained and unusable with current Koha and should be removed. It appears at some point there was work done on a feature to send SMS messages to a phone number using a form in the tools area. This has never been documented, files and git history make it look like work remained unfinished. sms/sms_listen_windows_start.pl - targetted for Windows, which is not supported by Koha 00-strict.t - reference to sms removed sms/sms_listen.pl - refers to a table sms_messages that doesn't exist - uses getmember() that doesn't exist sms/sms.pl - script calls routines that no longer exist in SMS.pm error_codes(), parse_phone(), write_sms() - template sms-home.tt is not accessible form anywhere in the templates sms-home.tt - see sms/sms.pl Signed-off-by: Magnus Enger Makes sense. 00-strict.t runs OK after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 09:36:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 07:36:55 +0000 Subject: [Koha-bugs] [Bug 18741] Web installer does not load default data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741 --- Comment #9 from Julian Maurice --- (In reply to Katrin Fischer from comment #7) > Dependency is not in 16.11.x - so this is probably not be needed there. > Also: doesn't apply. Since this comment, bug 18632 was pushed in 16.11.x and 16.05.x, so the fix is now needed in these versions too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 09:41:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 07:41:33 +0000 Subject: [Koha-bugs] [Bug 19227] 00-merge-conflict-markers.t launches too many tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19227 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 09:41:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 07:41:36 +0000 Subject: [Koha-bugs] [Bug 19227] 00-merge-conflict-markers.t launches too many tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19227 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66673|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 66834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66834&action=edit Bug 19227: Reduce the number of tests run by 00-merge-conflict-markers.t The number of tests on jenkins is sometimes confusing: https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/testReport/(root)/t_00_merge_conflict_markers_t/ shows that 00-merge-conflict-markers.t ran 10,751 tests, 124 less than the previous run. However 124 files have not been removed from the codebase! I suggest to count only 1 test for all files. Moreover files from blib and cover_db are counted, they should be excluded. Test plan: prove t/00-merge-conflict-markers.t must return green echo ">>>>>>>" >> mainpage.pl and run the test again It should now fail Signed-off-by: Magnus Enger Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 09:45:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 07:45:12 +0000 Subject: [Koha-bugs] [Bug 18741] Web installer does not load default data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741 --- Comment #10 from Julian Maurice --- Created attachment 66835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66835&action=edit [16.11.x] Bug 18741: Fix loading of SQL files in web installer Test plan: 1. Start a normal install using the web installer 2. When asked to select data to load, verify that 'message_transport_types' is checked, and check some optional data files 3. Continue the install to the end 4. Verify that message_transport_types is not empty, and that the optional data you checked is there Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 10:30:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 08:30:16 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Lyle Kozloff changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lyle at lyle.work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 10:43:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 08:43:03 +0000 Subject: [Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 --- Comment #4 from mksiva at yahoo.com --- Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 11:25:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 09:25:56 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #14 from Benjamin Rokseth --- Great work Tomas. please fix typo in your example ;) > $c->add_pagination_headers({ > total => $count, > params => $params )}; and add some sensible defaults (10/10?) to page and per_page so Pagination.pm doesnt die if none is given as params. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 11:38:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 09:38:24 +0000 Subject: [Koha-bugs] [Bug 10707] inventory not removing lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #4 from S?verine Queune --- I just apply the plan test in our local Koha (16.11.11). The "lost" status is correctly reset and the last seen date is fixed on the today date. It seems this bug can be closed. Do I need change it to "RESOLVED" or one of the QA team want to check first ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 11:49:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 09:49:33 +0000 Subject: [Koha-bugs] [Bug 19252] New: Upgrading message shows identical Version Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19252 Bug ID: 19252 Summary: Upgrading message shows identical Version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 66836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66836&action=edit Screenshot upgrading message with identical version in web installer While upgrading, the web installer shows a message similar like "We are upgrading from Koha 17.06.00.004 to 17.06.00.004" Expected: Different version numbers for "from" and for "to". It seems that dbversion and kohaversion are the same in installer/step3.tt (see screenshot). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:16:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:16:19 +0000 Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #19 from Benjamin Rokseth --- Created attachment 66837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66837&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:16:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:16:29 +0000 Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #20 from Benjamin Rokseth --- Created attachment 66838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66838&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:17:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:17:26 +0000 Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:17:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:17:35 +0000 Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:34:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:34:59 +0000 Subject: [Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 --- Comment #31 from Mason James --- (In reply to Katrin Fischer from comment #29) > Thx Fridolin for providing the patch! > > This patch has been pushed to 16.11.x and will be in 16.11.11. hi Cait i think 16.11.11 is missing this patch.. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63546 ..currently patron search seems broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:35:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:35:16 +0000 Subject: [Koha-bugs] [Bug 19035] Stored XSS in patron lists - lists.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19035 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:35:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:35:47 +0000 Subject: [Koha-bugs] [Bug 19114] Stored XSS in parcels.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19114 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 12:45:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 10:45:18 +0000 Subject: [Koha-bugs] [Bug 19165] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 13:37:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 11:37:12 +0000 Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66464|0 |1 is obsolete| | Attachment #66474|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 66839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66839&action=edit Bug 19173 - Make OPAC online payments pluggable While PayPal is fairly universal, there is a plethora of online payment system that are far more localized, servicing a single country ( e.g. Bug 18968 ) or even a single city! Instead of adding support for each and every one of these payment options directly into Koha, it makes more sense to add the ability to create online payment plugins. Test Plan: 1) Apply this patch 2) Download and install the Kitchen Sink plugin version 2.1.1 or later https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases 3) In the plugin options, enable the opac payments option 4) Create a patron with one or more fines 5) Log into the opac as that patron, note you now have the option to pay online via KitchenSink ImaginaryPay 6) Make an online payment 7) Note the payment was processed correctly Signed-off-by: Magnus Enger Awesome enhancement! I know we want to add at least one Norwegian payment service at some point. I followed the test plan and everything works as advertised. Turning off the "opac payments option" makes the option dissappear cleanly from the OPAC. I have *not* looked at the code or done any considerations about security. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 13:37:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 11:37:18 +0000 Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 --- Comment #8 from Kyle M Hall --- Created attachment 66840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66840&action=edit Bug 19173 [Followup] - Add opac payment and marc conversion plugins to the pulldown filter list Signed-off-by: Magnus Enger New categories are added to the pulldown and work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 13:38:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 11:38:52 +0000 Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66839|0 |1 is obsolete| | Attachment #66840|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 66841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66841&action=edit Bug 19173 - Make OPAC online payments pluggable While PayPal is fairly universal, there is a plethora of online payment system that are far more localized, servicing a single country ( e.g. Bug 18968 ) or even a single city! Instead of adding support for each and every one of these payment options directly into Koha, it makes more sense to add the ability to create online payment plugins. Test Plan: 1) Apply this patch 2) Download and install the Kitchen Sink plugin version 2.1.1 or later https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases 3) In the plugin options, enable the opac payments option 4) Create a patron with one or more fines 5) Log into the opac as that patron, note you now have the option to pay online via KitchenSink ImaginaryPay 6) Make an online payment 7) Note the payment was processed correctly Sponsored-by: Washoe County Library System Signed-off-by: Kyle M Hall Signed-off-by: Magnus Enger Awesome enhancement! I know we want to add at least one Norwegian payment service at some point. I followed the test plan and everything works as advertised. Turning off the "opac payments option" makes the option dissappear cleanly from the OPAC. I have *not* looked at the code or done any considerations about security. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 13:38:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 11:38:58 +0000 Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 --- Comment #10 from Kyle M Hall --- Created attachment 66842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66842&action=edit Bug 19173 [Followup] - Add opac payment and marc conversion plugins to the pulldown filter list Signed-off-by: Magnus Enger New categories are added to the pulldown and work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 13:39:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 11:39:09 +0000 Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 13:54:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 11:54:39 +0000 Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #7 is|1 |0 private| | Comment #8 is|1 |0 private| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:07:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:07:34 +0000 Subject: [Koha-bugs] [Bug 1356] Lose original search term when select "More options" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1356 Evro Ofranto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |EvroOfranto20 at Gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:10:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:10:55 +0000 Subject: [Koha-bugs] [Bug 19254] New: Bug ID Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19254 Bug ID: 19254 Summary: Bug ID Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: EvroOfranto20 at Gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 66844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66844&action=edit Akatsuki Was Here Herein record bugs concerning cases where Koha behaves in unexpected ways or fails depending on the web browser being used. Applies to both staff and OPAC bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:14:33 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56579|0 |1 is obsolete| | --- Comment #10 from Benjamin Rokseth --- Created attachment 66845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66845&action=edit Bug 16694 - Limit SIP2 auth by patron attribute The main use case of this bug is to use patron attributes to grant special privileges, e.g. to open a door to an unmanned library. This patch adds an extra check against patron attributes if login account in SIPconfig.xml has a key validate_patron_attribute set to some patron attribute. If a patron information request is sent (63), and patron has proper rights in the given attribute: (a value of 1/true or some authorised value mapping to 1) The user will be allowed access (in SIP: charge and/or renewal ok). Otherwise denied. Please note that this is specific to the SIP login account, so self checkout machines can be handled differently than e.g. a door card terminal. To test: 0) you need to debug using telnet or the koha provided sip_client 1) add validate_patron_attribute="testattribute" to some login account in SIPconfig.xml 2) add a patron attribute "testattribute" 3) edit some patron and set "testattribute" to "1" 4) do a sip login with the given login account from SIPconfig.xml 5) do a patron information request (63) on the patron 6) observe that no charge or renewal denied is given in the response (64 ) 7) try all or any of the following: - set patron attribute to anything but "1" - delete the patron attribute - map the patron attribute to an authorized list, e.g. (YES_NO) and set it to a value that doesn't map to "1", e.g. "No". 8) do a patron information request (63) again 9) observe that charge and renewal is now denied in the SIP response (64YY) 10) thank yourself if noone else does and grab a coffee Signed-off-by: Magnus Enger Took me a while to remember I was on a gitified setup and needed to do sudo cp C4/SIP/Sip/MsgType.pm /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm before I could test properly. Works as expected. I have a Swedish customer running a similar hack in production, so looking forward to getting this into Koha proper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:15:35 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #11 from Benjamin Rokseth --- rebased against master. Ignoring failing test 'Checkin V2' as it has no bearing on this bug and should be resolved in another bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:18:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:18:05 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #12 from Benjamin Rokseth --- Created attachment 66846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66846&action=edit Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:19:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:19:01 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66846|0 |1 is obsolete| | --- Comment #13 from Benjamin Rokseth --- Created attachment 66847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66847&action=edit Bug 18137: (QA followup) Make sure the session exists and is expired on expiration tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:19:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:19:41 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66847|0 |1 is obsolete| | --- Comment #14 from Benjamin Rokseth --- Created attachment 66848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66848&action=edit Bug 16694 - Limit SIP2 auth by patron attribute The main use case of this bug is to use patron attributes to grant special privileges, e.g. to open a door to an unmanned library. This patch adds an extra check against patron attributes if login account in SIPconfig.xml has a key validate_patron_attribute set to some patron attribute. If a patron information request is sent (63), and patron has proper rights in the given attribute: (a value of 1/true or some authorised value mapping to 1) The user will be allowed access (in SIP: charge and/or renewal ok). Otherwise denied. Please note that this is specific to the SIP login account, so self checkout machines can be handled differently than e.g. a door card terminal. To test: 0) you need to debug using telnet or the koha provided sip_client 1) add validate_patron_attribute="testattribute" to some login account in SIPconfig.xml 2) add a patron attribute "testattribute" 3) edit some patron and set "testattribute" to "1" 4) do a sip login with the given login account from SIPconfig.xml 5) do a patron information request (63) on the patron 6) observe that no charge or renewal denied is given in the response (64 ) 7) try all or any of the following: - set patron attribute to anything but "1" - delete the patron attribute - map the patron attribute to an authorized list, e.g. (YES_NO) and set it to a value that doesn't map to "1", e.g. "No". 8) do a patron information request (63) again 9) observe that charge and renewal is now denied in the SIP response (64YY) 10) thank yourself if noone else does and grab a coffee Signed-off-by: Magnus Enger Took me a while to remember I was on a gitified setup and needed to do sudo cp C4/SIP/Sip/MsgType.pm /usr/share/koha/lib/C4/SIP/Sip/MsgType.pm before I could test properly. Works as expected. I have a Swedish customer running a similar hack in production, so looking forward to getting this into Koha proper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:19:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:19:54 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66845|0 |1 is obsolete| | --- Comment #15 from Benjamin Rokseth --- Created attachment 66849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66849&action=edit Bug 16694 - Add tests to t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:22:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:22:56 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #16 from Marcel de Rooy --- (In reply to Benjamin Rokseth from comment #11) > rebased against master. > > Ignoring failing test 'Checkin V2' as it has no bearing on this bug and > should be resolved in another bug The test passes with me btw. Please copy your test results in a comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:24:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:24:13 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Benjamin Rokseth --- needs another signoff on added tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:27:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:27:52 +0000 Subject: [Koha-bugs] [Bug 19253] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Component|Koha |Architecture, internals, | |and plumbing Summary|We Are |SPAM Status|NEW |RESOLVED Product|Koha security |Koha Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:29:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:29:05 +0000 Subject: [Koha-bugs] [Bug 19254] Bug ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:29:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:29:31 +0000 Subject: [Koha-bugs] [Bug 19254] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Bug ID |SPAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:31:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:31:16 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #18 from Benjamin Rokseth --- (In reply to Marcel de Rooy from comment #16) > (In reply to Benjamin Rokseth from comment #11) > > rebased against master. > > > > Ignoring failing test 'Checkin V2' as it has no bearing on this bug and > > should be resolved in another bug > > The test passes with me btw. Please copy your test results in a comment. Good. May be I have corrupted my DB somehow from testing various tests. Seems there are problems on creating items resensitize(): no item found in object to resensitize at C4/SIP/ILS/Transaction/Checkin.pm line 127. # Failed test 'Check screen msg' # at ./t/db_dependent/SIP/Message.t line 448. # got: '' # expected: '1' new ILS::Item(Kckdb) : No item 'Kckdb'. at C4/SIP/ILS/Item.pm line 80. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:42:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:42:36 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #17) > AdjustRemark is a bit awkward, we could show the note only if the shelf is > shared, private and changes are allowed by anyone seeing this list. Hmm. Guess that 20 lines are a bit long to accomplish this, right? But apart from that, this sub just does what you say it should. And note it should not only show but it should also hide since it is dynamical and responds to change events on some other controls. I could compress it a bit, but essentially we need all the checks currently there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:42:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:42:19 +0000 Subject: [Koha-bugs] [Bug 19112] Stored XSS in basketheader.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19112 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:43:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:43:22 +0000 Subject: [Koha-bugs] [Bug 19110] XSS Stored in branches.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19110 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:43:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:43:41 +0000 Subject: [Koha-bugs] [Bug 19100] XSS Flaws in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19100 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:43:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:43:55 +0000 Subject: [Koha-bugs] [Bug 19105] XSS Stored in holidays.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19105 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:44:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:44:10 +0000 Subject: [Koha-bugs] [Bug 16069] XSS issue in basket.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16069 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #17 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:44:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:44:24 +0000 Subject: [Koha-bugs] [Bug 19079] XSS Flaws in Membership page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19079 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:44:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:44:37 +0000 Subject: [Koha-bugs] [Bug 19033] XSS Flaws in Currencies and exchange page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19033 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:44:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:44:52 +0000 Subject: [Koha-bugs] [Bug 19034] XSS Flaws in- Cities - Z39.50/ SRU servers administration - Patron categories pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19034 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:45:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:45:10 +0000 Subject: [Koha-bugs] [Bug 19050] XSS Flaws in Quick spine label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19050 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:45:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:45:23 +0000 Subject: [Koha-bugs] [Bug 19051] XSS Flaws in - Batch record deletion page - Batch item deletion page - Batch item modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19051 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:45:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:45:35 +0000 Subject: [Koha-bugs] [Bug 19052] XSS Flaws in - vendor search page - Invoice search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19052 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:45:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:45:34 +0000 Subject: [Koha-bugs] [Bug 19255] New: Correct explanation about list types on shelves.pl in staff Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Bug ID: 19255 Summary: Correct explanation about list types on shelves.pl in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl >From Jonathan on bug 18980: On the staff interface: """ Private list: Is managed by you and can be seen only by you. Public list: Can be seen by everybody, but managed only by you. """ Should not we update it? If a list is private but shared, the description is wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:45:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:45:46 +0000 Subject: [Koha-bugs] [Bug 19054] XSS Flaws in Report - Top Most-circulated items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19054 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:45:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:45:58 +0000 Subject: [Koha-bugs] [Bug 19078] XSS Flaws in System preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19078 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:46:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:46:13 +0000 Subject: [Koha-bugs] [Bug 18726] OPAC XSS - biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18726 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, is in 17.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:46:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:46:20 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19255 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > On the staff interface: > """ > Private list: Is managed by you and can be seen only by you. > Public list: Can be seen by everybody, but managed only by you. > """ > > Should not we update it? If a list is private but shared, the description is > wrong. Opened bug 19255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 [Bug 19255] Correct explanation about list types on shelves.pl in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 14:46:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 12:46:20 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list types on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 [Bug 18980] Add an explanation when Anyone permission has no actual effect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:13:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:13:31 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:13:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:13:34 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66823|0 |1 is obsolete| | --- Comment #5 from Lee Jamison --- Created attachment 66850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66850&action=edit Bug 18927: Use fully qualified subroutine names in C4::Items rebuild_zebra.pl fails in some conditions (perl version?) I do not recreate but it has been reported that reindex fails with: error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, line 751. To fix it we can use fully qualified subroutine names for: GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode Test plan: Confirm the rebuild_zebra script still works correctly after this patch Signed-off-by: Lee Jamison Script works correctly after patch is applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:28:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:28:34 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correct explanation about |Correct explanation about |list types on shelves.pl in |list categories on |staff |shelves.pl in staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:33:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:33:00 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 --- Comment #25 from Marc V?ron --- Created attachment 66851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66851&action=edit Bug 18472: Add system preferences to manage online help system This patch introduces two new system preferences in section 'Administration' - 'HelpSystem' to select / disable the help system to use. It is designed to allow future expansions (alternative / complementing help system), thats why it is a 'Multiple choice' with one choice - 'EnableEditingFilebasedHelp' is used to toggle on/off the 'Edit' field that appears at the bottom of the durrent help pages. To test: - In staff client, open help on some pages, including help on main page - They have a button 'Edit help'. On main page help, you see a text about 'Can I edit the online help?' - Apply patch, restart memcached and plack - Update database - In staff client, go to Administration > System preferences > Administration - Locate section 'Help system', do not yet schange settings - Verify that the help pages you visited look the same as before - Change syspref 'EnableEditingFilebasedHelp' to 'No' - Visit the help pages again, verify that 'Edit help' button no longer appears. - Set the system preference 'HelpSystem' to none (deselect 'File based (staff client) - Reload any page and verify that the 'Help' link in the page header does no longer display - In syspref 'HelpSystem', check 'File based (staff client)' - Reload any page, verify that the 'Help' link is displayed (Amended to correct wrong line in sysprefs.sql 201-04-29 mv) Signed-off-by: Josef Moravec (Minor change to make it apply on current master 2017-09-05 mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:35:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:35:05 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:41:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:41:33 +0000 Subject: [Koha-bugs] [Bug 19072] REST API: Toggle suspend for /api/v1/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #6 from Benjamin Rokseth --- The use of C4::Reserves::ToggleSuspend is a bit counter-intuitive here. If you send a PUT to /api/v1/holds/x with '{"suspend":false}' it would suspend hold if it was not already suspended. I would rather respect the body request and suspend according to that, or you would have unpredictable results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:42:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:42:33 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:47:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:47:10 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 --- Comment #22 from Marc V?ron --- Created attachment 66852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66852&action=edit Bug 18483 - Customised help: Enhance staff client with news based, easily editable help system Koha's staff client has a file based help system with an edit function for customising. However, the edited files have to be saved and restored with each release. Otherwise they are overwritten. As an enhancement or alternative, the existing news system is used to implement a complementing help system. Similar to the news, the text can be created for all branches or for individual branches. Help is context sensitive (based on the existing help system), and it can be created / edited directly from the help page (based on a user permission). Du to the need of this user permissen, a user permission for editing news is implemented as well. Display can be managed with a system preference (Bug 18472: Add system preference to manage online help system). Preferences default to legacy (fiele based) help. To test: - Apply patch on top of Bug 18472, restart memcached and plack - Update database (Alternative: fresh install) - Log in as superlibrarian (later we test the permisisons) - Verify that news behave as before - Verify that legacy help works as before - Locate system preferences 'EnableEditingFilebasedHelp' and 'Help system' - For our tests, set 'EnableEditingFilebasedHelp' to 'No' - In 'HelpSystem', uncheck 'File based' (none selected) - Refresh any page and verify that 'Help' Link in the main menu has vanished - Check both 'File based' and 'News based' - Verify that 'Help appears again in top menu - Click 'Help' for any page, verify that, above the 'classic' filebased help, you see a title 'Help for (library name) and two buttons 'Add help for this page' and 'Add help for all pages' - Close the help page - Go back to system preferences, select 'News based' only for 'HelpSystem' - Open Help again for any page - Verify that the text from file based help no longer displays, you should have a title and buttons only at the moment. - Click 'Add help for this page'. You are taken to the form you already know from editing 'News' - Click 'Cancel'. You should be taken back to the help page as before - Again click 'Add help for this page' and add an easyly identifiable title and some text, like you would do with news. - Leave the new field 'Help key' unchanged. - Submit. You should be taken back to the help you just created should appear - Close help page and open it again to verify that the text persists (for this page) - Go to an other page and verify that the help you added for the first page does not appear. - Add a help entry using the button 'Add help for all pages' - Go back to the first page you entered help for and verify, that it displays it's own help text and the text for all pages - Edit one of the texts, verify that it saves correctly - Add some more entries and verify that they appear as expected - Go to More > Tools (in an other tab) - Verify that the menu entry for News appears/disappears and changes text depending on the settings of system preference 'HelpSystem' - Open 'News' rsp. 'Help', verify that entries appear depending on the settings of syspref 'HelpSystem' - Verify that the filter for 'Display location' works - Verify that in the 'Location' column a hint about the page appears the entry was created for - Edit a staff help entry, verify that submit or close takes you back to the list - Bonus test: Edit a staff help entry, change the key to 'all', verify that the entry now appears for all pages. Change the key to 'help/admin/preferences' and verify that it appears now for the preferences page - Create a staff user with following permisisons only: catalogue (for login), edit_help and edit_news - Test visibility of news / help editing functionality depending on the edit_ permissions - Run QA tools Signed-off-by: Josef Moravec (Amended to resolve minor merge conflict. 2017-09-05 mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:47:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:47:35 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:49:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:49:05 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:49:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:49:07 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #1 from Marcel de Rooy --- Created attachment 66853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66853&action=edit Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:51:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:51:07 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:57:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:57:14 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 15:57:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 13:57:17 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64744|0 |1 is obsolete| | --- Comment #11 from Lee Jamison --- Created attachment 66854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66854&action=edit Bug 18071: Add authorities maintenance script With bug 9988 the manual merge option of merge_authorities was removed. (Note that it did not work any more too.) This patch reintroduces this functionality on the command line. This maintenance script now allows you to force renumbering field 001 for selected authid's, to delete authid's including the removal of references in biblio records, as well as merging several authid's into one reference record. Test plan: [1] Test the -renumber parameter. Field 001 and 005 should be updated. [2] Test the -delete parameter. Check if a linked biblio does no longer contain a reference to the deleted authority. [3] Test the -merge parameter. Create two PERSO_NAME records (say A,B) and attach biblios to them. Pick a CORPO_NAME record as reference record C. Now pass -merge -reference C -authid A,B Verify that A and B are gone, and the records link to C now. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 16:10:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 14:10:37 +0000 Subject: [Koha-bugs] [Bug 14976] Specify due date, calendar and useDaysMode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14976 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 16:17:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 14:17:09 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 16:27:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 14:27:25 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 16:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 14:41:14 +0000 Subject: [Koha-bugs] [Bug 14815] Different leader values per framework code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14815 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 16:48:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 14:48:08 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields , or based on the koha biblio level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 16:50:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 14:50:58 +0000 Subject: [Koha-bugs] [Bug 11594] store both item type and document type in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11594 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 16:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 14:52:17 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:01:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:01:42 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:02:46 +0000 Subject: [Koha-bugs] [Bug 7386] Label batches cannot be batch deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:15:35 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:16:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:16:18 +0000 Subject: [Koha-bugs] [Bug 11683] Add search by title or callnumber on courses reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11683 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:36:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:36:10 +0000 Subject: [Koha-bugs] [Bug 11979] Display correct not for loan status description on course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:43:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:43:47 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:48:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:48:15 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 17:50:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 15:50:35 +0000 Subject: [Koha-bugs] [Bug 13259] Set notforloan status when adding items to a course reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13259 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 18:06:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 16:06:29 +0000 Subject: [Koha-bugs] [Bug 19256] New: Koha::Acquisition::Order should use Koha::Object Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Bug ID: 19256 Summary: Koha::Acquisition::Order should use Koha::Object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 18:06:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 16:06:29 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19256 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 19:20:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 17:20:42 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 19:20:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 17:20:44 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66378|0 |1 is obsolete| | --- Comment #9 from Lee Jamison --- Created attachment 66855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66855&action=edit Bug 18999 - Added regression test Added regression test for GetBudgetSpent() and GetBudgetOrdered() into the t/db_dependent/Budgets.t Test plan: 1. Go into your koha-shell 2. set the PERL5LIB variable 3. Run t/db_dependent/Budgets.t All tests should pass Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison All tests pass as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:21:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:21:11 +0000 Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:21:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:21:14 +0000 Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54511|0 |1 is obsolete| | --- Comment #5 from Lee Jamison --- Created attachment 66856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66856&action=edit Bug 15173: Restore SubfieldsToAllowForRestrictedEditing Bug 7673 introduced SubfieldsToAllowForRestrictedEditing but bug 12176 broke it assuming that only selects were impacted by this feature. Test plan: Go back on bug 7673 and confirm that SubfieldsToAllowForRestrictedEditing is working as expected with this patch applied. Signed-off-by: Lee Jamison For clarification, the item fields that are entered in SubfieldsToAllowForRestrictedEditing should EXCLUDE the desired fields you want to disable. Test plan (updated to test the scenario in the bug Description): 1. Create a patron with only the following permissions: - catalogue (Required for staff login) - editcatalogue -> edit_catalogue - editcatalogue -> edit_items - editcatalogue -> edit_items_restricted 2. Navigate to Administration -> Global system preferences -> Cataloging -> Record Structure -> SubfieldsToAllowForRestrictedEditing 3. In the input field for SubfieldsToAllowForRestrictedEditing enter in all the 952 fields EXCEPT the ones desired to be disabled. In this case, we want to disallow editing of 952$2, 952$a, 952$b, 952$e, 952$h, and 952$o so we enter the following into the SubfieldsToAllowForRestrictedEditing (without quotes) "952$0 952$1 952$3 952$4 952$5 952$7 952$8 952$c 952$d 952$f 952$g 952$i 952$j 952$p 952$t 952$u 952$v 952$w 952$x 952$y 952$z" 4. Click Save all Cataloging preferences 5. Login to the staff client as the created restricted editing patron 6. Edit an item 7. Note that all fields except for the ones excluded from the syspref are editable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:34:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:34:06 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19207 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:34:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:34:06 +0000 Subject: [Koha-bugs] [Bug 19207] Don't export fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18201 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:34:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:34:33 +0000 Subject: [Koha-bugs] [Bug 19207] Don't export fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19207 --- Comment #1 from Katrin Fischer --- Please see also 19207 for a discussion about changes to the form! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:34:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:34:49 +0000 Subject: [Koha-bugs] [Bug 19207] Don't export fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19207 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Sorry, bug 18201! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:54:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:54:06 +0000 Subject: [Koha-bugs] [Bug 19206] How should we sort 19xx when order is pubdate? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- It's a hard one, I wonder how other systems might handle that. My initial feeling is that beginning (1900) seems better than end (1999) - but others might disagree. >From the documentatoin: https://www.loc.gov/marc/bibliographic/bd008a.html Determination of dates for 008/07-10 is made concurrently with the choice of code for 008/06. See the section above on 008/06 for examples and input conventions related to coded date information. The use of fill characters in 008/07-10, although possible, is discouraged since the data in Date 1 is used for retrieval and duplicate detection in many systems. When fill is used in 008/07-10, all four positions must contain the fill character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 22:55:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 20:55:30 +0000 Subject: [Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think there are also some cases for or/OR in the XSLT templates probably. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:15:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:15:08 +0000 Subject: [Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:15:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:15:11 +0000 Subject: [Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64957|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 66857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66857&action=edit Bug 18921: Resolve a few warnings in C4/XSLT.pm Resolves warnings like: Use of uninitialized value in hash element at C4/XSLT.pm line 262. Use of uninitialized value in numeric eq (==) at C4/XSLT.pm line 267. Use of uninitialized value $status in concatenation (.) or string at C4/XSLT.pm line 300. Note: Line numbers are not exactly the same anymore. Test plan: [1] Enable XSLT view in OPAC [2] Without this patch, you will probably have some of these warnings when doing some opac searches. [3] Apply this patch. Check the logs again. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:15:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:15:56 +0000 Subject: [Koha-bugs] [Bug 19257] New: Warn when reopening a basket Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 Bug ID: 19257 Summary: Warn when reopening a basket Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_basket_2epl line 229, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:17:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:17:35 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:17:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:17:39 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 --- Comment #1 from Aleisha Amohia --- Created attachment 66858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66858&action=edit Bug 19257: Prevent warn when reopening a basket To test: 1) Go to Acquisitions, find a vendor and a basket (create if you don't have either) 2) Close the basket 3) View the basket and reopen it 4) Notice the warn 5) Apply the patch and repeat steps 1-3 6) Notice the warn no longer shows and the basket is reopened as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:17:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:17:39 +0000 Subject: [Koha-bugs] [Bug 18437] Acquisitions fund edit repair In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer --- Thx for catching the translation issue Kyle. There is another here: $("#budget_users").prepend('
  • No users
    • '); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:18:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:18:30 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 5 23:22:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 21:22:06 +0000 Subject: [Koha-bugs] [Bug 10707] inventory not removing lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi S?verine, as we are not sure what fixed it (which bug) you can set it to 'RESOLVED WORKSFORME' :) QA will only look at bugs with patches. If you find a bug report that is no longer valid or somehow magically solved (it happens), it's ok to mark it as such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:05:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:05:30 +0000 Subject: [Koha-bugs] [Bug 19258] New: Warn when paying a fine or charge Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Bug ID: 19258 Summary: Warn when paying a fine or charge Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_paycollect_2epl line 72, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:09:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:09:57 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:10:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:10:00 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #1 from Aleisha Amohia --- Created attachment 66859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66859&action=edit Bug 19258: Prevent warn when paying a fine or charge To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select any fines and click Pay amount 3) Notice warn 4) Apply patch and repeat steps 1 & 2 5) Warn should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:11:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:11:13 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying a fine or charge from 'Pay amount' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Summary|Warn when paying a fine or |Warn when paying a fine or |charge |charge from 'Pay amount' | |button Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:13:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:13:37 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Warn when paying a fine or |Warn when paying or writing |charge from 'Pay amount' |off a fine or charge |button | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:14:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:14:02 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66859|Bug 19258: Prevent warn |Bug 19258: Prevent warn description|when paying a fine or |when paying a fine or |charge |charge from Pay Amount | |button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:36:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:36:31 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #2 from Aleisha Amohia --- Created attachment 66860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66860&action=edit Bug 19258: Prevent warns when writing off an individual fine The following warns are triggered when I click the Write Off button next to an individual fine or charge: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. (this shows many times) Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, click the Write off button next to the invoice you just created 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:40:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:40:23 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #3 from Aleisha Amohia --- Created attachment 66861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66861&action=edit Bug 19258: Preventing warns when paying a fine or charge from Pay selected button The following warns are triggered when I click the Pay selected button: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 267, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 273, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select the fine you just created and click Pay selected 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:44:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:44:41 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #4 from Aleisha Amohia --- Created attachment 66862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66862&action=edit Bug 19258: Prevent warn when reversing a payment The following warn is triggered when I click the Reverse button next to an individual payment on the Account tab: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side, create a manual invoice, pay it 2) Go to the Account tab, click Reverse next to the payment you just made 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 00:46:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Sep 2017 22:46:17 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #5 from Aleisha Amohia --- This is ready for testing and tests 4 different areas in the fines section of the member's page. Test each patch one after the other following each test plan. Will be quick testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 02:00:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 00:00:16 +0000 Subject: [Koha-bugs] [Bug 19259] New: Overdue rules do not save Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 Bug ID: 19259 Summary: Overdue rules do not save Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org I am unable to save any overdue rules. To reproduce: Go to Tools -> Overdue notice/status triggers Attempt to save some rules/make changes Click Save changes button Notice your rules were not saved. Check the overduerules table in mysql for confirmation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 02:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 00:00:24 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 05:58:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 03:58:50 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66858|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 66863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66863&action=edit Bug 19257: Prevent warn when reopening a basket To test: 1) Go to Acquisitions, find a vendor and a basket (create if you don't have either) 2) Close the basket 3) View the basket and reopen it 4) Notice the warn 5) Apply the patch and repeat steps 1-3 6) Notice the warn no longer shows and the basket is reopened as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 05:58:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 03:58:48 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 06:29:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 04:29:04 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #6 from M. Tompsett --- Created attachment 66864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66864&action=edit Bug 19258: Prevent warn when paying a fine or charge To test: 1) Go to a members detail page in staff client 2) Select the Fines tab in the left pane 3) Select the Create manual invoice tab below the button menu bar 4) Create a fine and click save (e.g. Type: Fine, Amount: 5.00) 5) Select the Pay fines tab below the button menu bar 6) Click Pay on the item 7) Blank the staff error log 8) click confirm -- staff error log has message 9) apply this first patch 10) repeat steps 3-8 -- staff error log is blank 11) run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 06:29:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 04:29:14 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66860|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 66865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66865&action=edit Bug 19258: Prevent warns when writing off an individual fine The following warns are triggered when I click the Write Off button next to an individual fine or charge: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. (this shows many times) Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, click the Write off button next to the invoice you just created 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 06:29:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 04:29:23 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66861|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 66866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66866&action=edit Bug 19258: Preventing warns when paying a fine or charge from Pay selected button The following warns are triggered when I click the Pay selected button: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 267, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 273, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select the fine you just created and click Pay selected 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 06:29:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 04:29:29 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66862|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 66867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66867&action=edit Bug 19258: Prevent warn when reversing a payment The following warn is triggered when I click the Reverse button next to an individual payment on the Account tab: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side, create a manual invoice, pay it 2) Go to the Account tab, click Reverse next to the payment you just made 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 06:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 04:30:43 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #66859|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 06:31:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 04:31:49 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 06:44:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 04:44:17 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- I was wondering if you could fix some other grammar while you are at it too. "Once the list is saved it will accessible" it will BE accessible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 07:29:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 05:29:05 +0000 Subject: [Koha-bugs] [Bug 19235] password visible in OPAC self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19235 --- Comment #3 from Apurba Jyoti Majumder --- The steps has been followed and tested OK Noe the password character are not visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 07:35:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 05:35:01 +0000 Subject: [Koha-bugs] [Bug 19252] Upgrading message shows identical version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19252 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrading message shows |Upgrading message shows |identical Version |identical version -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 07:54:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 05:54:32 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Confirmed. In my tests it saves columns Delay, Letter and Restrict. It does NOT save columns Email and Print (Phone and SMS not tested). While saving I get the following in plack-error.log: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`overduerules_transport_types`, CONSTRAINT `overduerules_fk` FOREIGN KEY (`overduerules_id`) REFERENCES `old_overduerules` (`overduerules_id`) ON DELETE CASCADE ON UPDATE CASCAD) [for Statement " INSERT INTO overduerules_transport_types( overduerules_id, letternumber, message_transport_type ) VALUES ( (SELECT overduerules_id FROM overduerules WHERE branchcode = ? AND categorycode = ?), ?, ? ) " with ParamValues: 0='', 1='K', 2=1, 3="email"] at /home/marc/koha/tools/overduerules.pl line 198. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 08:28:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 06:28:12 +0000 Subject: [Koha-bugs] [Bug 19073] Can't change library with patron batch modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 09:23:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 07:23:40 +0000 Subject: [Koha-bugs] [Bug 19260] New: Reservations / holds marked as problems being seen as expired ones and deleted wrongly. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Bug ID: 19260 Summary: Reservations / holds marked as problems being seen as expired ones and deleted wrongly. Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: r.delahunty at arts.ac.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We have the ReservesMaxPickupDelay set to 7 and the ExpireReservesMaxPickupDelay system parameter set to Don?t Allow. Our workflow is that staff use the report generated by waitingreserves.pl to identify titles to retrieve from the Reservations / holds awaiting pickup shelf, and delete the reservation and return the items to the shelf, or have that action trigger reservation satisfaction for the next person in the queue. Since our upgrade for 16.05 to 17.05 we are finding that when we run the cancel_expired_holds.pl job at 01:00 daily, reservations marked as problem ones are being deleted in addition to expired ones (expiration date set by user has been reached, or the default 100 days has been reached). Koha 17.05 appears to be disregarding the ExpireReservesMaxPickupDelay system parameter. (http://translate.koha-community.org/manual/master/en/html/17_cron_jobs.html#expiredholdscron). We have suspended this cron job in the meantime, and will write a query to identify expired ones we need to delete. Ideally we want problem reservations NOT to be seen as expired ones. Ray Delahunty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 12:19:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 10:19:17 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 12:19:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 10:19:11 +0000 Subject: [Koha-bugs] [Bug 19261] New: never hide biblionumber field in view policy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Bug ID: 19261 Summary: never hide biblionumber field in view policy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Since Bug 15870 fields defined as hidden in frameworks are not present in MARC. Some libraries may have/want field containing biblionumber hidden. This generates an error in OPAC detail view. I propose that field linked to biblionumber is not removed from MARC even if hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 12:46:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 10:46:13 +0000 Subject: [Koha-bugs] [Bug 9573] ability to download items lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:02:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:02:41 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #3 from Marcel de Rooy --- Created attachment 66868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66868&action=edit Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:03:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:03:33 +0000 Subject: [Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 --- Comment #5 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #4) > Signed-off-by: Katrin Fischer Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:06:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:06:33 +0000 Subject: [Koha-bugs] [Bug 19206] How should we sort 19xx when order is pubdate? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19206 --- Comment #2 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #1) > https://www.loc.gov/marc/bibliographic/bd008a.html >From the same page: 008/06 s 008/07-10 198u 008/11-14 #### 260 ##$aNew York :$bHaworth,$c[198-] 008/06 s 008/07-10 19uu 008/11-14 #### The character 'u' should normally be used for unknown years. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:21:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:21:31 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:21:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:21:34 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66850|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 66869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66869&action=edit Bug 18927: Use fully qualified subroutine names in C4::Items rebuild_zebra.pl fails in some conditions (perl version?) I do not recreate but it has been reported that reindex fails with: error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, line 751. To fix it we can use fully qualified subroutine names for: GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode Test plan: Confirm the rebuild_zebra script still works correctly after this patch Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:22:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:22:53 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #7 from Marcel de Rooy --- Workaround. Looks good to me. But we still do not know what disturbs perl somewhere in those C4 modules.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:48:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:48:44 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:48:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:48:46 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 --- Comment #1 from Fridolin SOMERS --- Created attachment 66870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66870&action=edit Bug 19261 - never hide biblionumber field in view policy Since Bug 15870 fields defined as hidden in frameworks are not present in MARC. Some libraries may have/want field containing biblionumber hidden. This generates an error in OPAC detail view. I propose that field linked to biblionumber is not removed from MARC even if hidden. Test plan : - Use XSLT for OPAC and intranet - Create a biblio record using default framework - Go to delail page in OPAC and intranet - Edit in default framework - In (sub)field linked to biblionumber, go to Advanced constraints - Uncheck OPAC and intranet in visibility and save => Check delail page in OPAC and intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:49:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:49:32 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 [Bug 15870] Add Filter for MARC to respect visibility settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 13:49:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 11:49:32 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 [Bug 19261] never hide biblionumber field in view policy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 14:06:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 12:06:15 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy --- - $patron_card->draw_guide_box($pdf) if $print_layout_xml->{'guide_box'}; - $patron_card->draw_barcode($pdf) if $print_layout_xml->{'barcode'}; + $patron_card->draw_guide_box($pdf) if $layout_xml->{'guide_box'}; + $patron_card->draw_guide_grid($pdf) if $layout_xml->{'guide_grid'}; + $patron_card->draw_barcode($pdf) if $layout_xml->{'barcode'}; Marc, Please explain this change. Formerly, as I understand, it flipped between layout_xml and layout_back_xml. Now you always set it to layout_xml. Do you change behavior for draw_guide_box and draw_barcode ? Status change to reflect need for feedback only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 14:18:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 12:18:23 +0000 Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 14:23:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 12:23:02 +0000 Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #34 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04 Bug 18996 [QA Followup] - Fix some minor whitespace issues : This patch did not apply but it was trivial to write it manually since its only spaces/tabs changes. This bud depends on Bug 17680 which is not in 17.05.x but I had no conflicts and Koha::Checkouts exists in 17.05.x. UT t/db_dependent/SIP/Message.t runs well. I encourage you to validate and contact me if there is a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:03:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:03:00 +0000 Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 --- Comment #35 from Marcel de Rooy --- (In reply to Fridolin SOMERS from comment #34) > This bud depends on Bug 17680 which is not in 17.05.x but I had no conflicts > and Koha::Checkouts exists in 17.05.x. Thats fine. You dont need 17680 in 17.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:08:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:08:22 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #12 from Marcel de Rooy --- Forgot to mention that qa tools reports a fail on pod somewhere too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:13:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:13:36 +0000 Subject: [Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #46 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04 Thanks for your job, a real never ending bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:18:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:18:21 +0000 Subject: [Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #22 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:22:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:22:43 +0000 Subject: [Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #17 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:23:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:23:13 +0000 Subject: [Koha-bugs] [Bug 19053] Auto renewal flag is not kept if a confirmation is needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:24:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:24:54 +0000 Subject: [Koha-bugs] [Bug 19053] Auto renewal flag is not kept if a confirmation is needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:25:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:25:42 +0000 Subject: [Koha-bugs] [Bug 15650] Credit Card Payment development other than Paypal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15650 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk --- Comment #1 from Emma Perks --- WorldPay may be a viable option for our NHS Trusts who do not support PayPal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:29:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:29:44 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #13 from Marc V?ron --- (In reply to Marcel de Rooy from comment #11) > - $patron_card->draw_guide_box($pdf) if > $print_layout_xml->{'guide_box'}; > - $patron_card->draw_barcode($pdf) if $print_layout_xml->{'barcode'}; > + $patron_card->draw_guide_box($pdf) if $layout_xml->{'guide_box'}; > + $patron_card->draw_guide_grid($pdf) if $layout_xml->{'guide_grid'}; > + $patron_card->draw_barcode($pdf) if $layout_xml->{'barcode'}; > > Marc, > Please explain this change. > Formerly, as I understand, it flipped between layout_xml and > layout_back_xml. Now you always set it to layout_xml. Do you change behavior > for draw_guide_box and draw_barcode ? > > Status change to reflect need for feedback only. Marcel, Thanks for QAing and pointing this out. Yes, it should be $print_layout_xml, not $layout_xml. Follow-up patch will follow. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:31:08 +0000 Subject: [Koha-bugs] [Bug 19049] Fix regression on stage-marc-import with to_marc plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #29 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:33:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:33:04 +0000 Subject: [Koha-bugs] [Bug 18919] "Transaction Branch" select field broken in Cash register statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18919 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:34:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:34:05 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #14 from Marc V?ron --- (In reply to Marcel de Rooy from comment #12) > Forgot to mention that qa tools reports a fail on pod somewhere too I can not reproduce with patch applied: Processing files before patches |========================>| 4 / 4 (100.00%) Processing files after patches |========================>| 4 / 4 (100.00%) OK C4/Patroncards/Patroncard.pm OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK patroncards/create-pdf.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK patroncards/edit-layout.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:39:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:39:12 +0000 Subject: [Koha-bugs] [Bug 18919] "Transaction Branch" select field broken in Cash register statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18919 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:41:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:41:36 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|veron at veron.ch |m.de.rooy at rijksmuseum.nl --- Comment #15 from Marcel de Rooy --- (In reply to Marc V?ron from comment #14) > (In reply to Marcel de Rooy from comment #12) > > Forgot to mention that qa tools reports a fail on pod somewhere too > > I can not reproduce with patch applied: Thx for checking. If you submit your follow-up, I will check again.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:42:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:42:43 +0000 Subject: [Koha-bugs] [Bug 19262] New: pod_spell.t does not work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Bug ID: 19262 Summary: pod_spell.t does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors: # Failed test 'POD spelling for ./acqui/invoice.pl' # at xt/author/pod_spell.t line 21. # Errors: # pl # Failed test 'POD spelling for ./acqui/neworderempty.pl' # at xt/author/pod_spell.t line 21. # Errors: # CGI # MARCfindbreeding # basketno # biblio # booksellerid # breedingid # neworderempty # ordernumber # pl # suggestionid # Failed test 'POD spelling for ./acqui/addorder.pl' # at xt/author/pod_spell.t line 21. # Errors: # CGI # ISBN # addorder # biblio # cgi # copyrightdate # neworderbiblio # neworderempty # newordersuggestion # pl And much more... Let's remove this file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:43:14 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #16 from Marcel de Rooy --- Should be the pod for new sub draw_guide_grid btw.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:43:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:43:49 +0000 Subject: [Koha-bugs] [Bug 19262] pod_spell.t does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:43:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:43:54 +0000 Subject: [Koha-bugs] [Bug 19262] pod_spell.t does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 --- Comment #1 from Jonathan Druart --- Created attachment 66871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66871&action=edit Bug 19262: Remove xt/author/pod_spell.t If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors. Let's remove this file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:44:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:44:24 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #17 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #16) > Should be the pod for new sub draw_guide_grid btw.. I understand that it will be hard to provide unit tests for this sub btw, as I should officially ask you for too. Maybe some advanced mocking session? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:45:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:45:26 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:45:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:45:31 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 --- Comment #1 from Jonathan Druart --- Created attachment 66872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66872&action=edit Bug 19256: Make Koha::Acq::Order using Koha::Object At the moment we have 2 different modules for acquisition orders: Koha::Tmp::Order[s] and Koha::Acquisition::Order The later has been added before the creation of Koha::Object. Koha::Tmp::Order[s] has been created to make the TT syntax for notices works with acquisition order data. This patch removes the temporary packages Koha::Tmp::Order[s] and adapt the code of Koha::Acquisition::Order[s] to be based on Koha::Object[s]. It also overloads Koha::Object->new to add the trick that was done in Koha::Acquisition::Order->insert. This is needed because acqui/addorder.pl is called from several places and CGI->Vars is used to retrieved order's attributes (and so much more). To avoid regression, the easiest (but not cleanest) way to do is to filter on aqorders column's names. This is *not* a pattern to follow! Test plan: Create basket and add orders from different ways, then continue a whole acquisition process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 15:50:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 13:50:26 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #18 from Marc V?ron --- (In reply to Marcel de Rooy from comment #17) > (In reply to Marcel de Rooy from comment #16) > > Should be the pod for new sub draw_guide_grid btw.. > > I understand that it will be hard to provide unit tests for this sub btw, as > I should officially ask you for too. Maybe some advanced mocking session? Sorry, that is out of my scope. If you insist I will have to abandon this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:01:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:01:56 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #19 from Marc V?ron --- Created attachment 66873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66873&action=edit Bug 18541: (QA follow-up) for comments #11 and #13 This patch changes variable names as mentioned in comments #11 and #13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:13:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:13:55 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #20 from Marc V?ron --- (In reply to Marcel de Rooy from comment #16) > Should be the pod for new sub draw_guide_grid btw.. There aren't any PODs in Patroncards.pm, I think that is for historical reasons. Does it make sense to add a pod just for one sub, or is it better to create a new bug "Add PODs to Patroncards.pm"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:16:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:16:15 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:16:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:16:18 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66872|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 66874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66874&action=edit Bug 19256: Make Koha::Acq::Order using Koha::Object At the moment we have 2 different modules for acquisition orders: Koha::Tmp::Order[s] and Koha::Acquisition::Order The later has been added before the creation of Koha::Object. Koha::Tmp::Order[s] has been created to make the TT syntax for notices works with acquisition order data. This patch removes the temporary packages Koha::Tmp::Order[s] and adapt the code of Koha::Acquisition::Order[s] to be based on Koha::Object[s]. It also overloads Koha::Object->new to add the trick that was done in Koha::Acquisition::Order->insert. This is needed because acqui/addorder.pl is called from several places and CGI->Vars is used to retrieved order's attributes (and so much more). To avoid regression, the easiest (but not cleanest) way to do is to filter on aqorders column's names. This is *not* a pattern to follow! Test plan: Create basket and add orders from different ways, then continue a whole acquisition process Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:16:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:16:24 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 --- Comment #3 from Kyle M Hall --- Created attachment 66875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66875&action=edit Bug 19256 - Remove warn from unit test Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:17:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:17:18 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:17:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:17:21 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63280|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 66876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66876&action=edit Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. To test: - Apply on top of patch 18465 - Go to Home > Tools > Patron card creator - Edit or create a layout - Turn on new choice 'Guide grid' in section 'General settings' - Leave 'Units' unchanged - Crate a PDF using 'Card batches' - Notice that card is printed with a layout grid that reflects selected unit with each 5th and 10th line in different color, unit description displayed bottom left, card dimensions displayed top right in small print inside the layout grid - Print PDF. Set printer settings in Adobe Reader or other PDF printing software to 'Actual size' to prevent scaling to printer's printable region - Mesure out printed PDF and verify that grid corresponds to selecte unit. - Go back to layout definition and choose an other unit, repeat steps to verify that grid respects selected unit. - Go back to layout definition, turn grid off, create PDF, verify that grid does not display in PDF Note for testers / QAers: Position of card elements (text, image...) do not respect the unit, this will be fixed in Bug 18550 Followed test plan and it worked as intended Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:17:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:17:25 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66873|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 66877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66877&action=edit Bug 18541: (QA follow-up) for comments #11 and #13 This patch changes variable names as mentioned in comments #11 and #13 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:17:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:17:29 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #23 from Marcel de Rooy --- Created attachment 66878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66878&action=edit Bug 18541: [QA Follow-up] Add POD to Patroncard.pm Just adding the POD framework to make qa tools happy. The authors are encouraged to complete this information. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:18:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:18:23 +0000 Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10904 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:18:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:18:21 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #24 from Marcel de Rooy --- (In reply to Marc V?ron from comment #20) > (In reply to Marcel de Rooy from comment #16) > > Should be the pod for new sub draw_guide_grid btw.. > > There aren't any PODs in Patroncards.pm, I think that is for historical > reasons. > > Does it make sense to add a pod just for one sub, or is it better to create > a new bug "Add PODs to Patroncards.pm"? I added a follow-up. Please add another follow-up to complete the pod for the new sub. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:18:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:18:23 +0000 Subject: [Koha-bugs] [Bug 10904] Limit patron modification request management by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12346 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:19:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:19:48 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #25 from Marcel de Rooy --- (In reply to Marc V?ron from comment #18) > Sorry, that is out of my scope. If you insist I will have to abandon this > bug. I will not insist. I recommend to push it, but the RM has final word. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:21:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:21:10 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #26 from Marcel de Rooy --- (In reply to Marc V?ron from comment #14) > I can not reproduce with patch applied: You probably are not using the latest version of qa tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:25:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:25:09 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:25:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:25:12 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66662|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 66879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66879&action=edit Bug 19215: Fixing typo in URL for patron clubs To test: 1) Go to Tools -> Clubs 2) Create a new club template if you do not already have one 3) Edit the template 4) Notice the URL is incorrect and the page is not found 5) Apply patch and go back to Clubs 6) Click edit button 7) Link should work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:27:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:27:00 +0000 Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:27:04 +0000 Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28621|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 66880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66880&action=edit Bgu 12346: Display the correct number of pending patron modifications on the patron module home page Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 0) Set IndependentBranchesPatronModifications = Yes 1) Create a number of modification request for BranchA 2) Log into the staff intranet with a patron without superlibrarian permissions and set your branch to BranchB 3) Note the modifications alert to does not display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays QA notes: What was the point of the branch variable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:27:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:27:28 +0000 Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Still valid, I have updated the patch and test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:27:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:27:37 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:27:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:27:40 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66879|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 66881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66881&action=edit Bug 19215: Fixing typo in URL for patron clubs To test: 1) Go to Tools -> Clubs 2) Create a new club template if you do not already have one 3) Edit the template 4) Notice the URL is incorrect and the page is not found 5) Apply patch and go back to Clubs 6) Click edit button 7) Link should work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:27:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:27:50 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:38:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:38:34 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64434|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 66882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66882&action=edit Bug 18823: Rancor - add support for editing/searching records from import batches Add the ability to edit records in import batches To test: 1 - Open the advanced cataloging editor 2 - Note you have options for save targets 3 - Save record in various formats and to a 'batch' 4 - Manage the batch and note your new record is included -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:38:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:38:37 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #3 from Nick Clemens --- Created attachment 66883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66883&action=edit Bug 18823: Rancor - Improvements to import batch searching Refactoring and improving feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:38:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:38:39 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #4 from Nick Clemens --- Created attachment 66884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66884&action=edit Bug 18823: Rancor - Allow searching of batches to be enabled/disabled To test: 1 - Open advanced cataloging editor (rancor) 2 - Under settings select 'import batches' 3 - Select some branches for search and some as save targets 4 - Verify the options work as expected (Note: empty batches cannot be searched) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:38:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:38:41 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #5 from Nick Clemens --- Created attachment 66885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66885&action=edit Bug 18823: Rancor - Save overriding warnings Allow saving of record even if invalid To test: Open/create a record with missing mandatory fields Click save Record is not saved and errors are listed Choose the dropdown under the save button and select 'Save overriding warnings' Note record is saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:42:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:42:49 +0000 Subject: [Koha-bugs] [Bug 19263] New: Advanced Editor - Rancor - Add auto control number (001) widget Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Bug ID: 19263 Summary: Advanced Editor - Rancor - Add auto control number (001) widget Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:42:57 +0000 Subject: [Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:43:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:43:09 +0000 Subject: [Koha-bugs] [Bug 12248] Error when using course reserves with item-level_itypes set to biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12248 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- This has been fixed by bug 11866 - { 'bSortable': false, 'aTargets': [ 9, 10, 11 ] } + { 'bSortable': false, 'aTargets': [ 'NoSort' ] } *** This bug has been marked as a duplicate of bug 11866 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:43:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:43:09 +0000 Subject: [Koha-bugs] [Bug 11866] Staff side course reserves too restrictive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11866 --- Comment #12 from Jonathan Druart --- *** Bug 12248 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:49:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:49:51 +0000 Subject: [Koha-bugs] [Bug 13702] Subroutine to check if a Biblio exists or is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #3 from Jonathan Druart --- This has no sense, you do not provide code that use these subroutines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:53:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:53:29 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18298 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 16:53:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 14:53:29 +0000 Subject: [Koha-bugs] [Bug 18298] Enforce password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:27:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:27:25 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Depends on| |18927 --- Comment #78 from Jonathan Druart --- (In reply to Jonathan Druart from comment #75) > Undefined subroutine &C4::Items::TransformKohaToMarc called at > /home/vagrant/kohaclone/C4/Items.pm line 1491. > > when I hit /cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=42 Bug 18927 fixes this issue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:27:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:27:25 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:38:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:38:18 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #21 from Alex Arnaud --- Created attachment 66886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66886&action=edit Bug 11580 - Fix expiry calculation and rewrite tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:42:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:42:30 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #22 from Alex Arnaud --- Here is a fix about Jonathan's comment. I don't know which status to choose for this BZ since it has been pushed to master... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:52:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:52:43 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #27 from Marc V?ron --- Created attachment 66887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66887&action=edit Bug 18541: (QA follow-up) for comment #24 (POD) Add description to POD for draw_guide_grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:53:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:53:51 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #23 from Jonathan Druart --- Created attachment 66888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66888&action=edit Bug 11580: Add one more test and clear the cache Make sure we are not just returning J-1 and clear the cache before and after the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:57:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:57:37 +0000 Subject: [Koha-bugs] [Bug 19264] New: Patron card creator: Add descriptions to PODs in Patroncard.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264 Bug ID: 19264 Summary: Patron card creator: Add descriptions to PODs in Patroncard.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org PODs in Patroncard.pm need descriptions. See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541#c23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:57:51 +0000 Subject: [Koha-bugs] [Bug 19264] Patron card creator: Add descriptions to PODs in Patroncard.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 [Bug 18541] Patron card creator: Add a grid to support layout design -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:57:51 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264 [Bug 19264] Patron card creator: Add descriptions to PODs in Patroncard.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 17:59:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 15:59:08 +0000 Subject: [Koha-bugs] [Bug 11580] If returnBeforeExpiry is on, holidays are not taken into account to calculate the due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|returnBeforeExpiry and |If returnBeforeExpiry is |closed day |on, holidays are not taken | |into account to calculate | |the due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:00:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:00:17 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 --- Comment #28 from Marc V?ron --- (In reply to Marcel de Rooy from comment #23) > Created attachment 66878 [details] [review] > Bug 18541: [QA Follow-up] Add POD to Patroncard.pm > > Just adding the POD framework to make qa tools happy. The authors > are encouraged to complete this information. > > Signed-off-by: Marcel de Rooy I filed Bug 19264 for completing all PODs in Patroncard.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:00:55 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18869 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Caused by bug 18869. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 [Bug 18869] Patron clubs and templates tables look strange when empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:00:55 +0000 Subject: [Koha-bugs] [Bug 18869] Patron clubs and templates tables look strange when empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 [Bug 19215] Typo in URL when editing a patron club template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:02:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:02:26 +0000 Subject: [Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:10:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:10:21 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66853|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 66889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66889&action=edit Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:10:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:10:27 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66868|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 66890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66890&action=edit Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:12:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:12:49 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from M. Tompsett --- Thanks for the followup addressing comment #2, Marcel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:15:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:15:54 +0000 Subject: [Koha-bugs] [Bug 17834] Change library news text for single-branch libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 --- Comment #9 from Jonathan Druart --- Created attachment 66891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66891&action=edit Bug 17834: Make translation easier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:26:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:26:23 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #24 from Jonathan Druart --- What are we doing here? If it is just replacing syspref fetch with Koha.Preference, the following is wrong: - [% IF ( display_patron_image ) %] + [% IF ( Koha.Preference('ShowPatronImageInWebBasedSelfCheck') ) %] display_patron_image is set when $borrower is set AND the pref is set. We had too many regressions in this area, I will not take any risks. If we are doing something else, it is not written in the commit messages. Please clarify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:32:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:32:01 +0000 Subject: [Koha-bugs] [Bug 17834] Change library news text for single-branch libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:32:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:32:21 +0000 Subject: [Koha-bugs] [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:32:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:32:24 +0000 Subject: [Koha-bugs] [Bug 11580] If returnBeforeExpiry is on, holidays are not taken into account to calculate the due date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #24 from Jonathan Druart --- (In reply to Alex Arnaud from comment #21) > Created attachment 66886 [details] [review] > Bug 11580 - Fix expiry calculation and rewrite tests (In reply to Jonathan Druart from comment #23) > Created attachment 66888 [details] [review] > Bug 11580: Add one more test and clear the cache > > Make sure we are not just returning J-1 and clear the cache before and > after the tests. These last 2 patches have been pushed to master, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:32:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:32:39 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:43:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:43:05 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:43:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:43:10 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45527|0 |1 is obsolete| | Attachment #45528|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 66892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66892&action=edit Bug 15339: TestBuilder warnings (code) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch holds the code changes. Examples of the kind of errors that it catches are in the tests (separate patch). Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:43:14 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #5 from Jonathan Druart --- Created attachment 66893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66893&action=edit Bug 15339: TestBuilder warnings (tests) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch contains the tests that doubles as a demonstration of the kind of error the patch is intended to prevent. Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:43:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:43:18 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #6 from Jonathan Druart --- Created attachment 66894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66894&action=edit Bug 15339: Improve parameter validation Only value and source are allowed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:43:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:43:49 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Patches have been rebased and adapt to the new code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:53:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:53:12 +0000 Subject: [Koha-bugs] [Bug 9964] Add plugins management link to the Administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #5 from Jonathan Druart --- (In reply to Julian Maurice from comment #4) > I believe those changes already have been pushed as part of bug 12412. > Can we close this one ? Confirmed (In reply to Jonathan Druart from comment #3) > The link is displayed even if C4::Context->config("enable_plugins") is false. This is certainly still true *** This bug has been marked as a duplicate of bug 12412 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 18:53:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 16:53:12 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #18 from Jonathan Druart --- *** Bug 9964 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:09:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:09:32 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- It works for me on master with a fresh install. old_overduerules sounds related to 3.23.00.007 What returns "show create table overduerules_transport_types"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:11:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:11:18 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:11:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:11:20 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66661|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 66895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66895&action=edit Bug 19214: Prevent error for patron clubs To test: 1) Create a club template and a club. 2) Add a user to the club 3) Log in to the OPAC as that user 4) Go to 'your summary' and click the Clubs tab 5) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 62. 6) Go to the staff side and go to the member page of that user 7) Go to 'details' and click the Clubs tab 8) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 71. 9) Apply patch 1) Repeat steps 4-7, confirming the errors do not show and clubs info loads correctly Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:21:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:21:08 +0000 Subject: [Koha-bugs] [Bug 19262] pod_spell.t does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:21:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:21:12 +0000 Subject: [Koha-bugs] [Bug 19262] pod_spell.t does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66871|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 66896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66896&action=edit Bug 19262: Remove xt/author/pod_spell.t If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors. Let's remove this file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:43:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:43:23 +0000 Subject: [Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #1 from Nick Clemens --- Created attachment 66897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66897&action=edit Bug 19263: Rancor - Add auto-001 widget WIP code - tied to authorised values for 001 field to set numebrs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:44:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:44:46 +0000 Subject: [Koha-bugs] [Bug 19265] New: Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 Bug ID: 19265 Summary: Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:57:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:57:55 +0000 Subject: [Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 --- Comment #2 from Nick Clemens --- Created attachment 66899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66899&action=edit Bug 19265: Rancor - import records into existing batch To test: 1 - Manage some staged records 2 - Note that there is now an 'Import additional records' button 3 - Click it 4 - You sould be able to import as usual, but note the target batch is specified 5 - Complete the import 6 - Verify all previous functionality works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:57:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:57:52 +0000 Subject: [Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 --- Comment #1 from Nick Clemens --- Created attachment 66898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66898&action=edit Bug 19265: Rancor - Add export of selected records, edit button to manage imports To test: 1 - Open a batch of staged records 2 - Note the new toolbar 3 - Select some records and export 4 - Verify previous functionality works as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:57:57 +0000 Subject: [Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 --- Comment #3 from Nick Clemens --- Created attachment 66900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66900&action=edit Bug 19265: Rancor - Fix sorting issue on manage batch page Adjust for extra column To test: 1 - Manage a stage batch 2 - Note records are correctly sorted by id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:58:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:58:12 +0000 Subject: [Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 19:58:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 17:58:12 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:00:04 +0000 Subject: [Koha-bugs] [Bug 19266] New: Add ability to match on 001 or 005 during import of records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Bug ID: 19266 Summary: Add ability to match on 001 or 005 during import of records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:00:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:00:22 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to match on 001 or 005 during import of records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |19265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:00:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:00:22 +0000 Subject: [Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 [Bug 19266] Add ability to match on 001 or 005 during import of records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:07:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:07:28 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to match on 001 or 005 during import of records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 --- Comment #1 from Nick Clemens --- Created attachment 66901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66901&action=edit Bug 19266: Allow 001 matching and 005 update on import of records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:11:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:11:55 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to match on 001 or 005 during import of records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66901|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 66902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66902&action=edit Bug 19266: Allow 001 matching and 005 update on import of records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:38:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:38:54 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:39:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:39:11 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:48:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:48:06 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66874|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 66903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66903&action=edit Bug 19256: Make Koha::Acq::Order using Koha::Object At the moment we have 2 different modules for acquisition orders: Koha::Tmp::Order[s] and Koha::Acquisition::Order The later has been added before the creation of Koha::Object. Koha::Tmp::Order[s] has been created to make the TT syntax for notices works with acquisition order data. This patch removes the temporary packages Koha::Tmp::Order[s] and adapt the code of Koha::Acquisition::Order[s] to be based on Koha::Object[s]. It also overloads Koha::Object->new to add the trick that was done in Koha::Acquisition::Order->insert. This is needed because acqui/addorder.pl is called from several places and CGI->Vars is used to retrieved order's attributes (and so much more). To avoid regression, the easiest (but not cleanest) way to do is to filter on aqorders column's names. This is *not* a pattern to follow! Test plan: Create basket and add orders from different ways, then continue a whole acquisition process Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:48:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:48:16 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66875|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 66904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66904&action=edit Bug 19256: (QA followup) Remove warn from unit test Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:48:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:48:23 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 66905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66905&action=edit Bug 19256: (QA followup) Add missing POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:49:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:49:31 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- The code looks correct (while it needs re-working at some point), the tests pass, QA scripts are happy, and I noticed no regressions on the UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 20:58:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 18:58:54 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Severity|minor |major --- Comment #3 from M. Tompsett --- Upgraded to major, as anyone wishing to use club functionality is affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 21:05:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 19:05:06 +0000 Subject: [Koha-bugs] [Bug 5592] circ rule cloning can be dangerous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5592 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 21:16:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 19:16:42 +0000 Subject: [Koha-bugs] [Bug 15351] RDA fields in Authority Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #6 from Joy Nelson --- I've reviewed the installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql I'm seeing all these RDA tags and subfields in that sql file. This ticket can be closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 21:40:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 19:40:53 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 --- Comment #3 from Marc V?ron --- (In reply to Jonathan Druart from comment #2) > It works for me on master with a fresh install. > > old_overduerules sounds related to 3.23.00.007 > > What returns "show create table overduerules_transport_types"? mysql> show create table overduerules_transport_types; +------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Table | Create Table | +------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | overduerules_transport_types | CREATE TABLE `overduerules_transport_types` ( `id` int(11) NOT NULL AUTO_INCREMENT, `letternumber` int(1) NOT NULL DEFAULT '1', `message_transport_type` varchar(20) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'email', `overduerules_id` int(11) NOT NULL, PRIMARY KEY (`id`), KEY `overduerules_fk` (`overduerules_id`), KEY `mtt_fk` (`message_transport_type`), CONSTRAINT `mtt_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `overduerules_fk` FOREIGN KEY (`overduerules_id`) REFERENCES `old_overduerules` (`overduerules_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci | +------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 21:40:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 19:40:52 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 21:46:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 19:46:31 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 21:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 19:51:54 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 22:24:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 20:24:11 +0000 Subject: [Koha-bugs] [Bug 15351] RDA fields in Authority Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #7 from Katrin Fischer --- Thx Joy! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 22:42:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 20:42:56 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 --- Comment #4 from Marc V?ron --- Reading: https://dev.mysql.com/doc/refman/5.5/en/rename-table.html ------- RENAME TABLE changes internally generated foreign key constraint names and user-defined foreign key constraint names that contain the string ?tbl_name_ibfk_? to reflect the new table name. InnoDB interprets foreign key constraint names that contain the string ?tbl_name_ibfk_? as internally generated names. Foreign key constraint names that point to the renamed table are automatically updated unless there is a conflict, in which case, the statement fails with an error. A conflict occurs if the renamed constraint name already exists. In such cases, you must drop and re-create the foreign keys in order for them to function properly. ------- Line 11590 in updatedatabase.pl renames table overduerules to old_overduerules, then it creates a new table overduerules. The renaming action changed / renamed REFERENCES in constraints of overduerules_transport_types (maybe in other tables as well?). That would explain that the error can not be reproduced on a fresh install (i.e. an install later than 3.23.00.007). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 22:44:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 20:44:59 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 --- Comment #5 from Aleisha Amohia --- Sorry I should clarify: When I first filed this bug I thought the whole feature was broken, but I was wrong. The overdue rule does not save when you put letters in the delay field (rather than numbers) and there is no error message. Otherwise I am actually able to save overdue rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 6 23:34:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 21:34:36 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jason Palmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpalmer at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 00:34:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 22:34:43 +0000 Subject: [Koha-bugs] [Bug 18360] Allow deletion of cancelled order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen at bywatersolutions.com --- Comment #2 from Karen --- One of our partners just told me that she would love to have the ability to delete an order entry. She says,"What KOHA needs is a delete order line feature. That is quite different from cancelling an order. I guess because we are small in comparison to many libraries, keeping records of cancelled orders is not important to us and gets in the way actually." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 00:57:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 22:57:13 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #25 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #24) > What are we doing here? > > If it is just replacing syspref fetch with Koha.Preference, the following is > wrong: > > - [% IF ( display_patron_image ) %] > + [% IF ( > Koha.Preference('ShowPatronImageInWebBasedSelfCheck') ) %] > > display_patron_image is set when $borrower is set AND the pref is set. > We had too many regressions in this area, I will not take any risks. > > If we are doing something else, it is not written in the commit messages. > > Please clarify. Oh I see what you mean, I think I've made the logic a little too confusing. I'll take out the [% IF ( Koha.Preference('ShowPatronImageInWebBasedSelfCheck') ) %] line in the template and leave the logic for that as it was. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 00:57:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 22:57:59 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 00:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Sep 2017 22:58:03 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #26 from Aleisha Amohia --- Created attachment 66906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66906&action=edit Bug 12691: [FOLLOW-UP] Fixing some logic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 03:08:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 01:08:24 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 03:08:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 01:08:27 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66870|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpull? --- Created attachment 66907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66907&action=edit Bug 19261 - never hide biblionumber field in view policy Followed test plan and biblionumber subfield 999c is visible in OPAC irrespective of visibility now. Patch applies and works as expected. Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 07:21:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 05:21:54 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 07:21:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 05:21:59 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66786|0 |1 is obsolete| | --- Comment #3 from Alex Buckley --- Created attachment 66908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66908&action=edit Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 07:24:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 05:24:28 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66787|0 |1 is obsolete| | --- Comment #4 from Alex Buckley --- Created attachment 66909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66909&action=edit Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:13:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:13:13 +0000 Subject: [Koha-bugs] [Bug 19035] Stored XSS in patron lists - lists.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19035 --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:13:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:13:28 +0000 Subject: [Koha-bugs] [Bug 19114] Stored XSS in parcels.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19114 --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:13:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:13:39 +0000 Subject: [Koha-bugs] [Bug 19112] Stored XSS in basketheader.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19112 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:13:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:13:52 +0000 Subject: [Koha-bugs] [Bug 19110] XSS Stored in branches.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19110 --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:14:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:14:07 +0000 Subject: [Koha-bugs] [Bug 19105] XSS Stored in holidays.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19105 --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:14:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:14:28 +0000 Subject: [Koha-bugs] [Bug 19079] XSS Flaws in Membership page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19079 --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:14:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:14:44 +0000 Subject: [Koha-bugs] [Bug 19033] XSS Flaws in Currencies and exchange page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19033 --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:15:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:15:12 +0000 Subject: [Koha-bugs] [Bug 19034] XSS Flaws in- Cities - Z39.50/ SRU servers administration - Patron categories pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19034 --- Comment #15 from Katrin Fischer --- This patches have been pushed to 16.11.x and are in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:15:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:15:25 +0000 Subject: [Koha-bugs] [Bug 19050] XSS Flaws in Quick spine label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19050 --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:15:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:15:46 +0000 Subject: [Koha-bugs] [Bug 19051] XSS Flaws in - Batch record deletion page - Batch item deletion page - Batch item modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19051 --- Comment #12 from Katrin Fischer --- These patches have been pushed to 16.11.x and are in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:16:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:16:07 +0000 Subject: [Koha-bugs] [Bug 19052] XSS Flaws in - vendor search page - Invoice search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19052 --- Comment #9 from Katrin Fischer --- These patches have been pushed to 16.11.x and are in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:16:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:16:36 +0000 Subject: [Koha-bugs] [Bug 19054] XSS Flaws in Report - Top Most-circulated items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19054 --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:16:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:16:52 +0000 Subject: [Koha-bugs] [Bug 19078] XSS Flaws in System preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19078 --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:17:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:17:07 +0000 Subject: [Koha-bugs] [Bug 18726] OPAC XSS - biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:17:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:17:25 +0000 Subject: [Koha-bugs] [Bug 16069] XSS issue in basket.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16069 --- Comment #18 from Katrin Fischer --- This patch has been pushed to 16.11.x and is in 16.11.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:50:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:50:26 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66887|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy --- Created attachment 66910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66910&action=edit Bug 18541: (QA follow-up) for comment #24 (POD) Add description to POD for draw_guide_grid Signed-off-by: Marcel de Rooy Amended: Moved the description from draw_guide_box to .._grid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 08:50:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 06:50:23 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 10:51:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 08:51:33 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:40:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:40:24 +0000 Subject: [Koha-bugs] [Bug 19267] New: Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Bug ID: 19267 Summary: Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:44:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:44:50 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:44:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:44:52 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 --- Comment #1 from Nick Clemens --- Created attachment 66911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66911&action=edit Bug 19267: Rancor - Warn before leaving page if record modified To test: 1 - Open the advanced editor 2 - Make some changes to a record 3 - Click on 'Patrons' or leave the page in some way 4 - Note there is no warning and changes are not saved 5 - Apply patch 6 - Open the advanced editor 7 - Make some changes 8 - Leave the page 9 - Note you get a warning of unsaved changes and can stay on the page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:50:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:50:53 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:51:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:51:49 +0000 Subject: [Koha-bugs] [Bug 19268] New: Fix wrong TestBuilder parameter in few unit tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Bug ID: 19268 Summary: Fix wrong TestBuilder parameter in few unit tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Bug 15339 made these errors visible. The values parameter should be value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:52:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:52:37 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66796|0 |1 is obsolete| | Attachment #66797|0 |1 is obsolete| | Attachment #66798|0 |1 is obsolete| | Attachment #66799|0 |1 is obsolete| | Attachment #66800|0 |1 is obsolete| | Attachment #66801|0 |1 is obsolete| | --- Comment #29 from Nick Clemens --- Created attachment 66912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66912&action=edit Bug 17380: Add some checks around Authorities::Types->find Resolves: Use of uninitialized value $biblio_fields in scalar chop at authorities/detail.pl line 212. Can't call method "authtypetext" on an undefined value at authorities/detail.pl line 216. Can't call method "authtypecode" on an undefined value at authorities/detail.pl line 180. NOTE: Some of these problems have actually been resolved now by bugs 18801 and 18811, but it is still better imo to have these checks. Test plan: [1] Verify unchanged behavior. Search for some authorities on authorities.pl and click on the details of a record. [2] Open an authorities detail page and change the authid in the URL to a not existing number. Instead of an internal server error, you should see a message like "The authority record you requested does not exist". Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:52:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:52:35 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:52:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:52:43 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #31 from Nick Clemens --- Created attachment 66914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66914&action=edit Bug 17380: Graceful resolution of missing reporting tag in merge Altough this patch deals with a mostly hypothetical case and this report makes it practically impossible anymore to merge with records in the Default framework (having no reporting tag), we can make the code of sub merge still a bit more robust here. If you would merge biblio records from one authtype to another and the new framework would not have a reporting tag, before this patch the result would be data loss. Merge would handle this request as a delete. This patch makes merge handle it differently: instead of clearing the biblio records, it keeps $a and $9 in order to make a future corrective merge possible. Note: The additional condition on line 1468 for $tags_using_authtype makes sure that we do not select all fields when the authtype should unexpectedly be empty string (Default). This prevents crashing on a "Control fields do not have subfields" error. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:52:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:52:40 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #30 from Nick Clemens --- Created attachment 66913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66913&action=edit Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority If we got an authtypecode from the database and this value is not NULL since the table column does not allow it, there is no need to call GuessAuthTypeCode for empty string (read: Default framework) in the sub get_from_authid. Furthermore, we remove three Koha::MetadataRecord::Authority->new calls. They are useless, since we do not pass a record. It just generates: No record passed at authorities/merge.pl line 96. Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66. Instead we throw an ObjectNotFound exception. Test plan: [1] Run t/db_dependent/Koha_Authority.t [2] Interface will be tested in the following patches. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:52:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:52:46 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #32 from Nick Clemens --- Created attachment 66915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66915&action=edit Bug 17380: Do not allow Default template in merge form This patch makes the following changes: [1] Removes Default from the template list. We should not merge with the Default framework, since it does not have a reporting tag. [2] Rearranges the error section in the template. It is confusing to have two error sections in this template. The error CANNOT_MOVE is not used. The error FRAMEWORK_NOT_SELECTED is replaced by WRONG_FRAMEWORK. [3] Do not allow to merge a record with itself. [4] Check if the merge reference record still contains any MARC tags. [5] Additional polishing: Simplify passing frameworks to template. Remove an unused Koha::Authority::Types->search. Remove obsolete POD header for functions from the script. Test plan: [1] Select two authorities to merge. Verify that you cannot select Default anymore as framework for the reference record. [2] Reproduce error WRONG_COUNT by adding another authid=999 in the URL after you selected two authority records for merging. [3] Remove the third authid from the URL and change the first or second authid into an unexisting record id. You should generate an Internal Server Error. The log should show the exception message. [4] Merge two authorities. Deselect all MARC tags. Should trigger the error EMPTY_MARC in the template. [5] Select the same authority record twice for merging. Should trigger the error DESTRUCTIVE_MERGE in the template. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:52:49 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #33 from Nick Clemens --- Created attachment 66916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66916&action=edit Bug 17380: (QA followup) Fix parameter in tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:52:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:52:52 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 --- Comment #34 from Nick Clemens --- Created attachment 66917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66917&action=edit Bug 17380: [QA Follow-up] Report error to user instead of throwing exception Internal server errors are good, user feedback is better. Signed-off-by: Marcel de Rooy Tiny change: removed the obsolete 'use Koha::Exceptions'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:58:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:58:26 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 --- Comment #1 from Marcel de Rooy --- Created attachment 66918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66918&action=edit Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t The values parameter should be called value. See bug 15339. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 11:59:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 09:59:19 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #6 from Nick Clemens --- Created attachment 66919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66919&action=edit Bug 18823: Rancor - improve import batch search/update ISBN handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:09:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:09:35 +0000 Subject: [Koha-bugs] [Bug 19228] Confirm delete doesn't show when deleting an item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:09:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:09:38 +0000 Subject: [Koha-bugs] [Bug 19228] Confirm delete doesn't show when deleting an item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66676|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 66920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66920&action=edit Bug 19228: Trigger confirm delete when removing item from course To test: 1) Enable UseCourseReserves syspref 2) Go to Course Reserves 3) Add a new course if you don't already have one 4) Add an item to the course 5) Click 'remove' to delete the item from the course 6) Notice the item deletes straight away with no confirmation prompt 7) Apply the patch 8) Repeat steps 4 and 5 9) Confirm the confirmation box pops up and works as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:09:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:09:58 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66892|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 66921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66921&action=edit Bug 15339: TestBuilder warnings (code) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch holds the code changes. Examples of the kind of errors that it catches are in the tests (separate patch). Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:10:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:10:06 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66893|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 66922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66922&action=edit Bug 15339: TestBuilder warnings (tests) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch contains the tests that doubles as a demonstration of the kind of error the patch is intended to prevent. Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:10:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:10:11 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66894|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 66923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66923&action=edit Bug 15339: Improve parameter validation Only value and source are allowed Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:10:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:10:16 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #11 from Marcel de Rooy --- Created attachment 66924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66924&action=edit Bug 15339: [QA Follow-up] Add a warning too when source is not supplied When you do not supply a source and add a few wrong parameters, you would not be warned. Because build simply returns undef. Adding a carp and a test for that situation too. Note: In the earlier subtest 'trivial tests' build was called without source. This now generates a warning. We just catch if there is a warning and test the actual warning itself later on. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:10:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:10:42 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:10:54 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15339 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:10:54 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19268 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:11:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:11:04 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:12:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:12:34 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:16:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:16:29 +0000 Subject: [Koha-bugs] [Bug 19269] New: Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 Bug ID: 19269 Summary: Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This patchset add two columns to import biblios to allow for searching on these values, it should allow for future use in matching and expanded display to give more record feedback -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:16:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:16:35 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:16:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:16:46 +0000 Subject: [Koha-bugs] [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18823 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:16:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:16:46 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:20:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:20:10 +0000 Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn' t take you back to the course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:20:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:20:13 +0000 Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn' t take you back to the course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66677|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 66925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66925&action=edit Bug 19229: Return to course when cancelling out of edit form To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves, create a course 3) Edit course 4) Click Cancel 5) Notice you are returned to the courses home page rather than returned to the course 6) Apply patch 7) Go to edit course and click cancel again 8) Confirm you are returned to the course and that this feels like the natural expectation. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:21:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:21:14 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66906|0 |1 is obsolete| | --- Comment #27 from Marc V?ron --- Created attachment 66926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66926&action=edit Bug 12691: [FOLLOW-UP] Fixing some logic Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:21:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:21:41 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:22:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:22:33 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Marcel de Rooy --- Jonathan: This could go along with 15339, but does not depend on it. Funny that these tests passed with other values than expected.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:22:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:22:41 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:23:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:23:09 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:34:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:34:31 +0000 Subject: [Koha-bugs] [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 --- Comment #1 from Nick Clemens --- Created attachment 66927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66927&action=edit Bug 19269 - database changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:34:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:34:33 +0000 Subject: [Koha-bugs] [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 --- Comment #2 from Nick Clemens --- Created attachment 66928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66928&action=edit Bug 19269: Rancor - Add LCCN, pubdate to indexing Also, fix control number updating for updated records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:51:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:51:58 +0000 Subject: [Koha-bugs] [Bug 19270] New: Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270 Bug ID: 19270 Summary: Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:52:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:52:34 +0000 Subject: [Koha-bugs] [Bug 19270] Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19269 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:52:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:52:34 +0000 Subject: [Koha-bugs] [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19270 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270 [Bug 19270] Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 12:58:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 10:58:35 +0000 Subject: [Koha-bugs] [Bug 19271] New: Show vendor name instead of internal number on ordered/ spent lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19271 Bug ID: 19271 Summary: Show vendor name instead of internal number on ordered/spent lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The list of ordered and spent amounts for each fund shows only the vendor's internal number instead of the vendor name. This makes the list less useful, especially for printing or exporting. Koha should show the vendor names instead of the numbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 13:08:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 11:08:24 +0000 Subject: [Koha-bugs] [Bug 19270] Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 13:08:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 11:08:26 +0000 Subject: [Koha-bugs] [Bug 19270] Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270 --- Comment #1 from Nick Clemens --- Created attachment 66929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66929&action=edit Bug 19270: Rancor - add ability to search batches by arbitrary marc fields To test: 1 - Open advanced cataloging editor 2 - In settings->import batches enable some batches for searching 3 - Click 'Advanced' in the search box 4 - Check an import batch, note a 'MARC field' searchbox appears 5 - Enter some test searches (use '*' as wildcard - add it to both ends of value unless you want exact search) 6 - Note results appear as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 13:39:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 11:39:46 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #19 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:17:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:17:30 +0000 Subject: [Koha-bugs] [Bug 19231] No warning of number of attached items when deleting a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #2 from Claire Gravely --- Hi Aleisha, I only got the normal warning message, but didn't get any information about the number of items attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:36:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:36:38 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #20 from Marcel de Rooy --- Created attachment 66930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66930&action=edit Bug 19059: [QA Follow-up] Typo holds for hold Resolves: The method found is not covered by tests at C4/Reserves.pm line 815. Test plan: Run t/db_dependent/Holds/CancelReserves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:41:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:41:52 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #21 from Marcel de Rooy --- Looks good to me. Few minor points left: FIXME in sub ModReserveFill + # FIXME Must call Koha::Hold->cancel ? => No, should call ->filled and add the correct log Not clear to me. Please clarify. sub _move_to_old The name suggests a move, but you are only copying data. circ/branchtransfers.pl + } # FIXME else? Can you fix it now? You add the if. Actually, the script always assumed that CancelReserve worked. So why not only test $holds->count for the call to cancel ? Same remark for other occurrences. Incl. circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:43:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:43:39 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #22 from Marcel de Rooy --- Will pass qa after feedback and adjustments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:52:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:52:24 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 --- Comment #7 from Marc V?ron --- Created attachment 66932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66932&action=edit Follow-up: Add POD descriptions to subs This patch simply adds POD descriptions to subs affected by first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:53:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:53:13 +0000 Subject: [Koha-bugs] [Bug 19264] Patron card creator: Add descriptions to PODs in Patroncard.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18541 |18550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 [Bug 18541] Patron card creator: Add a grid to support layout design https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 [Bug 18550] Patron card creator: Print output does not respect layout units -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:53:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:53:13 +0000 Subject: [Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19264 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264 [Bug 19264] Patron card creator: Add descriptions to PODs in Patroncard.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:53:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:53:13 +0000 Subject: [Koha-bugs] [Bug 18550] Patron card creator: Print output does not respect layout units In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18550 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264 [Bug 19264] Patron card creator: Add descriptions to PODs in Patroncard.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:57:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:57:04 +0000 Subject: [Koha-bugs] [Bug 19273] New: Confirm hold does not work for in-transit holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19273 Bug ID: 19273 Summary: Confirm hold does not work for in-transit holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a hold was transferred to another library and that library uses the "Confirm" button instead of the "Print and confirm" button, the hold will remain "in transit" and will not be marked as waiting. The patron will also not receive notification of the hold since it never gets marked as waiting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 14:57:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 12:57:09 +0000 Subject: [Koha-bugs] [Bug 19273] Confirm hold does not work for in-transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19273 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:00:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:00:23 +0000 Subject: [Koha-bugs] [Bug 19273] Confirm hold does not work for in-transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19273 --- Comment #1 from Kyle M Hall --- Created attachment 66933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66933&action=edit Bug 19273 - Confirm hold does not work for in-transit holds If a hold was transferred to another library and that library uses the "Confirm" button instead of the "Print and confirm" button, the hold will remain "in transit" and will not be marked as waiting. The patron will also not receive notification of the hold since it never gets marked as waiting. Test Plan: 1) Place a hold at Library A for pickup at Library B 2) Check the item in at Library A, confirm the transfer to Library B 3) Change your logged in branch to Library B 4) Check the item in at Library B 5) Confirm the hold using the "Confirm" button 6) Note the hold is still marked as in transit 7) Apply this patch 8) Repeat steps 1-5 9) Note the hold is marked correctly as waiting when the "Confirm" button is used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:00:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:00:21 +0000 Subject: [Koha-bugs] [Bug 19273] Confirm hold does not work for in-transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19273 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:05:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:05:25 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61878|0 |1 is obsolete| | --- Comment #67 from Julian Maurice --- Created attachment 66934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66934&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:05:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:05:30 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61879|0 |1 is obsolete| | --- Comment #68 from Julian Maurice --- Created attachment 66935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66935&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher tmp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:05:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:05:34 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61880|0 |1 is obsolete| | --- Comment #69 from Julian Maurice --- Created attachment 66936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66936&action=edit Bug 12802: FIX use the first valid email address if noemail is needed Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:05:38 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61881|0 |1 is obsolete| | --- Comment #70 from Julian Maurice --- Created attachment 66937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66937&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:05:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:05:42 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61882|0 |1 is obsolete| | --- Comment #71 from Julian Maurice --- Created attachment 66938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66938&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:05:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:05:47 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61883|0 |1 is obsolete| | --- Comment #72 from Julian Maurice --- Created attachment 66939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66939&action=edit Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:05:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:05:51 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61884|0 |1 is obsolete| | --- Comment #73 from Julian Maurice --- Created attachment 66940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66940&action=edit Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 15:06:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 13:06:55 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #74 from Julian Maurice --- Patches rebased on master, reintroducing the subroutine _update_message_to_address which is still needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:18:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:18:24 +0000 Subject: [Koha-bugs] [Bug 19274] New: Translatability: Fix new splitting problems related to database warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 Bug ID: 19274 Summary: Translatability: Fix new splitting problems related to database warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The warnings about database problems introduce new translatability problems, mostly related to sentence splitting by html tags. Examples for isolated fragments in Pootle: See the The following ids exist in both biblio (...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:22:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:22:39 +0000 Subject: [Koha-bugs] [Bug 18931] Add a "data corrupted" section on the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 [Bug 19274] Translatability: Fix new splitting problems related to database warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:22:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:22:39 +0000 Subject: [Koha-bugs] [Bug 19274] Translatability: Fix new splitting problems related to database warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 [Bug 18931] Add a "data corrupted" section on the about page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:28:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:28:53 +0000 Subject: [Koha-bugs] [Bug 18988] OPAC password not going by autoemailprimaryaddress preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18988 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:41:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:41:00 +0000 Subject: [Koha-bugs] [Bug 19274] Translatability: Fix new splitting problems related to database warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 --- Comment #1 from Marc V?ron --- Created attachment 66941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66941&action=edit Bug 19274: Translatability: Fix new splitting problems related to database warnings The warnings about database problems introduce new translatability problems, mostly related to sentence splitting by html tags. To test: - Verify that text changes make sense - Apply patch, verify that messages properly. Note: To force display you might want to add '1 ||' to the related if statements, including line 134, e.g. [% IF 1 || has_ai_issues %] - Bonus test: Go through an translation cicle and verify that fragemts as mentioned in initial comment are gone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:44:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:44:30 +0000 Subject: [Koha-bugs] [Bug 19274] Translatability: Fix new splitting problems related to database warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66941|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 66942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66942&action=edit Bug 19274: Translatability: Fix new splitting problems related to database warnings The warnings about database problems introduce new translatability problems, mostly related to sentence splitting by html tags. To test: - Verify that text changes make sense - Apply patch, verify that messages properly. Note: To force display you might want to add '1 ||' to the related if statements, including line 134, e.g. [% IF 1 || has_ai_issues %] - Bonus test: Go through an translation cicle and verify that fragemts as mentioned in initial comment are gone. (Amended to fix tiny typo) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:45:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:45:00 +0000 Subject: [Koha-bugs] [Bug 19274] Translatability: Fix new splitting problems related to database warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:45:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:45:51 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19259 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:45:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:45:51 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13624 --- Comment #6 from Jonathan Druart --- Marc, % git checkout 0aa6ba1599bb0de923619a365f529119dc5c67a6 # DBrev 3.23.00.006 % reset_all > SHOW CREATE TABLE overduerules_transport_types; | overduerules_transport_types | CREATE TABLE `overduerules_transport_types` ( `id` int(11) NOT NULL AUTO_INCREMENT, `branchcode` varchar(10) COLLATE utf8_unicode_ci NOT NULL DEFAULT '', `categorycode` varchar(10) COLLATE utf8_unicode_ci NOT NULL DEFAULT '', `letternumber` int(1) NOT NULL DEFAULT '1', `message_transport_type` varchar(20) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'email', PRIMARY KEY (`id`), KEY `overduerules_fk` (`branchcode`,`categorycode`), KEY `mtt_fk` (`message_transport_type`), CONSTRAINT `mtt_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `overduerules_fk` FOREIGN KEY (`branchcode`, `categorycode`) REFERENCES `overduerules` (`branchcode`, `categorycode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci | % git checkout master % restart_all % sudo koha-shell kohadev % perl installer/data/mysql/updatedatabase.pl > SHOW CREATE TABLE overduerules_transport_types; | overduerules_transport_types | CREATE TABLE `overduerules_transport_types` ( `id` int(11) NOT NULL AUTO_INCREMENT, `letternumber` int(1) NOT NULL DEFAULT '1', `message_transport_type` varchar(20) COLLATE utf8_unicode_ci NOT NULL DEFAULT 'email', `overduerules_id` int(11) NOT NULL, PRIMARY KEY (`id`), KEY `mtt_fk` (`message_transport_type`), KEY `overduerules_transport_types_fk` (`overduerules_id`), CONSTRAINT `mtt_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `overduerules_transport_types_fk` FOREIGN KEY (`overduerules_id`) REFERENCES `overduerules` (`overduerules_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci | Without data it seems that the update works fine. Maybe you got some errors during the upgrade? Is it a DB in production? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:51:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:51:09 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 --- Comment #7 from Jonathan Druart --- Seems ok with data too -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:53:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:53:38 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:53:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:53:42 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60737|0 |1 is obsolete| | Attachment #60738|0 |1 is obsolete| | --- Comment #36 from Nick Clemens --- Created attachment 66943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66943&action=edit Bug 13937 - Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:53:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:53:46 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #37 from Nick Clemens --- Created attachment 66944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66944&action=edit Bug 13937 (Followup) - Remove reference to sub _prefetch_records Remove reference to sub _prefetch_records It appears this subis built into fetch and this call is a duplicate Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:53:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:53:49 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #38 from Nick Clemens --- Created attachment 66945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66945&action=edit Bug 13937 - (Followup) Correct error call to use self -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 17:53:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 15:53:53 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #39 from Nick Clemens --- Created attachment 66946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66946&action=edit Bug 13937 - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:08:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:08:09 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #22 from Owen Leonard --- Is it correct that this bug depends on Bug 8630? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:14:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:14:25 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 --- Comment #8 from Marc V?ron --- (In reply to Jonathan Druart from comment #6) (...) > > Without data it seems that the update works fine. > > Maybe you got some errors during the upgrade? Is it a DB in production? Thanks for testing. It's not a DB for production. It's on a VM I installed a couple of years ago; best possible that while upgrading something went wrong. Question: Is there any script that can be used to check database structure integrity? (E.g. Typo3 CMS has such script in it's install section) ...and let's not forget the problem reported by Aleisha (see comment 5) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:20:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:20:07 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66824|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 66947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66947&action=edit Bug 19116: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:20:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:20:39 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #21 from Jonathan Druart --- Another try, the tests still pass with and without the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:23:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:23:15 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #22 from Jonathan Druart --- (In reply to Josef Moravec from comment #2) > And it is caused by bug 18438... If this is caused by template changes, why do we need to fix it at package level? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:42:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:42:18 +0000 Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn' t take you back to the course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:49:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:49:31 +0000 Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn' t take you back to the course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66925|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 66948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66948&action=edit Bug 19229: Return to course when cancelling out of edit form To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves, create a course 3) Edit course 4) Click Cancel 5) Notice you are returned to the courses home page rather than returned to the course 6) Apply patch 7) Go to edit course and click cancel again 8) Confirm you are returned to the course and that this feels like the natural expectation. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:52:17 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15339 | Blocks| |15339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 [Bug 15339] TestBuilder build parameter warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:52:17 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19268 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19268 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 [Bug 19268] Fix wrong TestBuilder parameter in few unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:52:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:52:44 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:52:49 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66918|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 66949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66949&action=edit Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t The values parameter should be called value. See bug 15339. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:53:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:53:03 +0000 Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:53:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:53:06 +0000 Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64677|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 66950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66950&action=edit Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:53:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:53:14 +0000 Subject: [Koha-bugs] [Bug 18599] "Record URL" link href is broken for multiple 856$u links in MARC record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18599 mustaqeem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mustaqeemabd at gmail.com --- Comment #1 from mustaqeem --- Also getting this error for Koha 17.05..work perfectly fine if there is only one 856 field, but error for multiple 856.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:55:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:55:26 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #12 from Jonathan Druart --- Created attachment 66951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66951&action=edit Bug 15339: Remove extra 'my' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:58:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:58:25 +0000 Subject: [Koha-bugs] [Bug 19228] Confirm delete doesn't show when deleting an item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:58:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:58:30 +0000 Subject: [Koha-bugs] [Bug 19228] Confirm delete doesn't show when deleting an item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66920|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 66952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66952&action=edit Bug 19228: Trigger confirm delete when removing item from course To test: 1) Enable UseCourseReserves syspref 2) Go to Course Reserves 3) Add a new course if you don't already have one 4) Add an item to the course 5) Click 'remove' to delete the item from the course 6) Notice the item deletes straight away with no confirmation prompt 7) Apply the patch 8) Repeat steps 4 and 5 9) Confirm the confirmation box pops up and works as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 18:59:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 16:59:57 +0000 Subject: [Koha-bugs] [Bug 19228] Confirm delete doesn't show when deleting an item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:00:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:00:14 +0000 Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn' t take you back to the course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:02:14 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:05:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:05:13 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:05:18 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66756|0 |1 is obsolete| | Attachment #66757|0 |1 is obsolete| | Attachment #66758|0 |1 is obsolete| | Attachment #66926|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 66953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66953&action=edit Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Bug 12691: [FOLLOW-UP] Follow-up patch This patch fixes merge conflicts and fixes the problems in Comment 7 QA tools complain about missing bracket, will be fixed in next followup Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Bug 12691: [FOLLOW-UP] Missing bracket Patch adds bracket to template file (Comment 16) Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Bug 12691: [FOLLOW-UP] Fixing some logic Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Patches have been squashed for readability and 1 removal occurrence of display_patron_image has been reintroduced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:08:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:08:15 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18179 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 [Bug 18179] Koha::Objects->find should not be called in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:08:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:08:15 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:10:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:10:08 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:10:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:10:08 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:11:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:11:25 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18870 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:11:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:11:25 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19214 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:16:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:16:57 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:17:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:17:01 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66895|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 66954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66954&action=edit Bug 19214: Prevent crash if ->club or ->patron is called in list context To test: 1) Create a club template and a club. 2) Add a user to the club 3) Log in to the OPAC as that user 4) Go to 'your summary' and click the Clubs tab 5) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 62. 6) Go to the staff side and go to the member page of that user 7) Go to 'details' and click the Clubs tab 8) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 71. 9) Apply patch 1) Repeat steps 4-7, confirming the errors do not show and clubs info loads correctly Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:17:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:17:05 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 --- Comment #5 from Jonathan Druart --- Created attachment 66955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66955&action=edit Bug 19214: prevent crash if club_template_field is called in list context Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:17:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:17:19 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:20:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:20:57 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don' t use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:21:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:21:28 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:31:08 +0000 Subject: [Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:30:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:30:55 +0000 Subject: [Koha-bugs] [Bug 19275] New: clubs table broken at the opac if public enrollment is not allowed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 Bug ID: 19275 Summary: clubs table broken at the opac if public enrollment is not allowed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:31:08 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 [Bug 19275] clubs table broken at the opac if public enrollment is not allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:31:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:31:16 +0000 Subject: [Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:33:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:33:02 +0000 Subject: [Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org --- Comment #1 from Jonathan Druart --- To recreate: Create a template club and disable public enrollment Create a club and add it a patron login at the opac with this patron => the table is broken at the opac, td are missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:35:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:35:19 +0000 Subject: [Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:35:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:35:23 +0000 Subject: [Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66857|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 66956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66956&action=edit Bug 18921: Resolve a few warnings in C4/XSLT.pm Resolves warnings like: Use of uninitialized value in hash element at C4/XSLT.pm line 262. Use of uninitialized value in numeric eq (==) at C4/XSLT.pm line 267. Use of uninitialized value $status in concatenation (.) or string at C4/XSLT.pm line 300. Note: Line numbers are not exactly the same anymore. Test plan: [1] Enable XSLT view in OPAC [2] Without this patch, you will probably have some of these warnings when doing some opac searches. [3] Apply this patch. Check the logs again. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:36:13 +0000 Subject: [Koha-bugs] [Bug 19273] Confirm hold does not work for in-transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- This is a duplicate to 19116. Very different fix - Kyle and Joseph, can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:36:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:36:22 +0000 Subject: [Koha-bugs] [Bug 19273] Confirm hold does not work for in-transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 19116 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:36:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:36:22 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #23 from Katrin Fischer --- *** Bug 19273 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:38:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:38:54 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66863|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 66957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66957&action=edit Bug 19257: Prevent warn when reopening a basket To test: 1) Go to Acquisitions, find a vendor and a basket (create if you don't have either) 2) Close the basket 3) View the basket and reopen it 4) Notice the warn 5) Apply the patch and repeat steps 1-3 6) Notice the warn no longer shows and the basket is reopened as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:38:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:38:48 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:40:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:40:59 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:41:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:41:03 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66864|0 |1 is obsolete| | Attachment #66865|0 |1 is obsolete| | Attachment #66866|0 |1 is obsolete| | Attachment #66867|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 66958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66958&action=edit Bug 19258: Prevent warn when paying a fine or charge To test: 1) Go to a members detail page in staff client 2) Select the Fines tab in the left pane 3) Select the Create manual invoice tab below the button menu bar 4) Create a fine and click save (e.g. Type: Fine, Amount: 5.00) 5) Select the Pay fines tab below the button menu bar 6) Click Pay on the item 7) Blank the staff error log 8) click confirm -- staff error log has message 9) apply this first patch 10) repeat steps 3-8 -- staff error log is blank 11) run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:41:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:41:07 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #11 from Jonathan Druart --- Created attachment 66959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66959&action=edit Bug 19258: Prevent warns when writing off an individual fine The following warns are triggered when I click the Write Off button next to an individual fine or charge: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. (this shows many times) Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, click the Write off button next to the invoice you just created 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:41:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:41:11 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #12 from Jonathan Druart --- Created attachment 66960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66960&action=edit Bug 19258: Preventing warns when paying a fine or charge from Pay selected button The following warns are triggered when I click the Pay selected button: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 267, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 273, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select the fine you just created and click Pay selected 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:41:15 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 --- Comment #13 from Jonathan Druart --- Created attachment 66961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66961&action=edit Bug 19258: Prevent warn when reversing a payment The following warn is triggered when I click the Reverse button next to an individual payment on the Account tab: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side, create a manual invoice, pay it 2) Go to the Account tab, click Reverse next to the payment you just made 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:43:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:43:33 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Readonly: see bug 16588 Koha::Patrons->merge: See 15336, it adds a Koha::Acquisition::Bookseller->merge_with #consistency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 19:48:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 17:48:38 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication ( country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:06:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:06:23 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:06:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:06:40 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:07:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:07:06 +0000 Subject: [Koha-bugs] [Bug 18921] Resolve a few warnings in C4/XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:07:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:07:22 +0000 Subject: [Koha-bugs] [Bug 19214] Patron clubs: Template process failed: undef error - Cannot use "->find" in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:07:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:07:55 +0000 Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn' t take you back to the course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:07:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:07:37 +0000 Subject: [Koha-bugs] [Bug 19228] Confirm delete doesn't show when deleting an item from course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:08:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:08:12 +0000 Subject: [Koha-bugs] [Bug 19256] Koha::Acquisition::Order should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:08:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:08:28 +0000 Subject: [Koha-bugs] [Bug 19257] Warn when reopening a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:08:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:08:43 +0000 Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:08:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:08:45 +0000 Subject: [Koha-bugs] [Bug 19258] Warn when paying or writing off a fine or charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:08:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:08:50 +0000 Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66950|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 66962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66962&action=edit Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:09:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:09:02 +0000 Subject: [Koha-bugs] [Bug 19268] Fix wrong TestBuilder parameter in few unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:09:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:09:15 +0000 Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff client catalog pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:09:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:09:48 +0000 Subject: [Koha-bugs] [Bug 6685] circ rules by groups of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org --- Comment #10 from Chris Slone --- We'd also be interested in this enhancement as it would greatly help us in enforcing our policies. For example, we created two DVD item types in order to provide longer loan periods on DVD sets. Our policies have long dictated that our patrons may have 15 of any combination of DVDs checked-out, but with the current item limits in Koha the DVDs and DVD sets get counted separately. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 20:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 18:27:04 +0000 Subject: [Koha-bugs] [Bug 6685] circ rules by groups of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685 --- Comment #11 from Chris Slone --- Forgot to add: Maybe this can take advantage of the Itemtypecat authorized value? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:26:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:26:54 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication ( country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37313|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 66963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66963&action=edit Bug 13912: Add DefaultCountryField008 syspref This syspref is going to be used for populating field 008, range 15-17 with a desired default. It is currently hardcoded to 'xxu'. If not set, it will still fallback to 'xxu'. Signed-off-by: m23 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:27:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:27:03 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication ( country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37314|0 |1 is obsolete| | --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 66964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66964&action=edit Bug 13912: Fix LOC link Signed-off-by: m23 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:27:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:27:10 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication ( country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 --- Comment #16 from Tom?s Cohen Arazi --- Created attachment 66965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66965&action=edit Bug 13912: (QA followup) Update database Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:27:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:27:42 +0000 Subject: [Koha-bugs] [Bug 13912] Add syspref for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|System preference for |Add syspref for default |default place of |place of publication |publication (country code) |(country code) for field |for field 008, range 15-17 |008, range 15-17 Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:27:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:27:50 +0000 Subject: [Koha-bugs] [Bug 13912] Add syspref for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:27:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:27:58 +0000 Subject: [Koha-bugs] [Bug 13912] Add syspref for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:36:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:36:38 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 21:43:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 19:43:48 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields , or based on the koha biblio level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 7 22:59:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 20:59:21 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 --- Comment #40 from Mike --- Can anybody rebase it on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 01:25:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 23:25:15 +0000 Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 01:25:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 23:25:19 +0000 Subject: [Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66880|0 |1 is obsolete| | --- Comment #10 from Alex Buckley --- Created attachment 66966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66966&action=edit Bgu 12346: Display the correct number of pending patron modifications on the patron module home page Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 0) Set IndependentBranchesPatronModifications = Yes 1) Create a number of modification request for BranchA 2) Log into the staff intranet with a patron without superlibrarian permissions and set your branch to BranchB 3) Note the modifications alert to does not display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays QA notes: What was the point of the branch variable? Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 01:40:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 23:40:18 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Laurel Moran changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmoran at sdlawlibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 01:40:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Sep 2017 23:40:41 +0000 Subject: [Koha-bugs] [Bug 18466] No article requests breaks the opac-user-views block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466 Laurel Moran changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmoran at sdlawlibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 02:17:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 00:17:47 +0000 Subject: [Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #5 from Alex Buckley --- Created attachment 66967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66967&action=edit No Cancel button displayed Hi Christopher When I tested this patch I found that the 'Transferring item to:' text was displayed in Test A, B, and C however the 'Cancel' button is only being displayed in test C -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 02:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 00:18:18 +0000 Subject: [Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 02:40:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 00:40:17 +0000 Subject: [Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #6 from Alex Buckley --- OK so I have now got it displaying the 'cancel transfer' button, so the patch works as described in the test plan. However running the QA test it fails on valid_template, could you please fix this up Christopher and then I'll be happy to re-test and sign off on your patch FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 04:39:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 02:39:23 +0000 Subject: [Koha-bugs] [Bug 19222] Why does dt_from_string not understand yyyy-mm-ddThh:mm:ss ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19222 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 04:39:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 02:39:26 +0000 Subject: [Koha-bugs] [Bug 19222] Why does dt_from_string not understand yyyy-mm-ddThh:mm:ss ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19222 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66669|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 66968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66968&action=edit Bug 19222: Why does dt_from_string not understand yyyy-mm-ddThh:mm:ss? dt_from_string disregards the time part when there is a T before it. But note that if you print a datetime it actually prints that T. Like: 2017-08-31T13:32:37 A small regex adjustment could be helpful. Test plan: Run t/DateUtils.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 04:40:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 02:40:53 +0000 Subject: [Koha-bugs] [Bug 19222] Why does dt_from_string not understand yyyy-mm-ddThh:mm:ss ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19222 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- I suppose my pondering over [Z\+-]\d{2}:?\d{2} or something similar for the timezone offset is best saved for another bug, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 05:46:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 03:46:36 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #19 from Alex Buckley --- Hi Josef Sorry but failed in the running of QA test tools: OK circ/circulation.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template After that is fixed up I will be happy to test and signoff as the patches worked as described in the test plans -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 06:36:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 04:36:24 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64966|0 |1 is obsolete| | --- Comment #24 from Alex Buckley --- Created attachment 66969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66969&action=edit Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures Many DBIx-stuffs depend on last_insert_id Followed test plan from comment #4, works as expected Signed-off-by: Marc V?ron Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 06:37:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 04:37:51 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64967|0 |1 is obsolete| | --- Comment #25 from Alex Buckley --- Created attachment 66970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66970&action=edit Bug 18231: Make sure we will not add the column twice Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 06:40:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 04:40:32 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 06:40:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 04:40:42 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64968|0 |1 is obsolete| | --- Comment #26 from Alex Buckley --- Created attachment 66971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66971&action=edit Bug 18231: (follow-up) Fix t/db_dependent/Koha/Objects.t This Bug broke a test in t/db_dependent/Koha/Objects.t. This patch replaces now failing test with an equal one but targetting a different Koha-object. To test: 1. Apply first & second patch in this Bug and run updatedatabase.pl 2. prove t/db_dependent/Koha/Objects.t 3. Observe following failure: DBIx::Class::ResultSet::find(): find() expects either a column/value hashref, or a list of values corresponding to the columns of the specified unique constraint 'primary' at /home/koha/Koha/Koha/Objects.pm line 227 4. Apply this patch 5. prove t/db_dependent/Koha/Objects.t 6. Observe test passing Followed test plan, patch worked as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 07:35:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 05:35:52 +0000 Subject: [Koha-bugs] [Bug 19222] Why does dt_from_string not understand yyyy-mm-ddThh:mm:ss ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19222 --- Comment #5 from Marcel de Rooy --- (In reply to M. Tompsett from comment #4) > I suppose my pondering over [Z\+-]\d{2}:?\d{2} or something similar for the > timezone offset is best saved for another bug, right? Thx for signing off. Yeah, open a new report :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 07:37:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 05:37:56 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #14 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #12) > Created attachment 66951 [details] [review] > Bug 15339: Remove extra 'my' O my. Thx for catching that.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 07:51:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 05:51:11 +0000 Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #17 from Marcel de Rooy --- Thx for updating your patch. If I look at Manage Batches and click Edit, I can add a description and save it by clicking on the link next to the text box. After that we have a text field for borrowernumbers and a series of buttons. This does not really look good. I am no design expert, but could you ask around for some advice in that regard (maybe Owen) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 08:13:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 06:13:40 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #24 from Katrin Fischer --- There is a template level fix/patch from Kyle on the linked bug 19273 - not sure what makes more sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:00:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:00:46 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 --- Comment #28 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #27) > Created attachment 66791 [details] [review] > Bug 18351: [FOLLOW-UP] Removing swp file Thx for responding. I meant: get rid of the swp file in the original patch. No need to have it in git. I will fix it now. QA: Looking here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:40:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:40:25 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:40:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:40:28 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65569|0 |1 is obsolete| | Attachment #65570|0 |1 is obsolete| | Attachment #65571|0 |1 is obsolete| | Attachment #65572|0 |1 is obsolete| | Attachment #66304|0 |1 is obsolete| | Attachment #66791|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy --- Created attachment 66974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66974&action=edit Bug 18351: Able to delete budget with funds To test: 1) Create a budget, add a fund 2) Delete budget. Notice this is successful and triggers no warning message etc. 3) Go to Funds. Notice the funds appear as if they are not there 4) Go into mysql and view the aqbudgetperiods table - notice the funds are still there and are now inaccessible. 5) Apply patch 6) Create a budget, add a fund 7) Attempt to delete budget. Notice you can't click Delete button. Confirm number of funds in hover message is correct. 8) Delete fund 9) Confirm you can now delete budget. Sponsored-by: Catalyst IT Signed-off-by: Felix Hemme Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Some code fixes See Comment 5. Ready to test. Signed-off-by: Lee Jamison Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Code fix See comment 10. Ready for testing. Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Prevent deletion from forcing URL This patch adds a check in the script for existing funds so that the budget cannot be deleted when forcing the URL and has other small fixes. Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Prevent deletion if funds are added after clicking 'Delete' and before confirming delete Followed test plan and patch works as described. Signed-off-by: Dilan Johnpull? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:41:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:41:21 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|unspecified |master --- Comment #30 from Marcel de Rooy --- Looks good to me. Minor comment (no blocker): The script contains a $total variable that seems to be unused (not passed to template). The template now contains: [% IF ( total || funds_exist ) %] Cannot delete budget '[% budget_period_description %]' The total check appears to be unneeded. Similary: [% IF ( delete_confirm ) %] [% IF ( total ) %]

    Cannot delete budget

    This record is used [% total %] times . Deletion is not possible.

    [% ELSIF ( funds_exist ) %]

    Cannot delete budget

    This budget has funds attached. You must delete all attached funds before you can delete this budget.

    The total branch here probably was meant for existing funds, but seems unused. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:07 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:10 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65636|0 |1 is obsolete| | Attachment #65637|0 |1 is obsolete| | Attachment #65638|0 |1 is obsolete| | Attachment #65639|0 |1 is obsolete| | Attachment #65640|0 |1 is obsolete| | Attachment #66783|0 |1 is obsolete| | Attachment #66930|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy --- Created attachment 66975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66975&action=edit Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel This patch adds a new Koha::Hold->cancel method and replaces the calls to C4::Reserves::CancelReserve with it. Test plan: - Add and cancel holds - Change priority of holds Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:14 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #24 from Marcel de Rooy --- Created attachment 66976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66976&action=edit Bug 19059: Remove CancelReserve - move tests Move the existing tests Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:18 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #25 from Marcel de Rooy --- Created attachment 66977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66977&action=edit Bug 19059: Remove CancelReserve - add new tests This is bonus, let's add new tests Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:21 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #26 from Marcel de Rooy --- Created attachment 66978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66978&action=edit Bug 19059: Remove CancelReserve - do not log DELETE There is something wrong with the DELETE log, it should be replaced with a FILLED log. Anyway, here we do not want it to be logged. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:25 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #27 from Marcel de Rooy --- Created attachment 66979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66979&action=edit Bug 19059: Remove CancelReserve It's done! Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:29 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #28 from Marcel de Rooy --- Created attachment 66980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66980&action=edit Bug 19059: Fix compilation issues Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:49:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:49:33 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #29 from Marcel de Rooy --- Created attachment 66981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66981&action=edit Bug 19059: [QA Follow-up] Typo holds for hold Resolves: The method found is not covered by tests at C4/Reserves.pm line 815. Test plan: Run t/db_dependent/Holds/CancelReserves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 09:51:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 07:51:31 +0000 Subject: [Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 --- Comment #30 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #22) > Will pass qa after feedback and adjustments. Added my signoff lines. Please look at comment21. In view of the fact that I will not be able to respond immediately in the coming weeks, passing QA now. The points mentioned are no real blockers.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 10:31:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 08:31:55 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #37 from Marcel de Rooy --- QA: Looking here again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:08:49 +0000 Subject: [Koha-bugs] [Bug 19276] New: CanBookBeIssued: unsuccessfully refers to borrower category_type X Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Bug ID: 19276 Summary: CanBookBeIssued: unsuccessfully refers to borrower category_type X Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org This code seems to be unused now: if ( $borrower->{'category_type'} eq 'X' && ( $item->{barcode} )) { # stats only borrower -- add entry to statistics table, and return issuingimpossible{STATS} = 1 . &UpdateStats({ ... Why? The key category_type does not exist. Or perhaps does no longer exist. Perhaps it has been refactored to a Koha object hash or something ? The check itself refers to a column in the categories table that formerly got included in the borrower hash. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:09:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:09:27 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15438 --- Comment #1 from Marcel de Rooy --- Found while testing 15438 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:09:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:09:27 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19276 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:32:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:32:19 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save ( delay field should accept numbers only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overdue rules do not save |Overdue rules do not save | |(delay field should accept | |numbers only) Severity|blocker |normal --- Comment #9 from Marc V?ron --- - The problem described in comment #1 was related to a local database issue. I fixed the database structure, and I can no longer reproduce the problem (not saving Email and Print flags) - It is possible to save changes with the exception of comment #5: It does not save when you put letters in the delay field (rather than numbers) - Changing importance to "normal" - Changing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:33:35 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save ( delay field should accept numbers only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 --- Comment #10 from Marc V?ron --- - Changing .... the title for better description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:52:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:52:24 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #38 from Marcel de Rooy --- Tested: OK INVALID_DATE OK due date before now LUKT NIET MET SIP OK $borrower->{'category_type'} eq 'X' => STATS OK DEBARRED OK EXPIRED OK DEBT OK OTHER_CHARGES NOT_FOR_LOAN OK no renewal OK already issued OK reserve waiting === 9300CNmarcel|COsecret|CPRMA| 11NN20170908 10400020170324 144000AOCPL|AA1|ABperl01|ACsecret| transaction date due date 121NNY20170908 103749AORMA|AA1|ABperl01|AJ|AH20170929 235900| old due date still OK? 121YNY20170908 104034AORMA|AA1|ABperl01|AJ|AH20171020 235900|AFItem already checked out to you: renewing item.| 120NUN20170908 104157AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : NO_MORE_RENEWALS|BLY| OBSERVATION: When the checkout fails, SIP returns a VALID_PATRON response BL=Y invalid due date: 11NN20170908 10400020171324 144000AOCPL|AA1|ABperl01|ACsecret| still OK OBSERVATION: The due date passed in the sip request is simply ignored. If I pass an old date or even an invalid date, the item is still checked out. statistical patron 121NNY20170908 105517AORMA|AA1|ABperl01|AJ|AH20170929 235900| Should fail. Bug 19276 opened (error in CanBookBeIssued) debarred 120NUN20170908 112612AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| Sep 8 11:17:21 master koha_sip[14160]: add_field: Undefined value being added to 'AJ' expired 120NUN20170908 112802AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| too much charges (noissuecharge) 120NUN20170908 113317AORMA|AA1|ABperl01|AJ|AH|AFPatron Blocked|BLY| Looks like the check in do_checkout is not even needed. Blocked before calling do_checkout. other charges resulting in DEBT and OTHER_CHARGES alert 120NUN20170908 113609AORMA|AA1|ABperl01|AJ|AH|AFOutstanding Fines block issue|BLY| not for loan 120NUN20170908 114107AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : NOT_FOR_LOAN|BLY| other patron reserve waiting 120NUN20170908 114331AORMA|AA1|ABperl01|AJ|AH|AFItem is on hold shelf for another patron.|BLY| hacking CanBookBeIssued returning BIGERROR in issuingimpossible 120NUN20170908 114606AORMA|AA1|ABperl01|AJ|AH|AFIssue failed : BIGERROR|BLY| hacking CanBookBeIssued returning BIGERROR in needsconfirmation 120NUN20170908 114726AORMA|AA1|ABperl01|AJ|AH|AFItem cannot be issued: BIGERROR|BLY| passing lowercase nonsense in both hashrefs WORKS 121NNY20170908 114834AORMA|AA1|ABperl01|AJ|AH20170929 235900| -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:52:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:52:48 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #39 from Marcel de Rooy --- notforloan is OK too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 11:59:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 09:59:59 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save ( delay field should accept numbers only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 --- Comment #11 from Marc V?ron --- (In reply to Marc V?ron from comment #4) > Reading: > https://dev.mysql.com/doc/refman/5.5/en/rename-table.html > ------- > RENAME TABLE changes internally generated foreign key constraint names and > user-defined foreign key constraint names that contain the string > ?tbl_name_ibfk_? to reflect the new table name. InnoDB interprets foreign > key constraint names that contain the string ?tbl_name_ibfk_? as internally > generated names. > > Foreign key constraint names that point to the renamed table are > automatically updated unless there is a conflict, in which case, the > statement fails with an error. A conflict occurs if the renamed constraint > name already exists. In such cases, you must drop and re-create the foreign > keys in order for them to function properly. > ------- > > Line 11590 in updatedatabase.pl renames table overduerules to > old_overduerules, then it creates a new table overduerules. > > The renaming action changed / renamed REFERENCES in constraints of > overduerules_transport_types (maybe in other tables as well?). > > That would explain that the error can not be reproduced on a fresh install > (i.e. an install later than 3.23.00.007). For the records: The database issue could be fixed with following hack: mysql> show create table overduerules_transport_types; (Verify that you see REFERENCES `old_overduerules`) mysql> RENAME TABLE overduerules TO old_overduerules; mysql> RENAME TABLE old_overduerules TO overduerules; mysql> show create table overduerules_transport_types; (Verify that REFERENCES has changed to REFERENCES `overduerules`) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:00:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:00:35 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #40 from Marcel de Rooy --- Think we still need a last; statement after this one too: $self->screen_msg("Item is reserved for another patron upon return."); $noerror = 0; But I tested this situation too. Better to exit the loop rightaway now? No blocker, but theoretically one error could be overwritten by another. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:02:14 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:02:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:02:17 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64265|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 66982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66982&action=edit Bug 15438 - Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field. The returns from C4::Circulation::CanBookBeIssued used to be structured as a hashref of entries like REASON => { data => 'foo', moredata => 'bar', }; Some entries still are. But many are now REASON => 1, data => 'foo', moredata => 'bar', The sip Checkout routine still assumed the former, as it reports any causes it was not aware of (to maintain support for a changing api) The data fields could leak into the screen message field of the response. e.g. the borrowernumber or surname of the borrower who has a hold on an issued title. Some real messages were getting obscured by this This patch sanatizes the return from from CanBookBeIssued by removing keys which are not all uppercase It also fixes a case where the key's data element was used for the screen message when we should use the key itself Updated the documentation of CanBookBeIssued to flag up the assumption re case and the fact that 3 elements rather than two may be returned The loop through the returned keys was a bit bogus so we now explicitly jump out if noerror is unset Signed-off-by: Marcel de Rooy Tested quite extensively. Test results put on Bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:02:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:02:23 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #42 from Marcel de Rooy --- Created attachment 66983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66983&action=edit Bug 15438: [QA Follow-up] Moving POD statement for CanBookBeIssued The statement for head3 NB ('nota bene'?) looks like a hash key in the list of possible return values for $needsconfirmation. Moved it up and prefixed it with IMPORTANT. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:10:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:10:41 +0000 Subject: [Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #43 from Marcel de Rooy --- QA Comment: Looks good to me apart from a few minor comments (see above). Just noting: When the checkout fails, SIP returns a VALID_PATRON response BL=Y. It does not when the checkout is ok. The due date passed in the sip request is simply ignored. If I pass an old date or even an invalid date, the item is still checked out. Opened bug 19276 for error in CanBookBeIssued re statistical patrons. We could perhaps use a unit test that helps us 'force' a policy somehow about the lowercase/uppercase returns from CanBookBeIssued. We are still missing a checkout test in t/db/SIP/Message. No time to write it here. In view of the age of this patch and the attention already given by several people before me, I am passing QA on this patch now too. (The last comment of Kyle could be read as a kind of signoff too btw.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:13:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:13:51 +0000 Subject: [Koha-bugs] [Bug 6936] allow selection by multiple item types or libraries when exporting bibs/ items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 Jeremy Evans changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Jeremy.evans at nibsc.org --- Comment #4 from Jeremy Evans --- We would support this. I just had to run the report 8 times to get the export files needed for 8 item types. It would be much easier to be able to multi-select the item types and get just one output file. In some cases I would also want to be able to filter by shelf location or ccode as well as library/item type. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:14:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:14:41 +0000 Subject: [Koha-bugs] [Bug 6936] allow selection by multiple item types or libraries when exporting bibs/ items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 --- Comment #5 from Jeremy Evans --- We would support this. I just had to run the report 8 times to get the export files needed for 8 item types. It would be much easier to be able to multi-select the item types and get just one output file. In some cases I would also want to be able to filter by shelf location or ccode as well as library/item type. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 12:14:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 10:14:57 +0000 Subject: [Koha-bugs] [Bug 6952] have MARC export tool display count of bibs it will export before exporting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6952 Jeremy Evans changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Jeremy.evans at nibsc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:10:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:10:25 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:13:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:13:44 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:13:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:13:48 +0000 Subject: [Koha-bugs] [Bug 18149] Move CountUsage calls to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65653|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 66984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66984&action=edit Bug 18149: Move CountUsage calls to Koha namespace After the introduction of Koha::Authorities->get_usage_count with bug 9988, we can now replace the remaining occurrences of CountUsage. At the same time we remove CountUsageChildren. This was an empty sub. The typo get_count_usage in a subtest title is adjusted. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Perform a search on authorities-home.pl and verify that you see plausible numbers for 'used in xx records'. [3] Click on Details for one authority. See the same number? [4] Do the same as in 2/3 for Authority search on OPAC. [5] Remember the authid and enter this in the record numbers box on tools/batch_delete_records.pl. Select Authorities and click Continue. The next form shows a column "Used in". Do you see the same count again? [6] Git grep CountUsage. You should see just one hit in a comment that can be kept in Koha/Authorities.pm. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:37:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:37:27 +0000 Subject: [Koha-bugs] [Bug 19277] New: TT syntax - Data is not ordered in notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 Bug ID: 19277 Summary: TT syntax - Data is not ordered in notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This issue has been highlighted by a failing test: ISSUESLIP displays checkouts in random order I thought it was because of dates comparison, but it comes from the following line in C4::Letters::_get_tt_params my $objects = $module->search( { $key => { -in => $values } } ); The DBMS will return data like there is ordered in the DB. For instance: select borrowernumber from borrowers where borrowernumber in (5, 3, 1); or select borrowernumber from borrowers where borrowernumber=5 or borrowernumber=3 or borrowernumber=1; will return 1, 3, 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:37:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:37:57 +0000 Subject: [Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |17966 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:37:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:37:57 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 [Bug 19277] TT syntax - Data is not ordered in notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:46:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:46:09 +0000 Subject: [Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:46:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:46:12 +0000 Subject: [Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 --- Comment #1 from Jonathan Druart --- Created attachment 66985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66985&action=edit Bug 19277: TT syntax - Display ordered data This issue has been highlighted by a failing test: ISSUESLIP displays checkouts in random order I thought it was because of dates comparison, but it comes from the following line in C4::Letters::_get_tt_params my $objects = $module->search( { $key => { -in => $values } } ); The DBMS will return data like there is ordered in the DB. For instance: select borrowernumber from borrowers where borrowernumber in (5, 3, 1); or select borrowernumber from borrowers where borrowernumber=5 or borrowernumber=3 or borrowernumber=1; will return 1, 3, 5 I did not find a generic way to do that, so used "ORDER BY FIELD" which will not be portable. Test plan: If you do not apply this patch, the tests will sometime fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 14:46:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 12:46:17 +0000 Subject: [Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 --- Comment #2 from Jonathan Druart --- Created attachment 66986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66986&action=edit Bug 19277: Make sure the tests will pass even if they are slow This patch was my first attempt to fix the issue. I think it is good to have it, if issue.timestamp and issue.issuedate are the same, the result will be orderd by issue_id. The tests highlight the fact that checkouts must be displayed in the correct order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:29:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:29:54 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #139 from Kyle M Hall --- Created attachment 66987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66987&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:33:50 +0000 Subject: [Koha-bugs] [Bug 14972] Limit by availability does not return results if *any* items are on-loan or lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14972 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:47:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:47:34 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137, 19196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 [Bug 19196] Add pagination helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:47:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:47:34 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 [Bug 19234] Add query parameters handling helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:47:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:47:34 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 [Bug 19234] Add query parameters handling helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:48:02 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18137 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:48:02 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19234 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 [Bug 19234] Add query parameters handling helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 15:59:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 13:59:57 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:00:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:00:01 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66820|0 |1 is obsolete| | Attachment #66821|0 |1 is obsolete| | Attachment #66822|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 66988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66988&action=edit Bug 19196: Unit tests This patch adds unit tests for the new pagination Mojo plugin. Sponsored-by: ByWater Solutions Sponsored-by: Camden County Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:00:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:00:13 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 --- Comment #17 from Kyle M Hall --- Created attachment 66990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66990&action=edit Bug 19196: Make plugin available to endpoints This patch just initializes the plugin on the main controller class so it is available for all endpoints to use. As it is not used, in order to test just restart plack and make sure the endpoints work (run the t/db_dependent/api/v1 tests). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:00:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:00:09 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 --- Comment #16 from Kyle M Hall --- Created attachment 66989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66989&action=edit Bug 19196: Add Koha::REST::Plugin::Pagination This patch introduces a Mojolicious plugin to be used on the REST api. It adds a helper method: add_pagination_headers ====================== When used, it adds a _Link_ header to the reponse with the calculated values for pagination, and X-Total-Count containing the total results like this: my $params = $c->validation->output; my $patrons = Koha::Patrons->search; my $count = $patrons->count; $c->add_pagination_headers({ total => $count, params => $params )}; To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/Koha/REST/Plugin/Pagination.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater solutions Sponsored-by: Camden County Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:13:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:13:38 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:13:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:13:41 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66752|0 |1 is obsolete| | Attachment #66753|0 |1 is obsolete| | Attachment #66754|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 66991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66991&action=edit Bug 19234: Unit tests for query parameters handling helpers This patch adds unit tests for the new query parameters handling Mojo plugin. Sponsored-by: Camden County Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:13:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:13:47 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #5 from Kyle M Hall --- Created attachment 66992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66992&action=edit Bug 19234: Add query parameters handling helpers This patch introduces a Mojolicious plugin to be used on the REST api. It adds a helper method: generate_dbic_query =================== When used, it generates what's needed to perform a search on DBIC/Koha::Objects like this: my $params = $c->validation->output; my ($filter, $attributes) = $c->generate_dbic_query($params); my $patrons = Koha::Patrons->search( $filter, $attributes ); It introduces a reserved word _exact_match that controls the generated $filter: - Default behaviour: right truncation on the query params - _exact_match=1: no truncation added. All the plugin's behaviour is tested. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater solutions Sponsored-by: Camden County Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:13:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:13:51 +0000 Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #6 from Kyle M Hall --- Created attachment 66993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66993&action=edit Bug 19234: (followup) Make Query plugin available to endpoints Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:17:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:17:18 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Component|Architecture, internals, |REST api |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:19:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:19:18 +0000 Subject: [Koha-bugs] [Bug 19278] New: Add a configurable default page size for endpoints Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278 Bug ID: 19278 Summary: Add a configurable default page size for endpoints Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Bug 19196 introduces a handy pagination handling plugin that would benefit from a syspref where a default page size can be specified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:19:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:19:35 +0000 Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19196 Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 [Bug 19196] Add pagination helpers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:19:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:19:35 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278 [Bug 19278] Add a configurable default page size for endpoints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 16:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 14:46:00 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #25 from Kyle M Hall --- (In reply to Jonathan Druart from comment #22) > (In reply to Josef Moravec from comment #2) > > And it is caused by bug 18438... > > If this is caused by template changes, why do we need to fix it at package > level? Which is why I'd suggest my fix on bug 19273 which is a one line template change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:10:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:10:20 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:12:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:12:21 +0000 Subject: [Koha-bugs] [Bug 19279] New: performance of linked items in search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Bug ID: 19279 Summary: performance of linked items in search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When catalog has fields 773 (461 in UNIMARC), those linked items are fetched for display in search results. Look like the code could be more performant by replacing item search by $9 with direct call with GetMarcItem(). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:12:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:12:36 +0000 Subject: [Koha-bugs] [Bug 19279] performance of linked items in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:12:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:12:45 +0000 Subject: [Koha-bugs] [Bug 19279] performance of linked items in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:14:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:14:05 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Severity|enhancement |critical Depends on| |17829 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- This may have bad side-effects. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:14:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:14:05 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:17:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:17:30 +0000 Subject: [Koha-bugs] [Bug 5560] pagination option for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5560 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:27:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:27:45 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:27:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:27:55 +0000 Subject: [Koha-bugs] [Bug 14798] Renew and checkin do not update parts of checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14798 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:32:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:32:30 +0000 Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 66994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66994&action=edit Bug 19278: Add RESTdefaultPageSize syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:32:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:32:37 +0000 Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 66995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66995&action=edit Bug 19278: Unit tests This patch introduces tests for a behaviour change in Koha::REST::Plugin::Pagination. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/Koha/REST/Plugin/Pagination.t => FAIL: Tests should fail without the followup patch applied Sponsored-by: Camden County Sponsored-by: Bywater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:32:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:32:44 +0000 Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 66996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66996&action=edit Bug 19278: Make the pagination plugin use RESTdefaultPageSize This bug introduces a new syspref RESTdefaultPageSize that is used on the Koha::REST::Plugin::Pagination plugin to default to a valid value for the page size if the param is not present on the query. This patch also considers the situation in which no 'page' param is passed, and no header should be added. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/Koha/REST/Plugin/Pagination.t => FAIL: Tests fail because the plugin doesn't behave as the tests expect. - Apply this patch - Run: k$ prove t/Koha/REST/Plugin/Pagination.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: Camden County Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:34:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:34:03 +0000 Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no, | |kyle at bywatersolutions.com Status|NEW |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:41:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:41:56 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:42:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:42:51 +0000 Subject: [Koha-bugs] [Bug 7029] searching : fuzzy et steming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7029 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:49:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:49:09 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:49:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:49:11 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:49:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:49:13 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 --- Comment #3 from Jonathan Druart --- Created attachment 66997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66997&action=edit Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour Bug 17829 must have been handle this specific case: GetMember set category_type, but now $borrower is a Koha::Patron unblessed and does not contain the category_type. The fix is to call ->category->category_type on the Koha::Patron object to be able to know if they are a statistic patrons. Test plan: Run the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:51:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:51:56 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 --- Comment #4 from Jonathan Druart --- Lowering the severity, it's not in stable releases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:52:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:52:03 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:53:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:53:14 +0000 Subject: [Koha-bugs] [Bug 19280] New: CanBookBeIssued must take a Koha::Patron in parameter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Bug ID: 19280 Summary: CanBookBeIssued must take a Koha::Patron in parameter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org We need to make subroutine from C4 use more Koha::Object objects Seeing bug 19276, starting here is a good start. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:53:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:53:17 +0000 Subject: [Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:53:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:53:20 +0000 Subject: [Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 --- Comment #2 from Kyle M Hall --- Created attachment 66998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66998&action=edit Bug 19275 - clubs table broken at the opac if public enrollment is not allowed Test Plan: 1. Create a template club and disable public enrollment 2. Create a club and add it a patron 3. login at the opac with this patron 4. Note the borked clubs table 5. Apply this patch 6. Refresh the page 7. Table is fixed! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:53:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:53:23 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |19276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:53:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:53:23 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:54:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:54:01 +0000 Subject: [Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:54:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:54:35 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 17:54:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 15:54:40 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 --- Comment #1 from Jonathan Druart --- Created attachment 66999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66999&action=edit Bug 19280: Pass a Koha::Patron to CanBookBeIssued We need to make subroutine from C4 use more Koha::Object objects Seeing bug 19276, starting here is a good start. Test plan: The tests should still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 18:48:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 16:48:48 +0000 Subject: [Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 18:48:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 16:48:50 +0000 Subject: [Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66985|0 |1 is obsolete| | --- Comment #3 from Lee Jamison --- Created attachment 67000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67000&action=edit Bug 19277: TT syntax - Display ordered data This issue has been highlighted by a failing test: ISSUESLIP displays checkouts in random order I thought it was because of dates comparison, but it comes from the following line in C4::Letters::_get_tt_params my $objects = $module->search( { $key => { -in => $values } } ); The DBMS will return data like there is ordered in the DB. For instance: select borrowernumber from borrowers where borrowernumber in (5, 3, 1); or select borrowernumber from borrowers where borrowernumber=5 or borrowernumber=3 or borrowernumber=1; will return 1, 3, 5 I did not find a generic way to do that, so used "ORDER BY FIELD" which will not be portable. Test plan: If you do not apply this patch, the tests will sometime fail Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 18:49:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 16:49:01 +0000 Subject: [Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66986|0 |1 is obsolete| | --- Comment #4 from Lee Jamison --- Created attachment 67001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67001&action=edit Bug 19277: Make sure the tests will pass even if they are slow This patch was my first attempt to fix the issue. I think it is good to have it, if issue.timestamp and issue.issuedate are the same, the result will be orderd by issue_id. The tests highlight the fact that checkouts must be displayed in the correct order. Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 19:11:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 17:11:52 +0000 Subject: [Koha-bugs] [Bug 15644] City dropdown default selection when modifying a patron matches only on city In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 8 19:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Sep 2017 17:11:54 +0000 Subject: [Koha-bugs] [Bug 15644] City dropdown default selection when modifying a patron matches only on city In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66010|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 67002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67002&action=edit [SIGNED-OFF] Bug 15644 - City dropdown default selection when modifying a patron matches only on city This patch modifies the include files which contain the form fields for city, state, zipcode, etc. shown on the patron entry screen. The files are modified so that the city/state/zip ", [% END %] "dt_cardnumber": - "[% data.cardnumber | html %]", + "[% To.json( data.cardnumber ) %]", But we should do it for all the data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 19:59:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 17:59:34 +0000 Subject: [Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 19:59:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 17:59:36 +0000 Subject: [Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67320|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 67408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67408&action=edit Bug 19307: Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass Signed-off-by: David Bourgault Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:05:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:05:40 +0000 Subject: [Koha-bugs] [Bug 19375] New: Show message when transfer is finished by checking in Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19375 Bug ID: 19375 Summary: Show message when transfer is finished by checking in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When book is in transfer and is in transfer and is checked in in target library, the transfer is finished by this operation. It would be nice to have some message about that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:23:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:23:41 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67309|0 |1 is obsolete| | --- Comment #39 from Tom?s Cohen Arazi --- Created attachment 67409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67409&action=edit Bug 19116: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:23:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:23:50 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67310|0 |1 is obsolete| | --- Comment #40 from Tom?s Cohen Arazi --- Created attachment 67410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67410&action=edit Bug 19116: (followup) Add tests to highlight the problem in CheckReserves Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:24:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:24:00 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67308|0 |1 is obsolete| | --- Comment #41 from Tom?s Cohen Arazi --- Created attachment 67411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67411&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:24:21 +0000 Subject: [Koha-bugs] [Bug 19376] New: Add 655$a (Genre/Form) to zebra search facets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Bug ID: 19376 Summary: Add 655$a (Genre/Form) to zebra search facets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: david.bourgault at inlibro.com Reporter: david.bourgault at inlibro.com This is a functionality we have with some clients, that we would like to push to the Koha community. It has no impact on libraries that ignore the 655$a tag, but enhances search filtering for those who do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:24:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:24:30 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:24:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:24:35 +0000 Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault at inlibro.com | |, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:27:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:27:16 +0000 Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:34:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:34:08 +0000 Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:34:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:34:10 +0000 Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #1 from David Bourgault --- Created attachment 67412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67412&action=edit Bug 19376 - Adds 655$a to Zebra facets Test plan: 0) Apply patch 1) Depending on your setup, copy the content of the following files to their counterparts in /etc/ (or where your Koha configuration files are) : /etc/zebradb/biblios/etc/bib1.att /etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml /etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xsl /etc/zebradb/marc_defs/marc21/biblios/record.abs /etc/zebradb/ccl.properties 2) Edit a record to use the 655$a MARC tag, if you don't already 3) In the OPAC or Intranet, execute a search that would get a hit on the record you edited. > You should see the "Genre form" filter appear on the left 4) Click on the entry under "Genre form" > You should now only see the records with the matching 655$a tag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 20:49:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 18:49:55 +0000 Subject: [Koha-bugs] [Bug 18724] Upload cover image failed without error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Could you confirm this is still valid? It certainly because the connection to the DBMS was lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:00:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:00:33 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Could you detail? It seems to work for me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:05:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:05:09 +0000 Subject: [Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:05:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:05:13 +0000 Subject: [Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 --- Comment #1 from Jonathan Druart --- Created attachment 67413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67413&action=edit Bug 18449: Rename misleading button when renewing If you hit the renewal limit on the renewal tab, the message gives you a message like: "Windows 8 / ( 50610018249545 ) has been renewed the maximum number of times by Johnny Test ( 12345678 )" And has a button that reads: "Ignore and continue" This button is misleading, as it may be interpreted as "ignore the limit and continue to renew the item". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:05:38 +0000 Subject: [Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Patch complexity|--- |String patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:09:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:09:13 +0000 Subject: [Koha-bugs] [Bug 18391] Error: You do not have permission to access this page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- I cannot recreate. We had something similar some months ago (I cannot find the bug number), so it is certainly fixed. Please reopen if it happens again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:12:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:12:04 +0000 Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- What wording do you suggest? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:20:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:20:36 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:20:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:20:41 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 --- Comment #4 from Jonathan Druart --- Created attachment 67414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67414&action=edit Bug 18342: Enable memcached by default for new installs Note that there is no way to create an install without memcached. As it is now considered as stable, there is no point to not use it. Test plan: Create a new Koha install and make sure memcached is enabled by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:20:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:20:52 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:23:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:23:27 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18342 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18342 | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 [Bug 18342] Set memcached as 'enabled' by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:23:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:23:27 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18250 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18250 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 [Bug 18250] koha-common should start after memcached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:37:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:37:30 +0000 Subject: [Koha-bugs] [Bug 19247] Feature release change tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 --- Comment #2 from Alex Buckley --- Created attachment 67415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67415&action=edit Bug 19247 - Followup: QA test tool fixes Test plan: 1. Run QA test tools and notice that all files pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:41:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:41:12 +0000 Subject: [Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357 --- Comment #3 from Nick Clemens --- I don't think the wording is the problem, it is the implementation - instead of being 'unlimited' the rules are applying as 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 21:56:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 19:56:11 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #17 from Nick Clemens --- (In reply to Jonathan Druart from comment #16) > Nick, maybe we should squash the patches and require another signoff? Sounds good to me, will try to get tests and do that shortly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 22:21:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 20:21:19 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 --- Comment #2 from David Bourgault --- Created attachment 67416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67416&action=edit Bug 17457 - Add tests in Acquisition.t Adds tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 22:23:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 20:23:22 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 --- Comment #3 from David Bourgault --- To test : 0) Previous test plan 6) prove t/db_dependent/Acquisition.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 22:25:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 20:25:07 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 --- Comment #4 from David Bourgault --- Created attachment 67417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67417&action=edit Bug 17457 - Small fix to prevent variable name collision -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 22:30:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 20:30:35 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67355|0 |1 is obsolete| | Attachment #67416|0 |1 is obsolete| | Attachment #67417|0 |1 is obsolete| | --- Comment #5 from David Bourgault --- Created attachment 67418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67418&action=edit Bug 17457 - Adv. Acquisition search with ISBN variations New patch : I did some git manipulation mistakes and previous patches wouldn't not apply, sorry :( Advanced acquisition search will now follow the "SearchWithISBNVariations" system preference. Test plan : 0) Make sure you have orders pending or completed 1) Enable SearchWithISBNVariations if it is not enabled 2) Search for one of your orders by its ISBN, it should appear 3) Search for the same order by a variation of its ISBN, I used this website to find it : http://www.hahnlibrary.net/libraries/isbncalc.html You should not get a result. 4) Apply patch 5) Repeat step 2-3. You should get a hit both times. 6) prove t/db_dependent/Acquisition.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 23:12:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 21:12:28 +0000 Subject: [Koha-bugs] [Bug 19247] Feature release change tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67415|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 23:12:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 21:12:56 +0000 Subject: [Koha-bugs] [Bug 19247] Feature release change tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 --- Comment #3 from Alex Buckley --- Created attachment 67419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67419&action=edit Bug 19247 - Followup: QA test tool fixes Test plan: 1. Run QA test tools and notice that all files pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 27 23:29:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 21:29:39 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 01:45:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 23:45:45 +0000 Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 01:45:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 23:45:47 +0000 Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67122|0 |1 is obsolete| | --- Comment #5 from Alex Buckley --- Created attachment 67420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67420&action=edit Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy Following the pattern introduced by bug 19300, we are going to move the OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy Test plan: Make sure the onshelfholds policy is correct when placing a hold Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 01:47:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Sep 2017 23:47:18 +0000 Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67123|0 |1 is obsolete| | --- Comment #6 from Alex Buckley --- Created attachment 67421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67421&action=edit Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed At this point the subroutine is not used anymore Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 04:59:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 02:59:27 +0000 Subject: [Koha-bugs] [Bug 19377] New: Remove $5 charge from sample item types Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Bug ID: 19377 Summary: Remove $5 charge from sample item types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When I'm testing Koha, I always use all the sample data, and invariably I wind up having to write off charges and update the book item type, since my trial checkouts incur rental charges because the sample item type of book has a $5 rental charge. It's a trivial change... but I'm sure this must annoy a lot of other developers as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 05:03:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 03:03:00 +0000 Subject: [Koha-bugs] [Bug 19377] Remove $5 charge from sample item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 05:03:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 03:03:02 +0000 Subject: [Koha-bugs] [Bug 19377] Remove $5 charge from sample item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 --- Comment #1 from David Cook --- Created attachment 67422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67422&action=edit Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 05:36:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 03:36:41 +0000 Subject: [Koha-bugs] [Bug 19378] New: Onboarding tool should allow configuration of holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19378 Bug ID: 19378 Summary: Onboarding tool should allow configuration of holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At the moment, the onboarding tool allows you to set on-shelf holds but it doesn't let you actually set up allowed hold counts which means holds are disabled by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 05:49:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 03:49:40 +0000 Subject: [Koha-bugs] [Bug 19379] New: Selenium test for the list workflow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19379 Bug ID: 19379 Summary: Selenium test for the list workflow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The Selenium test patch for this bug report will add a biblio and items to that biblio. A list will be created and then the item will be added to the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 05:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 03:58:42 +0000 Subject: [Koha-bugs] [Bug 19379] Selenium test for the list workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19379 --- Comment #1 from Alex Buckley --- Created attachment 67423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67423&action=edit Bug 19379 - Selenium test for the list workflow This selenium test logs into the Koha intranet and adds a biblio and items to that biblio. It then creates a list, and adds the item to the list confirming that the item was successfully added to the list. Test plan (this test plan includes how to install Selenium as well as how to run this test, for the benefit of people who have not got Selenium installed on their machines): 1. wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar 2. vim /etc/apt/sources.list.d/firefox.list 3. Paste into the file: deb http://packages.linuxmint.com debian import 4. sudo apt-get update 5. sudo apt-get install firefox 6. sudo apt-get install xvfb 7. Set the SELENIUM_PATH vartiable: SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar 8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & 9. DISPLAY=:1 java -jar $SELENIUM_PATH Note: This will start up the selenium server. Everytime you want to shutdown this terminal window and want to restart Selenium just run the step 9 command to restart the Selenium server 10. Open a new terminal window and write in: git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch build/master --single-branch --depth 1 11. cd Selenium-Remote-Driver 12. perl Makefile.PL 13. make 14. make test 15. sudo make install 16. Now everything is installed and you can set up for running the selenium tests 17. Create a superlibrarian user with the username koha and password koha 18. If your usual port configuration for the intranet and OPAC is 8081 and 8080 respectively then set the staffClientBaseURL and OPACBaseURL system preferences to localhost:8080 and localhost:80 respectively 19. sudo koha-shell 20. perl t/db_dependent/selenium/list_workflow.t 21. The test should pass. Note: The time_diff comments in the test output showing what the test is doing Note: If you have issues with installing Selenium and Selenium::Remote::Driver please write a comment on the bug report and I will be more than happy to create a screencapture video showing all the steps Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 06:24:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 04:24:08 +0000 Subject: [Koha-bugs] [Bug 19366] PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 06:24:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 04:24:11 +0000 Subject: [Koha-bugs] [Bug 19366] PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67404|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 67424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67424&action=edit Bug 19366: Do not block patron's detail update if EmailMustBeUnique If the pref PatronSelfRegistrationEmailMustBeUnique is set ("consider"), a patron is not allowed to register with an existing email address. The existing code is wrong and reject a patron that is updating their personal details with "This email address already exists in our database.", even if the patron did not modify their email address. This is caused by the query we made, we must search for patron with this email address but who is not the current patron. Test plan: - Set PatronSelfRegistrationEmailMustBeUnique to "consider" - Register a new patron with an existing email address => you should not be allowed - Use a non-existent email address => You should be allowed - Edit your patron details - Modify some infos => Should pass - Modify your email address with an existing one => You should not be allowed to do that Followed test plan, patches worked as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 08:37:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 06:37:21 +0000 Subject: [Koha-bugs] [Bug 19377] Remove $5 charge from sample item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Good idea. However, I think it should be fixed in all languages, not only in English, e.g.: ./installer/data/mysql/pl-PL/optional/sample_itemtypes.sql ./installer/data/mysql/es-ES/optional/sample_itemtypes.sql ./installer/data/mysql/de-DE/optional/sample_itemtypes.sql (there are more) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 08:41:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 06:41:35 +0000 Subject: [Koha-bugs] [Bug 19371] Change template table column text from 'Delete?' to 'Cancel?' on the patron circulation page holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67391|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 67425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67425&action=edit Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 08:42:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 06:42:01 +0000 Subject: [Koha-bugs] [Bug 19371] Change template table column text from 'Delete?' to 'Cancel?' on the patron circulation page holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 09:36:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 07:36:06 +0000 Subject: [Koha-bugs] [Bug 19377] Remove $5 charge from sample item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67422|0 |1 is obsolete| | --- Comment #3 from Magnus Enger --- Created attachment 67426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67426&action=edit Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Signed-off-by: Magnus Enger Applied the patch and looked at the change to the SQL-file. Looks good. That fine on books has surprised me one too many times! :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 09:36:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 07:36:03 +0000 Subject: [Koha-bugs] [Bug 19377] Remove $5 charge from sample item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 12:04:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 10:04:41 +0000 Subject: [Koha-bugs] [Bug 19380] New: Add transfer informations in ILS-DI GetRecords response Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Bug ID: 19380 Summary: Add transfer informations in ILS-DI GetRecords response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 12:05:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 10:05:31 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 --- Comment #1 from Julian Maurice --- Created attachment 67427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67427&action=edit Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new element inside //record/items/item that contains , and 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the element is not there. 7. prove t/db_dependent/ILSDI_Services.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 12:05:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 10:05:39 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 12:58:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 10:58:23 +0000 Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Or the other way around: Replace the built-in help files with links to the online documentation. We would probably be better off maintaining documentation in one place - the manual. Links to the manual could have "placeholders" for version and language (based on the language chosen by the user). The base URL of those links could also be configurable, so a somewhat paranoid library could link to their own local version of the manual, instead of being potentially tracked by a central server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:07:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:07:18 +0000 Subject: [Koha-bugs] [Bug 19381] Replace the built-in help files with links to the online manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19381 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11115 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:07:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:07:18 +0000 Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19381 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:07:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:07:10 +0000 Subject: [Koha-bugs] [Bug 19381] New: Replace the built-in help files with links to the online manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19381 Bug ID: 19381 Summary: Replace the built-in help files with links to the online manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org We would probably be better off maintaining documentation in one place - the manual. Links to the manual could have "placeholders" for version and language (based on the language chosen by the user). The base URL of those links could also be configurable, so a somewhat paranoid library could link to their own local version of the manual, instead of being potentially tracked by a central server. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:29:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:29:17 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:29:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:29:20 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #2 from Magnus Enger --- Created attachment 67428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67428&action=edit Bug 19260 - Restore ExpireReservesMaxPickupDelay It looks like bug 12063 accidentally removed the functionality of ExpireReservesMaxPickupDelay. This patch aims to restore it. To test: Before applying the patch: - Make sure ExpireReservesMaxPickUpDelay = "Don't allow" - Check out a book to a user - Add a reservastion on it for another user - Check the hold in the database. You should have: found = W, waitingdate = today, expirationdate = today + the value of ReservesMaxPickUpDelay The problem here is the expirationdate, it should be empty when ExpireReservesMaxPickUpDelay = "Don't allow". After applying the patch: - Repeat the steps above - expirationdate should now be NULL Please be creative when testing this. I am not sure I have seen all the possible concequences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:54:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:54:10 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Marijana Glavica -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:54:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:54:22 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 13:54:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 11:54:29 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 67429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67429&action=edit Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 14:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 12:14:33 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 14:16:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 12:16:00 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 14:27:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 12:27:25 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 14:32:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 12:32:10 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Marijana Glavica -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 14:32:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 12:32:22 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 14:32:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 12:32:30 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 67430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67430&action=edit Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica Signed-off-by: Marijana Glavica -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 14:58:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 12:58:53 +0000 Subject: [Koha-bugs] [Bug 14414] add field for processing fee for invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14414 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 15:01:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 13:01:39 +0000 Subject: [Koha-bugs] [Bug 19382] New: Add ability to block guarantees based on fees owed by guarantor and other guarantees Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Bug ID: 19382 Summary: Add ability to block guarantees based on fees owed by guarantor and other guarantees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 14570, 14577 Some libraries would like to not only block the circulation of a guarantor based on fines owed by guarantees, but would also like to block circulation for all guarantees as well. Basically, if a family as a whole reaches a certain threshold of fines, the entire family will be blocked from checking out items. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 15:01:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 13:01:39 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 15:01:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 13:01:39 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/ guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 15:02:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 13:02:05 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 15:10:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 13:10:53 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 --- Comment #8 from Marijana Glavica --- Sorry, I am not sure how this duplicate testing and signing-off has happened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 15:14:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 13:14:34 +0000 Subject: [Koha-bugs] [Bug 19383] New: Add ability to print hold receipts automatically Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Bug ID: 19383 Summary: Add ability to print hold receipts automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries don't wish to require librarians to confirm each hold during checkin. Instead they would like to only be alerted that a hold was filled. To implement this we should: 1) Implement new system preference to automatically confirm holds 2) Implement new system preference to automatically print confirmed hold receipts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 15:48:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 13:48:04 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #112 from Benjamin Rokseth --- Have tested on a live system now, with the NNCIPP backend module from Magnus, and after some fixes we can confirm the entire processof ordering from a remote library, receiving, lending out and returning the item has been successful. Have yet to test the opposite direction, but will have a second look on this module patch and hopefully sign off when we're done testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:06 +0000 Subject: [Koha-bugs] [Bug 19384] New: [OMNIBUS] Add Selenium tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Bug ID: 19384 Summary: [OMNIBUS] Add Selenium tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:41 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13691 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 [Bug 13691] Add some selenium scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:45 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:41 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:45 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 [Bug 19243] Selenium test for testing the administration module functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:48 +0000 Subject: [Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |19384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:48 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 [Bug 19189] Reserving and renewing item in OPAC selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:52 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:52 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 [Bug 19185] Web installer and onboarding tool selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:54 +0000 Subject: [Koha-bugs] [Bug 19184] Purchase workflow selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |19384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:54 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19184 [Bug 19184] Purchase workflow selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:57 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183 [Bug 19183] Acquisition module setup selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:47:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:47:57 +0000 Subject: [Koha-bugs] [Bug 19183] Acquisition module setup selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:48:02 +0000 Subject: [Koha-bugs] [Bug 19182] Item search in intranet and OPAC selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:48:02 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19182 [Bug 19182] Item search in intranet and OPAC selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:48:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:48:05 +0000 Subject: [Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:48:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:48:05 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181 [Bug 19181] Intranet and OPAC authentication selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:48:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:48:08 +0000 Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 [Bug 18974] Cataloging MARC21 record and adding item selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 17:48:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 15:48:08 +0000 Subject: [Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19384 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 [Bug 19384] [OMNIBUS] Add Selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 18:02:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 16:02:06 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |unspecified Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | Severity|enhancement |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 18:02:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 16:02:25 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 [Bug 12063] Change date calculation for reserve expiration to skip all holidays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 18:02:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 16:02:25 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 18:06:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 16:06:19 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #3 from Jonathan Druart --- We will need tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 19:21:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 17:21:37 +0000 Subject: [Koha-bugs] [Bug 17349] Add item screen does not populate in serials module when multiple late issues exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17349 Jason Palmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpalmer at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 19:49:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 17:49:01 +0000 Subject: [Koha-bugs] [Bug 19385] New: t/Calendar.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19385 Bug ID: 19385 Summary: t/Calendar.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The cache 'exception_holidays' may be populated when we run these tests, we need to clear it before the tests are run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 19:51:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 17:51:28 +0000 Subject: [Koha-bugs] [Bug 19385] t/Calendar.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19385 --- Comment #1 from Jonathan Druart --- Created attachment 67431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67431&action=edit Bug 19385: Fix random t/Calendar.t failure - clear the cache before The cache 'exception_holidays' may be populated when we run these tests, we need to clear it before the tests are run. Test plan: prove t/db_dependent/Circulation/CalcDateDue.t t/Calendar.t Without this patch, t/Calendar will fail with: # Failed test 'Exception holiday is not a closed day test' # at t/Calendar.t line 159. # got: '1' # expected: '0' # Looks like you failed 1 test of 38. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 19:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 17:51:23 +0000 Subject: [Koha-bugs] [Bug 19385] t/Calendar.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 19:51:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 17:51:42 +0000 Subject: [Koha-bugs] [Bug 19385] t/Calendar.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 19:51:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 17:51:51 +0000 Subject: [Koha-bugs] [Bug 19385] t/Calendar.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 20:21:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 18:21:17 +0000 Subject: [Koha-bugs] [Bug 19385] t/Calendar.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Pushed to master for 17.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 22:30:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 20:30:53 +0000 Subject: [Koha-bugs] [Bug 19386] New: t/db_dependent/SIP/Patron.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 Bug ID: 19386 Summary: t/db_dependent/SIP/Patron.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depending on the values used by TestBuilder, some tests from t/db_dependent/SIP/Patron.t can fail # Failed test 'Not blocked without overdues when set to 'Don't block'' # at t/db_dependent/SIP/Patron.t line 55. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'confirmation'' # at t/db_dependent/SIP/Patron.t line 61. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'Block'' # at t/db_dependent/SIP/Patron.t line 67. # got: '0' # expected: '1' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 22:33:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 20:33:29 +0000 Subject: [Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 22:33:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 20:33:32 +0000 Subject: [Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 --- Comment #1 from Jonathan Druart --- Created attachment 67432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67432&action=edit Bug 19386: Prevent t/db_dependent/SIP/Patron.t to fail randomly Depending on the values used by TestBuilder, some tests from t/db_dependent/SIP/Patron.t can fail # Failed test 'Not blocked without overdues when set to 'Don't block'' # at t/db_dependent/SIP/Patron.t line 55. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'confirmation'' # at t/db_dependent/SIP/Patron.t line 61. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'Block'' # at t/db_dependent/SIP/Patron.t line 67. # got: '0' # expected: '1' Caused by this check in C4::SIP::ILS::Patron->new 110 for (qw(EXPIRED CHARGES CREDITS GNA LOST DBARRED NOTES)) { 111 ($flags->{$_}) or next; [...] 115 if ($flags->{$_}->{noissues}) { 116 foreach my $toggle (qw(charge_ok renew_ok recall_ok hold_ok inet)) { 117 $ilspatron{$toggle} = 0; # if we get noissues, disable everything 118 } 119 } 120 } Test plan: Execute several times (50x?) these tests. Without this patch they may fail With this patch they must never fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 28 22:34:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 20:34:03 +0000 Subject: [Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 --- Comment #2 from Jonathan Druart --- Note: We should certainly add these values as default for TestBuilder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 01:16:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Sep 2017 23:16:41 +0000 Subject: [Koha-bugs] [Bug 18061] Enhance items page (moredetail.pl) with Bootstrap 3 panels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Sarah Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sarahkirby at catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Sarah Kirby --- Bug 18061 - Enhance items page (moredetail.pl) with Bootstrap 3 panels 60005 - Bug 18061: Restyle catalogue moredetail page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18061: Restyle catalogue moredetail page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 18061: Restyle catalogue moredetail page The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18061-Restyle-catalogue-moredetail-page-ctght0.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 04:38:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 02:38:36 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 --- Comment #2 from Alex Buckley --- Created attachment 67433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67433&action=edit Bug 19243 - Followup moving common Selenium functions into a seperate module In this patch a module t/lib/Selenium.pm has been created and it contains the auth, patron_auth, patron_opac_auth, cleaup, time_difffunctions which are common to other Selenium text scripts. Also a function to wait for an element to be found before it is interacted with was created and it is called pause_driver At present this pause_driver function throws an error in the test output saying that it cannot find an element and then it fails. Test plan (this test plan includes how to install Selenium as well as how to run this test, for the benefit of people who have not got Selenium installed on their machines): 1. wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar 2. vim /etc/apt/sources.list.d/firefox.list 3. Paste into the file: deb http://packages.linuxmint.com debian import 4. sudo apt-get update 5. sudo apt-get install firefox 6. sudo apt-get install xvfb 7. Set the SELENIUM_PATH vartiable: SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar 8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & 9. DISPLAY=:1 java -jar $SELENIUM_PATH Note: This will start up the selenium server. Everytime you want to shutdown this terminal window and want to restart Selenium just run the step 9 command to restart the Selenium server 10. Open a new terminal window and write in: git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch build/master --single-branch --depth 1 11. cd Selenium-Remote-Driver 12. perl Makefile.PL 13. make 14. make test 15. sudo make install 16. Now everything is installed and you can set up for running the selenium tests 17. Drop and recreate the Koha database and restart memcached 18. Go through the web installer installing all sample data and onboarding tool 19. Create a superlibrarian user with the username koha and password koha 20. If your usual port configuration for the intranet and OPAC is 8081 and 8080 respectively then set the staffClientBaseURL and OPACBaseURL system preferences to localhost:8080 and localhost:80 respectively 21. sudo koha-shell 22. perl t/db_dependent/selenium/administration_tasks.t 23. The test should pass. Note: The time_diff comments in the test output showing what the test is doing Note: If you have issues with installing Selenium and Selenium::Remote::Driver please write a comment on the bug report and I will be more than happy to create a screencapture video showing all the steps Note: Warns in front of the $driver->get_title() function have been implemented because during troubleshooting they were found to be an effective solution for stopping the test from failing due to not being able to find an element on the page. If anyone can suggest an alternative to using these warns please do Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 04:42:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 02:42:03 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 05:43:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 03:43:12 +0000 Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Sarah Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |sarahkirby at catalyst.net.nz --- Comment #3 from Sarah Kirby --- After applying the patch and running the updatedatabase.pl script only the publication date is showing and the receival date is not shown on the OPAC detail page. Where are you wanting the receival date to be displayed? It wasn't showing under the Subscriptions tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 10:00:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 08:00:59 +0000 Subject: [Koha-bugs] [Bug 19350] Holds without link in 773 trigger SQL::Abstract::puke In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19350 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Please write tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 10:12:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 08:12:10 +0000 Subject: [Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616 --- Comment #19 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #18) > Fridolin, now that bug 18653 is resolved, would you reconsider? Depends now on Bug 18956 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 10:46:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 08:46:04 +0000 Subject: [Koha-bugs] [Bug 19013] sample_data.sql inserts patrons with guarantorid that do not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 10:47:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 08:47:12 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 --- Comment #3 from Alex Buckley --- Hi Jonathan I have moved out the common Selenium functions (auth, patron_auth, patron_opac_auth, fill_form, cleanup) and have placed them in t/lib/Selenium.pm. Running the tests after doing that I found that they passed successfully. I will continue working on this tommorow but I have not been able to get the wait_until function working correctly after a lot of troubleshooting ( you can see it in t::lib::Selenium.pm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 10:54:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 08:54:05 +0000 Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #11 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 10:57:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 08:57:18 +0000 Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:00:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:00:39 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:03:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:03:52 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #32 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:09:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:09:10 +0000 Subject: [Koha-bugs] [Bug 19003] Add a TestBuilder default for borrowers.login_attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19003 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:13:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:13:25 +0000 Subject: [Koha-bugs] [Bug 18857] Have "actions" at both ends of the circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18857 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:15:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:15:33 +0000 Subject: [Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Bug 19255 depends on bug 18980, which changed state. Bug 18980 Summary: Add an explanation when Anyone permission has no actual effect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:15:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:15:32 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #21 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:19:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:19:24 +0000 Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66856|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 67434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67434&action=edit Bug 15173: Restore SubfieldsToAllowForRestrictedEditing Bug 7673 introduced SubfieldsToAllowForRestrictedEditing but bug 12176 broke it assuming that only selects were impacted by this feature. Test plan: Go back on bug 7673 and confirm that SubfieldsToAllowForRestrictedEditing is working as expected with this patch applied. Signed-off-by: Lee Jamison For clarification, the item fields that are entered in SubfieldsToAllowForRestrictedEditing should EXCLUDE the desired fields you want to disable. Test plan (updated to test the scenario in the bug Description): 1. Create a patron with only the following permissions: - catalogue (Required for staff login) - editcatalogue -> edit_catalogue - editcatalogue -> edit_items - editcatalogue -> edit_items_restricted 2. Navigate to Administration -> Global system preferences -> Cataloging -> Record Structure -> SubfieldsToAllowForRestrictedEditing 3. In the input field for SubfieldsToAllowForRestrictedEditing enter in all the 952 fields EXCEPT the ones desired to be disabled. In this case, we want to disallow editing of 952$2, 952$a, 952$b, 952$e, 952$h, and 952$o so we enter the following into the SubfieldsToAllowForRestrictedEditing (without quotes) "952$0 952$1 952$3 952$4 952$5 952$7 952$8 952$c 952$d 952$f 952$g 952$i 952$j 952$p 952$t 952$u 952$v 952$w 952$x 952$y 952$z" 4. Click Save all Cataloging preferences 5. Login to the staff client as the created restricted editing patron 6. Edit an item 7. Note that all fields except for the ones excluded from the syspref are editable Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:22:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:22:54 +0000 Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Julian Maurice --- Note that restricted borrowers are still able to edit every subfields if they know how to use a browser to manipulate the DOM (removing the 'readonly' attribute is enough). But that may be fixed in another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:25:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:25:27 +0000 Subject: [Koha-bugs] [Bug 5471] Quotes in tags cause moderation approval/rejection to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:28:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:28:56 +0000 Subject: [Koha-bugs] [Bug 19042] Silence warnings t/db_dependent/Letters.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19042 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:31:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:31:37 +0000 Subject: [Koha-bugs] [Bug 19329] IntranetSlipPrinterJS label is obsoleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:32:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:32:52 +0000 Subject: [Koha-bugs] [Bug 19047] Fix AddBiblio call in Reserves.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19047 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:34:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:34:10 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:39:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:39:19 +0000 Subject: [Koha-bugs] [Bug 19329] IntranetSlipPrinterJS label is obsoleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67199|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 67435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67435&action=edit Bug 19329: Update IntranetSlipPrinterJS system preference description. Test plan: 0) Apply the patch 1) Go to administration -> system preferences -> staff client 2) Read the description by IntranetSlipPrinterJS and confirm it's right Signed-off-by: Marc V?ron Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:39:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:39:29 +0000 Subject: [Koha-bugs] [Bug 19329] IntranetSlipPrinterJS label is obsoleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:40:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:40:40 +0000 Subject: [Koha-bugs] [Bug 19074] Show patron category description instead of code in patron batch modification list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19074 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Patch does not apply on 17.05.x because of Bug 17829. Since this is a minor, I propose to set as resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:43:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:43:27 +0000 Subject: [Koha-bugs] [Bug 19070] Fix Circulation/Branch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19070 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:45:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:45:03 +0000 Subject: [Koha-bugs] [Bug 19070] Fix Circulation/Branch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19070 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19071 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:45:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:45:03 +0000 Subject: [Koha-bugs] [Bug 19071] Fix Circulation/issue.t and Members/IssueSlip.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19071 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19070 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:48:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:48:15 +0000 Subject: [Koha-bugs] [Bug 19071] Fix Circulation/issue.t and Members/IssueSlip.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19071 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:50:14 +0000 Subject: [Koha-bugs] [Bug 13012] suggestion.suggesteddate should be set to NOW if not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13012 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:52:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:52:27 +0000 Subject: [Koha-bugs] [Bug 18941] C4:: Budgets GetBudgetByCode should return active budgets over inactive budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18941 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #11 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:54:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:54:39 +0000 Subject: [Koha-bugs] [Bug 18985] SQL reports 'Last edit' and 'Last run' columns sort alphabetically, not chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18985 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 11:56:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 09:56:56 +0000 Subject: [Koha-bugs] [Bug 19027] Circulation rules: Better wording for standard rules for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19027 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #10 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:00:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:00:28 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:04:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:04:22 +0000 Subject: [Koha-bugs] [Bug 18292] Tests do not need to return 1; In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #25 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. I push this enh to stable in order to avoid future rebase errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:15:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:15:09 +0000 Subject: [Koha-bugs] [Bug 18469] Suspend all holds when specifying a date to resume hold does not keep date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:18:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:18:11 +0000 Subject: [Koha-bugs] [Bug 9409] koha-create --request-db should be able to accept a dbhost option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:27:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:27:22 +0000 Subject: [Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #16 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:27:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:27:23 +0000 Subject: [Koha-bugs] [Bug 18877] Add documentation on dbhost for koha-create help In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877 Bug 18877 depends on bug 14533, which changed state. Bug 14533 Summary: koha-create --use-db option shouldn't create any db or db user https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:27:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:27:58 +0000 Subject: [Koha-bugs] [Bug 18877] Add documentation on dbhost for koha-create help In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:31:05 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 12:35:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 10:35:25 +0000 Subject: [Koha-bugs] [Bug 18817] Update links in the help files for the new 17.11 manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #24 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:27:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:27:19 +0000 Subject: [Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:29:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:29:01 +0000 Subject: [Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:29:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:29:41 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #54 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:30:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:30:54 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #22 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:35:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:35:37 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:46:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:46:50 +0000 Subject: [Koha-bugs] [Bug 19381] Replace the built-in help files with links to the online manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19381 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:47:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:47:27 +0000 Subject: [Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:50:05 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66908|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 67436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67436&action=edit Bug 19120: Add tests to reproduce the problem TEST PLAN --------- 1) apply this patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS! -- This proves the test works. 3) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:50:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:50:09 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66909|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 67437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67437&action=edit Bug 19120: Leave cancelled ordered items alone when reopening basket TEST PLAN --------- 1) Apply first patch 2) prove t/db_dependent/Acquisition/close_reopen_basket.t -- FAILS 3) Apply this patch 4) prove t/db_dependent/Acquisition/close_reopen_basket.t -- SUCCESS! 5) run koha qa test tools Followed test plan, patch worked as described Signed-off-by: Alex Buckley Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:50:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:50:24 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:52:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:52:22 +0000 Subject: [Koha-bugs] [Bug 19357] Error when submitting biblionumbers to batch record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:57:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:57:04 +0000 Subject: [Koha-bugs] [Bug 19357] Error when submitting biblionumbers to batch record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 --- Comment #5 from Julian Maurice --- Created attachment 67438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67438&action=edit Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:57:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:57:16 +0000 Subject: [Koha-bugs] [Bug 19357] Error when submitting biblionumbers to batch record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:58:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:58:18 +0000 Subject: [Koha-bugs] [Bug 19334] circulation history doesn' t set biblionumber so left navigation is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19334 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:59:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:59:25 +0000 Subject: [Koha-bugs] [Bug 19334] circulation history doesn' t set biblionumber so left navigation is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19334 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67312|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 67439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67439&action=edit Bug 19334 - circulation history doesn't set biblionumber so left navigation is broken Navigation on the left (Normal, MARC, etc...) needs biblionumber in template variables to work. Test: 1. go to checkout history for any biblio 2. verify that normal, MARC, etc links on the left no longer work due to missing biblionumber in URL 3. apply patch and test it again Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:59:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:59:39 +0000 Subject: [Koha-bugs] [Bug 19334] circulation history doesn' t set biblionumber so left navigation is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19334 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 13:59:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 11:59:42 +0000 Subject: [Koha-bugs] [Bug 19323] subscription edit permission issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:00:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:00:02 +0000 Subject: [Koha-bugs] [Bug 19323] subscription edit permission issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:00:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:00:04 +0000 Subject: [Koha-bugs] [Bug 19323] subscription edit permission issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67153|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 67440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67440&action=edit Bug 19323: subscription edit permission issue If a librarian has edit_subscription but not create_subscription : When trying to edit a subscription, after saving permission is denied. This is because permissions in serials/subscription-add.pl depends on arg 'op' and on edit this arg starts with 'modify' but changes to 'modsubscription' when saving. Test plan : - Create a user with staff access - Define its permissions on serials : only edit_subscription - Edit a subscription - Click 'Next' - Click 'Test prediction pattern' - Click 'Save subscription' => Without patch you get to page serials/subscription-add.pl with permission denied => With patch subscription is saved and you get to subscription details page Signed-off-by: Caroline Cyr La Rose Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:04:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:04:24 +0000 Subject: [Koha-bugs] [Bug 19387] New: DAMNIT!! Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19387 Bug ID: 19387 Summary: DAMNIT!! Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: sil3ntpeople at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 67441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67441&action=edit 99syndicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:04:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:04:44 +0000 Subject: [Koha-bugs] [Bug 19366] PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:06:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:06:38 +0000 Subject: [Koha-bugs] [Bug 19366] PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:06:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:06:41 +0000 Subject: [Koha-bugs] [Bug 19366] PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67424|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 67442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67442&action=edit Bug 19366: Do not block patron's detail update if EmailMustBeUnique If the pref PatronSelfRegistrationEmailMustBeUnique is set ("consider"), a patron is not allowed to register with an existing email address. The existing code is wrong and reject a patron that is updating their personal details with "This email address already exists in our database.", even if the patron did not modify their email address. This is caused by the query we made, we must search for patron with this email address but who is not the current patron. Test plan: - Set PatronSelfRegistrationEmailMustBeUnique to "consider" - Register a new patron with an existing email address => you should not be allowed - Use a non-existent email address => You should be allowed - Edit your patron details - Modify some infos => Should pass - Modify your email address with an existing one => You should not be allowed to do that Followed test plan, patches worked as described Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:07:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:07:06 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:07:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:07:58 +0000 Subject: [Koha-bugs] [Bug 19388] New: Error in course details on OPAC if an item is checked-out Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 Bug ID: 19388 Summary: Error in course details on OPAC if an item is checked-out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: mglavica at ffzg.hr QA Contact: testopia at bugs.koha-community.org In course reserves, if an item which was added to a course is checked out, it is not possible to show details for that course on OPAC. The error says: "Template process failed: undef error - The method onsite_checkout is not covered by tests! at /home/koha/src/C4/Templates.pm line 121." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:09:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:09:47 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:09:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:09:50 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67430|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 67443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67443&action=edit Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template Bug 15801 removes the 2 lines that were necessary to retrieve the framework selected by the user and pass it to the template. All bibliographic records created when adding an order to the basket using an external source used the default framework. Test plan: Add an order to a basket from an external source Select another framework than the default one => Without this patch, whatever the framework you picked, the default one is used => With this patch applied the framework code you will pick will be used Signed-off-by: Marijana Glavica Signed-off-by: Marijana Glavica Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:15:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:15:50 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #2 from Josef Moravec --- Comment on attachment 67373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67373 Bug 19368 - Ignore words when sorting serial search Review of attachment 67373: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19368&attachment=67373) ----------------------------------------------------------------- Nice enhancement David. Just few comments/issues, all looks easy to fix ;) In update database file, don't use INSERT IGNORE, it is mysqlism. Better to make update files using perl skeleton and do needed db tests in the code. ::: installer/data/mysql/sysprefs.sql @@ +475,4 @@ > ('SelfCheckTimeout','120','','Define the number of seconds before the Web-based Self Checkout times out a patron','Integer'), > ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'), > ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'), > +('SerialSortIgnoreWords','des du de la le les leur d l an a the',NULL,'Words to ignore in serial search','Free'), Your commit message says, it's empty by default... which is good idea IMHO ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt @@ +38,4 @@ > return confirm(_("Are you sure you want to reopen this subscription?")); > }); > }); > + $ typo? ::: serials/serials-search.pl @@ +139,5 @@ > + } > + $subsctitle =~ s/^\s+//; > + $sub->{titlesort} = ucfirst($subsctitle); > + > + warn $subsctitle; please, remove this warn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:16:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:16:10 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:19:20 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:19:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:19:22 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66907|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 67444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67444&action=edit Bug 19261 - never hide biblionumber field in view policy Followed test plan and biblionumber subfield 999c is visible in OPAC irrespective of visibility now. Patch applies and works as expected. Signed-off-by: Dilan Johnpull? Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:19:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:19:59 +0000 Subject: [Koha-bugs] [Bug 18318] Wrong unicode tokenization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|tomascohen at gmail.com |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:21:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:21:08 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:25:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:25:38 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:25:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:25:41 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67028|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 67445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67445&action=edit Bug 19276: (bug 17829 follow-up) Fix Statistic patrons behaviour Bug 17829 must have been handle this specific case: GetMember set category_type, but now $borrower is a Koha::Patron unblessed and does not contain the category_type. The fix is to call ->category->category_type on the Koha::Patron object to be able to know if they are a statistic patrons. Test plan: Run the tests Tests pass, as does QA test tool Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:28:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:28:32 +0000 Subject: [Koha-bugs] [Bug 18354] Adding item type attribute to cover image div In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- If SEARCH_RESULT.itemtype can be undefined, is class "itemtype_" valid ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:30:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:30:14 +0000 Subject: [Koha-bugs] [Bug 16463] OPAC discharge page should warn the user about checkouts before they request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:30:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:30:23 +0000 Subject: [Koha-bugs] [Bug 16463] OPAC discharge page should warn the user about checkouts before they request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:30:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:30:16 +0000 Subject: [Koha-bugs] [Bug 16463] OPAC discharge page should warn the user about checkouts before they request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67033|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 67446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67446&action=edit Bug 16463: Replace discharge link with error message if user has checked out items To test: 1) Ensure the useDischarge syspref is enabled 2) Check out an item to a borrower 3) Log in to the OPAC as this borrower 4) Click the 'ask for a discharge' link in the nav 5) Click the 'Ask for a discharge' link 6) Notice you cannot be discharged because you have checkouts 7) Apply the patch, click the 'ask for a discharge' link in the nav 8) Notice the link has been replaced with an appropriate error message 9) Attempt to force the discharge URL: /cgi-bin/koha/opac-discharge?op=request 10) Notice the message and you cannot be discharged. 11) Confirm that when you check in your item, the discharge link shows again and works as expected. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:30:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:30:38 +0000 Subject: [Koha-bugs] [Bug 18581] Add standard edit and delete buttons to suggestions list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18581 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #5 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:31:12 +0000 Subject: [Koha-bugs] [Bug 19317] Move of checkouts - Remove leftover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19317 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:35:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:35:43 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #3 from David Bourgault --- Created attachment 67447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67447&action=edit Bug 19368 - Correction on QA feedback - Removed 'IGNORE' in the atomicupdate SQL. There is currently no other systempreference by that name in master so that should work fine - Removed leftover test values from syspref.sql - Removed extra '$' in serial-search.tt - Removed leftover 'warn' in serial-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:35:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:35:40 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 14:35:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 12:35:45 +0000 Subject: [Koha-bugs] [Bug 18318] Wrong unicode tokenization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Julian Maurice --- The patch does what it says, but it adds a dependency (ICU plugin) without mentioning it anywhere (AFAIK). I don't know what is the best place for this (https://wiki.koha-community.org/wiki/Elasticsearch maybe ?), but it must be written somewhere. Marking as Failed QA for now. I will pass QA as soon as there is some kind of documentation for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:04:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:04:42 +0000 Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 --- Comment #4 from David Bourgault --- (In reply to Sarah Kirby from comment #3) > After applying the patch and running the updatedatabase.pl script only the > publication date is showing and the receival date is not shown on the OPAC > detail page. > > Where are you wanting the receival date to be displayed? It wasn't showing > under the Subscriptions tab. It's supposed to be displayed in the 'Date' column of the table under 'subscriptions'. It replaces the existing date (which is the receival date). Did you check that the systempreference OPACSerialDisplayPublishedDate was set to 1 ('publication date' in the web interface). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:13:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:13:58 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #32 from Fridolin SOMERS --- Looks fine to me for patron create. But years range is strange when a date of birth already exists, say "01/01/1950", years range is 1850 to 1950. I propose a follow-up to set range from current year and 120 (instead of 100) years earlier. Some people may have more than 100 years,maybe more often in the future. (Lets hope we will soon all be cyborgs ~(o_o)~ ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:15:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:15:04 +0000 Subject: [Koha-bugs] [Bug 18318] Wrong unicode tokenization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Julian Maurice from comment #4) > The patch does what it says, but it adds a dependency (ICU plugin) without > mentioning it anywhere (AFAIK). > I don't know what is the best place for this > (https://wiki.koha-community.org/wiki/Elasticsearch maybe ?), but it must be > written somewhere. > > Marking as Failed QA for now. I will pass QA as soon as there is some kind > of documentation for this. The commit message mentions itbut definitely worth documenting in a more publicly available place. I've adjusted the docs (https://wiki.koha-community.org/wiki/Elasticsearch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:15:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:15:38 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 --- Comment #33 from Fridolin SOMERS --- Created attachment 67448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67448&action=edit Bug 18447: (follow-up) years range not dependent on current value Bug 18447 sets for date of birth a year range "c-100:c" meaning current year and 100 years earlier. This is good when imput is empty. But when input already contains a date, say "01/01/1950", years range is 1850 to 1950. This patch sets for date of birth a year range "-120:+0" to not be dependent on current value. Some people may have more than 100 years (maybe more often in the future) so i choose to propose maximum 120 years old. To test : 1) Go to intranet 2) Create a new patron 3) Click on date picker on "Date of birth" input 4) Look at available years in combobox, you see from 1897 to 2017 5) Edit an existing patron with for example date of birth in 1950 6) Repeat 3) and 4) 7) Go to OPAC 8) Login with a patron with for example date of birth in 1950 9) Go to "your personal details" 10) Repeate 3) and 4) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:16:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:16:01 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:16:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:16:17 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:24:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:24:07 +0000 Subject: [Koha-bugs] [Bug 18318] Wrong unicode tokenization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 --- Comment #6 from Julian Maurice --- (In reply to Tom?s Cohen Arazi from comment #5) > I've adjusted the docs (https://wiki.koha-community.org/wiki/Elasticsearch). Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:24:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:24:11 +0000 Subject: [Koha-bugs] [Bug 18318] Wrong unicode tokenization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67344|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 67449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67449&action=edit Bug 18318: Unicode support for Elasticsearch You must install the icu plugin for elasticsearch https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu.html Once installed, apply this patch Reindex your data, deleting the existing indexes perl /home/vagrant/kohaclone/misc/search_tools/rebuild_elastic_search.pl -d Find (or add) some titles with accented characters Verify that a search for the exact character or the unaccented version works Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:24:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:24:23 +0000 Subject: [Koha-bugs] [Bug 18318] Wrong unicode tokenization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:25:06 +0000 Subject: [Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:26:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:26:25 +0000 Subject: [Koha-bugs] [Bug 19317] Move of checkouts - Remove leftover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19317 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:26:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:26:26 +0000 Subject: [Koha-bugs] [Bug 19126] Fix Members.t with IndependentBranches set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19126 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:26:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:26:28 +0000 Subject: [Koha-bugs] [Bug 19317] Move of checkouts - Remove leftover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19317 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67139|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 67450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67450&action=edit Bug 19317: (bug 18966 follow-up) Remove leftover Nothing important here, but this line should have been removed by bug 18966: 2177 # Update the fines 2178 $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); The issue_id is now the same when moved from issues to old_issues. We do not need to update the accountlines table. No test plan here, you need to understand previous changes to validate this patch. Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:29:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:29:39 +0000 Subject: [Koha-bugs] [Bug 19118] Due to wrong variable name passed vendor name is not coming in browser title bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19118 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:33:20 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #21 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:35:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:35:00 +0000 Subject: [Koha-bugs] [Bug 19088] plugins-upload.pl causes uninitialized value noise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #9 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:35:32 +0000 Subject: [Koha-bugs] [Bug 19025] Move C4::Reserves::GetReserveInfo to Koha::Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19025 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |RESOLVED --- Comment #7 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:35:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:35:33 +0000 Subject: [Koha-bugs] [Bug 19055] GetReservesToBranch is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19055 Bug 19055 depends on bug 19025, which changed state. Bug 19025 Summary: Move C4::Reserves::GetReserveInfo to Koha::Holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19025 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:35:32 +0000 Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Bug 17728 depends on bug 19025, which changed state. Bug 19025 Summary: Move C4::Reserves::GetReserveInfo to Koha::Holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19025 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:36:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:36:21 +0000 Subject: [Koha-bugs] [Bug 17969] Refactor the way <> is generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:36:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:36:22 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Bug 17967 depends on bug 17969, which changed state. Bug 17969 Summary: Refactor the way <> is generated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:37:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:37:12 +0000 Subject: [Koha-bugs] [Bug 19018] Can we make XSLT_Handler a little bit less verbose ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19018 Bug 19018 depends on bug 17807, which changed state. Bug 17807 Summary: Use XSLT_Handler in oai.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:37:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:37:12 +0000 Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #25 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:38:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:38:29 +0000 Subject: [Koha-bugs] [Bug 18422] Add Select2 to authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:38:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:38:59 +0000 Subject: [Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #29 from Fridolin SOMERS --- Enhancement Bug 18665 not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:41:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:41:45 +0000 Subject: [Koha-bugs] [Bug 18687] Translatability: abbr tag should not contain lang attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18687 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:45:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:45:24 +0000 Subject: [Koha-bugs] [Bug 18754] Translatability: Get rid of exposed tt directives in opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:45:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:45:52 +0000 Subject: [Koha-bugs] [Bug 18776] Translatability: Get rid of exposed tt directives in opac-advsearch.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18776 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:46:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:46:46 +0000 Subject: [Koha-bugs] [Bug 18776] Translatability: Get rid of exposed tt directives in opac-advsearch.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18776 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:48:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:48:49 +0000 Subject: [Koha-bugs] [Bug 18777] Translatability: Get rid of exposed tt directives in opac-memberentry.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:49:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:49:51 +0000 Subject: [Koha-bugs] [Bug 19344] DB fields login_attempts and lang may be inverted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19344 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:50:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:50:59 +0000 Subject: [Koha-bugs] [Bug 18779] Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:51:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:51:31 +0000 Subject: [Koha-bugs] [Bug 18780] Translatability: Get rid of exposed tt directive in masthead-langmenu.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18780 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:51:52 +0000 Subject: [Koha-bugs] [Bug 18781] Translatability: Get rid of exposed tt directives in openlibrary-readapi.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18781 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:52:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:52:56 +0000 Subject: [Koha-bugs] [Bug 19215] Typo in URL when editing a patron club template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19215 Bug 19215 depends on bug 18869, which changed state. Bug 18869 Summary: Patron clubs and templates tables look strange when empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:52:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:52:55 +0000 Subject: [Koha-bugs] [Bug 18869] Patron clubs and templates tables look strange when empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18869 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:53:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:53:53 +0000 Subject: [Koha-bugs] [Bug 18860] OPAC Messaging Settings table is not styled with In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18860 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:56:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:56:09 +0000 Subject: [Koha-bugs] [Bug 18422] Add Select2 to authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67142|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 67451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67451&action=edit Bug 18422 - Add Select2 to authority editor Overview: Repeat tag fails if authority field has select subfield (for example, UNIMARC 700$8, 800$a) This patch adds Select2 to authority editor Steps to Reproduce: In authority editor repeat field that has select subfield Actual Results: Field does not repeat (copy is not created). Console shows a js TypeError in cataloging.js: ?$(...).select2 is not a function? Expected Results: Field will repeat (copy is created) Additional Information: Error happens in version 16.11+ after adding Select2 js functions. The easiest way to fix is to add Select2 to authority editor Signed-off-by: Fridolin Somers Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:56:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:56:12 +0000 Subject: [Koha-bugs] [Bug 18422] Add Select2 to authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 --- Comment #6 from Julian Maurice --- Created attachment 67452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67452&action=edit Bug 18422: (QA follow-up) Check if select2 is available before using it cataloging.js might not always be loaded with select2.js, so we should check its availability to prevent JS errors Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:56:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:56:40 +0000 Subject: [Koha-bugs] [Bug 18422] Add Select2 to authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:56:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:56:55 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:56:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:56:57 +0000 Subject: [Koha-bugs] [Bug 18871] It is unclear how to view a patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18871 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:58:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:58:53 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |RESOLVED --- Comment #9 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 15:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 13:59:47 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66387|0 |1 is obsolete| | Attachment #66388|0 |1 is obsolete| | Attachment #66389|0 |1 is obsolete| | Attachment #66390|0 |1 is obsolete| | Attachment #66391|0 |1 is obsolete| | Attachment #66392|0 |1 is obsolete| | Attachment #66393|0 |1 is obsolete| | Attachment #66394|0 |1 is obsolete| | Attachment #66395|0 |1 is obsolete| | Attachment #66396|0 |1 is obsolete| | Attachment #66397|0 |1 is obsolete| | Attachment #66716|0 |1 is obsolete| | --- Comment #93 from Tom?s Cohen Arazi --- Created attachment 67453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67453&action=edit Bug 14826: Update database Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:00:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:00:07 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #94 from Tom?s Cohen Arazi --- Created attachment 67454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67454&action=edit Bug 14826: Add Koha::Account::Offset(s) modules Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:00:24 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #95 from Tom?s Cohen Arazi --- Created attachment 67455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67455&action=edit Bug 14826: Resurrect account offsets table The account offsets table should be used to track increments and decrements of fines via payments and credits, as well as fine accruals. It should be able to match fees to payments and visa versa, so we can know which fee was paid by a given payment, and which payments applied to a given fee. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Note the table accountoffsets has been renamed to account_offsets 4) Ensure fine generation creates offsets 5) Ensure creating a manual invoice creates an offset 6) Ensure a lost item charge creates an offset 7) Ensure Reverse Payment creates an offset 8) Ensure a payment creates an offset 9) Ensure a payment for multiple fees creates an offset for each 10) Ensure writeoffs create offsets Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:00:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:00:40 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #96 from Tom?s Cohen Arazi --- Created attachment 67456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67456&action=edit Bug 14826; Unit Tests Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:00:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:00:53 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #97 from Tom?s Cohen Arazi --- Created attachment 67457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67457&action=edit Bug 14826: Remove old offset table schema file Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:01:04 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #98 from Tom?s Cohen Arazi --- Created attachment 67458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67458&action=edit Bug 14826: Remove old offset table schema file Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:01:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:01:14 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #99 from Tom?s Cohen Arazi --- Created attachment 67459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67459&action=edit Bug 14826: Add new offset table schema file Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:01:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:01:23 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #100 from Tom?s Cohen Arazi --- Created attachment 67460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67460&action=edit Bug 14826: Add offset for rental fees Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:01:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:01:34 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #101 from Tom?s Cohen Arazi --- Created attachment 67461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67461&action=edit Bug 14826: Add unit tests for _FixAccountForLostAndReturned and _FixOverduesOnReturn Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:01:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:01:46 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #102 from Tom?s Cohen Arazi --- Created attachment 67462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67462&action=edit Bug 14826: (QA followup) Fix minor issues with unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:01:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:01:58 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #103 from Tom?s Cohen Arazi --- Created attachment 67463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67463&action=edit Bug 14826: (QA followup) Only use plural modules in other modules Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:02:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:02:09 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #104 from Tom?s Cohen Arazi --- Created attachment 67464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67464&action=edit Bug 14826: Add account offset type table Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:02:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:02:24 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #105 from Tom?s Cohen Arazi --- Created attachment 67465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67465&action=edit Bug 14826: (QA followup) POD fixes This patch just fixes POD. There are still some false positives with the QA scripts. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:04:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:04:26 +0000 Subject: [Koha-bugs] [Bug 19344] DB fields login_attempts and lang may be inverted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19344 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:04:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:04:29 +0000 Subject: [Koha-bugs] [Bug 19344] DB fields login_attempts and lang may be inverted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19344 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67222|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 67466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67466&action=edit Bug 19344: Reorder lang and login_attempts in the [deleted]borrowers tables Due to a bad rebase, the borrowers and deletedborrowers table structure may different from a new install and upgraded install For new installs, the order was: lang, login_attempts For upgraded installs, it was lang, last_seen, login_attempts After this patch, the order must be: - last_seen - lang - login_attempts Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:07:11 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #106 from Tom?s Cohen Arazi --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:09:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:09:12 +0000 Subject: [Koha-bugs] [Bug 19029] Move the clone button and implement a security question on smart-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:09:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:09:51 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #107 from Tom?s Cohen Arazi --- @RM: Please note that I obsoleted the (non-applying) schema file changes. They need to be generated when pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:12:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:12:05 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:12:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:12:14 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:20:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:20:57 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67098|0 |1 is obsolete| | --- Comment #14 from Julian Maurice --- Created attachment 67467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67467&action=edit Bug 18374: QueryAutoTruncate unit tests To test: 1 - Apply just this patch - should fail 2 - Apply the other patch - should pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:21:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:21:02 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67099|0 |1 is obsolete| | --- Comment #15 from Julian Maurice --- Created attachment 67468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67468&action=edit Bug 18374: Respect QueryAutoTruncate syspref in Elasticsearch This patchset adds a subroutine '_truncate_terms' to the ES QueryParser. If QueryAutoTruncate is enabled this function will be called for any search to add wildcard '*' to all terms To test: 1 - Enable Elasticsearch and have some records indexed 2 - Search for partial terms 3 - Note they fail unless '*' is appended 4 - Apply patch, leave QueryAutoTruncate disabled 5 - Note partial term searches still fail 6 - Enable QueryAutoTruncate 7 - Note partial term searches succeed 8 - Do some regular and advanced searches to make sure results are as expected Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:21:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:21:06 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67100|0 |1 is obsolete| | --- Comment #16 from Julian Maurice --- Created attachment 67469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67469&action=edit Bug 18374: (QA followup) Remove warning in Elasticsearch/Search.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:21:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:21:10 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 --- Comment #17 from Julian Maurice --- Created attachment 67470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67470&action=edit Bug 18374: (QA follow-up) Tidy up code Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:21:24 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:33:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:33:46 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #34 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #32) > Looks fine to me for patron create. > But years range is strange when a date of birth already exists, say > "01/01/1950", years range is 1850 to 1950. > > I propose a follow-up to set range from current year and 120 (instead of > 100) years earlier. > Some people may have more than 100 years,maybe more often in the future. > (Lets hope we will soon all be cyborgs ~(o_o)~ ) We already discussed about that, please open a new bug report if you want to modify the current behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:33:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:33:54 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:34:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:34:04 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:34:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:34:09 +0000 Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for date of birth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67448|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:35:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:35:51 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67317|0 |1 is obsolete| | Attachment #67318|0 |1 is obsolete| | Attachment #67319|0 |1 is obsolete| | --- Comment #17 from Tom?s Cohen Arazi --- Created attachment 67471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67471&action=edit Bug 18999: Add regression tests Added regression test for GetBudgetSpent() and GetBudgetOrdered() into the t/db_dependent/Budgets.t Test plan: 1. Go into your koha-shell 2. set the PERL5LIB variable 3. Run t/db_dependent/Budgets.t All tests should pass Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:35:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:35:59 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 67472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67472&action=edit Bug 18999: (QA followup) Minor fixes for tests Removed unneccessary declaration of $budget and changed Koha::Acquisition::Order->new->insert into Koha::Acquisition::Order->new->store as requested in tester feedback Test plan: 1. Go into your koha-shell 2. set the PERL5LIB variable 3. Run t/db_dependent/Budgets.t All tests should pass Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:36:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:36:05 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 67473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67473&action=edit Bug 18999: Modified SQL query in GetBudgetSpent() in C4/Budgets.pm Removed the SQL select condition 'AND closedate IS NOT NULL' because this was not returning shippingcost values and it does not exist in the SQL query to return the shipping cost in spent.pl Also removed the retrieval of shipping cost and the associated addition of item(s) cost and shipping cost in GetBudgetOrdered() in C4/Budgets.pm to prevent the shipping costs being subtracted off the fund total twice Test plan: 1. Go to Acquisition and create a currency, budget (make this value of 100), fund ( make this the value of 50), vendor (if neccessary) 2. Create a basket and click 'Add to basket' 3. Add 2 items with the vendor price of 10 4. Click 'Receive shipment' and write in the shipment cost of 6 5. Click 'Finish receiving' and go back to Acquisitions 6. Notice the spent column value is 0.00 but if you click on the value then the spent.pl page is displayed and shows that the shipment cost was 6.00 7. On the acquisition page also notice that the ordered column value is 26.00 8. Click on the name of the fund and notice the spent column value is 0.00 in the fund page table 9. Apply patch 10. Refresh acquisition page and notice that 6.00 is the value in the Spent column and 20.00 is the value in the ordered column. Both of which match the subtotal of the full-list tables displayed when you click on these values 11. Also notice the spent value in the fund page table is 6.00 12 Observe the changes to GetBudgetSpent() and GetBudgetOrdered() C4/Budgets.pm and check they make sense Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:36:13 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 67474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67474&action=edit Bug 18999: (QA followup) ModReceiveOrder expects a hashref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:52:49 +0000 Subject: [Koha-bugs] [Bug 19388] Error in course details on OPAC if an item is checked-out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:52:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:52:53 +0000 Subject: [Koha-bugs] [Bug 19388] Error in course details on OPAC if an item is checked-out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 --- Comment #1 from Jonathan Druart --- Created attachment 67475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67475&action=edit Bug 19388: FIX display item status if item is checked out In course reserves, if an item which was added to a course is checked out, it is not possible to show details for that course on OPAC. The error says: "Template process failed: undef error - The method onsite_checkout is not covered by tests! at /home/koha/src/C4/Templates.pm line 121." onsite_checkout is an attribute of Koha::Checkout, not Koha::Item Test plan: Create a course with 2 items that are checked out (standard and on-site) At the OPAC, add them to your cart and confirm the status of these 2 items is correct Confirm that on the detail page of the bib record as well as the detail of the course. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:54:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:54:15 +0000 Subject: [Koha-bugs] [Bug 19388] Error in course details on OPAC if an item is checked-out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18276 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #2 from Jonathan Druart --- Looks like it has been caused by bug 18276. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 16:54:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 14:54:15 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 [Bug 19388] Error in course details on OPAC if an item is checked-out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:07:27 +0000 Subject: [Koha-bugs] [Bug 19357] Error when submitting biblionumbers to batch record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:25:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:25:01 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:25:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:25:28 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #42 from Jonathan Druart --- I am not confident with this patch, I am expecting side-effects. But I do not have anything else to suggest, let's give a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:25:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:25:55 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:25:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:25:58 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64300|0 |1 is obsolete| | Attachment #64301|0 |1 is obsolete| | Attachment #64302|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 67476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67476&action=edit Bug 18786 - Update database Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:26:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:26:05 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #13 from Kyle M Hall --- Created attachment 67477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67477&action=edit Bug 18786 - Add ability to create custom payment types Some libraries would like to be able to specify more specific payment types such as cash, check, credit card, or even canned food ( for food drives ). This feature will allow a library to specify payment types as authorised values of the type PAYMENT_TYPE. Test Plan: 1) Apply patches 2) Update database 3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card' 4) Go to the fines section of a patron who has several fines 5) Tab 'Fines' 6) Click on 'Pay' for an individual fine 7) Verify that in the form a 'Pay an individual fine' dropdown appears with payment types 8) Select a payment type, confirm payment 9) Verify that payment type appears in "Description of charges" in tab 'Account' Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:30:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:30:54 +0000 Subject: [Koha-bugs] [Bug 18790] Add ability to void payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65932|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 67478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67478&action=edit Bug 18790 - Add ability to void payments We've had the ability to 'reverse' a payment for a long time, but it would be much better if we had a true void payment function that replaces the paid amounts into the fee so that it appears as if the payment was never made. Test Plan: 1) Apply this patch and dependent patches 2) Run updatedatabase.pl 3) Create some fines 4) Pay those fines 5) Use the new 'void' button to void the payments 6) Note the fines were restored to their pre-payment amounts Signed-off-by: Koha-us conference Signed-off-by: BWS Sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:35:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:35:25 +0000 Subject: [Koha-bugs] [Bug 19389] New: Don' t offer search option for libary groups when no groups are defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389 Bug ID: 19389 Summary: Don't offer search option for libary groups when no groups are defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The intranet advanced search page offers to search for groups of libraries, even if the pull down is empty as no library groups have been defined. It would be nicer to hide this search option when no groups are defined. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:35:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:35:33 +0000 Subject: [Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Jonathan Druart --- Please add more tests: - donald duck and the mouse - * - "donald duck" and "the mouse" - field:value I am sure you will see that it needs more work :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:43:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:43:21 +0000 Subject: [Koha-bugs] [Bug 19086] Multiple cross-site scripting vulnerabilities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Product|Koha security |Koha Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Component|Koha |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:43:51 +0000 Subject: [Koha-bugs] [Bug 19125] XSS - members.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Architecture, internals, | |and plumbing Group|Koha security | Product|Koha security |Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:44:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:44:14 +0000 Subject: [Koha-bugs] [Bug 19103] Stored XSS in itemtypes.pl - patron-attr-types.pl - matching-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19103 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:44:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:44:10 +0000 Subject: [Koha-bugs] [Bug 19128] XSS - patron-attr-types.tt, authorised_values.tt and categories.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Architecture, internals, | |and plumbing Product|Koha security |Koha Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:44:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:44:23 +0000 Subject: [Koha-bugs] [Bug 19108] Stored XSS in multiple scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19108 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:44:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:44:26 +0000 Subject: [Koha-bugs] [Bug 19127] Stored XSS in csv-profiles.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Architecture, internals, | |and plumbing Group|Koha security | Product|Koha security |Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:45:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:45:20 +0000 Subject: [Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:45:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:45:37 +0000 Subject: [Koha-bugs] [Bug 16463] OPAC discharge page should warn the user about checkouts before they request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:45:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:45:54 +0000 Subject: [Koha-bugs] [Bug 18318] Wrong unicode tokenization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18318 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:46:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:46:11 +0000 Subject: [Koha-bugs] [Bug 19086] Multiple cross-site scripting vulnerabilities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19086 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:46:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:46:28 +0000 Subject: [Koha-bugs] [Bug 19103] Stored XSS in itemtypes.pl - patron-attr-types.pl - matching-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19103 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:46:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:46:45 +0000 Subject: [Koha-bugs] [Bug 19108] Stored XSS in multiple scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19108 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:47:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:47:03 +0000 Subject: [Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:47:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:47:21 +0000 Subject: [Koha-bugs] [Bug 19120] Order cancelled status is reset on basket open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:47:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:47:38 +0000 Subject: [Koha-bugs] [Bug 19125] XSS - members.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:47:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:47:56 +0000 Subject: [Koha-bugs] [Bug 19127] Stored XSS in csv-profiles.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:48:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:48:12 +0000 Subject: [Koha-bugs] [Bug 19128] XSS - patron-attr-types.tt, authorised_values.tt and categories.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:48:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:48:29 +0000 Subject: [Koha-bugs] [Bug 19323] subscription edit permission issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:48:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:48:45 +0000 Subject: [Koha-bugs] [Bug 19329] IntranetSlipPrinterJS label is obsoleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:49:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:49:01 +0000 Subject: [Koha-bugs] [Bug 19334] circulation history doesn' t set biblionumber so left navigation is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:49:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:49:19 +0000 Subject: [Koha-bugs] [Bug 19357] Error when submitting biblionumbers to batch record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:49:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:49:36 +0000 Subject: [Koha-bugs] [Bug 19366] PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:49:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:49:52 +0000 Subject: [Koha-bugs] [Bug 19372] Selecting MARC framework doesn' t work when adding to basket from an external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:58:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:58:32 +0000 Subject: [Koha-bugs] [Bug 19390] New: OPAC view link in staff results should open in a new tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Bug ID: 19390 Summary: OPAC view link in staff results should open in a new tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The OPAC view link on the detail page always opens in a new tab, but the newer link in the staf result list does not. All OPAC view links should open in a new tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 17:58:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 15:58:39 +0000 Subject: [Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 18:02:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 16:02:33 +0000 Subject: [Koha-bugs] [Bug 19261] never hide biblionumber field in view policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart --- Please add a test to t/db_dependent/Filter_MARC_ViewPolicy.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 18:03:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 16:03:48 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 18:05:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 16:05:52 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64350|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 67479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67479&action=edit Bug 2696 - Fine Payments Should Show What Was Paid For Test Plan: 1) Apply this patch and its' dependencies 2) Create and pay some various fees and fines 3) View the payments for fees, and fees paid by payments by using the new 'Details' button available on boraccount.pl Signed-off-by: Lee Jamison Running updatedatabase.pl after patch application makes dependencies happy. Passes QA Tools and works as intended. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 18:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 16:07:27 +0000 Subject: [Koha-bugs] [Bug 18805] Add ability to use up account credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:22:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:22:42 +0000 Subject: [Koha-bugs] [Bug 17277] Current Location column in Holdings table showing empty under OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:45:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:45:30 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:45:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:45:32 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #3 from Kyle M Hall --- Created attachment 67480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67480&action=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:45:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:45:52 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |normal Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:51:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:51:49 +0000 Subject: [Koha-bugs] [Bug 19388] Error in course details on OPAC if an item is checked-out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs Signoff |Signed Off --- Comment #3 from Caroline Cyr La Rose --- I tested and it worked. I was able to see the course details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:58:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:58:34 +0000 Subject: [Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:58:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:58:36 +0000 Subject: [Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67432|0 |1 is obsolete| | --- Comment #3 from David Bourgault --- Created attachment 67481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67481&action=edit Bug 19386: Prevent t/db_dependent/SIP/Patron.t to fail randomly Depending on the values used by TestBuilder, some tests from t/db_dependent/SIP/Patron.t can fail # Failed test 'Not blocked without overdues when set to 'Don't block'' # at t/db_dependent/SIP/Patron.t line 55. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'confirmation'' # at t/db_dependent/SIP/Patron.t line 61. # got: '0' # expected: '1' # Failed test 'Not blocked without overdues when set to 'Block'' # at t/db_dependent/SIP/Patron.t line 67. # got: '0' # expected: '1' Caused by this check in C4::SIP::ILS::Patron->new 110 for (qw(EXPIRED CHARGES CREDITS GNA LOST DBARRED NOTES)) { 111 ($flags->{$_}) or next; [...] 115 if ($flags->{$_}->{noissues}) { 116 foreach my $toggle (qw(charge_ok renew_ok recall_ok hold_ok inet)) { 117 $ilspatron{$toggle} = 0; # if we get noissues, disable everything 118 } 119 } 120 } Test plan: Execute several times (50x?) these tests. Without this patch they may fail With this patch they must never fail Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 19:59:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 17:59:42 +0000 Subject: [Koha-bugs] [Bug 19386] t/db_dependent/SIP/Patron.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19386 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault at inlibro.com --- Comment #4 from David Bourgault --- Test 100 hundred times before and after. Before it failed 6 times, after it did not. Command used: for i in {1..100}; do prove t/db_dependent/SIP/Patron.t | grep Failed; done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:01:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:01:20 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #113 from Kyle M Hall --- I'm getting failures on all the unit tests : \ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:17:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:17:10 +0000 Subject: [Koha-bugs] [Bug 18724] Upload cover image failed without error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18724 --- Comment #3 from Sebastian Krieg --- This is still valid. The error message confirm the lost of communication between DBMS and application. But I didn't find any reason why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:18:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:18:25 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save ( delay field should accept numbers only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:18:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:18:27 +0000 Subject: [Koha-bugs] [Bug 19259] Overdue rules do not save ( delay field should accept numbers only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67400|0 |1 is obsolete| | --- Comment #13 from David Bourgault --- Created attachment 67482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67482&action=edit Bug 19259: Enforce type of the delay value when editing overdue rules - template side only Overdue rules do not save when a delay that is not an integer > 0, without any warnings. This patch forces the user to select a number > 0. Test plan: Without this patch applied, enter non-integer value or negative or 0 => The rule will not be inserted without any warnings. With this patch applied you will get an message from the browser and the form will not save Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:20:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:20:04 +0000 Subject: [Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 Dominic Pichette changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67413|0 |1 is obsolete| | --- Comment #2 from Dominic Pichette --- Created attachment 67483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67483&action=edit Bug 18449: Rename misleading button when renewing If you hit the renewal limit on the renewal tab, the message gives you a message like: "Windows 8 / ( 50610018249545 ) has been renewed the maximum number of times by Johnny Test ( 12345678 )" And has a button that reads: "Ignore and continue" This button is misleading, as it may be interpreted as "ignore the limit and continue to renew the item". Signed-off-by: Dominic Pichette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:20:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:20:19 +0000 Subject: [Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 Dominic Pichette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette at inlibro.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:36:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:36:39 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65208|0 |1 is obsolete| | --- Comment #3 from David Bourgault --- Created attachment 67484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67484&action=edit Bug 18979: Speed up 'valid-templates.t' tests Test plan: Confirm than prove xt/author/valid-templates.t is quicker with this patch. Before I got: Files=1, Tests=840, 21 wallclock secs ( 0.18 usr 0.02 sys + 20.28 cusr 0.32 csys = 20.80 CPU) After: Files=1, Tests=840, 17 wallclock secs ( 0.06 usr 0.01 sys + 21.56 cusr 0.48 csys = 22.11 CPU) Signed-off by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:37:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:37:59 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault at inlibro.com Status|Needs Signoff |Signed Off --- Comment #4 from David Bourgault --- I tested 10 times, before and after. Before it averaged 18.4 wallclock seconds per run After it average dropped slightly to 16.6 wallclock seconds It's a very minor improvement, but there seems to be one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:50:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:50:53 +0000 Subject: [Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #13 from Caroline Cyr La Rose --- I'm not sure of the test plan and expected result. Do we have to place the hold from the OPAC or staff interface? And for the result, is it supposed to override the default holds policy? - I changed one of my circulation rules to If all unavailable for one of my patron categories (x all item types). - Fixed a record so that one of the items was in the home library of the user and one was in another branch (both current location and home library) - Check out the item that was in the same home library as the patron from the fiex patron category to another user - Tried to place a hold for my patron in the staff interface. It says "Not on hold OR Due DD/MM/AAAA Item level hold not allowed from OPAC. There is a little yellow "!" triangle icon next to BOTH items but I can still override the circ rule. I have a pop-up saying "This item normally cannot be put on hold except for patrons from (2nd branch), Place hold on this item?" - From the OPAC, I logged in as my user and tried to place the hold and it says "Sorry non of these items can be placed on hold." / "No available items". - After the patch, the yellow "!" triangle icon is ONLY next to the item from the 2nd location (not patron's home library) in the staff interface. So, no problem to reserve the checked out item, but I have to override to reserve the available item. - From the OPAC, I was able to place my hold on the bib record without problem. I went into the "Holds to pull" report and saw that the item from the 2nd location was there, waiting to be pulled from the shelf. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 20:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 18:53:40 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #114 from Magnus Enger --- (In reply to Kyle M Hall from comment #113) > I'm getting failures on all the unit tests : \ Yeah, acording to Alex, those tests are mostly written for an older iteration of the code. It has been said that Alex will be working one day a week on ILL in the coming weeks, so I hope writing those tests will be his number one priority... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:03:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:03:32 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Dominic Pichette changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:03:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:03:53 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Dominic Pichette changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:14:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:14:31 +0000 Subject: [Koha-bugs] [Bug 19388] Error in course details on OPAC if an item is checked-out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19388 --- Comment #4 from Caroline Cyr La Rose --- Created attachment 67485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67485&action=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:15:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:15:21 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose --- Works as described! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:16:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:16:50 +0000 Subject: [Koha-bugs] [Bug 19128] XSS - patron-attr-types.tt, authorised_values.tt and categories.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 [Bug 19391] auth_values_input_www.t is failing because of bug 19128 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:16:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:16:50 +0000 Subject: [Koha-bugs] [Bug 19391] New: auth_values_input_www.t is failing because of bug 19128 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 Bug ID: 19391 Summary: auth_values_input_www.t is failing because of bug 19128 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 19128 # Failed test 'Add a new category button should be displayed' # at t/db_dependent/www/auth_values_input_www.t line 90. # got: '0' # expected: '1' # Failed test 'Add a new category button should be displayed' # at t/db_dependent/www/auth_values_input_www.t line 110. # got: '0' # expected: '1' [16:16:34] t/db_dependent/www/auth_values_input_www.t .. 20/33 # Failed test at t/db_dependent/www/auth_values_input_www.t line 166. # got: '0' # expected: '1' # Looks like you failed 3 tests of 33. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19128 [Bug 19128] XSS - patron-attr-types.tt, authorised_values.tt and categories.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:17:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:17:46 +0000 Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because of bug 19128 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:17:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:17:50 +0000 Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because of bug 19128 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 --- Comment #1 from Jonathan Druart --- Created attachment 67486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67486&action=edit Bug 19391: (bug 19128 follow-up) Fix failing tests from auth_values_input_www.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:21:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:21:39 +0000 Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because of bug 19128 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:27:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:27:24 +0000 Subject: [Koha-bugs] [Bug 19186] SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19186 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67406|0 |1 is obsolete| | --- Comment #3 from David Bourgault --- Created attachment 67487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67487&action=edit Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be Cardnumber. Especially since more and more libraries are using chip cards instead of barcodes. Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:28:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:28:05 +0000 Subject: [Koha-bugs] [Bug 19392] New: auth_values_input_www.t does not clean up Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 Bug ID: 19392 Summary: auth_values_input_www.t does not clean up Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The two authorised value categories are not removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:29:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:29:23 +0000 Subject: [Koha-bugs] [Bug 19186] SelfCheckoutByLogin should list 'cardnumber' as an option instead of 'barcode' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19186 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault at inlibro.com Status|Needs Signoff |Signed Off --- Comment #4 from David Bourgault --- git grep SelfCheckoutByLogin found no SQL files or anything that looked like an insertion... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:30:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:30:10 +0000 Subject: [Koha-bugs] [Bug 19392] auth_values_input_www.t does not clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 --- Comment #1 from Jonathan Druart --- Created attachment 67488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67488&action=edit Bug 19392: Clean-up behind auth_values_input_www.t The two categories created by this test script are not removed Test plan: without this patch, the two authorised value categories ????? and t?mas are not removed when the script finishes. Now it does! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:30:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:30:06 +0000 Subject: [Koha-bugs] [Bug 19392] auth_values_input_www.t does not clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:49:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:49:52 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67428|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose --- Created attachment 67489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67489&action=edit Bug 19260 - Restore ExpireReservesMaxPickupDelay It looks like bug 12063 accidentally removed the functionality of ExpireReservesMaxPickupDelay. This patch aims to restore it. To test: Before applying the patch: - Make sure ExpireReservesMaxPickUpDelay = "Don't allow" - Check out a book to a user - Add a reservastion on it for another user - Check the hold in the database. You should have: found = W, waitingdate = today, expirationdate = today + the value of ReservesMaxPickUpDelay The problem here is the expirationdate, it should be empty when ExpireReservesMaxPickUpDelay = "Don't allow". After applying the patch: - Repeat the steps above - expirationdate should now be NULL Please be creative when testing this. I am not sure I have seen all the possible concequences. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:50:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:50:57 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Dominic Pichette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette at inlibro.co | |m --- Comment #11 from Dominic Pichette --- I had this error trying to access the account tab in fines: Global symbol "$input" requires explicit package name (did you forget to declare "my $input"?) at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 41. syntax error at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 44, near "1cc607141dd67a2373996a1cf5116b1334354420 " Global symbol "$input" requires explicit package name (did you forget to declare "my $input"?) at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 56. Execution of /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:53:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:53:22 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #5 from Caroline Cyr La Rose --- Works as advertised. There was a step missing from the test plan, however, you have to return the reserved item for the db to show W in "found" field and (today's) date in "waiting date". Once I figured that out, everything worked as you said. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 21:55:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 19:55:05 +0000 Subject: [Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67489|0 |1 is obsolete| | Attachment #67489|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:02:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:02:07 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Dominic Pichette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette at inlibro.co | |m --- Comment #3 from Dominic Pichette --- is the patch only adding a field in preferences or is it using it somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:10:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:10:33 +0000 Subject: [Koha-bugs] [Bug 18120] CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 --- Comment #29 from Jonathan Druart --- Created attachment 67490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67490&action=edit Bug 18120: Tidy up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:15:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:15:29 +0000 Subject: [Koha-bugs] [Bug 19392] auth_values_input_www.t does not clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:15:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:15:42 +0000 Subject: [Koha-bugs] [Bug 19392] auth_values_input_www.t does not clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:15:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:15:56 +0000 Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because of bug 19128 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:16:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:16:03 +0000 Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because of bug 19128 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:17:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:17:11 +0000 Subject: [Koha-bugs] [Bug 13912] Add syspref for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:17:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:17:28 +0000 Subject: [Koha-bugs] [Bug 18120] CRUD endpoint for vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:17:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:17:34 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Dominic Pichette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette at inlibro.co | |m --- Comment #31 from Dominic Pichette --- Just installed the patch and did step 1 and 2. though running the command at step 2 gives me this: export PERL5LIB=/path/to/koha;export KOHA_CONF=/etc/koha/koha-conf.xml;./purge_suggestions.pl -days 30 I understand it is not the result you want? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:17:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:17:44 +0000 Subject: [Koha-bugs] [Bug 18422] Add Select2 to authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:18:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:18:17 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:18:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:18:00 +0000 Subject: [Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:18:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:18:23 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Jonathan Druart --- (In reply to Dominic Pichette from comment #11) > I had this error trying to access the account tab in fines: Hi Dominic, When you find an issue, you can switch the status to Failed QA. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:18:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:18:32 +0000 Subject: [Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:18:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:18:48 +0000 Subject: [Koha-bugs] [Bug 19317] Move of checkouts - Remove leftover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:18:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:18:58 +0000 Subject: [Koha-bugs] [Bug 19344] DB fields login_attempts and lang may be inverted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:19:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:19:11 +0000 Subject: [Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because of bug 19128 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:19:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:19:31 +0000 Subject: [Koha-bugs] [Bug 19392] auth_values_input_www.t does not clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 29 22:45:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 20:45:10 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david.bourgault at inlibro.com --- Comment #2 from David Bourgault --- I can't apply the patch fatal: sha1 information is lacking or useless (C4/Members.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 30 00:40:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 22:40:00 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 --- Comment #8 from Jonathan Druart --- Created attachment 67491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67491&action=edit Bug 19276: Update the number of tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 30 00:40:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Sep 2017 22:40:24 +0000 Subject: [Koha-bugs] [Bug 19276] CanBookBeIssued: unsuccessfully refers to borrower category_type X In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19276 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Created attachment 67491 [details] [review] > Bug 19276: Update the number of tests Pushed to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 30 02:40:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Sep 2017 00:40:34 +0000 Subject: [Koha-bugs] [Bug 19387] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DAMNIT!! |SPAM CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 30 14:30:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Sep 2017 12:30:05 +0000 Subject: [Koha-bugs] [Bug 18817] Update links in the help files for the new 17.11 manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 --- Comment #25 from Katrin Fischer --- I think we had agreed to use the old manual still for 17.05 and do the final switch with 17.11 - which means this shouldn't be pushed to 17.11. -- You are receiving this mail because: You are watching all bug changes.