[Koha-bugs] [Bug 19072] REST API: Toggle suspend for /api/v1/holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19072

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #6 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
The use of C4::Reserves::ToggleSuspend is a bit counter-intuitive here. If you
send a PUT to /api/v1/holds/x with '{"suspend":false}' it would suspend hold if
it was not already suspended.

I would rather respect the body request and suspend according to that, or you
would have unpredictable results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.