[Koha-bugs] [Bug 18541] Patron card creator: Add a grid to support layout design

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Sep 6 15:29:44 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541

--- Comment #13 from Marc Véron <veron at veron.ch> ---
(In reply to Marcel de Rooy from comment #11)
> -        $patron_card->draw_guide_box($pdf) if
> $print_layout_xml->{'guide_box'};
> -        $patron_card->draw_barcode($pdf) if $print_layout_xml->{'barcode'};
> +        $patron_card->draw_guide_box($pdf) if $layout_xml->{'guide_box'};
> +        $patron_card->draw_guide_grid($pdf) if $layout_xml->{'guide_grid'};
> +        $patron_card->draw_barcode($pdf) if $layout_xml->{'barcode'};
> 
> Marc,
> Please explain this change.
> Formerly, as I understand, it flipped between layout_xml and
> layout_back_xml. Now you always set it to layout_xml. Do you change behavior
> for draw_guide_box and draw_barcode ?
> 
> Status change to reflect need for feedback only.

Marcel,
Thanks for QAing and pointing this out.
Yes, it should be $print_layout_xml, not $layout_xml.

Follow-up patch will follow.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list