[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What are we doing here?

If it is just replacing syspref fetch with Koha.Preference, the following is
wrong:

-                [% IF ( display_patron_image ) %]
+                [% IF ( Koha.Preference('ShowPatronImageInWebBasedSelfCheck')
) %]

display_patron_image is set when $borrower is set AND the pref is set.
We had too many regressions in this area, I will not take any risks.

If we are doing something else, it is not written in the commit messages.

Please clarify.

-- 
You are receiving this mail because:
You are watching all bug changes.