[Koha-bugs] [Bug 19059] Move C4::Reserves::CancelReserve to the Koha::Hold->cancel
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Sep 7 14:41:52 CEST 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059
--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looks good to me. Few minor points left:
FIXME in sub ModReserveFill
+ # FIXME Must call Koha::Hold->cancel ? => No, should call ->filled and add
the correct log
Not clear to me. Please clarify.
sub _move_to_old
The name suggests a move, but you are only copying data.
circ/branchtransfers.pl
+ } # FIXME else?
Can you fix it now? You add the if. Actually, the script always assumed that
CancelReserve worked. So why not only test $holds->count for the call to cancel
?
Same remark for other occurrences. Incl. circ/returns.pl
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list