[Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 8 09:40:28 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65569|0                           |1
        is obsolete|                            |
  Attachment #65570|0                           |1
        is obsolete|                            |
  Attachment #65571|0                           |1
        is obsolete|                            |
  Attachment #65572|0                           |1
        is obsolete|                            |
  Attachment #66304|0                           |1
        is obsolete|                            |
  Attachment #66791|0                           |1
        is obsolete|                            |

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 66974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66974&action=edit
Bug 18351: Able to delete budget with funds

To test:
1) Create a budget, add a fund
2) Delete budget. Notice this is successful and triggers no warning
message etc.
3) Go to Funds. Notice the funds appear as if they are not there
4) Go into mysql and view the aqbudgetperiods table - notice the funds
are still there and are now inaccessible.
5) Apply patch
6) Create a budget, add a fund
7) Attempt to delete budget. Notice you can't click Delete button.
Confirm number of funds in hover message is correct.
8) Delete fund
9) Confirm you can now delete budget.

Sponsored-by: Catalyst IT

Signed-off-by: Felix Hemme <felix.hemme at thulb.uni-jena.de>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Bug 18351: [FOLLOW-UP] Some code fixes

See Comment 5. Ready to test.

Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Bug 18351: [FOLLOW-UP] Code fix

See comment 10.
Ready for testing.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Bug 18351: [FOLLOW-UP] Prevent deletion from forcing URL

This patch adds a check in the script for existing funds so that the
budget cannot be deleted when forcing the URL and has other small fixes.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Bug 18351: [FOLLOW-UP] Prevent deletion if funds are added after clicking
'Delete' and before confirming delete

Followed test plan and patch works as described.

Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list