[Koha-bugs] [Bug 19277] TT syntax - Data is not ordered in notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 66985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66985&action=edit
Bug 19277: TT syntax - Display ordered data

This issue has been highlighted by a failing test: ISSUESLIP displays checkouts
in random order

I thought it was because of dates comparison, but it comes from the following
line in C4::Letters::_get_tt_params
  my $objects = $module->search( { $key => { -in => $values } } );

The DBMS will return data like there is ordered in the DB.
For instance:
  select borrowernumber from borrowers where borrowernumber in (5, 3, 1);
or
  select borrowernumber from borrowers where borrowernumber=5 or
borrowernumber=3 or borrowernumber=1;

will return 1, 3, 5

I did not find a generic way to do that, so used "ORDER BY FIELD" which will
not be portable.

Test plan:
If you do not apply this patch, the tests will sometime fail

-- 
You are receiving this mail because:
You are watching all bug changes.