[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've tried to fix the tests replacing the newer by the old modules, but getting
stuck here:

    # Data corrupted: add same issue_id to old_issues
    Koha::OldIssues->new({ issue_id => $issue->issue_id })->store;

The method store is not covered by tests at t/db_dependent/SIP/Message.t line
312.
    not ok 15 - DBIx error on duplicate issue_id
    #   Failed test 'DBIx error on duplicate issue_id'
    #   at t/db_dependent/SIP/Message.t line 316.
    # didn't find a warning
    # expected to find warning: (?^u:Duplicate entry)
    # expected to find warning: (?^u:data corrupted)
    not ok 16 - OK flag is false when we encounter data corruption in
old_issues
    #   Failed test 'OK flag is false when we encounter data corruption in
old_issues'
    #   at t/db_dependent/SIP/Message.t line 318.
    #          got: '1'
    #     expected: '0'
    not ok 17 - Alert flag is set
    #   Failed test 'Alert flag is set'
    #   at t/db_dependent/SIP/Message.t line 319.
    #          got: 'N'
    #     expected: 'Y'
    not ok 18 - Code AF not found in
'|AOz7vpbEBO2|ABNZd|AQz7vpbEBO2|AJNVjlgNa_|AAgHWDOyBTR|CRmibXFk|CSd0dkNUeiPLgDfs5ZS8tKmTiko63dH74rAf5ikn_Jg2QXE6TEmks381qyPoSUvy5ZORcYPHtyT_BiUpH7vTR2KdHjc_TNDNaFvZtMsvaP_qDOQLqP8ZWfJMGFKWO1dd6VaXt1kCqgU1zqOmoPEcox92XXWlL54V0df04DoOGpaGq2aChxvamLvEPhEgLDsbLhw34EI28uO9DfKFYDtPpVteffxIy7qHyFZHgkPNthjLMNAeDYSZZP9Y|'?
    #   Failed test 'Code AF not found in
'|AOz7vpbEBO2|ABNZd|AQz7vpbEBO2|AJNVjlgNa_|AAgHWDOyBTR|CRmibXFk|CSd0dkNUeiPLgDfs5ZS8tKmTiko63dH74rAf5ikn_Jg2QXE6TEmks381qyPoSUvy5ZORcYPHtyT_BiUpH7vTR2KdHjc_TNDNaFvZtMsvaP_qDOQLqP8ZWfJMGFKWO1dd6VaXt1kCqgU1zqOmoPEcox92XXWlL54V0df04DoOGpaGq2aChxvamLvEPhEgLDsbLhw34EI28uO9DfKFYDtPpVteffxIy7qHyFZHgkPNthjLMNAeDYSZZP9Y|'?'
    #   at t/db_dependent/SIP/Message.t line 364.
    #          got: '0'
    #     expected: '1'
    not ok 19 - OK flag is true when we checkin after removing the duplicate
    #   Failed test 'OK flag is true when we checkin after removing the
duplicate'
    #   at t/db_dependent/SIP/Message.t line 327.
    #          got: '0'
    #     expected: '1'
    not ok 20 - Alert flag is not set
    #   Failed test 'Alert flag is not set'
    #   at t/db_dependent/SIP/Message.t line 328.
    #          got: 'Y'
    #     expected: 'N'
    ok 21 - Issue record is gone now
    # Looks like you failed 6 tests of 21.

-- 
You are receiving this mail because:
You are watching all bug changes.