[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Sep 11 21:11:11 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 67058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67058&action=edit
Bug 18996: [16.11.x] [QA Follow-up] Remove global variables from Message.t

As per request of Colin in comment18, this patch makes the use of global
variables in Message.t no longer needed.
The three subtests are now completely independent and could well be moved
to separate test scripts.

Note: Strictly speaking, the use of global (package) variables could
potentially introduce new bugs (e.g. if the value is modified outside the
script). This seems not to be the case here, but we are safe now.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list