[Koha-bugs] [Bug 19329] The automatic slip printing does not work when IntranetSlipPrinterJS defined

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Sep 19 07:42:13 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19329

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Owen Leonard from comment #2)
> The manual refers to the wiki, which includes this instruction:
> 
> "Important: The script must implement the function $( window
> ).load(function()
> because it replaces the original function)."
> 
> The example on that wiki page includes a try-catch example which includes
> "window.print()" and "window.close()."
> 
> Isn't this patch going to create conflicts for libraries with existing
> IntranetSlipPrinterJS setups?

In that case, yes it would be conflict. Then we need to document it better in
UI, because the text by the system preference '' says:

'Use the following JavaScript for printing slips. Define at least function
printThenClose().'

Which is what does not work.

I will rework the patch to just change this sentence. Thanks Owen.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list