[Koha-bugs] [Bug 19234] Add query parameters handling helpers

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 22 23:05:28 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #7)
> Comment on attachment 66991 [details] [review]
> Bug 19234: Unit tests for query parameters handling helpers
> 
> Review of attachment 66991 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: t/Koha/REST/Plugin/Query.t
> @@ +68,5 @@
> > +
> > +    $t->get_ok('/query')
> > +      ->status_is( 200 )
> > +      ->json_is( '/attributes' => { page => 2, rows => 3 } )
> > +      ->json_is( '/filter' => { firstname => { like => 'Manuel%' }, surname => { like => 'Cohen Arazi%' } } );
> 
> Is it by design that this 'like' is actually a 'starts with' rather than a
> 'contains' search?

I was just keeping the current behaviour. If we added more options (contains,
left truncation, etc) we should still keep right truncation as default to avoid
unneeded behaviour changes.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list