[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #4)

> I know it's a somewhat early draft, hope the comments are still helpful:
Yes! Good to get feedback early :-)

> - Maybe the reason should be an authorised values list. Or a list in
> combination with a notes field?
The first I planned as a later enhancement, but the second is interesting, I
will take a look

> - I am not sure about the use case for encumber now/encumber later. Do you
> have a bit more information about this requirement maybe? (please take a
> look at my comments and tests on bug 18999)
Yes, 'encumber while open' decide if your credits affect the invoice when open,
or only when closed.
If 'encumber while open' is checked then adjustments should show in 'ordered'
until invoice is closed - once it is closed they move to 'spent'
If not 'encumber while open' the adjustments have no effect on 'ordered' while
invoice is open and move to 'spent' when closed

> - Budget should be fund in the form 
Yup, will fix

> - I think a delete link or button might be nicer than the checkbox - or have
> both in a nice table.
I am working on improving the GUI

> - Adjustments can be stored currently without a fund, I think this needs
> some validation.
This was to mirror 'Shipping cost' which may not have a fund, it seems the
value is not deducted when this is used? It can be removed if not necessary

> - Adjustments can be positive or negative, right? (credit (-) and additional
> shipping/processing costs (+)?) So far this seems to work.
Yes, the intention is to allow corrections of any kind to the invoice

> - Format prices nicely using the TT plugin everywhere.
Will fix

> - For the rollover things should be alright for the open orders as the new
> feature should not take effect there. But moving remaining funds over would
> have to take the actual amount into account.
Hmmm...as I understand the process a rollover only moves unreceived orders - we
are dealing with things at the invoice level - any invoices/adjustments should
be closed and affect the old budget only - if you have a remaning credit from
an invoice that should end up in the 'move remaining funds' and the adjustments
should be taken into account there. I think that should work right now

> This is a much asked for and needed feature - please keep it going!
Agreed :-)

> Looking at bug 10412: Could we imagine a use case where the credit note is independent from an invoice?
I think these achieve similar ends by different means - an invoice with
adjustments and no orders seems equivalent to a free standing credit - it
seemed logical to have an invoice for any monetary adjustment and if that bug
is resurrected it could be done without the option to link to invoices and be
compatible with this.

-- 
You are receiving this mail because:
You are watching all bug changes.