[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 67428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67428&action=edit
Bug 19260 - Restore ExpireReservesMaxPickupDelay

It looks like bug 12063 accidentally removed the functionality of
ExpireReservesMaxPickupDelay. This patch aims to restore it.

To test:

Before applying the patch:
- Make sure ExpireReservesMaxPickUpDelay = "Don't allow"
- Check out a book to a user
- Add a reservastion on it for another user
- Check the hold in the database. You should have:
  found = W, waitingdate = today, expirationdate = today + the value of
  ReservesMaxPickUpDelay

The problem here is the expirationdate, it should be empty when
ExpireReservesMaxPickUpDelay = "Don't allow".

After applying the patch:
- Repeat the steps above
- expirationdate should now be NULL

Please be creative when testing this. I am not sure I have seen
all the possible concequences.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.