[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > There is an access to the removed variable "holds" in the template
> > loop_order.holds
> > 
> > That means we now see "Can't delete catalog record, see constraints below",
> > but without anything below...
> 
> The code you are referencing is in loop_orders, but this patch only alters
> loop_received which does not have that message. I'm not sure how this patch
> could be causing that. If you can give me some line numbers I'd be happy to
> take another look!

Indeed, sounds like I mixed the 2 tables reading the code.

Something else:
1. What about comment 6?

2. "1 / 0" reads wrong, but I have no idea how it could be better.

3. line 141     $line{holds} = 0;
should be removed, right?

-- 
You are receiving this mail because:
You are watching all bug changes.