[Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 3 13:18:28 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935

--- Comment #31 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 72755
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72755
Bug 19935: Replace GetPendingIssues - Discharges

Review of attachment 72755:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19935&attachment=72755)
-----------------------------------------------------------------

::: Koha/Patron/Discharge.pm
@@ +9,4 @@
>  
>  use Koha::Database;
>  use Koha::DateUtils qw( dt_from_string output_pref );
> +use Koha::Checkouts;

should remain Koha::Patrons

@@ +35,5 @@
>  
> +    my $patron = Koha::Patrons->find( $params->{borrowernumber} );
> +    return unless $patron;
> +
> +    my $has_pending_checkouts = $patron->pending_checkouts->count;

shouldn't it be this? As said in commit message?
$patron->checkouts->count;

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list